126486 2014-01-03 23:40:26 -0800 CStack Branch: ARM64 add of stack pointer not valid as second source operand 2014-01-04 10:28:14 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 964379 0 msaboff 2014-01-03 23:40:26 -0800 Due to architectural limitations, the stack pointer register cannot be used as the second source operand for various instructions. Currently only the add instruction is used by the macro assembler with the stack pointer as the second source operand. The ARM64 add macro assembler can swap the two source operands in this case. 964381 1 220368 msaboff 2014-01-03 23:43:59 -0800 Created attachment 220368 Patch 964399 2 220368 mark.lam 2014-01-04 07:05:27 -0800 Comment on attachment 220368 Patch r=me 964416 3 msaboff 2014-01-04 10:28:14 -0800 Committed r161313: <http://trac.webkit.org/changeset/161313> 220368 2014-01-03 23:43:59 -0800 2014-01-04 07:05:26 -0800 Patch 126486.patch text/plain 1514 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMzA4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAxLTAzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IEFSTTY0IGFkZCBvZiBzdGFjayBwb2ludGVyIG5vdCB2YWxpZCBh cyBzZWNvbmQgc291cmNlIG9wZXJhbmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNjQ4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFN3YXAgdGhlIHNvdXJjZSBvcGVyYW5kcyBpbiBhZGQ2NCgpIGlmIHRo ZSBzZWNvbmQgYXJndW1lbnQgaXMgdGhlIHN0YWNrIHBvaW50ZXIKKyAgICAgICAgdG8gd29yayBh cm91bmQgQVJNNjQgbGltaXRhdGlvbnMgZm9yIHVzaW5nIHRoZSBzdGFjayBwb2ludGVyIGFzIGEg c2Vjb25kIHNvdXJjZSBvcGVyYW5kLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyQVJNNjQuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk02NDo6YWRkNjQpOgor CiAyMDE0LTAxLTAzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAg ICAgIGNzdGFjayBCcmFuY2g6IEFSTTY0IExMSW50IGZhaWxzIHRvIGNvbXBpbGUgZHVlIHRvIGlu c3RydWN0aW9ucyBsaW1pdGF0aW9ucyB3aXRoIHNwCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaAkocmV2aXNpb24g MTYxMjk5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxl ckFSTTY0LmgJKHdvcmtpbmcgY29weSkKQEAgLTIwMSw3ICsyMDEsMTAgQEAgcHVibGljOgogCiAg ICAgdm9pZCBhZGQ2NChSZWdpc3RlcklEIHNyYywgUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKLSAg ICAgICAgbV9hc3NlbWJsZXIuYWRkPDY0PihkZXN0LCBkZXN0LCBzcmMpOworICAgICAgICBpZiAo c3JjID09IEFSTTY0UmVnaXN0ZXJzOjpzcCkKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmFkZDw2 ND4oZGVzdCwgc3JjLCBkZXN0KTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgbV9hc3NlbWJs ZXIuYWRkPDY0PihkZXN0LCBkZXN0LCBzcmMpOwogICAgIH0KIAogICAgIHZvaWQgYWRkNjQoVHJ1 c3RlZEltbTMyIGltbSwgUmVnaXN0ZXJJRCBkZXN0KQo=