126478 2014-01-03 17:45:05 -0800 CStack Branch: slowPathFor() should emit an epilogue instead of popping the callFrameRegister 2014-01-04 10:26:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 964352 0 msaboff 2014-01-03 17:45:05 -0800 Before ThunkGenerators::slowPathFor() jumps to the target function, it returns the stack to the function entry state. Currently it does this using a pop(callFrameRegister). Instead it should emit a function epilogue(). This will work for architectures that have a link register that the callee will want to save in its prologue in addition to the callFrameRegister. 964356 1 220360 msaboff 2014-01-03 17:51:30 -0800 Created attachment 220360 Patch 964395 2 220360 mark.lam 2014-01-04 05:46:31 -0800 Comment on attachment 220360 Patch r=me 964415 3 msaboff 2014-01-04 10:26:51 -0800 Committed r161312: <http://trac.webkit.org/changeset/161312> 220360 2014-01-03 17:51:30 -0800 2014-01-04 05:46:30 -0800 Patch 126478.patch text/plain 1323 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMzAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTAxLTAzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IHNsb3dQYXRoRm9yKCkgc2hvdWxkIGVtaXQgYW4gZXBpbG9ndWUg aW5zdGVhZCBvZiBwb3BwaW5nIHRoZSBjYWxsRnJhbWVSZWdpc3RlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2NDc4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlZCB0aGUgcG9wKGNhbGxGcmFt ZVJlZ2lzdGVyKSB0byBlbWl0RnVuY3Rpb25FcGlsb2d1ZSgpLgorCisgICAgICAgICogaml0L1Ro dW5rR2VuZXJhdG9ycy5jcHA6CisgICAgICAgIChKU0M6OnNsb3dQYXRoRm9yKToKKwogMjAxNC0w MS0wMyAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBjc3Rh Y2sgQnJhbmNoOiBBUk02NCBMTEludCBmYWlscyB0byBjb21waWxlIGR1ZSB0byBpbnN0cnVjdGlv bnMgbGltaXRhdGlvbnMgd2l0aCBzcApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9U aHVua0dlbmVyYXRvcnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvVGh1bmtHZW5lcmF0b3JzLmNwcAkocmV2aXNpb24gMTYxMjk5KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MSw3 ICs5MSw3IEBAIHN0YXRpYyB2b2lkIHNsb3dQYXRoRm9yKAogICAgIC8vIDIpIEhvc3QgY2FsbCBy ZXR1cm4gdmFsdWUgcmV0dXJuZXIgdGhpbmd5LgogICAgIC8vIDMpIFRoZSBmdW5jdGlvbiB0byBj YWxsLgogICAgIGVtaXRQb2ludGVyVmFsaWRhdGlvbihqaXQsIEdQUkluZm86OnJldHVyblZhbHVl R1BSKTsKLSAgICBqaXQucG9wKEdQUkluZm86OmNhbGxGcmFtZVJlZ2lzdGVyKTsKKyAgICBqaXQu ZW1pdEZ1bmN0aW9uRXBpbG9ndWUoKTsKICAgICBqaXQuanVtcChHUFJJbmZvOjpyZXR1cm5WYWx1 ZUdQUik7CiB9CiAK