126468 2014-01-03 15:49:51 -0800 [WebGL] CGLPixelFormat should specify SampleBuffer and Sample count when using MSAA 2014-01-03 16:16:41 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue dino kondapallykalyan roger_fong webkit-bug-importer oldest_to_newest 964300 0 bfulgham 2014-01-03 15:49:51 -0800 I found this while trying to debug the failure of webgl/1.0.2/resources/webgl_test_files/conformance/rendering/gl-scissor-test.html. The WebGL code assumes we are using multisampling when the WebGL "antialias" attribute is set, but the Mac port does not enable these flags in the underlying CGPixelFormat for the OpenGL context. This causes the gl-scissor-test to render garbage for the "antialias" case. 964301 1 220348 bfulgham 2014-01-03 15:53:32 -0800 Created attachment 220348 Patch 964310 2 220348 dino 2014-01-03 16:10:27 -0800 Comment on attachment 220348 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220348&action=review > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:145 > + bool useMultisampling = m_attrs.antialias; > + > + setPixelFormat(attribs, 32, 32, !attrs.forceSoftwareRenderer, true, false, useMultisampling); This preserves our existing behaviour to request supersampling when anti-aliasing was false. I guess that's ok. 964312 3 220348 bfulgham 2014-01-03 16:16:34 -0800 Comment on attachment 220348 Patch Clearing flags on attachment: 220348 Committed r161294: <http://trac.webkit.org/changeset/161294> 964313 4 bfulgham 2014-01-03 16:16:36 -0800 All reviewed patches have been landed. Closing bug. 964314 5 webkit-bug-importer 2014-01-03 16:16:41 -0800 <rdar://problem/15747163> 220348 2014-01-03 15:53:32 -0800 2014-01-03 16:16:34 -0800 Patch bug-126468-20140103155331.patch text/plain 4294 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTI5MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAxLTAzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXZWJHTF0gQ0dMUGl4ZWxG b3JtYXQgc2hvdWxkIHNwZWNpZnkgU2FtcGxlQnVmZmVyIGFuZCBTYW1wbGUgY291bnQgd2hlbiB1 c2luZyBNU0FBCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjY0NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDb3ZlcmVkIGJ5IHdlYmdsLzEuMC4yL3Jlc291cmNlcy93ZWJnbF90ZXN0X2ZpbGVzL2NvbmZv cm1hbmNlL3JlbmRlcmluZy9nbC1zY2lzc29yLXRlc3QuaHRtbAorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dDNETWFjLm1tOgorICAgICAgICAoV2ViQ29y ZTo6c2V0UGl4ZWxGb3JtYXQpOiBBZGQga0NHTFBGQU11bHRpc2FtcGxlLCBrQ0dMUEZBU2FtcGxl QnVmZmVycyAoYW5kIGNvdW50KSwgYW5kCisgICAgICAgIGtDR0xQRkFTYW1wbGVzIChhbmQgY291 bnQpIHRvIG91ciBwaXhlbCBmb3JtYXQgd2hlbiAnYW50aWFsaWFzPXRydWUnLgorICAgICAgICAo V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0Q6OkdyYXBoaWNzQ29udGV4dDNEKTogUGFzcyBhIG5l dyAnYW50aWFsaWFzJyBmbGFnIHRvIHRoZSBzZXRQaXhlbEZvcm1hdAorICAgICAgICBtZXRob2Qg c28gd2UgY2FuIHR1cm4gb24gTVNBQSBmZWF0dXJlcyB3aGVuIG5lZWRlZC4KKwogMjAxNC0wMS0w MyAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGxpbmVh Z2VPZlR5cGUgcmVuZGVyZXIgaXRlcmF0b3IgYW5kIHN0YXJ0IHVzaW5nIGl0LgpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dDNETWFjLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9HcmFw aGljc0NvbnRleHQzRE1hYy5tbQkocmV2aXNpb24gMTYxMjg0KQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dDNETWFjLm1tCSh3b3JraW5nIGNv cHkpCkBAIC02MSw3ICs2MSw3IEBAIHB1YmxpYzoKICAgICB+R3JhcGhpY3NDb250ZXh0M0RQcml2 YXRlKCkgeyB9CiB9OwogCi1zdGF0aWMgdm9pZCBzZXRQaXhlbEZvcm1hdChWZWN0b3I8Q0dMUGl4 ZWxGb3JtYXRBdHRyaWJ1dGU+JiBhdHRyaWJzLCBpbnQgY29sb3JCaXRzLCBpbnQgZGVwdGhCaXRz LCBib29sIGFjY2VsZXJhdGVkLCBib29sIHN1cGVyc2FtcGxlLCBib29sIGNsb3Nlc3QpCitzdGF0 aWMgdm9pZCBzZXRQaXhlbEZvcm1hdChWZWN0b3I8Q0dMUGl4ZWxGb3JtYXRBdHRyaWJ1dGU+JiBh dHRyaWJzLCBpbnQgY29sb3JCaXRzLCBpbnQgZGVwdGhCaXRzLCBib29sIGFjY2VsZXJhdGVkLCBi b29sIHN1cGVyc2FtcGxlLCBib29sIGNsb3Nlc3QsIGJvb2wgYW50aWFsaWFzKQogewogICAgIGF0 dHJpYnMuY2xlYXIoKTsKICAgICAKQEAgLTc3LDExICs3NywxOSBAQCBzdGF0aWMgdm9pZCBzZXRQ aXhlbEZvcm1hdChWZWN0b3I8Q0dMUGl4CiAgICAgICAgIGF0dHJpYnMuYXBwZW5kKHN0YXRpY19j YXN0PENHTFBpeGVsRm9ybWF0QXR0cmlidXRlPihrQ0dMUmVuZGVyZXJHZW5lcmljRmxvYXRJRCkp OwogICAgIH0KICAgICAgICAgCi0gICAgaWYgKHN1cGVyc2FtcGxlKQorICAgIGlmIChzdXBlcnNh bXBsZSAmJiAhYW50aWFsaWFzKQogICAgICAgICBhdHRyaWJzLmFwcGVuZChrQ0dMUEZBU3VwZXJz YW1wbGUpOwogICAgICAgICAKICAgICBpZiAoY2xvc2VzdCkKICAgICAgICAgYXR0cmlicy5hcHBl bmQoa0NHTFBGQUNsb3Nlc3RQb2xpY3kpOworCisgICAgaWYgKGFudGlhbGlhcykgeworICAgICAg ICBhdHRyaWJzLmFwcGVuZChrQ0dMUEZBTXVsdGlzYW1wbGUpOworICAgICAgICBhdHRyaWJzLmFw cGVuZChrQ0dMUEZBU2FtcGxlQnVmZmVycyk7CisgICAgICAgIGF0dHJpYnMuYXBwZW5kKHN0YXRp Y19jYXN0PENHTFBpeGVsRm9ybWF0QXR0cmlidXRlPigxKSk7CisgICAgICAgIGF0dHJpYnMuYXBw ZW5kKGtDR0xQRkFTYW1wbGVzKTsKKyAgICAgICAgYXR0cmlicy5hcHBlbmQoc3RhdGljX2Nhc3Q8 Q0dMUGl4ZWxGb3JtYXRBdHRyaWJ1dGU+KDQpKTsKKyAgICB9CiAgICAgICAgIAogICAgIGF0dHJp YnMuYXBwZW5kKHN0YXRpY19jYXN0PENHTFBpeGVsRm9ybWF0QXR0cmlidXRlPigwKSk7CiB9CkBA IC0xMzIsMjAgKzE0MCwyMyBAQCBHcmFwaGljc0NvbnRleHQzRDo6R3JhcGhpY3NDb250ZXh0M0Qo R3JhCiAgICAgLy8KICAgICAvLyBJZiBub25lIG9mIHRoYXQgd29ya3MsIHdlIHNpbXBseSBmYWls IGFuZCBzZXQgbV9jb250ZXh0T2JqIHRvIDAuCiAKLSAgICBzZXRQaXhlbEZvcm1hdChhdHRyaWJz LCAzMiwgMzIsICFhdHRycy5mb3JjZVNvZnR3YXJlUmVuZGVyZXIsIHRydWUsIGZhbHNlKTsKKyAg ICBib29sIHVzZU11bHRpc2FtcGxpbmcgPSBtX2F0dHJzLmFudGlhbGlhczsKKyAgICAKKyAgICBz ZXRQaXhlbEZvcm1hdChhdHRyaWJzLCAzMiwgMzIsICFhdHRycy5mb3JjZVNvZnR3YXJlUmVuZGVy ZXIsIHRydWUsIGZhbHNlLCB1c2VNdWx0aXNhbXBsaW5nKTsKICAgICBDR0xDaG9vc2VQaXhlbEZv cm1hdChhdHRyaWJzLmRhdGEoKSwgJnBpeGVsRm9ybWF0T2JqLCAmbnVtUGl4ZWxGb3JtYXRzKTsK IAogICAgIGlmIChudW1QaXhlbEZvcm1hdHMgPT0gMCkgewotICAgICAgICBzZXRQaXhlbEZvcm1h dChhdHRyaWJzLCAzMiwgMzIsICFhdHRycy5mb3JjZVNvZnR3YXJlUmVuZGVyZXIsIGZhbHNlLCBm YWxzZSk7CisgICAgICAgIHNldFBpeGVsRm9ybWF0KGF0dHJpYnMsIDMyLCAzMiwgIWF0dHJzLmZv cmNlU29mdHdhcmVSZW5kZXJlciwgZmFsc2UsIGZhbHNlLCB1c2VNdWx0aXNhbXBsaW5nKTsKICAg ICAgICAgQ0dMQ2hvb3NlUGl4ZWxGb3JtYXQoYXR0cmlicy5kYXRhKCksICZwaXhlbEZvcm1hdE9i aiwgJm51bVBpeGVsRm9ybWF0cyk7CiAKICAgICAgICAgaWYgKG51bVBpeGVsRm9ybWF0cyA9PSAw KSB7Ci0gICAgICAgICAgICBzZXRQaXhlbEZvcm1hdChhdHRyaWJzLCAzMiwgMTYsICFhdHRycy5m b3JjZVNvZnR3YXJlUmVuZGVyZXIsIGZhbHNlLCBmYWxzZSk7CisgICAgICAgICAgICBzZXRQaXhl bEZvcm1hdChhdHRyaWJzLCAzMiwgMTYsICFhdHRycy5mb3JjZVNvZnR3YXJlUmVuZGVyZXIsIGZh bHNlLCBmYWxzZSwgdXNlTXVsdGlzYW1wbGluZyk7CiAgICAgICAgICAgICBDR0xDaG9vc2VQaXhl bEZvcm1hdChhdHRyaWJzLmRhdGEoKSwgJnBpeGVsRm9ybWF0T2JqLCAmbnVtUGl4ZWxGb3JtYXRz KTsKIAogICAgICAgICAgICAgIGlmICghYXR0cnMuZm9yY2VTb2Z0d2FyZVJlbmRlcmVyICYmIG51 bVBpeGVsRm9ybWF0cyA9PSAwKSB7Ci0gICAgICAgICAgICAgICAgIHNldFBpeGVsRm9ybWF0KGF0 dHJpYnMsIDMyLCAxNiwgZmFsc2UsIGZhbHNlLCB0cnVlKTsKKyAgICAgICAgICAgICAgICAgc2V0 UGl4ZWxGb3JtYXQoYXR0cmlicywgMzIsIDE2LCBmYWxzZSwgZmFsc2UsIHRydWUsIGZhbHNlKTsK ICAgICAgICAgICAgICAgICAgQ0dMQ2hvb3NlUGl4ZWxGb3JtYXQoYXR0cmlicy5kYXRhKCksICZw aXhlbEZvcm1hdE9iaiwgJm51bVBpeGVsRm9ybWF0cyk7CisgICAgICAgICAgICAgICAgIHVzZU11 bHRpc2FtcGxpbmcgPSBmYWxzZTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KQEAg LTE4Myw2ICsxOTQsOSBAQCBHcmFwaGljc0NvbnRleHQzRDo6R3JhcGhpY3NDb250ZXh0M0QoR3Jh CiAgICAgICAgIFttX3dlYkdMTGF5ZXIuZ2V0KCkgc2V0TmFtZTpAIldlYkdMIExheWVyIl07CiAj ZW5kaWYgICAgCiAgICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUworCisgICAgaWYgKHVzZU11 bHRpc2FtcGxpbmcpCisgICAgICAgIDo6Z2xFbmFibGUoR0xfTVVMVElTQU1QTEUpOwogICAgIAog ICAgIC8vIGNyZWF0ZSBhIHRleHR1cmUgdG8gcmVuZGVyIGludG8KICAgICA6OmdsR2VuVGV4dHVy ZXMoMSwgJm1fdGV4dHVyZSk7Cg==