126456 2014-01-03 13:29:06 -0800 Add lineageOfType renderer iterator and start using it. 2014-01-07 11:34:04 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn koivisto kondapallykalyan simon.fraser oldest_to_newest 964245 0 kling 2014-01-03 13:29:06 -0800 We should have a lineageOfType iterator for renderers, just like we already do for elements. 964261 1 220337 kling 2014-01-03 14:04:59 -0800 Created attachment 220337 Patch 964276 2 220337 ggaren 2014-01-03 14:45:26 -0800 Comment on attachment 220337 Patch r=me 964287 3 220337 commit-queue 2014-01-03 15:15:52 -0800 Comment on attachment 220337 Patch Clearing flags on attachment: 220337 Committed r161288: <http://trac.webkit.org/changeset/161288> 964288 4 commit-queue 2014-01-03 15:15:54 -0800 All reviewed patches have been landed. Closing bug. 965096 5 220337 simon.fraser 2014-01-07 11:34:04 -0800 Comment on attachment 220337 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220337&action=review > Source/WebCore/rendering/RenderAncestorIterator.h:187 > +inline RenderAncestorIteratorAdapter<T> lineageOfType(RenderObject& first) "lineageOfType" doesn't tell me that this is walking the ancestor chain (you can have a descendant lineage as well as an ancestor lineage). Can we rename it to ancestorLineageOfType()? 220337 2014-01-03 14:04:59 -0800 2014-01-07 11:34:04 -0800 Patch bug-126456.diff text/plain 7395 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYTdlYWE4Li43NDAxOTVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzgg QEAKIDIwMTQtMDEtMDMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIEFkZCBsaW5lYWdlT2ZUeXBlIHJlbmRlcmVyIGl0ZXJhdG9yIGFuZCBzdGFydCB1c2luZyBp dC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyNjQ1Nj4KKworICAgICAgICBBZGQg YSBjb252ZW5pZW50IHdheSB0byBpdGVyYXRlIG92ZXIgYSByZW5kZXJlcnMgYW5jZXN0cnkgKmlu Y2x1ZGluZyoKKyAgICAgICAgdGhlIHN0YXJ0aW5nIHBvaW50IHJlbmRlcmVyIChpZiBpdCBtZWV0 cyB0aGUgdHlwZSBjcml0ZXJpYS4pCisKKyAgICAgICAgVGhpcyB3b3JrcyBqdXN0IGxpa2UgbGlu ZWFnZU9mVHlwZSBmb3IgRWxlbWVudHMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQW5jZXN0b3JJdGVyYXRvci5oOgor ICAgICAgICAoV2ViQ29yZTo6bGluZWFnZU9mVHlwZSk6CisKKyAgICAgICAgICAgIEFkZGVkLiBS ZXR1cm5zIGFuIGFkYXB0ZXIgZm9yIHdhbGtpbmcgYSByZW5kZXJlcidzIGVudGlyZSBsaW5lYWdl CisgICAgICAgICAgICBtYXRjaGluZyBhbnkgcmVuZGVyZXIgb2YgdGhlIGdpdmVuIHR5cGUuCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuaDoKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyTGF5ZXJNb2RlbE9iamVjdC5oOgorCisgICAgICAgICAgICBBZGQgdGhl IHJlcXVpc2l0ZSBpc1JlbmRlcmVyT2ZUeXBlPFQ+IGhlbHBlcnMuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6ZW5jbG9z aW5nRmxvYXRQYWludGluZ0xheWVyKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6ZW5jbG9zaW5nTGF5ZXIpOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjplbmNsb3NpbmdCb3gpOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyT2JqZWN0OjplbmNsb3NpbmdCb3hNb2RlbE9iamVjdCk6CisKKyAgICAg ICAgICAgIFNpbXBsaWZ5IHdpdGggbGluZWFnZU9mVHlwZS4gQWRkZWQgc29tZSBGSVhNRXMgYWJv dXQgZnVuY3Rpb25zCisgICAgICAgICAgICB0aGF0IHNob3VsZCByZXR1cm4gcmVmZXJlbmNlcyBp bnN0ZWFkIG9mIHBvaW50ZXJzLgorCisyMDE0LTAxLTAzICBBbmRyZWFzIEtsaW5nICA8YWtsaW5n QGFwcGxlLmNvbT4KKwogICAgICAgICBEZXBsb3kgbW9yZSBjaGlsZCByZW5kZXJlciBpdGVyYXRv cnMgaW4gUmVuZGVyQmxvY2tGbG93LgogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI2 NDM0PgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQW5jZXN0 b3JJdGVyYXRvci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckFuY2VzdG9ySXRl cmF0b3IuaAppbmRleCA3ZDJmZDZlLi4zOWRkMDVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQW5jZXN0b3JJdGVyYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJBbmNlc3Rvckl0ZXJhdG9yLmgKQEAgLTcyLDYgKzcyLDggQEAgcHJp dmF0ZToKIAogdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IFJlbmRlckFuY2VzdG9ySXRlcmF0b3JBZGFw dGVyPFQ+IGFuY2VzdG9yc09mVHlwZShSZW5kZXJPYmplY3QmKTsKIHRlbXBsYXRlIDx0eXBlbmFt ZSBUPiBSZW5kZXJBbmNlc3RvckNvbnN0SXRlcmF0b3JBZGFwdGVyPFQ+IGFuY2VzdG9yc09mVHlw ZShjb25zdCBSZW5kZXJPYmplY3QmKTsKK3RlbXBsYXRlIDx0eXBlbmFtZSBUPiBSZW5kZXJBbmNl c3Rvckl0ZXJhdG9yQWRhcHRlcjxUPiBsaW5lYWdlT2ZUeXBlKFJlbmRlck9iamVjdCYpOwordGVt cGxhdGUgPHR5cGVuYW1lIFQ+IFJlbmRlckFuY2VzdG9yQ29uc3RJdGVyYXRvckFkYXB0ZXI8VD4g bGluZWFnZU9mVHlwZShjb25zdCBSZW5kZXJPYmplY3QmKTsKIAogLy8gUmVuZGVyQW5jZXN0b3JJ dGVyYXRvcgogCkBAIC0xODEsNiArMTgzLDIyIEBAIGlubGluZSBSZW5kZXJBbmNlc3RvckNvbnN0 SXRlcmF0b3JBZGFwdGVyPFQ+IGFuY2VzdG9yc09mVHlwZShjb25zdCBSZW5kZXJPYmplY3QmCiAg ICAgcmV0dXJuIFJlbmRlckFuY2VzdG9yQ29uc3RJdGVyYXRvckFkYXB0ZXI8VD4oZmlyc3QpOwog fQogCit0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KK2lubGluZSBSZW5kZXJBbmNlc3Rvckl0ZXJhdG9y QWRhcHRlcjxUPiBsaW5lYWdlT2ZUeXBlKFJlbmRlck9iamVjdCYgZmlyc3QpCit7CisgICAgaWYg KGlzUmVuZGVyZXJPZlR5cGU8Y29uc3QgVD4oZmlyc3QpKQorICAgICAgICByZXR1cm4gUmVuZGVy QW5jZXN0b3JJdGVyYXRvckFkYXB0ZXI8VD4oc3RhdGljX2Nhc3Q8VCo+KCZmaXJzdCkpOworICAg IHJldHVybiBhbmNlc3RvcnNPZlR5cGU8VD4oZmlyc3QpOworfQorCit0ZW1wbGF0ZSA8dHlwZW5h bWUgVD4KK2lubGluZSBSZW5kZXJBbmNlc3RvckNvbnN0SXRlcmF0b3JBZGFwdGVyPFQ+IGxpbmVh Z2VPZlR5cGUoY29uc3QgUmVuZGVyT2JqZWN0JiBmaXJzdCkKK3sKKyAgICBpZiAoaXNSZW5kZXJl ck9mVHlwZTxjb25zdCBUPihmaXJzdCkpCisgICAgICAgIHJldHVybiBSZW5kZXJBbmNlc3RvckNv bnN0SXRlcmF0b3JBZGFwdGVyPFQ+KHN0YXRpY19jYXN0PGNvbnN0IFQqPigmZmlyc3QpKTsKKyAg ICByZXR1cm4gYW5jZXN0b3JzT2ZUeXBlPFQ+KGZpcnN0KTsKK30KKwogfQogCiAjZW5kaWYKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKaW5kZXggYzZmOWY3MS4uMWJlMmYxMCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKQEAgLTQ0ODUsMTQgKzQ0ODUs MTEgQEAgaW50IFJlbmRlckJveDo6YmFzZWxpbmVQb3NpdGlvbihGb250QmFzZWxpbmUgYmFzZWxp bmVUeXBlLCBib29sIC8qZmlyc3RMaW5lKi8sIEwKIAogUmVuZGVyTGF5ZXIqIFJlbmRlckJveDo6 ZW5jbG9zaW5nRmxvYXRQYWludGluZ0xheWVyKCkgY29uc3QKIHsKLSAgICBjb25zdCBSZW5kZXJF bGVtZW50KiBjdXJyID0gdGhpczsKLSAgICB3aGlsZSAoY3VycikgewotICAgICAgICBSZW5kZXJM YXllciogbGF5ZXIgPSBjdXJyLT5oYXNMYXllcigpICYmIGN1cnItPmlzQm94KCkgPyB0b1JlbmRl ckJveChjdXJyKS0+bGF5ZXIoKSA6IDA7Ci0gICAgICAgIGlmIChsYXllciAmJiBsYXllci0+aXNT ZWxmUGFpbnRpbmdMYXllcigpKQotICAgICAgICAgICAgcmV0dXJuIGxheWVyOwotICAgICAgICBj dXJyID0gY3Vyci0+cGFyZW50KCk7CisgICAgZm9yIChhdXRvJiBib3ggOiBsaW5lYWdlT2ZUeXBl PFJlbmRlckJveD4oKnRoaXMpKSB7CisgICAgICAgIGlmIChib3gubGF5ZXIoKSAmJiBib3gubGF5 ZXIoKS0+aXNTZWxmUGFpbnRpbmdMYXllcigpKQorICAgICAgICAgICAgcmV0dXJuIGJveC5sYXll cigpOwogICAgIH0KLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogTGF5 b3V0UmVjdCBSZW5kZXJCb3g6OmxvZ2ljYWxWaXN1YWxPdmVyZmxvd1JlY3RGb3JQcm9wYWdhdGlv bihSZW5kZXJTdHlsZSogcGFyZW50U3R5bGUpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuaCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oCmluZGV4IGIzZTM3YmUuLjIyYzMxOWYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5oCkBA IC0zNDUsNiArMzQ1LDggQEAgcHJpdmF0ZToKICAgICB2b2lkIHBhaW50TWFza0ZvclRleHRGaWxs Qm94KEltYWdlQnVmZmVyKiwgY29uc3QgSW50UmVjdCYsIElubGluZUZsb3dCb3gqLCBjb25zdCBM YXlvdXRSZWN0JiwgUmVuZGVyUmVnaW9uKik7CiB9OwogCit0ZW1wbGF0ZSA8PiBpbmxpbmUgYm9v bCBpc1JlbmRlcmVyT2ZUeXBlPGNvbnN0IFJlbmRlckJveE1vZGVsT2JqZWN0Pihjb25zdCBSZW5k ZXJPYmplY3QmIHJlbmRlcmVyKSB7IHJldHVybiByZW5kZXJlci5pc0JveE1vZGVsT2JqZWN0KCk7 IH0KKwogUkVOREVSX09CSkVDVF9UWVBFX0NBU1RTKFJlbmRlckJveE1vZGVsT2JqZWN0LCBpc0Jv eE1vZGVsT2JqZWN0KCkpCiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllck1vZGVsT2JqZWN0LmggYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJNb2RlbE9iamVjdC5oCmluZGV4IDNiMDNkNjku LjZjNzViMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ck1vZGVsT2JqZWN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy TW9kZWxPYmplY3QuaApAQCAtNjcsNiArNjcsOCBAQCBwcml2YXRlOgogICAgIHN0YXRpYyBib29s IHNfbGF5ZXJXYXNTZWxmUGFpbnRpbmc7CiB9OwogCit0ZW1wbGF0ZSA8PiBpbmxpbmUgYm9vbCBp c1JlbmRlcmVyT2ZUeXBlPGNvbnN0IFJlbmRlckxheWVyTW9kZWxPYmplY3Q+KGNvbnN0IFJlbmRl ck9iamVjdCYgcmVuZGVyZXIpIHsgcmV0dXJuIHJlbmRlcmVyLmlzUmVuZGVyTGF5ZXJNb2RlbE9i amVjdCgpOyB9CisKIFJFTkRFUl9PQkpFQ1RfVFlQRV9DQVNUUyhSZW5kZXJMYXllck1vZGVsT2Jq ZWN0LCBpc1JlbmRlckxheWVyTW9kZWxPYmplY3QoKSkKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAppbmRleCA3M2E4ZTMz Li5mM2M3MzBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcApA QCAtNDksNiArNDksNyBAQAogI2luY2x1ZGUgIlJlbmRlckZsb3dUaHJlYWQuaCIKICNpbmNsdWRl ICJSZW5kZXJHZW9tZXRyeU1hcC5oIgogI2luY2x1ZGUgIlJlbmRlcklubGluZS5oIgorI2luY2x1 ZGUgIlJlbmRlckl0ZXJhdG9yLmgiCiAjaW5jbHVkZSAiUmVuZGVyTGF5ZXIuaCIKICNpbmNsdWRl ICJSZW5kZXJMYXllckJhY2tpbmcuaCIKICNpbmNsdWRlICJSZW5kZXJOYW1lZEZsb3dUaHJlYWQu aCIKQEAgLTQ3MiwxNCArNDczLDExIEBAIHZvaWQgUmVuZGVyT2JqZWN0OjpyZXNldFRleHRBdXRv c2l6aW5nKCkKIAogUmVuZGVyTGF5ZXIqIFJlbmRlck9iamVjdDo6ZW5jbG9zaW5nTGF5ZXIoKSBj b25zdAogewotICAgIGNvbnN0IFJlbmRlck9iamVjdCogY3VyciA9IHRoaXM7Ci0gICAgd2hpbGUg KGN1cnIpIHsKLSAgICAgICAgUmVuZGVyTGF5ZXIqIGxheWVyID0gY3Vyci0+aGFzTGF5ZXIoKSA/ IHRvUmVuZGVyTGF5ZXJNb2RlbE9iamVjdChjdXJyKS0+bGF5ZXIoKSA6IDA7Ci0gICAgICAgIGlm IChsYXllcikKLSAgICAgICAgICAgIHJldHVybiBsYXllcjsKLSAgICAgICAgY3VyciA9IGN1cnIt PnBhcmVudCgpOworICAgIGZvciAoYXV0byYgcmVuZGVyZXIgOiBsaW5lYWdlT2ZUeXBlPFJlbmRl ckxheWVyTW9kZWxPYmplY3Q+KCp0aGlzKSkgeworICAgICAgICBpZiAocmVuZGVyZXIubGF5ZXIo KSkKKyAgICAgICAgICAgIHJldHVybiByZW5kZXJlci5sYXllcigpOwogICAgIH0KLSAgICByZXR1 cm4gMDsKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogYm9vbCBSZW5kZXJPYmplY3Q6OnNjcm9s bFJlY3RUb1Zpc2libGUoY29uc3QgTGF5b3V0UmVjdCYgcmVjdCwgY29uc3QgU2Nyb2xsQWxpZ25t ZW50JiBhbGlnblgsIGNvbnN0IFNjcm9sbEFsaWdubWVudCYgYWxpZ25ZKQpAQCAtNDk0LDI4ICs0 OTIsMTQgQEAgYm9vbCBSZW5kZXJPYmplY3Q6OnNjcm9sbFJlY3RUb1Zpc2libGUoY29uc3QgTGF5 b3V0UmVjdCYgcmVjdCwgY29uc3QgU2Nyb2xsQWxpZ24KIAogUmVuZGVyQm94KiBSZW5kZXJPYmpl Y3Q6OmVuY2xvc2luZ0JveCgpIGNvbnN0CiB7Ci0gICAgUmVuZGVyT2JqZWN0KiBjdXJyID0gY29u c3RfY2FzdDxSZW5kZXJPYmplY3QqPih0aGlzKTsKLSAgICB3aGlsZSAoY3VycikgewotICAgICAg ICBpZiAoY3Vyci0+aXNCb3goKSkKLSAgICAgICAgICAgIHJldHVybiB0b1JlbmRlckJveChjdXJy KTsKLSAgICAgICAgY3VyciA9IGN1cnItPnBhcmVudCgpOwotICAgIH0KLSAgICAKLSAgICBBU1NF UlRfTk9UX1JFQUNIRUQoKTsKLSAgICByZXR1cm4gMDsKKyAgICAvLyBGSVhNRTogVGhpcyBzaG91 bGQgcmV0dXJuIGEgcmVmZXJlbmNlOyBpdCBjYW4gYWx3YXlzIGZpbmQgdGhlIHJvb3QgUmVuZGVy Vmlldy4KKyAgICByZXR1cm4gbGluZWFnZU9mVHlwZTxSZW5kZXJCb3g+KGNvbnN0X2Nhc3Q8UmVu ZGVyT2JqZWN0Jj4oKnRoaXMpKS5maXJzdCgpOwogfQogCiBSZW5kZXJCb3hNb2RlbE9iamVjdCog UmVuZGVyT2JqZWN0OjplbmNsb3NpbmdCb3hNb2RlbE9iamVjdCgpIGNvbnN0CiB7Ci0gICAgUmVu ZGVyT2JqZWN0KiBjdXJyID0gY29uc3RfY2FzdDxSZW5kZXJPYmplY3QqPih0aGlzKTsKLSAgICB3 aGlsZSAoY3VycikgewotICAgICAgICBpZiAoY3Vyci0+aXNCb3hNb2RlbE9iamVjdCgpKQotICAg ICAgICAgICAgcmV0dXJuIHRvUmVuZGVyQm94TW9kZWxPYmplY3QoY3Vycik7Ci0gICAgICAgIGN1 cnIgPSBjdXJyLT5wYXJlbnQoKTsKLSAgICB9Ci0KLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK LSAgICByZXR1cm4gMDsKKyAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgcmV0dXJuIGEgcmVmZXJl bmNlOyBpdCBjYW4gYWx3YXlzIGZpbmQgdGhlIHJvb3QgUmVuZGVyVmlldy4KKyAgICByZXR1cm4g bGluZWFnZU9mVHlwZTxSZW5kZXJCb3hNb2RlbE9iamVjdD4oY29uc3RfY2FzdDxSZW5kZXJPYmpl Y3QmPigqdGhpcykpLmZpcnN0KCk7CiB9CiAKIGJvb2wgUmVuZGVyT2JqZWN0OjpmaXhlZFBvc2l0 aW9uZWRXaXRoTmFtZWRGbG93Q29udGFpbmluZ0Jsb2NrKCkgY29uc3QK