126455 2014-01-03 13:27:06 -0800 [WebGL] glScissor Test is not accounted for when generating internal rendering textures 2014-01-03 13:42:16 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Major --- 1 bfulgham bfulgham bfulgham commit-queue dino kondapallykalyan noam roger_fong oldest_to_newest 964243 0 bfulgham 2014-01-03 13:27:06 -0800 Our WebGL implementation uses a texture handle part of the drawing operations to put the final rendered scene into the HTML Canvas. If a WebGL program is using the glScissor feature, this impacts our texture generation. This bug manifests as regions of the screen being filled with random data, rather than the intended scene to be displayed. We should check the status of the GL_SCISSOR_TEST and GL_DITHER features, disable them for our internal drawing, and then re-enable them (if needed) before returning to the JS program. 964247 1 bfulgham 2014-01-03 13:30:39 -0800 This error causes the following examples to fail: http://threejs.org/examples/#webgl_materials_texture_anisotropy http://threejs.org/examples/#webgl_materials_texture_filters http://threejs.org/examples/#webgl_materials_texture_manualmipmap http://threejs.org/examples/#webgl_multiple_views 964248 2 220333 bfulgham 2014-01-03 13:34:25 -0800 Created attachment 220333 Patch 964251 3 commit-queue 2014-01-03 13:37:03 -0800 Attachment 220333 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:200: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:201: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:202: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:202: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:219: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:221: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:219: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:221: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 8 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 964252 4 bfulgham 2014-01-03 13:37:41 -0800 (In reply to comment #3) > Attachment 220333 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp', '--commit-queue']" exit_code: 1 > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:200: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:201: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:202: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:202: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:219: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:221: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:219: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:221: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] > Total errors found: 8 in 2 files > These are very much false positives. The whole section of code is indented 4 spaces. What is check-webkit-style thinking? 964257 5 bfulgham 2014-01-03 13:42:16 -0800 Committed r161285: <http://trac.webkit.org/changeset/161285> 220333 2014-01-03 13:34:25 -0800 2014-01-03 13:40:13 -0800 Patch bug-126455-20140103133424.patch text/plain 2010 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTI4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTAzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXZWJHTF0gZ2xTY2lzc29y IHRlc3QgaXMgbm90IGFjY291bnRlZCBmb3Igd2hlbiBnZW5lcmF0aW5nIGludGVybmFsIHJlbmRl cmluZyB0ZXh0dXJlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyNjQ1NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTU3NDQyMDY+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSB3ZWJn bC8xLjAuMi9jb25mb3JtYW5jZS9yZW5kZXJpbmcvZ2wtc2Npc3Nvci10ZXN0Lmh0bWwKKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENv bW1vbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6cHJlcGFyZVRl eHR1cmUpOiBDaGVjayBzdGF0ZSBvZiBHTF9TQ0lTU09SX1RFU1QgYW5kIEdMX0RJVEhFUiwgZGVh Y3RpdmF0ZSB0aGVtIGR1cmluZworICAgICAgICBvdXIgaW50ZXJuYWwgZHJhd2luZywgdGhlbiB0 dXJuIHRoZW0gYmFjayBvbiBmb3IgZnVydGhlciBwcm9jZXNzaW5nLgorCiAyMDE0LTAxLTAzICBK ZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtNZWRpYUNvbnRyb2xz XVtpT1NdIEVuYWJsZSBKYXZhU2NyaXB0IE1lZGlhIENvbnRyb2xzIG9uIGlPUy4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9w ZW5HTENvbW1vbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAkocmV2aXNpb24g MTYxMjczKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBo aWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk1LDYgKzE5 NSwxMiBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjpwcmVwYXJlVGV4dHVyZSgpCiAgICAgICAg IHJldHVybjsKIAogICAgIG1ha2VDb250ZXh0Q3VycmVudCgpOworCisgICAgR0xib29sZWFuIGlz U2Npc3NvckVuYWJsZWQgPSA6OmdsSXNFbmFibGVkKEdMX1NDSVNTT1JfVEVTVCk7CisgICAgOjpn bERpc2FibGUoR0xfU0NJU1NPUl9URVNUKTsKKyAgICBHTGJvb2xlYW4gaXNEaXRoZXJFbmFibGVk ID0gOjpnbElzRW5hYmxlZChHTF9ESVRIRVIpOworICAgIDo6Z2xEaXNhYmxlKEdMX0RJVEhFUik7 CisgICAgCiAgICAgaWYgKG1fYXR0cnMuYW50aWFsaWFzKQogICAgICAgICByZXNvbHZlTXVsdGlz YW1wbGluZ0lmTmVjZXNzYXJ5KCk7CiAKQEAgLTIwOCw2ICsyMTQsMTEgQEAgdm9pZCBHcmFwaGlj c0NvbnRleHQzRDo6cHJlcGFyZVRleHR1cmUoKQogICAgICAgICA6OmdsQmluZEZyYW1lYnVmZmVy RVhUKEdyYXBoaWNzQ29udGV4dDNEOjpGUkFNRUJVRkZFUiwgbV9zdGF0ZS5ib3VuZEZCTyk7CiAg ICAgOjpnbEZpbmlzaCgpOwogICAgIG1fbGF5ZXJDb21wb3NpdGVkID0gdHJ1ZTsKKworICAgIGlm IChpc1NjaXNzb3JFbmFibGVkKQorICAgICAgICA6OmdsRW5hYmxlKEdMX1NDSVNTT1JfVEVTVCk7 CisgICAgaWYgKGlzRGl0aGVyRW5hYmxlZCkKKyAgICAgICAgOjpnbEVuYWJsZShHTF9ESVRIRVIp OwogfQogI2VuZGlmCiAK