126454 2014-01-03 12:54:01 -0800 [super dealloc] missing in Source/JavaScriptCore/API/tests/testapi.mm, fails to build with -Werror,-Wobjc-missing-super-calls 2014-01-03 18:14:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 dfarler dfarler commit-queue ddkilzer ggaren mrowe oldest_to_newest 964232 0 dfarler 2014-01-03 12:54:01 -0800 Source/JavaScriptCore/API/tests/testapi.mm:172:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls] Source/JavaScriptCore/API/tests/testapi.mm:440:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls] 964235 1 220331 dfarler 2014-01-03 12:58:05 -0800 Created attachment 220331 Patch 964237 2 220331 mrowe 2014-01-03 13:10:43 -0800 Comment on attachment 220331 Patch This'll break the 64-bit build. 964238 3 mrowe 2014-01-03 13:12:01 -0800 The file is built with ARC enabled on all architectures that support it (e.g., everything but i386), and [super dealloc] will generate an error under ARC. 964264 4 220331 ggaren 2014-01-03 14:09:57 -0800 Comment on attachment 220331 Patch It looks like we've been using "#if !__has_feature(objc_arc)" to handle stuff like this. 964268 5 dfarler 2014-01-03 14:21:26 -0800 Nice, that’s exactly what I was testing locally. 964339 6 220357 dfarler 2014-01-03 17:17:54 -0800 Created attachment 220357 Patch 964345 7 220357 ggaren 2014-01-03 17:25:29 -0800 Comment on attachment 220357 Patch r=me 964353 8 220357 dfarler 2014-01-03 17:45:44 -0800 Comment on attachment 220357 Patch Thanks! 964360 9 220357 commit-queue 2014-01-03 18:14:38 -0800 Comment on attachment 220357 Patch Clearing flags on attachment: 220357 Committed r161304: <http://trac.webkit.org/changeset/161304> 964361 10 commit-queue 2014-01-03 18:14:40 -0800 All reviewed patches have been landed. Closing bug. 220331 2014-01-03 12:58:05 -0800 2014-01-03 17:17:52 -0800 Patch bug-126454-20140103125804.patch text/plain 1631 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MmEwMmJiNWUxOWVlOGQ3NzZiYjdkM2I1MDg3Y2I4MDEwZDMyYmJmLi5kNDMzMTQ1NzRiYWZmZTAy ODlmZGMyNTVmNDY0MjljYjgxMDBjNTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNC0wMS0wMyAgRGF2aWQgRmFybGVyICA8ZGZhcmxlckBhcHBsZS5jb20+ CisKKyAgICAgICAgW3N1cGVyIGRlYWxsb2NdIG1pc3NpbmcgaW4gU291cmNlL0phdmFTY3JpcHRD b3JlL0FQSS90ZXN0cy90ZXN0YXBpLm1tLCBmYWlscyB0byBidWlsZCB3aXRoIC1XZXJyb3IsLVdv YmpjLW1pc3Npbmctc3VwZXItY2FsbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNjQ1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkubW06CisgICAgICAgICgtW1RleHRY WVogZGVhbGxvY10pOgorICAgICAgICBhZGQgW3N1cGVyIGRlYWxsb2NdCisgICAgICAgICgtW0V2 aWxBbGxvY2F0aW9uT2JqZWN0IGRlYWxsb2NdKToKKyAgICAgICAgYWRkIFtzdXBlciBkZWFsbG9j XQorCiAyMDE0LTAxLTAyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxNjAzMDQpOiBbR1RLXSBEaXNhYmxlIGxpYnRvb2wg ZmFzdCBpbnN0YWxsCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3Rz L3Rlc3RhcGkubW0gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkubW0K aW5kZXggOWZjYjRkOGY2ZTk2MWI5MTJiYTE0NDg4MmI3NjU1YzM4MWZlM2I5OC4uNzcyMTc5NDY5 NDNmNmFlOTAwMzk5MGJmNjkwZmYyNzc3MTM4MTg3MiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9BUEkvdGVzdHMvdGVzdGFwaS5tbQpAQCAtMTY5LDYgKzE2OSw3IEBAIGJvb2wgdGVzdFhZWlRl c3RlZCA9IGZhbHNlOwogLSAodm9pZClkZWFsbG9jCiB7CiAgICAgW1ttX29uY2xpY2tIYW5kbGVy IHZhbHVlXS5jb250ZXh0LnZpcnR1YWxNYWNoaW5lIHJlbW92ZU1hbmFnZWRSZWZlcmVuY2U6bV9v bmNsaWNrSGFuZGxlciB3aXRoT3duZXI6c2VsZl07CisgICAgW3N1cGVyIGRlYWxsb2NdOwogfQog QGVuZAogCkBAIC00MzcsNiArNDM4LDcgQEAgc3RhdGljIGJvb2wgZXZpbEFsbG9jYXRpb25PYmpl Y3RXYXNEZWFsbG9jZWQgPSBmYWxzZTsKIHsKICAgICBbc2VsZiBkb0V2aWxUaGluZ3NXaXRoQ29u dGV4dDptX2NvbnRleHRdOwogICAgIGV2aWxBbGxvY2F0aW9uT2JqZWN0V2FzRGVhbGxvY2VkID0g dHJ1ZTsKKyAgICBbc3VwZXIgZGVhbGxvY107CiB9CiAKIC0gKEpTVmFsdWUgKilkb0V2aWxUaGlu Z3NXaXRoQ29udGV4dDooSlNDb250ZXh0ICopY29udGV4dAo= 220357 2014-01-03 17:17:54 -0800 2014-01-03 18:14:38 -0800 Patch bug-126454-20140103171754.patch text/plain 1707 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MmEwMmJiNWUxOWVlOGQ3NzZiYjdkM2I1MDg3Y2I4MDEwZDMyYmJmLi5kNDMzMTQ1NzRiYWZmZTAy ODlmZGMyNTVmNDY0MjljYjgxMDBjNTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNC0wMS0wMyAgRGF2aWQgRmFybGVyICA8ZGZhcmxlckBhcHBsZS5jb20+ CisKKyAgICAgICAgW3N1cGVyIGRlYWxsb2NdIG1pc3NpbmcgaW4gU291cmNlL0phdmFTY3JpcHRD b3JlL0FQSS90ZXN0cy90ZXN0YXBpLm1tLCBmYWlscyB0byBidWlsZCB3aXRoIC1XZXJyb3IsLVdv YmpjLW1pc3Npbmctc3VwZXItY2FsbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNjQ1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogQVBJL3Rlc3RzL3Rlc3RhcGkubW06CisgICAgICAgICgtW1RleHRY WVogZGVhbGxvY10pOgorICAgICAgICBhZGQgW3N1cGVyIGRlYWxsb2NdCisgICAgICAgICgtW0V2 aWxBbGxvY2F0aW9uT2JqZWN0IGRlYWxsb2NdKToKKyAgICAgICAgYWRkIFtzdXBlciBkZWFsbG9j XQorCiAyMDE0LTAxLTAyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxNjAzMDQpOiBbR1RLXSBEaXNhYmxlIGxpYnRvb2wg ZmFzdCBpbnN0YWxsCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3Rz L3Rlc3RhcGkubW0gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGkubW0K aW5kZXggOWZjYjRkOGY2ZTk2MWI5MTJiYTE0NDg4MmI3NjU1YzM4MWZlM2I5OC4uZjIyMTk0YzYz NzYzZWM5ZWIwZGUxZDFjMGRiMTA2MWQxMGMzZWRmMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0YXBpLm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9BUEkvdGVzdHMvdGVzdGFwaS5tbQpAQCAtMTY5LDYgKzE2OSw5IEBAIGJvb2wgdGVzdFhZWlRl c3RlZCA9IGZhbHNlOwogLSAodm9pZClkZWFsbG9jCiB7CiAgICAgW1ttX29uY2xpY2tIYW5kbGVy IHZhbHVlXS5jb250ZXh0LnZpcnR1YWxNYWNoaW5lIHJlbW92ZU1hbmFnZWRSZWZlcmVuY2U6bV9v bmNsaWNrSGFuZGxlciB3aXRoT3duZXI6c2VsZl07CisjaWYgIV9faGFzX2ZlYXR1cmUob2JqY19h cmMpCisgICAgW3N1cGVyIGRlYWxsb2NdOworI2VuZGlmCiB9CiBAZW5kCiAKQEAgLTQzNyw2ICs0 NDAsOSBAQCBzdGF0aWMgYm9vbCBldmlsQWxsb2NhdGlvbk9iamVjdFdhc0RlYWxsb2NlZCA9IGZh bHNlOwogewogICAgIFtzZWxmIGRvRXZpbFRoaW5nc1dpdGhDb250ZXh0Om1fY29udGV4dF07CiAg ICAgZXZpbEFsbG9jYXRpb25PYmplY3RXYXNEZWFsbG9jZWQgPSB0cnVlOworI2lmICFfX2hhc19m ZWF0dXJlKG9iamNfYXJjKQorICAgIFtzdXBlciBkZWFsbG9jXTsKKyNlbmRpZgogfQogCiAtIChK U1ZhbHVlICopZG9FdmlsVGhpbmdzV2l0aENvbnRleHQ6KEpTQ29udGV4dCAqKWNvbnRleHQK