126437 2014-01-03 10:13:46 -0800 webkit-2.3.3 USE_ACCELERATE_FFT && WEBAUDIO_GSTREAMER build fails 2015-05-10 14:17:00 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126492 1 jeremyhu webkit-unassigned calvaris crogers mcatanzaro pnormand zan oldest_to_newest 964152 0 jeremyhu 2014-01-03 10:13:46 -0800 If USE_ACCELERATE_FFT is set, <gst/fft/gstfftf32.h> is not included, so WEBAUDIO_GSTREAMER builds fail with: :info:build Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp:46:38: error: use of undeclared identifier 'GstFFTF32Complex' :info:build , m_complexData(std::make_unique<GstFFTF32Complex[]>(unpackedFFTDataSize(m_FFTSize))) :info:build ^ :info:build Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp:46:55: error: expected expression :info:build , m_complexData(std::make_unique<GstFFTF32Complex[]>(unpackedFFTDataSize(m_FFTSize))) :info:build ^ :info:build mv -f Source/WebCore/platform/audio/.deps/libPlatform_la-AudioBus.Tpo Source/WebCore/platform/audio/.deps/libPlatform_la-AudioBus.Plo --- Some additional info: webkitgtk-2.3.3 $ grep -R GstFFTF32Complex * Source/WebCore/platform/audio/FFTFrame.h: std::unique_ptr<GstFFTF32Complex[]> m_complexData; Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp: , m_complexData(std::make_unique<GstFFTF32Complex[]>(unpackedFFTDataSize(m_FFTSize))) Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp: , m_complexData(std::make_unique<GstFFTF32Complex[]>(unpackedFFTDataSize(m_FFTSize))) $ grep -R GstFFTF32Complex /opt/local/include/gstreamer-1.0/ /opt/local/include/gstreamer-1.0/gst/fft/gstfftf32.h:typedef struct _GstFFTF32Complex GstFFTF32Complex; /opt/local/include/gstreamer-1.0/gst/fft/gstfftf32.h: * GstFFTF32Complex: /opt/local/include/gstreamer-1.0/gst/fft/gstfftf32.h:struct _GstFFTF32Complex /opt/local/include/gstreamer-1.0/gst/fft/gstfftf32.h: GstFFTF32Complex *freqdata); /opt/local/include/gstreamer-1.0/gst/fft/gstfftf32.h:void gst_fft_f32_inverse_fft (GstFFTF32 *self, const GstFFTF32Complex *freqdata, --- I tried to address the issue with the attached patch, but the build still fails (I'll followup with another ticket). 964154 1 220317 jeremyhu 2014-01-03 10:14:42 -0800 Created attachment 220317 gstreamer.patch 964392 2 pnormand 2014-01-04 04:23:57 -0800 I think USE_ACCELERATE_FFT should be unset when webkitgtk is built on OSX. Can you please try that approach? 964424 3 jeremyhu 2014-01-04 12:41:56 -0800 (In reply to comment #2) > I think USE_ACCELERATE_FFT should be unset when webkitgtk is built on OSX. Can you please try that approach? That's a reasonable request, but I won't be able to until #126438 is resolved. 968193 4 pnormand 2014-01-14 23:48:32 -0800 (In reply to comment #3) > (In reply to comment #2) > > I think USE_ACCELERATE_FFT should be unset when webkitgtk is built on OSX. Can you please try that approach? > > That's a reasonable request, but I won't be able to until #126438 is resolved. Hum I'm not so sure about that but I didn't really have a close look at the other bug. 1029842 5 pnormand 2014-08-18 13:29:17 -0700 (In reply to comment #2) > I think USE_ACCELERATE_FFT should be unset when webkitgtk is built on OSX. Can you please try that approach? Actually now I think it'd make more sense to use the FFTFrameMac implementation on OSX instead of the GStreamer backend. The main reason is that the Mac version would likely perform better (but I don't have benchmarks to prove it :)) 1049510 6 pnormand 2014-11-18 09:53:07 -0800 *** Bug 126438 has been marked as a duplicate of this bug. *** 1093579 7 mcatanzaro 2015-05-10 14:17:00 -0700 I believe this issue is obsolete based on comments in bug #126492. If this issue is still present in 2.8.1 or 2.9.1 please leave a note so we can reopen. 220317 2014-01-03 10:14:42 -0800 2014-01-03 10:14:42 -0800 gstreamer.patch gstreamer.patch text/plain 955 jeremyhu LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0ZGVEZyYW1lLmgub3JpZwkyMDEzLTEy LTA0IDIzOjI3OjAxLjAwMDAwMDAwMCAtMDgwMAorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v YXVkaW8vRkZURnJhbWUuaAkyMDE0LTAxLTAzIDEwOjA3OjQyLjAwMDAwMDAwMCAtMDgwMApAQCAt MzksMzEgKzM5LDI3IEBACiAKICNpZiBVU0VfQUNDRUxFUkFURV9GRlQKICNpbmNsdWRlIDxBY2Nl bGVyYXRlL0FjY2VsZXJhdGUuaD4KLSNlbmRpZgotCi0jaWYgIVVTRV9BQ0NFTEVSQVRFX0ZGVAot CisjZWxzZQogI2lmIFVTRShXRUJBVURJT19NS0wpCiAjaW5jbHVkZSAibWtsX2RmdGkuaCIKICNl bmRpZiAvLyBVU0UoV0VCQVVESU9fTUtMKQogCi0jaWYgVVNFKFdFQkFVRElPX0dTVFJFQU1FUikK LSNpbmNsdWRlIDxnbGliLmg+Ci0jaW5jbHVkZSA8bWVtb3J5PgotR19CRUdJTl9ERUNMUwotI2lu Y2x1ZGUgPGdzdC9mZnQvZ3N0ZmZ0ZjMyLmg+Ci1HX0VORF9ERUNMUwotI2VuZGlmIC8vIFVTRShX RUJBVURJT19HU1RSRUFNRVIpCi0KICNpZiBVU0UoV0VCQVVESU9fT1BFTk1BWF9ETF9GRlQpCiAj aW5jbHVkZSAiZGwvc3AvYXBpL2FybVNQLmgiCiAjaW5jbHVkZSAiZGwvc3AvYXBpL29teFNQLmgi CiAjZWxpZiBVU0UoV0VCQVVESU9fRkZNUEVHKQogc3RydWN0IFJERlRDb250ZXh0OwogI2VuZGlm Ci0KICNlbmRpZiAvLyAhVVNFX0FDQ0VMRVJBVEVfRkZUCiAKKyNpZiBVU0UoV0VCQVVESU9fR1NU UkVBTUVSKQorI2luY2x1ZGUgPGdsaWIuaD4KKyNpbmNsdWRlIDxtZW1vcnk+CitHX0JFR0lOX0RF Q0xTCisjaW5jbHVkZSA8Z3N0L2ZmdC9nc3RmZnRmMzIuaD4KK0dfRU5EX0RFQ0xTCisjZW5kaWYg Ly8gVVNFKFdFQkFVRElPX0dTVFJFQU1FUikKKwogI2lmIFVTRShXRUJBVURJT19JUFApCiAjaW5j bHVkZSA8aXBwcy5oPgogI2VuZGlmIC8vIFVTRShXRUJBVURJT19JUFApCg==