<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126431</bug_id>
          
          <creation_ts>2014-01-03 09:00:09 -0800</creation_ts>
          <short_desc>[GTK] configure errors out when building with libc++</short_desc>
          <delta_ts>2014-01-06 11:59:14 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>126325</dependson>
          <blocked>126492</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Jeremy Huddleston Sequoia">jeremyhu</reporter>
          <assigned_to name="Zan Dobersek">zan</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>mrobinson</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>964121</commentid>
    <comment_count>0</comment_count>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2014-01-03 09:00:09 -0800</bug_when>
    <thetext>In webkit-gtk-2.3.3 (compared to 2.2.3), CheckSystemAndBasicDependencies.m4 was updated to error out if anything other than libstdc++ &gt;= 4.8.1 is used.  This causes configure to error out when using libc++, but libc++ should work fine.

--- Source/autotools/CheckSystemAndBasicDependencies.m4.orig	2014-01-03 08:55:20.000000000 -0800
+++ Source/autotools/CheckSystemAndBasicDependencies.m4	2014-01-03 08:57:19.000000000 -0800
@@ -123,14 +123,6 @@ elif test &quot;$cxx_compiler&quot; = &quot;clang++&quot;; t
     OLD_CXXFLAGS=&quot;$CXXFLAGS&quot;
     CXXFLAGS=&quot;-std=c++11&quot;
     AC_LANG_PUSH([C++])
-    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
-#include &lt;type_traits&gt;
-#if defined(__GLIBCXX__) &amp;&amp; __GLIBCXX__ &gt;= 20130531
-bool libstdcxxTest = std::is_trivially_destructible&lt;bool&gt;::value;
-#else
-#error libstdc++ &gt;= 4.8.1 is required
-#endif
-])], [], [AC_MSG_ERROR([libstdc++ &gt;= 4.8.1 is required as the standard library used with the Clang compiler.])])
     AC_LANG_POP([C++])
     CXXFLAGS=&quot;$OLD_CXXFLAGS&quot;
 fi</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964122</commentid>
    <comment_count>1</comment_count>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2014-01-03 09:03:45 -0800</bug_when>
    <thetext>Note that we&apos;re using the above as a workaround.  I was just providing it to indicate the source of the problem.  It&apos;s obviously not suited for integration as you likely just want to error out if libstdc++ older than 4.8.1 is used.

I suggest you change that to:

#if defined(__GLIBCXX__) &amp;&amp; __GLIBCXX__ &lt; 20130531
#error libstdc++ &lt; 4.8.1 is not supported
#endif</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964162</commentid>
    <comment_count>2</comment_count>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2014-01-03 10:28:55 -0800</bug_when>
    <thetext>Related to #126325</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964496</commentid>
    <comment_count>3</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-01-05 05:09:46 -0800</bug_when>
    <thetext>The solution to this bug depends on bug #126325.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964581</commentid>
    <comment_count>4</comment_count>
      <attachid>220421</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-01-06 01:34:54 -0800</bug_when>
    <thetext>Created attachment 220421
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964698</commentid>
    <comment_count>5</comment_count>
      <attachid>220421</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-01-06 11:59:09 -0800</bug_when>
    <thetext>Comment on attachment 220421
Patch

Clearing flags on attachment: 220421

Committed r161359: &lt;http://trac.webkit.org/changeset/161359&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964699</commentid>
    <comment_count>6</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-01-06 11:59:14 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220421</attachid>
            <date>2014-01-06 01:34:54 -0800</date>
            <delta_ts>2014-01-06 11:59:09 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-126431-20140106013452.patch</filename>
            <type>text/plain</type>
            <size>2857</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTMz
NCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAx
LTA2ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL
XSBjb25maWd1cmUgZXJyb3JzIG91dCB3aGVuIGJ1aWxkaW5nIHdpdGggbGliYysrCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY0MzEKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFYXNlIHVwIHRoZSBDbGFu
ZyBhbmQgbGlic3RkYysrIGNvbWJpbmF0aW9uIHRlc3QgdG8gb25seSBmYWlsIGlmIGxpYnN0ZGMr
KyA8IDQuOC4xIGlzIGFjdHVhbGx5IHVzZWQuCisgICAgICAgIFRoaXMgYWxsb3dzIGZvciBsaWJj
KysgdG8gYmUgdXNlZCBhcyB3ZWxsLiBUaGUgdGVzdCBpcyBtb3ZlZCBpbnRvIFNldHVwQ29tcGls
ZXJGbGFncy5tNCBhbmQgaXMgZG9uZQorICAgICAgICBhZnRlciB0aGUgQ1hYRkxBR1MgdmFyaWFi
bGUgaXMgcHJvcGVybHkgc2V0IHVwLCB0aGF0IGlzIHdoZW4gYWxsIHRoZSBDKysgY29tcGlsZXIg
b3B0aW9ucyBhcmUgZGV0ZXJtaW5lZC4KKworICAgICAgICAqIFNvdXJjZS9hdXRvdG9vbHMvQ2hl
Y2tTeXN0ZW1BbmRCYXNpY0RlcGVuZGVuY2llcy5tNDoKKyAgICAgICAgKiBTb3VyY2UvYXV0b3Rv
b2xzL1NldHVwQ29tcGlsZXJGbGFncy5tNDoKKwogMjAxNC0wMS0wNiAgWmFuIERvYmVyc2VrICA8
emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gVXNlIGxpYmMrKyBmb3IgQysr
MTEgb24gZGFyd2luCkluZGV4OiBTb3VyY2UvYXV0b3Rvb2xzL0NoZWNrU3lzdGVtQW5kQmFzaWNE
ZXBlbmRlbmNpZXMubTQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2F1dG90b29scy9DaGVja1N5c3Rl
bUFuZEJhc2ljRGVwZW5kZW5jaWVzLm00CShyZXZpc2lvbiAxNjEzMzQpCisrKyBTb3VyY2UvYXV0
b3Rvb2xzL0NoZWNrU3lzdGVtQW5kQmFzaWNEZXBlbmRlbmNpZXMubTQJKHdvcmtpbmcgY29weSkK
QEAgLTExOSwyMCArMTE5LDYgQEAgQUNfTEFOR19QT1AoW0MrK10pCiAKIGlmIHRlc3QgIiRjeHhf
Y29tcGlsZXIiID0gInVua25vd24iOyB0aGVuCiAgICAgQUNfTVNHX0VSUk9SKFtDb21waWxlciBH
Q0MgPj0gNC43IG9yIENsYW5nID49IDMuMiBpcyByZXF1aXJlZCBmb3IgQysrIGNvbXBpbGF0aW9u
XSkKLWVsaWYgdGVzdCAiJGN4eF9jb21waWxlciIgPSAiY2xhbmcrKyI7IHRoZW4KLSAgICBPTERf
Q1hYRkxBR1M9IiRDWFhGTEFHUyIKLSAgICBDWFhGTEFHUz0iLXN0ZD1jKysxMSIKLSAgICBBQ19M
QU5HX1BVU0goW0MrK10pCi0gICAgQUNfQ09NUElMRV9JRkVMU0UoW0FDX0xBTkdfUFJPR1JBTShb
Ci0jaW5jbHVkZSA8dHlwZV90cmFpdHM+Ci0jaWYgZGVmaW5lZChfX0dMSUJDWFhfXykgJiYgX19H
TElCQ1hYX18gPj0gMjAxMzA1MzEKLWJvb2wgbGlic3RkY3h4VGVzdCA9IHN0ZDo6aXNfdHJpdmlh
bGx5X2Rlc3RydWN0aWJsZTxib29sPjo6dmFsdWU7Ci0jZWxzZQotI2Vycm9yIGxpYnN0ZGMrKyA+
PSA0LjguMSBpcyByZXF1aXJlZAotI2VuZGlmCi1dKV0sIFtdLCBbQUNfTVNHX0VSUk9SKFtsaWJz
dGRjKysgPj0gNC44LjEgaXMgcmVxdWlyZWQgYXMgdGhlIHN0YW5kYXJkIGxpYnJhcnkgdXNlZCB3
aXRoIHRoZSBDbGFuZyBjb21waWxlci5dKV0pCi0gICAgQUNfTEFOR19QT1AoW0MrK10pCi0gICAg
Q1hYRkxBR1M9IiRPTERfQ1hYRkxBR1MiCiBmaQogCiAjIEMvQysrIEhlYWRlcnMKSW5kZXg6IFNv
dXJjZS9hdXRvdG9vbHMvU2V0dXBDb21waWxlckZsYWdzLm00Cj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9hdXRvdG9vbHMvU2V0dXBDb21waWxlckZsYWdzLm00CShyZXZpc2lvbiAxNjEzMzQpCisrKyBT
b3VyY2UvYXV0b3Rvb2xzL1NldHVwQ29tcGlsZXJGbGFncy5tNAkod29ya2luZyBjb3B5KQpAQCAt
MTYsNiArMTYsMTYgQEAgaWYgdGVzdCAiJGN4eF9jb21waWxlciIgPSAiY2xhbmcrKyI7IHRoZQog
ICAgIGlmIHRlc3QgIiRvc19kYXJ3aW4iID0gInllcyI7IHRoZW4KICAgICAgICAgQVNfQ0FTRShb
JENYWEZMQUdTXSwgWyotc3RkbGliPSpdLCBbXSwgW0NYWEZMQUdTPSIkQ1hYRkxBR1MgLXN0ZGxp
Yj1saWJjKysiXSkKICAgICBmaQorCisgICAgIyBJZiBDbGFuZyB3aWxsIGJlIHVzaW5nIGxpYnN0
ZGMrKyBhcyB0aGUgc3RhbmRhcmQgbGlicmFyeSwgdmVyc2lvbiA+PSA0LjguMSBzaG91bGQgYmUg
aW4gdXNlLgorICAgIEFDX0xBTkdfUFVTSChbQysrXSkKKyAgICBBQ19DT01QSUxFX0lGRUxTRShb
QUNfTEFOR19QUk9HUkFNKFsKKyNpZiBkZWZpbmVkKF9fR0xJQkNYWF9fKSAmJiBfX0dMSUJDWFhf
XyA+PSAyMDEzMDUzMQorI2luY2x1ZGUgPHR5cGVfdHJhaXRzPgorYm9vbCBsaWJzdGRjeHhUZXN0
ID0gc3RkOjppc190cml2aWFsbHlfZGVzdHJ1Y3RpYmxlPGJvb2w+Ojp2YWx1ZTsKKyNlbmRpZgor
XSldLCBbXSwgW0FDX01TR19FUlJPUihbbGlic3RkYysrID49IDQuOC4xIGlzIHJlcXVpcmVkIGFz
IHRoZSBzdGFuZGFyZCBsaWJyYXJ5IHVzZWQgd2l0aCB0aGUgQ2xhbmcgY29tcGlsZXIuXSldKQor
ICAgIEFDX0xBTkdfUE9QKFtDKytdKQogZmkKIAogaWYgdGVzdCAiJGhvc3RfY3B1IiA9ICJzaDQi
OyB0aGVuCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>