126430 2014-01-03 06:21:13 -0800 REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214 2014-01-03 10:45:46 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned mrobinson oldest_to_newest 964077 0 cgarcia 2014-01-03 06:21:13 -0800 Because the injected bundle lib is not found. ** (WebKitWebProcess:5992): WARNING **: Error loading the injected bundle (./Tools/gtk/../../WebKitBuild/Release/Programs/libTestWebKitAPIInjectedBundle.la): ./Tools/gtk/../../WebKitBuild/Release/Programs/libTestWebKitAPIInjectedBundle.la: cannot open shared object file: No such file or directory TEST: ./Tools/gtk/../../WebKitBuild/Release/Programs/TestWebKitAPI/TestWebKit2: TIMEOUT 964078 1 220299 cgarcia 2014-01-03 06:23:07 -0800 Created attachment 220299 Patch 964079 2 220299 mrobinson 2014-01-03 06:33:34 -0800 Comment on attachment 220299 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220299&action=review > Tools/Scripts/run-gtk-tests:199 > - self._test_env["TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH"] = common.library_build_path() > + self._test_env["TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH"] = common.build_path("Libraries") library_build_path is supposed to return the path to Libraries for the autotools build and 'lib' for the cmake build. 964080 3 mrobinson 2014-01-03 06:36:19 -0800 (In reply to comment #2) > (From update of attachment 220299 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220299&action=review > > > Tools/Scripts/run-gtk-tests:199 > > - self._test_env["TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH"] = common.library_build_path() > > + self._test_env["TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH"] = common.build_path("Libraries") > > library_build_path is supposed to return the path to Libraries for the autotools build and 'lib' for the cmake build. It looks like library_build_path should just return build_path('Libraries', '.libs', *args) for autotools. Sorry about the breakage. 964081 4 cgarcia 2014-01-03 06:37:25 -0800 (In reply to comment #2) > (From update of attachment 220299 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220299&action=review > > > Tools/Scripts/run-gtk-tests:199 > > - self._test_env["TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH"] = common.library_build_path() > > + self._test_env["TEST_WEBKIT_API_WEBKIT2_INJECTED_BUNDLE_PATH"] = common.build_path("Libraries") > > library_build_path is supposed to return the path to Libraries for the autotools build and 'lib' for the cmake build. if I change common.library_build_path() I'll break the gtk doc generation 964084 5 mrobinson 2014-01-03 06:43:10 -0800 (In reply to comment #4) > if I change common.library_build_path() I'll break the gtk doc generation Can't the gtkdoc build against the real libraries, instead of the libtool wrappers? I guess it depends on what the rpath is nowadays? 964085 6 cgarcia 2014-01-03 06:46:35 -0800 (In reply to comment #5) > (In reply to comment #4) > > > if I change common.library_build_path() I'll break the gtk doc generation > > Can't the gtkdoc build against the real libraries, instead of the libtool wrappers? I guess it depends on what the rpath is nowadays? real libraries are in build_dir/.libs anyway, not in build_dir/Libraries/.libs 964087 7 mrobinson 2014-01-03 06:52:24 -0800 (In reply to comment #6) > real libraries are in build_dir/.libs anyway, not in build_dir/Libraries/.libs Ah, right! Sorry. I'm still waking up. I think the solution here is to make another function in common for the extra libraries (like libTestWebKitAPIInjectedBundle.la). 964088 8 mrobinson 2014-01-03 06:53:08 -0800 (In reply to comment #7) > (In reply to comment #6) > > > real libraries are in build_dir/.libs anyway, not in build_dir/Libraries/.libs > > Ah, right! Sorry. I'm still waking up. I think the solution here is to make another function in common for the extra libraries (like libTestWebKitAPIInjectedBundle.la). In the cmake build all the libraries are built into 'lib,' so this function could just return library_build_path. 964104 9 cgarcia 2014-01-03 08:22:23 -0800 I still don't understand what's wrong with the patch TBH. 964107 10 mrobinson 2014-01-03 08:38:25 -0800 (In reply to comment #9) > I still don't understand what's wrong with the patch TBH. The Libraries directory doesn't exist for the cmake build. It builds all libraries into <build_directory>/lib. 964110 11 cgarcia 2014-01-03 08:42:04 -0800 (In reply to comment #10) > (In reply to comment #9) > > I still don't understand what's wrong with the patch TBH. > > The Libraries directory doesn't exist for the cmake build. It builds all libraries into <build_directory>/lib. Ah, so the problem is that it fails when building with cmake. 964165 12 220320 cgarcia 2014-01-03 10:33:33 -0800 Created attachment 220320 Updated patch 964171 13 cgarcia 2014-01-03 10:45:46 -0800 Committed r161268: <http://trac.webkit.org/changeset/161268> 220299 2014-01-03 06:23:07 -0800 2014-01-03 10:33:33 -0800 Patch wk2-tests-fix.diff text/plain 1464 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyY2Ew MTY3Li5jYzY5ZmVmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDEtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE2MTIxNCk6IFtH VEtdIFdlYktpdDIgQyBBUEkgdGVzdHMgZmFpbCB0byBydW4gYWZ0ZXIgcjE2MTIxNAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2NDMwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVEVTVF9XRUJLSVRfQVBJ X1dFQktJVDJfSU5KRUNURURfQlVORExFX1BBVEggaXMgaW5jb3JyZWN0bHkgc2V0LgorCisgICAg ICAgICogU2NyaXB0cy9ydW4tZ3RrLXRlc3RzOgorICAgICAgICAoVGVzdFJ1bm5lci5fc2V0dXBf dGVzdGluZ19lbnZpcm9ubWVudCk6IFVzZSB0aGUgcmlnaHQgTGlicmFyaWVzIHBhdGguCisKIDIw MTQtMDEtMDIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtHVEtdIEFkZCBBUEkgdG8gV2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpc2lvbiB0byBj aGVjayBpZiB0aGUgTUlNRSB0eXBlIGNhbiBiZSBzaG93bgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy9ydW4tZ3RrLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCmluZGV4IGEy NzcxZmYuLjUyNGU3ZTMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwor KysgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKQEAgLTE5Niw3ICsxOTYsNyBAQCBjbGFz cyBUZXN0UnVubmVyOgogICAgICAgICBzZWxmLl90ZXN0X2VudiA9IG9zLmVudmlyb24KICAgICAg ICAgc2VsZi5fdGVzdF9lbnZbJ0dTRVRUSU5HU19CQUNLRU5EJ10gPSAnbWVtb3J5JwogICAgICAg ICBzZWxmLl90ZXN0X2VudlsiVEVTVF9XRUJLSVRfQVBJX1dFQktJVDJfUkVTT1VSQ0VTX1BBVEgi XSA9IGNvbW1vbi50b3BfbGV2ZWxfcGF0aCgiVG9vbHMiLCAiVGVzdFdlYktpdEFQSSIsICJUZXN0 cyIsICJXZWJLaXQyIikKLSAgICAgICAgc2VsZi5fdGVzdF9lbnZbIlRFU1RfV0VCS0lUX0FQSV9X RUJLSVQyX0lOSkVDVEVEX0JVTkRMRV9QQVRIIl0gPSBjb21tb24ubGlicmFyeV9idWlsZF9wYXRo KCkKKyAgICAgICAgc2VsZi5fdGVzdF9lbnZbIlRFU1RfV0VCS0lUX0FQSV9XRUJLSVQyX0lOSkVD VEVEX0JVTkRMRV9QQVRIIl0gPSBjb21tb24uYnVpbGRfcGF0aCgiTGlicmFyaWVzIikKICAgICAg ICAgc2VsZi5fdGVzdF9lbnZbIldFQktJVF9FWEVDX1BBVEgiXSA9IHNlbGYuX3Byb2dyYW1zX3Bh dGgKIAogICAgICAgICBpZiBub3Qgc2VsZi5fcnVuX3h2ZmIoKToK 220320 2014-01-03 10:33:33 -0800 2014-01-03 10:39:32 -0800 Updated patch wk2-tests-fix.diff text/plain 2367 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3YTc0 NmU3Li5jMmU5OWQ4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTQtMDEtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFJFR1JFU1NJT04ocjE2MTIxNCk6IFtH VEtdIFdlYktpdDIgQyBBUEkgdGVzdHMgZmFpbCB0byBydW4gYWZ0ZXIgcjE2MTIxNAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2NDMwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1n dGstdGVzdHM6CisgICAgICAgIChUZXN0UnVubmVyLl9zZXR1cF90ZXN0aW5nX2Vudmlyb25tZW50 KToKKyAgICAgICAgKiBndGsvY29tbW9uLnB5OiBVc2UgY29tbW9uLnRlc3RzX2xpYnJhcnlfYnVp bGRfcGF0aCgpIGluc3RlYWQuCisgICAgICAgICh0ZXN0c19saWJyYXJ5X2J1aWxkX3BhdGgpOiBI ZWxwZXIgZnVudGlvbiB0aGF0IHJldHVybnMgdGhlIHBhdGgKKyAgICAgICAgd2hlcmUgdGhlIHRl c3RzIGxpYnJhcmllcyBhcmUgYnVpbHQuCisKKzIwMTQtMDEtMDMgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIE1vdmUgYWxsIEdUSy9H T2JqZWN0IHVuaXQgdGVzdHMgdG8gVG9vbHMvVGVzdFdlYktpdEFQSQogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MzQyCiAKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwpp bmRleCBiNmZhOTU0Li41ZGFlYWYwIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1ndGst dGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCkBAIC0xOTksNyArMTk5LDcg QEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAgc2VsZi5fdGVzdF9lbnYgPSBvcy5lbnZpcm9u CiAgICAgICAgIHNlbGYuX3Rlc3RfZW52WydHU0VUVElOR1NfQkFDS0VORCddID0gJ21lbW9yeScK ICAgICAgICAgc2VsZi5fdGVzdF9lbnZbIlRFU1RfV0VCS0lUX0FQSV9XRUJLSVQyX1JFU09VUkNF U19QQVRIIl0gPSBjb21tb24udG9wX2xldmVsX3BhdGgoIlRvb2xzIiwgIlRlc3RXZWJLaXRBUEki LCAiVGVzdHMiLCAiV2ViS2l0MiIpCi0gICAgICAgIHNlbGYuX3Rlc3RfZW52WyJURVNUX1dFQktJ VF9BUElfV0VCS0lUMl9JTkpFQ1RFRF9CVU5ETEVfUEFUSCJdID0gY29tbW9uLmxpYnJhcnlfYnVp bGRfcGF0aCgpCisgICAgICAgIHNlbGYuX3Rlc3RfZW52WyJURVNUX1dFQktJVF9BUElfV0VCS0lU Ml9JTkpFQ1RFRF9CVU5ETEVfUEFUSCJdID0gY29tbW9uLnRlc3RzX2xpYnJhcnlfYnVpbGRfcGF0 aCgpCiAgICAgICAgIHNlbGYuX3Rlc3RfZW52WyJXRUJLSVRfRVhFQ19QQVRIIl0gPSBzZWxmLl9w cm9ncmFtc19wYXRoCiAKICAgICAgICAgaWYgbm90IHNlbGYuX3J1bl94dmZiKCk6CmRpZmYgLS1n aXQgYS9Ub29scy9ndGsvY29tbW9uLnB5IGIvVG9vbHMvZ3RrL2NvbW1vbi5weQppbmRleCA1YzRi NzVmLi4wMmRiOTMyIDEwMDY0NAotLS0gYS9Ub29scy9ndGsvY29tbW9uLnB5CisrKyBiL1Rvb2xz L2d0ay9jb21tb24ucHkKQEAgLTI0LDYgKzI0LDcgQEAgaW1wb3J0IHN5cwogc2NyaXB0X2RpciA9 IE5vbmUKIGJ1aWxkX2RpciA9IE5vbmUKIGxpYnJhcnlfYnVpbGRfZGlyID0gTm9uZQordGVzdHNf bGlicmFyeV9idWlsZF9kaXIgPSBOb25lCiBpc19jbWFrZSA9IE5vbmUKIGJ1aWxkX3R5cGVzID0g KCdSZWxlYXNlJywgJ0RlYnVnJykKIApAQCAtNTAsNiArNTEsMTYgQEAgZGVmIGxpYnJhcnlfYnVp bGRfcGF0aCgqYXJncyk6CiAgICAgcmV0dXJuIGxpYnJhcnlfYnVpbGRfZGlyCiAKIAorZGVmIHRl c3RzX2xpYnJhcnlfYnVpbGRfcGF0aCgqYXJncyk6CisgICAgaWYgaXNfY21ha2VfYnVpbGQoKToK KyAgICAgICAgcmV0dXJuIGxpYnJhcnlfYnVpbGRfcGF0aCgqYXJncykKKworICAgIGdsb2JhbCB0 ZXN0c19saWJyYXJ5X2J1aWxkX2RpcgorICAgIGlmIG5vdCB0ZXN0c19saWJyYXJ5X2J1aWxkX2Rp cjoKKyAgICAgICAgdGVzdHNfbGlicmFyeV9idWlsZF9kaXIgPSBidWlsZF9wYXRoKCdMaWJyYXJp ZXMnLCAqYXJncykKKyAgICByZXR1cm4gdGVzdHNfbGlicmFyeV9idWlsZF9kaXIKKworCiBkZWYg YmluYXJ5X2J1aWxkX3BhdGgoKmFyZ3MpOgogICAgIGdsb2JhbCBsaWJyYXJ5X2J1aWxkX2Rpcgog ICAgIGlmIG5vdCBsaWJyYXJ5X2J1aWxkX2RpcjoK