12643 2007-02-06 21:49:22 -0800 NPN_Status is using latin-1 encoding for the message instead of UTF-8 2007-02-14 10:12:09 -0800 1 1 1 Unclassified WebKit Plug-ins 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 ap ap darin oldest_to_newest 26525 0 ap 2007-02-06 21:49:22 -0800 I believe the convention is that char* pointers are UTF-8. 26526 1 12996 ap 2007-02-06 21:52:41 -0800 Created attachment 12996 proposed patch 26528 2 ggaren 2007-02-06 22:08:58 -0800 Comments in the file indicate that we use Latin1 on purpose to handle invalid input (since there's no such thing as invalid Latin1). Darin's check-in comment (from svn) was: Use Windows Latin-1 rather than MacRoman for messages. I guess we should test later to find out which is used by MacIE and conform to that, but for now this seems like a better default. Have you done any testing to see what other browsers support? I'd like Darin to review this, but I think it should be a - unless we're diverging from other browsers here. 26530 3 ap 2007-02-06 22:17:37 -0800 Mozilla uses UTF-8: <http://lxr.mozilla.org/mozilla1.8/source/layout/generic/nsObjectFrame.cpp#2547> 26519 4 12996 mjs 2007-02-06 22:45:42 -0800 Comment on attachment 12996 proposed patch r=me 25245 5 ggaren 2007-02-07 06:45:27 -0800 In that case, should we convert all the calls from Latin1? 24901 6 ap 2007-02-07 09:15:57 -0800 That's a fair question! While investigating this bug, I looked for other places in WebBaseNetscapePluginView.mm that handled C strings as Latin-1, and found GetURL/PostURL. However, URLs are formally ASCII anyway, so the behavior for non-ASCII ones may be more tricky, and I didn't investigate it yet. 24497 7 ap 2007-02-10 06:44:36 -0800 Darin, Geoff has suggested asking you to look at this patch before landing it - could you please take a look? 24077 8 darin 2007-02-12 10:39:53 -0800 I did look and talked to Geoff. I don't have anything definitive to say here except that: 1) we should not break existing plug-ins, even ones that have assumptions about our strange behavior 2) we should act like other browsers do, to make plug-ins work as well as possible 3) we should behave in a way that "makes sense" and works with any characters 4) if we are encoding or decoding in a way that can have failures, we need to carefully define what we do in those failure cases -- converting arbitrary bytes interpreted as Latin-1 to UTF-16 is an example of something that can never fail, as is encoding valid UTF-16 to UTF-8 bytes, where as converting to Latin-1 or decoding UTF-8 are examples of things that can fail But I assume you already know all of that. 23498 9 ap 2007-02-13 11:44:03 -0800 Committed revision 19608. I believe that in this particular case an outright failure to set status text is better than displaying garbage that may result from processing it as Latin-1, thus landing as is. 23395 10 13160 ap 2007-02-13 21:28:27 -0800 Created attachment 13160 fix the fix Darin has pointed out that I forgot the most obvious problem: CFRelease will crash when given a null parameter. So, it's still necessary to explicitly check for conversion failure. 23343 11 13160 darin 2007-02-14 08:57:16 -0800 Comment on attachment 13160 fix the fix r=me 23304 12 ap 2007-02-14 10:12:09 -0800 Committed revision 19625. 12996 2007-02-06 21:52:41 -0800 2007-02-06 22:45:42 -0800 proposed patch 12643r1_patch.txt text/plain 1375 ap SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTk0NTkpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTMgQEAKKzIwMDctMDItMDcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjQzCisgICAgICAgIE5QTl9T dGF0dXMgaXMgdXNpbmcgbGF0aW4tMSBlbmNvZGluZyBmb3IgdGhlIG1lc3NhZ2UgaW5zdGVhZCBv ZiBVVEYtOAorCisgICAgICAgICogUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVnaW5WaWV3Lm1t OgorICAgICAgICAoLVtXZWJCYXNlTmV0c2NhcGVQbHVnaW5WaWV3IHN0YXR1czpdKTogVXNlIGtD RlN0cmluZ0VuY29kaW5nVVRGOC4KKwogMjAwNy0wMi0wNiAgS2V2aW4gRGVja2VyIDxrZGVja2Vy QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXhlZDogPHJkYXI6Ly9wcm9ibGVtLzQ5NzY2ODE+IEFT U0VSVElPTiBmYWlsdXJlIG9uIHF1aXQgQCB0YWxrY3J1bmNoLmNvbSBpbiBfTlBOX1JlbGVhc2VP YmplY3QKSW5kZXg6IFdlYktpdC9QbHVnaW5zL1dlYkJhc2VOZXRzY2FwZVBsdWdpblZpZXcubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L1BsdWdpbnMvV2ViQmFzZU5ldHNjYXBlUGx1Z2luVmlldy5t bQkocmV2aXNpb24gMTk0MzQpCisrKyBXZWJLaXQvUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVn aW5WaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMjE2LDcgKzIyMTYsNyBAQCBzdGF0aWMgT1NT dGF0dXMgVFNNRXZlbnRIYW5kbGVyKEV2ZW50SGFuCiAgICAgICAgIHJldHVybjsKICAgICB9CiAK LSAgICBDRlN0cmluZ1JlZiBzdGF0dXMgPSBDRlN0cmluZ0NyZWF0ZVdpdGhDU3RyaW5nKE5VTEws IG1lc3NhZ2UsIGtDRlN0cmluZ0VuY29kaW5nV2luZG93c0xhdGluMSk7CisgICAgQ0ZTdHJpbmdS ZWYgc3RhdHVzID0gQ0ZTdHJpbmdDcmVhdGVXaXRoQ1N0cmluZyhOVUxMLCBtZXNzYWdlLCBrQ0ZT dHJpbmdFbmNvZGluZ1VURjgpOwogICAgIExPRyhQbHVnaW5zLCAiTlBOX1N0YXR1czogJUAiLCBz dGF0dXMpOwogICAgIFdlYlZpZXcgKnd2ID0gW3NlbGYgd2ViVmlld107CiAgICAgW1t3diBfVUlE ZWxlZ2F0ZUZvcndhcmRlcl0gd2ViVmlldzp3diBzZXRTdGF0dXNUZXh0OihOU1N0cmluZyAqKXN0 YXR1c107Cg== 13160 2007-02-13 21:28:27 -0800 2007-02-14 08:57:16 -0800 fix the fix 12643-2.txt text/plain 1308 ap SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTk2MTgpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTMgQEAKKzIwMDctMDItMTQgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjQzCisgICAgICAgIE5QTl9T dGF0dXMgaXMgdXNpbmcgbGF0aW4tMSBlbmNvZGluZyBmb3IgdGhlIG1lc3NhZ2UgaW5zdGVhZCBv ZiBVVEYtOAorCisgICAgICAgICogUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVnaW5WaWV3Lm1t OgorICAgICAgICAoLVtXZWJCYXNlTmV0c2NhcGVQbHVnaW5WaWV3IHN0YXR1czpdKTogQ2hlY2sg Zm9yIHBvc3NpYmxlIGNvbnZlcnNpb24gZmFpbHVyZS4KKwogMjAwNy0wMi0xMyAgT2xpdmVyIEh1 bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4uCkluZGV4 OiBXZWJLaXQvUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVnaW5WaWV3Lm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdC9QbHVnaW5zL1dlYkJhc2VOZXRzY2FwZVBsdWdpblZpZXcubW0JKHJldmlzaW9u IDE5NjE4KQorKysgV2ViS2l0L1BsdWdpbnMvV2ViQmFzZU5ldHNjYXBlUGx1Z2luVmlldy5tbQko d29ya2luZyBjb3B5KQpAQCAtMjIxNyw2ICsyMjE3LDExIEBAIHN0YXRpYyBPU1N0YXR1cyBUU01F dmVudEhhbmRsZXIoRXZlbnRIYW4KICAgICB9CiAKICAgICBDRlN0cmluZ1JlZiBzdGF0dXMgPSBD RlN0cmluZ0NyZWF0ZVdpdGhDU3RyaW5nKE5VTEwsIG1lc3NhZ2UsIGtDRlN0cmluZ0VuY29kaW5n VVRGOCk7CisgICAgaWYgKCFzdGF0dXMpIHsKKyAgICAgICAgTE9HX0VSUk9SKCJOUE5fU3RhdHVz OiB0aGUgbWVzc2FnZSB3YXMgbm90IHZhbGlkIFVURi04Iik7CisgICAgICAgIHJldHVybjsKKyAg ICB9CisgICAgCiAgICAgTE9HKFBsdWdpbnMsICJOUE5fU3RhdHVzOiAlQCIsIHN0YXR1cyk7CiAg ICAgV2ViVmlldyAqd3YgPSBbc2VsZiB3ZWJWaWV3XTsKICAgICBbW3d2IF9VSURlbGVnYXRlRm9y d2FyZGVyXSB3ZWJWaWV3Ond2IHNldFN0YXR1c1RleHQ6KE5TU3RyaW5nICopc3RhdHVzXTsK