126428 2014-01-03 04:33:45 -0800 [WinCairo] Compile error. 2014-01-03 09:17:50 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue dbates japhet oldest_to_newest 964074 0 peavo 2014-01-03 04:33:45 -0800 The CFRetain(image) call in MemoryCache::addImageToCache does not compile because the NativeImagePtr type is not an CGImageRef on WinCairo. 964075 1 220297 peavo 2014-01-03 04:50:56 -0800 Created attachment 220297 Patch 964112 2 220297 bfulgham 2014-01-03 08:49:17 -0800 Comment on attachment 220297 Patch r=me 964126 3 220297 commit-queue 2014-01-03 09:17:47 -0800 Comment on attachment 220297 Patch Clearing flags on attachment: 220297 Committed r161264: <http://trac.webkit.org/changeset/161264> 964127 4 commit-queue 2014-01-03 09:17:50 -0800 All reviewed patches have been landed. Closing bug. 220297 2014-01-03 04:50:56 -0800 2014-01-03 09:17:47 -0800 Patch bug-126428-20140103135035.patch text/plain 2409 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTI1OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTAzICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBlcnJvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyNjQyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSBOYXRpdmVJbWFnZVB0ciB0eXBlIGlzIG5vdCBhbiBDR0ltYWdlUmVmIG9uIFdpbkNh aXJvLCBjYW5ub3QgdXNlIENGUmV0YWluLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL01lbW9y eUNhY2hlLmNwcDogUmVwbGFjZSBVU0UoQ0YpIHdpdGggVVNFKENHKS4KKyAgICAgICAgKiBsb2Fk ZXIvY2FjaGUvTWVtb3J5Q2FjaGUuaDogRGl0dG8uCisKIDIwMTQtMDEtMDMgIEFuZHJlYXMgS2xp bmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB1bnVzZWQgRG9jdW1lbnQ6 Om9wZW5TZWFyY2hEZXNjcmlwdGlvblVSTCgpLgpJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVy L2NhY2hlL01lbW9yeUNhY2hlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvY2FjaGUvTWVtb3J5Q2FjaGUuY3BwCShyZXZpc2lvbiAxNjEyNTkpCisrKyBTb3VyY2UvV2Vi Q29yZS9sb2FkZXIvY2FjaGUvTWVtb3J5Q2FjaGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTIs OCArMjEyLDggQEAgdW5zaWduZWQgTWVtb3J5Q2FjaGU6OmxpdmVDYXBhY2l0eSgpIGNvbgogICAg IHJldHVybiBtX2NhcGFjaXR5IC0gZGVhZENhcGFjaXR5KCk7CiB9CiAKLSNpZiBVU0UoQ0YpCi0v LyBGSVhNRTogUmVtb3ZlIHRoZSBVU0UoQ0YpIG9uY2Ugd2UgZWl0aGVyIG1ha2UgTmF0aXZlSW1h Z2VQdHIgYSBzbWFydCBwb2ludGVyIG9uIGFsbCBwbGF0Zm9ybXMgb3IKKyNpZiBVU0UoQ0cpCisv LyBGSVhNRTogUmVtb3ZlIHRoZSBVU0UoQ0cpIG9uY2Ugd2UgZWl0aGVyIG1ha2UgTmF0aXZlSW1h Z2VQdHIgYSBzbWFydCBwb2ludGVyIG9uIGFsbCBwbGF0Zm9ybXMgb3IKIC8vIHJlbW92ZSB0aGUg dXNhZ2Ugb2YgQ0ZSZXRhaW4oKSBpbiBNZW1vcnlDYWNoZTo6YWRkSW1hZ2VUb0NhY2hlKCkgc28g YXMgdG8gbWFrZSB0aGUgY29kZSBwbGF0Zm9ybS1pbmRlcGVuZGVudC4KIGJvb2wgTWVtb3J5Q2Fj aGU6OmFkZEltYWdlVG9DYWNoZShOYXRpdmVJbWFnZVB0ciBpbWFnZSwgY29uc3QgVVJMJiB1cmws IGNvbnN0IFN0cmluZyYgY2FjaGVQYXJ0aXRpb24pCiB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9s b2FkZXIvY2FjaGUvTWVtb3J5Q2FjaGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9s b2FkZXIvY2FjaGUvTWVtb3J5Q2FjaGUuaAkocmV2aXNpb24gMTYxMjU5KQorKysgU291cmNlL1dl YkNvcmUvbG9hZGVyL2NhY2hlL01lbW9yeUNhY2hlLmgJKHdvcmtpbmcgY29weSkKQEAgLTE4OCw4 ICsxODgsOCBAQCBwdWJsaWM6CiAgICAgdW5zaWduZWQgbGl2ZVNpemUoKSBjb25zdCB7IHJldHVy biBtX2xpdmVTaXplOyB9CiAgICAgdW5zaWduZWQgZGVhZFNpemUoKSBjb25zdCB7IHJldHVybiBt X2RlYWRTaXplOyB9CiAKLSNpZiBVU0UoQ0YpCi0gICAgLy8gRklYTUU6IFJlbW92ZSB0aGUgVVNF KENGKSBvbmNlIHdlIGVpdGhlciBtYWtlIE5hdGl2ZUltYWdlUHRyIGEgc21hcnQgcG9pbnRlciBv biBhbGwgcGxhdGZvcm1zIG9yCisjaWYgVVNFKENHKQorICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhl IFVTRShDRykgb25jZSB3ZSBlaXRoZXIgbWFrZSBOYXRpdmVJbWFnZVB0ciBhIHNtYXJ0IHBvaW50 ZXIgb24gYWxsIHBsYXRmb3JtcyBvcgogICAgIC8vIHJlbW92ZSB0aGUgdXNhZ2Ugb2YgQ0ZSZXRh aW4oKSBpbiBNZW1vcnlDYWNoZTo6YWRkSW1hZ2VUb0NhY2hlKCkgc28gYXMgdG8gbWFrZSB0aGUg Y29kZSBwbGF0Zm9ybS1pbmRlcGVuZGVudC4KICAgICBib29sIGFkZEltYWdlVG9DYWNoZShOYXRp dmVJbWFnZVB0ciwgY29uc3QgVVJMJiwgY29uc3QgU3RyaW5nJiBjYWNoZVBhcnRpdGlvbik7CiAg ICAgdm9pZCByZW1vdmVJbWFnZUZyb21DYWNoZShjb25zdCBVUkwmLCBjb25zdCBTdHJpbmcmIGNh Y2hlUGFydGl0aW9uKTsK