126423 2014-01-03 00:34:52 -0800 cstack Branch: ARM64 LLInt fails to compile due to instructions limitations with sp 2014-01-03 17:23:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 964043 0 msaboff 2014-01-03 00:34:52 -0800 ARM64 has many limitations on using the stack pointer as the register number 31 is also used as the zero source xzr register. After recent CStack changes, the LLInt won't compile for ARM64 due to some of these limitations. Examples include using sp as a source operand for a store or arithmetic instruction. 964051 1 220289 msaboff 2014-01-03 00:48:48 -0800 Created attachment 220289 Patch It may make sense longer term to fix the offline assembler to transform improper pseudo ops using a source of SP to emit a "mov temp, sp ; op ..., temp, ...". That change is much larger and it is easier to cover the few cases by changing the .asm files in this patch. 964153 2 220289 fpizlo 2014-01-03 10:14:04 -0800 Comment on attachment 220289 Patch R=me. Can you also file a bug against offlineasm? *eventually* we can make offlineasm do these things for us. 964342 3 msaboff 2014-01-03 17:22:27 -0800 (In reply to comment #2) > (From update of attachment 220289 [details]) > R=me. Can you also file a bug against offlineasm? *eventually* we can make offlineasm do these things for us. Filed <https://bugs.webkit.org/show_bug.cgi?id=126476> - "ARM64 backend for Offlineasm doesn't properly handle instructions limitations of SP register" 964343 4 msaboff 2014-01-03 17:23:16 -0800 Committed r161300: <http://trac.webkit.org/changeset/161300> 220289 2014-01-03 00:48:48 -0800 2014-01-03 10:14:04 -0800 Patch 126423.patch text/plain 4795 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMjU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDE0LTAxLTAzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIGNzdGFjayBCcmFuY2g6IEFSTTY0IExMSW50IGZhaWxzIHRvIGNvbXBpbGUgZHVlIHRvIGlu c3RydWN0aW9ucyBsaW1pdGF0aW9ucyB3aXRoIHNwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY0MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEaXNhYmxlZCB0aGUgY2hlY2tTdGFja1BvaW50ZXJBbGln bm1lbnQgbWFjcm8gZm9yIEFSTTY0IHNpbmNlIGl0IHdpbGwgZmF1bHQgb24gYW55CisgICAgICAg IGltcHJvcGVyIGNoYW5nZXMgdG8gdGhlIHN0YWNrIHBvaW50ZXIgdGhhdCByZXN1bHQgaW4gYmFk IGFsaWdubWVudC4KKworICAgICAgICBDaGFuZ2VkIHVzZXMgb2Ygc3AgdG8gZWl0aGVyIG1vdmUg aW50byBhIHRlbXAgcmVnaXN0ZXIgZm9yIGNlcnRhaW4gb3BlcmF0aW9ucywgb3IKKyAgICAgICAg Y2hhbmdlZCB0aGUgb3JkZXIgb2Ygc3VidHJhY3Qgb3BlcmFuZHMuICBUaGUgb3BlcmFuZCBvcmRl cmluZyBpbmNsdWRlcyBicmFuY2gKKyAgICAgICAgY29tcGFyZSBwc2V1ZG8gb3BzLiAgSW4gdGhl IHByb2Nlc3MgZGlzY292ZXJlZCB0aGF0IHNhbml0aXplU3RhY2tGb3JWTSB3YXMgcGxhaW4KKyAg ICAgICAgd3JvbmcgYW5kIG5ldmVyIGV4ZWN1dGVkIHRoZSBjbGVhciBsb29wLCBzbyBJIGZpeGVk IHRoYXQgd2hpbGUgY2hhbmdpbmcgdGhlIG9wZXJhbmQKKyAgICAgICAgb3JkZXJpbmcgb2YgdGhl IGNvbXBhcmVzLgorCisgICAgICAgIFRoZSBBUk02NCBidWlsZCBhbHNvIGNvbXBsYWlucyB0aGF0 IHdlIGFyZSBkb2luZyBhIGNvbXBhcmUgYW5kIGJyYW5jaCB0byBhCisgICAgICAgIG5vbi1sb2Nh bCBsYWJlbCBzbyBJIGNoYW5nZWQgYnJhbmNoSWZFeGNlcHRpb24gdG8gYnJhbmNoIGFyb3VuZCBh IGptcCB0bworICAgICAgICBhIHBvc3NpYmxlIGdsb2JhbCBsYWJlbC4KKworICAgICAgICBUZXN0 ZWQgb24gWDg2LTY0LgorCisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc206 CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbToKKwogMjAxNC0wMS0w MiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkcmVzc2VkIHJl dmlldyBjb21tZW50cyBpbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI2MzkzI2M1LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50 ZXJwcmV0ZXI2NC5hc20KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50 L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc20JKHJldmlzaW9uIDE2MTI1MSkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCSh3b3JraW5nIGNv cHkpCkBAIC0xMjUsMTAgKzEyNSwxMiBAQCBtYWNybyBkb0NhbGxUb0phdmFTY3JpcHQobWFrZUNh bGwpCiAgICAgIyBlc3RpbWF0ZWQgc3RhY2tQb2ludGVyQXRWTUVudHJ5IHZhbHVlLiBBZGp1c3Qg dGhlIGpzU3RhY2tMaW1pdCBieQogICAgICMgdGhlIGRlbHRhIGJldHdlZW4gdGhlIGFjdHVhbCBz dGFja1BvaW50ZXJBdFZNRW50cnkgYW5kIHRoZSBlc3RpbWF0ZQogICAgICMgdGhhdCB3ZSB1c2Vk IHByZXZpb3VzbHkuCi0gICAgc3VicCBWTTo6c3RhY2tQb2ludGVyQXRWTUVudHJ5W3ZtXSwgc3As IHRlbXAyCisgICAgbW92ZSBzcCwgdGVtcDIKKyAgICBzdWJwIFZNOjpzdGFja1BvaW50ZXJBdFZN RW50cnlbdm1dLCB0ZW1wMiwgdGVtcDIKICAgICBzdWJwIFZNOjptX2pzU3RhY2tMaW1pdFt2bV0s IHRlbXAyLCB0ZW1wMgogICAgIHN0b3JlcCB0ZW1wMiwgVk06Om1fanNTdGFja0xpbWl0W3ZtXQot ICAgIHN0b3JlcCBzcCwgVk06OnN0YWNrUG9pbnRlckF0Vk1FbnRyeVt2bV0KKyAgICBtb3ZlIHNw LCB0ZW1wMgorICAgIHN0b3JlcCB0ZW1wMiwgVk06OnN0YWNrUG9pbnRlckF0Vk1FbnRyeVt2bV0K IAogICAgICMgVGhlIHN0YWNrIGhvc3Qgem9uZSBlbnN1cmVzIHRoYXQgd2UgaGF2ZSBhZGVxdWF0 ZSBzcGFjZSBmb3IgdGhlCiAgICAgIyBWTUVudHJ5U2VudGluZWxGcmFtZS4gUHJvY2VlZCB3aXRo IGFsbG9jYXRpbmcgYW5kIGluaXRpYWxpemluZyB0aGUKQEAgLTE5OSw3ICsyMDEsOCBAQCBtYWNy byBkb0NhbGxUb0phdmFTY3JpcHQobWFrZUNhbGwpCiAgICAgam1wIC5jb3B5QXJnc0xvb3AKIAog LmNvcHlBcmdzRG9uZToKLSAgICBzdG9yZXAgc3AsIFZNOjp0b3BDYWxsRnJhbWVbdm1dCisgICAg bW92ZSBzcCwgdGVtcDIKKyAgICBzdG9yZXAgdGVtcDIsIFZNOjp0b3BDYWxsRnJhbWVbdm1dCiAK ICAgICBtb3ZlIDB4ZmZmZjAwMDAwMDAwMDAwMCwgY3NyMQogICAgIGFkZHAgMiwgY3NyMSwgY3Ny MgpAQCAtNDMzLDcgKzQzNiw5IEBAIG1hY3JvIGJyYW5jaElmRXhjZXB0aW9uKGxhYmVsKQogICAg IGxvYWRwIFNjb3BlQ2hhaW5bY2ZyXSwgdDMKICAgICBhbmRwIE1hcmtlZEJsb2NrTWFzaywgdDMK ICAgICBsb2FkcCBNYXJrZWRCbG9jazo6bV93ZWFrU2V0ICsgV2Vha1NldDo6bV92bVt0M10sIHQz Ci0gICAgYnRxbnogVk06Om1fZXhjZXB0aW9uW3QzXSwgbGFiZWwKKyAgICBidHF6IFZNOjptX2V4 Y2VwdGlvblt0M10sIC5ub0V4Y2VwdGlvbgorICAgIGptcCBsYWJlbAorLm5vRXhjZXB0aW9uOgog ZW5kCiAKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJw cmV0ZXIuYXNtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dM ZXZlbEludGVycHJldGVyLmFzbQkocmV2aXNpb24gMTYxMjUxKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC0y MTcsMTEgKzIxNywxNSBAQCBtYWNybyBhc3NlcnQoYXNzZXJ0aW9uKQogZW5kCiAKIG1hY3JvIGNo ZWNrU3RhY2tQb2ludGVyQWxpZ25tZW50KHRlbXBSZWcsIGxvY2F0aW9uKQotICAgIGFuZHAgc3As IDB4ZiwgdGVtcFJlZwotICAgIGJ0cHogdGVtcFJlZywgLnN0YWNrUG9pbnRlck9rYXkKLSAgICBt b3ZlIGxvY2F0aW9uLCB0ZW1wUmVnCi0gICAgYnJlYWsKLS5zdGFja1BvaW50ZXJPa2F5OgorICAg IGlmIEFSTTY0CisgICAgICAgICMgQVJNNjQgd2lsbCBjaGVjayBmb3IgdXMhCisgICAgZWxzZQor ICAgICAgICBhbmRwIHNwLCAweGYsIHRlbXBSZWcKKyAgICAgICAgYnRweiB0ZW1wUmVnLCAuc3Rh Y2tQb2ludGVyT2theQorICAgICAgICBtb3ZlIGxvY2F0aW9uLCB0ZW1wUmVnCisgICAgICAgIGJy ZWFrCisgICAgLnN0YWNrUG9pbnRlck9rYXk6CisgICAgZW5kCiBlbmQKIAogbWFjcm8gcHJlc2Vy dmVDYWxsZXJQQ0FuZENGUigpCkBAIC00MzMsNyArNDM3LDEyIEBAIG1hY3JvIHByb2xvZ3VlKGNv ZGVCbG9ja0dldHRlciwgY29kZUJsb2MKICAgICAgICAgY0NhbGwyKG9zclNsb3dQYXRoLCBjZnIs IFBDKQogICAgICAgICBidHB6IHQwLCAucmVjb3ZlcgogICAgICAgICBtb3ZlIGNmciwgc3AgIyBy ZXN0b3JlIHRoZSBwcmV2aW91cyBzcAotICAgICAgICBwb3AgY2ZyICMgcG9wIHRoZSBjYWxsZXJG cmFtZSBzaW5jZSB3ZSB3aWxsIGp1bXAgdG8gYSBmdW5jdGlvbiB0aGF0IHdhbnRzIHRvIHNhdmUg aXQKKyAgICAgICAgIyBwb3AgdGhlIGNhbGxlckZyYW1lIHNpbmNlIHdlIHdpbGwganVtcCB0byBh IGZ1bmN0aW9uIHRoYXQgd2FudHMgdG8gc2F2ZSBpdAorICAgICAgICBpZiBBUk02NAorICAgICAg ICAgICAgcG9wTFJBbmRGUAorICAgICAgICBlbHNlCisgICAgICAgICAgICBwb3AgY2ZyCisgICAg ICAgIGVuZAogICAgICAgICBqbXAgdDAKICAgICAucmVjb3ZlcjoKICAgICAgICAgY29kZUJsb2Nr R2V0dGVyKHQxKQpAQCAtNTY4LDE2ICs1NzcsMTcgQEAgX3Nhbml0aXplU3RhY2tGb3JWTToKICAg ICBlbmQKIAogICAgIGxvYWRwIFZNOjptX2xhc3RTdGFja1RvcFt2bV0sIGFkZHJlc3MKLSAgICBi cGFlcSBhZGRyZXNzLCBzcCwgLnplcm9GaWxsRG9uZQorICAgIGJwYmVxIHNwLCBhZGRyZXNzLCAu emVyb0ZpbGxEb25lCiAKICAgICBtb3ZlIDAsIHplcm9WYWx1ZQogLnplcm9GaWxsTG9vcDoKICAg ICBzdG9yZXAgemVyb1ZhbHVlLCBbYWRkcmVzc10KLSAgICBzdWJwIFB0clNpemUsIGFkZHJlc3MK LSAgICBicGIgYWRkcmVzcywgc3AsIC56ZXJvRmlsbERvbmUKKyAgICBhZGRwIFB0clNpemUsIGFk ZHJlc3MKKyAgICBicGEgc3AsIGFkZHJlc3MsIC56ZXJvRmlsbExvb3AKIAogLnplcm9GaWxsRG9u ZToKLSAgICBzdG9yZXAgc3AsIFZNOjptX2xhc3RTdGFja1RvcFt2bV0KKyAgICBtb3ZlIHNwLCBh ZGRyZXNzCisgICAgc3RvcmVwIGFkZHJlc3MsIFZNOjptX2xhc3RTdGFja1RvcFt2bV0KICAgICBy ZXQKIAogCg==