126422 2014-01-03 00:25:41 -0800 CStack Branch: slowPathFor in ThunkGenerators.cpp fail to compile 2014-01-03 17:46:37 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 1 msaboff msaboff oldest_to_newest 964039 0 msaboff 2014-01-03 00:25:41 -0800 slowPathFor() in ThunkGenerators.cpp cause a compilation failure on ARM64 due to missing noreturn attribute. 964041 1 220287 msaboff 2014-01-03 00:27:55 -0800 Created attachment 220287 Patch 964151 2 220287 fpizlo 2014-01-03 10:12:25 -0800 Comment on attachment 220287 Patch I really don't like the use of these pragmas. Is this because slowPathFor calls a function marked NORETURN? If so, remove NORETURN from that function. Can't remove NORETURN from a function because it uses CRASH() or RELEASE_ASSERT_NOT_REACHED()? In that case, just use UNREACHABLE_FOR_PLATFORM() instead. 964354 3 msaboff 2014-01-03 17:46:37 -0800 (In reply to comment #2) > (From update of attachment 220287 [details]) > I really don't like the use of these pragmas. Is this because slowPathFor calls a function marked NORETURN? If so, remove NORETURN from that function. Can't remove NORETURN from a function because it uses CRASH() or RELEASE_ASSERT_NOT_REACHED()? In that case, just use UNREACHABLE_FOR_PLATFORM() instead. This bug is no longer needed. The compilation issue was due to pop(callFrameRegister) being a CRASH() on ARM64. Fixing the real issue now handled in <https://bugs.webkit.org/show_bug.cgi?id=126478> - "CStack Branch: slowPathFor() should emit an epilogue instead of popping the callFrameRegister". 220287 2014-01-03 00:27:55 -0800 2014-01-03 10:12:25 -0800 Patch 126422.patch text/plain 1700 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMjU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTAxLTAzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IHNsb3dQYXRoRm9yIGluIFRodW5rR2VuZXJhdG9ycy5jcHAgZmFp bCB0byBjb21waWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjY0MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGRlZCBkaWFnbm9zdGljIGlnbm9yZWQgIi1XbWlzc2luZy1ub3JldHVybiIgcHJhZ21h cyBmb3IgY2xhbiB0byBzaWxlbmNlIAorICAgICAgICB0aGUgd2FybmluZyBhbmQgYWxsb3cgdGhl IGZpbGUgdG8gY29tcGlsZS4KKworICAgICAgICAqIGppdC9UaHVua0dlbmVyYXRvcnMuY3BwOgor CiAyMDE0LTAxLTAyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBB ZGRyZXNzZWQgcmV2aWV3IGNvbW1lbnRzIGluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjYzOTMjYzUuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1Ro dW5rR2VuZXJhdG9ycy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9UaHVua0dlbmVyYXRvcnMuY3BwCShyZXZpc2lvbiAxNjEyNTEpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc2LDYg Kzc2LDEwIEBAIE1hY3JvQXNzZW1ibGVyQ29kZVJlZiB0aHJvd0V4Y2VwdGlvbkZyb20KICAgICBy ZXR1cm4gRklOQUxJWkVfQ09ERShwYXRjaEJ1ZmZlciwgKCJUaHJvdyBleGNlcHRpb24gZnJvbSBj YWxsIHNsb3cgcGF0aCB0aHVuayIpKTsKIH0KIAorI2lmIENPTVBJTEVSKENMQU5HKQorI3ByYWdt YSBjbGFuZyBkaWFnbm9zdGljIHB1c2gKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVk ICItV21pc3Npbmctbm9yZXR1cm4iCisjZW5kaWYKIHN0YXRpYyB2b2lkIHNsb3dQYXRoRm9yKAog ICAgIENDYWxsSGVscGVycyYgaml0LCBWTSogdm0sIFBfSklUT3BlcmF0aW9uX0Ugc2xvd1BhdGhG dW5jdGlvbikKIHsKQEAgLTk0LDYgKzk4LDkgQEAgc3RhdGljIHZvaWQgc2xvd1BhdGhGb3IoCiAg ICAgaml0LnBvcChHUFJJbmZvOjpjYWxsRnJhbWVSZWdpc3Rlcik7CiAgICAgaml0Lmp1bXAoR1BS SW5mbzo6cmV0dXJuVmFsdWVHUFIpOwogfQorI2lmIENPTVBJTEVSKENMQU5HKQorI3ByYWdtYSBj bGFuZyBkaWFnbm9zdGljIHBvcAorI2VuZGlmCiAKIHN0YXRpYyBNYWNyb0Fzc2VtYmxlckNvZGVS ZWYgbGlua0ZvclRodW5rR2VuZXJhdG9yKAogICAgIFZNKiB2bSwgQ29kZVNwZWNpYWxpemF0aW9u S2luZCBraW5kLCBSZWdpc3RlclByZXNlcnZhdGlvbk1vZGUgcmVnaXN0ZXJzKQo=