126421 2014-01-03 00:16:53 -0800 CStack Branch: Make emitPutToCallFrameHeaderBeforePrologue and friends work for all platforms 2014-01-03 16:54:29 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 964034 0 msaboff 2014-01-03 00:16:53 -0800 Currently AssemblyHelpers::emitPutToCallFrameHeaderBeforePrologue() only works for X86. We need to make it work for all platforms. 964036 1 220286 msaboff 2014-01-03 00:21:14 -0800 Created attachment 220286 Patch 964329 2 msaboff 2014-01-03 16:54:29 -0800 Committed r161298: <http://trac.webkit.org/changeset/161298> 220286 2014-01-03 00:21:14 -0800 2014-01-03 10:09:35 -0800 Patch 126421.patch text/plain 6571 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMjU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE0LTAxLTAzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IE1ha2UgZW1pdFB1dFRvQ2FsbEZyYW1lSGVhZGVyQmVmb3JlUHJv bG9ndWUgYW5kIGZyaWVuZHMgd29yayBmb3IgYWxsIHBsYXRmb3JtcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2NDIxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgbmV3IGhlbHBlciBwcm9sb2d1 ZVN0YWNrUG9pbnRlckRlbHRhKCkgdGhhdCByZXR1cm5zIHRoZSBhbW91bnQgdGhlIHN0YWNrCisg ICAgICAgIHBvaW50ZXIgc2hvdWxkIGJlIGFkanVzdGVkIHdoZW4gYWNjZXNzaW5nIGEgQ2FsbEZy YW1lIHZpYSB0aGUgc3RhY2sgcG9pbnRlcgorICAgICAgICBiZWZvcmUgdGhlIGZ1bmN0aW9uIHBy b2xvZ3VlIGhhcyBiZWVuIGV4ZWN1dGVkLgorCisgICAgICAgICogaml0L0Fzc2VtYmx5SGVscGVy cy5oOgorICAgICAgICAoSlNDOjpBc3NlbWJseUhlbHBlcnM6OnByb2xvZ3VlU3RhY2tQb2ludGVy RGVsdGEpOgorICAgICAgICAoSlNDOjpBc3NlbWJseUhlbHBlcnM6OmVtaXRGdW5jdGlvbkVwaWxv Z3VlKToKKyAgICAgICAgKEpTQzo6QXNzZW1ibHlIZWxwZXJzOjplbWl0UHV0VG9DYWxsRnJhbWVI ZWFkZXJCZWZvcmVQcm9sb2d1ZSk6CisgICAgICAgIChKU0M6OkFzc2VtYmx5SGVscGVyczo6ZW1p dFB1dFBheWxvYWRUb0NhbGxGcmFtZUhlYWRlckJlZm9yZVByb2xvZ3VlKToKKyAgICAgICAgKEpT Qzo6QXNzZW1ibHlIZWxwZXJzOjplbWl0UHV0VGFnVG9DYWxsRnJhbWVIZWFkZXJCZWZvcmVQcm9s b2d1ZSk6CisKIDIwMTQtMDEtMDIgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZHJlc3NlZCByZXZpZXcgY29tbWVudHMgaW4gaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNjM5MyNjNS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvQXNzZW1ibHlIZWxwZXJzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9Bc3NlbWJseUhlbHBlcnMuaAkocmV2aXNpb24gMTYxMjUxKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9Bc3NlbWJseUhlbHBlcnMuaAkod29ya2luZyBjb3B5KQpAQCAtNTgs OCArNTgsNyBAQCBwdWJsaWM6CiAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2soKSB7IHJldHVybiBt X2NvZGVCbG9jazsgfQogICAgIFZNKiB2bSgpIHsgcmV0dXJuIG1fdm07IH0KICAgICBBc3NlbWJs ZXJUeXBlX1QmIGFzc2VtYmxlcigpIHsgcmV0dXJuIG1fYXNzZW1ibGVyOyB9Ci0gICAgCi0jaWYg Q1BVKFg4Nl82NCkgfHwgQ1BVKFg4NikKKwogICAgIHZvaWQgY2hlY2tTdGFja1BvaW50ZXJBbGln bm1lbnQoKQogICAgIHsKICNpZm5kZWYgTkRFQlVHCkBAIC02OSw2ICs2OCwxMyBAQCBwdWJsaWM6 CiAjZW5kaWYKICAgICB9CiAKKyNpZiBDUFUoWDg2XzY0KSB8fCBDUFUoWDg2KQorICAgIHNpemVf dCBwcm9sb2d1ZVN0YWNrUG9pbnRlckRlbHRhKCkKKyAgICB7CisgICAgICAgIC8vIFByb2xvZ3Vl IG9ubHkgc2F2ZXMgdGhlIGZyYW1lUG9pbnRlclJlZ2lzdGVyCisgICAgICAgIHJldHVybiBzaXpl b2Yodm9pZCopOworICAgIH0KKwogICAgIHZvaWQgZW1pdEZ1bmN0aW9uUHJvbG9ndWUoKQogICAg IHsKICAgICAgICAgcHVzaChmcmFtZVBvaW50ZXJSZWdpc3Rlcik7CkBAIC03NywxMSArODMsMTAg QEAgcHVibGljOgogCiAgICAgdm9pZCBlbWl0RnVuY3Rpb25FcGlsb2d1ZSgpCiAgICAgewotICAg ICAgICAvLyBGSVhNRTogVGhlIHN0YWNrIHBvaW50ZXIgbmVlZCB0byBiZSBjYWxjdWxhdGVkIGZy b20gdGhlIGZyYW1lUG9pbnRlcgogICAgICAgICBtb3ZlKGZyYW1lUG9pbnRlclJlZ2lzdGVyLCBz dGFja1BvaW50ZXJSZWdpc3Rlcik7CiAgICAgICAgIHBvcChmcmFtZVBvaW50ZXJSZWdpc3Rlcik7 CiAgICAgfQotICAgIAorCiAgICAgdm9pZCBwcmVzZXJ2ZVJldHVybkFkZHJlc3NBZnRlckNhbGwo R1BSUmVnIHJlZykKICAgICB7CiAgICAgICAgIHBvcChyZWcpOwpAQCAtOTYsMzIgKzEwMSwxNSBA QCBwdWJsaWM6CiAgICAgewogICAgICAgICBwdXNoKGFkZHJlc3MpOwogICAgIH0KKyNlbmRpZiAv LyBDUFUoWDg2XzY0KSB8fCBDUFUoWDg2KQogCi0gICAgLy8gZW1pdFB1dFRvQ2FsbEZyYW1lSGVh ZGVyQmVmb3JlUHJvbG9ndWUoKSBhbmQgcmVsYXRlZCBhcmUgdXNlZCB0byBhY2Nlc3MgY2FsbGVl IGZyYW1lIGhlYWRlcgotICAgIC8vIGZpZWxkcyBiZWZvcmUgdGhlIGNvZGUgZnJvbSBlbWl0RnVu Y3Rpb25Qcm9sb2d1ZSgpIGhhcyBleGVjdXRlZC4KLSAgICAvLyBGaXJzdCwgdGhlIGFjY2VzcyBp cyB2aWEgdGhlIHN0YWNrIHBvaW50ZXIuIFNlY29uZCwgdGhlIGFkZHJlc3MgY2FsY3VsYXRpb24g bXVzdCBhbHNvIHRha2UKLSAgICAvLyBpbnRvIGFjY291bnQgdGhhdCB0aGUgc3RhY2sgcG9pbnRl ciBtYXkgbm90IGhhdmUgYmVlbiBhZGp1c3RlZCBkb3duIGZvciB0aGUgcmV0dXJuIFBDIGFuZC9v cgotICAgIC8vIGNhbGxlcidzIGZyYW1lIHBvaW50ZXIuIE9uIHNvbWUgcGxhdGZvcm1zLCB0aGUg Y2FsbGVlIGlzIHJlc3BvbnNpYmxlIGZvciBwdXNoaW5nIHRoZQotICAgIC8vICJsaW5rIHJlZ2lz dGVyIiBjb250YWluaW5nIHRoZSByZXR1cm4gYWRkcmVzcyBpbiB0aGUgZnVuY3Rpb24gcHJvbG9n dWUuCi0jaWYgVVNFKEpTVkFMVUU2NCkKLSAgICB2b2lkIGVtaXRQdXRUb0NhbGxGcmFtZUhlYWRl ckJlZm9yZVByb2xvZ3VlKEdQUlJlZyBmcm9tLCBKU1N0YWNrOjpDYWxsRnJhbWVIZWFkZXJFbnRy eSBlbnRyeSkKLSAgICB7Ci0gICAgICAgIHN0b3JlUHRyKGZyb20sIEFkZHJlc3Moc3RhY2tQb2lu dGVyUmVnaXN0ZXIsIGVudHJ5ICogc3RhdGljX2Nhc3Q8cHRyZGlmZl90PihzaXplb2YoUmVnaXN0 ZXIpKSAtIHNpemVvZih2b2lkKikpKTsKLSAgICB9Ci0jZWxzZQotICAgIHZvaWQgZW1pdFB1dFBh eWxvYWRUb0NhbGxGcmFtZUhlYWRlckJlZm9yZVByb2xvZ3VlKEdQUlJlZyBmcm9tLCBKU1N0YWNr OjpDYWxsRnJhbWVIZWFkZXJFbnRyeSBlbnRyeSkKLSAgICB7Ci0gICAgICAgIHN0b3JlUHRyKGZy b20sIEFkZHJlc3Moc3RhY2tQb2ludGVyUmVnaXN0ZXIsIGVudHJ5ICogc3RhdGljX2Nhc3Q8cHRy ZGlmZl90PihzaXplb2YoUmVnaXN0ZXIpKSAtIHNpemVvZih2b2lkKikgKyBPQkpFQ1RfT0ZGU0VU T0YoRW5jb2RlZFZhbHVlRGVzY3JpcHRvciwgYXNCaXRzLnBheWxvYWQpKSk7Ci0gICAgfQotCi0g ICAgdm9pZCBlbWl0UHV0VGFnVG9DYWxsRnJhbWVIZWFkZXJCZWZvcmVQcm9sb2d1ZShUcnVzdGVk SW1tMzIgdGFnLCBKU1N0YWNrOjpDYWxsRnJhbWVIZWFkZXJFbnRyeSBlbnRyeSkKKyNpZiBDUFUo QVJNKSB8fCBDUFUoQVJNNjQpCisgICAgc2l6ZV90IHByb2xvZ3VlU3RhY2tQb2ludGVyRGVsdGEo KQogICAgIHsKLSAgICAgICAgc3RvcmVQdHIodGFnLCBBZGRyZXNzKHN0YWNrUG9pbnRlclJlZ2lz dGVyLCBlbnRyeSAqIHN0YXRpY19jYXN0PHB0cmRpZmZfdD4oc2l6ZW9mKFJlZ2lzdGVyKSkgLSBz aXplb2Yodm9pZCopICsgT0JKRUNUX09GRlNFVE9GKEVuY29kZWRWYWx1ZURlc2NyaXB0b3IsIGFz Qml0cy50YWcpKSk7CisgICAgICAgIC8vIFByb2xvZ3VlIHNhdmVzIHRoZSBmcmFtZVBvaW50ZXJS ZWdpc3RlciBhbmQgbGlua1JlZ2lzdGVyCisgICAgICAgIHJldHVybiAyICogc2l6ZW9mKHZvaWQq KTsKICAgICB9Ci0jZW5kaWYKLSNlbmRpZiAvLyBDUFUoWDg2XzY0KSB8fCBDUFUoWDg2KQogCi0j aWYgQ1BVKEFSTSkgfHwgQ1BVKEFSTTY0KQogICAgIEFMV0FZU19JTkxJTkUgdm9pZCBwcmVzZXJ2 ZVJldHVybkFkZHJlc3NBZnRlckNhbGwoUmVnaXN0ZXJJRCByZWcpCiAgICAgewogICAgICAgICBt b3ZlKGxpbmtSZWdpc3RlciwgcmVnKTsKQEAgLTEzOSw2ICsxMjcsMTIgQEAgcHVibGljOgogI2Vu ZGlmCiAKICNpZiBDUFUoTUlQUykKKyAgICBzaXplX3QgcHJvbG9ndWVTdGFja1BvaW50ZXJEZWx0 YSgpCisgICAgeworICAgICAgICAvLyBQcm9sb2d1ZSBzYXZlcyB0aGUgZnJhbWVQb2ludGVyUmVn aXN0ZXIgYW5kIHJldHVybkFkZHJlc3NSZWdpc3RlcgorICAgICAgICByZXR1cm4gMiAqIHNpemVv Zih2b2lkKik7CisgICAgfQorICAgIAogICAgIEFMV0FZU19JTkxJTkUgdm9pZCBwcmVzZXJ2ZVJl dHVybkFkZHJlc3NBZnRlckNhbGwoUmVnaXN0ZXJJRCByZWcpCiAgICAgewogICAgICAgICBtb3Zl KHJldHVybkFkZHJlc3NSZWdpc3RlciwgcmVnKTsKQEAgLTE1Niw2ICsxNTAsMTIgQEAgcHVibGlj OgogI2VuZGlmCiAKICNpZiBDUFUoU0g0KQorICAgIHNpemVfdCBwcm9sb2d1ZVN0YWNrUG9pbnRl ckRlbHRhKCkKKyAgICB7CisgICAgICAgIC8vIFByb2xvZ3VlIHNhdmVzIHRoZSBmcmFtZVBvaW50 ZXJSZWdpc3RlciBhbmQgbGluayByZWdpc3RlcgorICAgICAgICByZXR1cm4gMiAqIHNpemVvZih2 b2lkKik7CisgICAgfQorICAgIAogICAgIEFMV0FZU19JTkxJTkUgdm9pZCBwcmVzZXJ2ZVJldHVy bkFkZHJlc3NBZnRlckNhbGwoUmVnaXN0ZXJJRCByZWcpCiAgICAgewogICAgICAgICBtX2Fzc2Vt Ymxlci5zdHNwcihyZWcpOwpAQCAtMjA4LDYgKzIwOCwyOSBAQCBwdWJsaWM6CiAgICAgICAgIHN0 b3JlUHRyKGZyb20sIEFkZHJlc3MoR1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIsIENhbGxGcmFt ZTo6cmV0dXJuUENPZmZzZXQoKSkpOwogICAgIH0KIAorICAgIC8vIGVtaXRQdXRUb0NhbGxGcmFt ZUhlYWRlckJlZm9yZVByb2xvZ3VlKCkgYW5kIHJlbGF0ZWQgYXJlIHVzZWQgdG8gYWNjZXNzIGNh bGxlZSBmcmFtZSBoZWFkZXIKKyAgICAvLyBmaWVsZHMgYmVmb3JlIHRoZSBjb2RlIGZyb20gZW1p dEZ1bmN0aW9uUHJvbG9ndWUoKSBoYXMgZXhlY3V0ZWQuCisgICAgLy8gRmlyc3QsIHRoZSBhY2Nl c3MgaXMgdmlhIHRoZSBzdGFjayBwb2ludGVyLiBTZWNvbmQsIHRoZSBhZGRyZXNzIGNhbGN1bGF0 aW9uIG11c3QgYWxzbyB0YWtlCisgICAgLy8gaW50byBhY2NvdW50IHRoYXQgdGhlIHN0YWNrIHBv aW50ZXIgbWF5IG5vdCBoYXZlIGJlZW4gYWRqdXN0ZWQgZG93biBmb3IgdGhlIHJldHVybiBQQyBh bmQvb3IKKyAgICAvLyBjYWxsZXIncyBmcmFtZSBwb2ludGVyLiBPbiBzb21lIHBsYXRmb3Jtcywg dGhlIGNhbGxlZSBpcyByZXNwb25zaWJsZSBmb3IgcHVzaGluZyB0aGUKKyAgICAvLyAibGluayBy ZWdpc3RlciIgY29udGFpbmluZyB0aGUgcmV0dXJuIGFkZHJlc3MgaW4gdGhlIGZ1bmN0aW9uIHBy b2xvZ3VlLgorI2lmIFVTRShKU1ZBTFVFNjQpCisgICAgdm9pZCBlbWl0UHV0VG9DYWxsRnJhbWVI ZWFkZXJCZWZvcmVQcm9sb2d1ZShHUFJSZWcgZnJvbSwgSlNTdGFjazo6Q2FsbEZyYW1lSGVhZGVy RW50cnkgZW50cnkpCisgICAgeworICAgICAgICBzdG9yZVB0cihmcm9tLCBBZGRyZXNzKHN0YWNr UG9pbnRlclJlZ2lzdGVyLCBlbnRyeSAqIHN0YXRpY19jYXN0PHB0cmRpZmZfdD4oc2l6ZW9mKFJl Z2lzdGVyKSkgLSBwcm9sb2d1ZVN0YWNrUG9pbnRlckRlbHRhKCkpKTsKKyAgICB9CisjZWxzZQor ICAgIHZvaWQgZW1pdFB1dFBheWxvYWRUb0NhbGxGcmFtZUhlYWRlckJlZm9yZVByb2xvZ3VlKEdQ UlJlZyBmcm9tLCBKU1N0YWNrOjpDYWxsRnJhbWVIZWFkZXJFbnRyeSBlbnRyeSkKKyAgICB7Cisg ICAgICAgIHN0b3JlUHRyKGZyb20sIEFkZHJlc3Moc3RhY2tQb2ludGVyUmVnaXN0ZXIsIGVudHJ5 ICogc3RhdGljX2Nhc3Q8cHRyZGlmZl90PihzaXplb2YoUmVnaXN0ZXIpKSAtIHByb2xvZ3VlU3Rh Y2tQb2ludGVyRGVsdGEoKSArIE9CSkVDVF9PRkZTRVRPRihFbmNvZGVkVmFsdWVEZXNjcmlwdG9y LCBhc0JpdHMucGF5bG9hZCkpKTsKKyAgICB9CisKKyAgICB2b2lkIGVtaXRQdXRUYWdUb0NhbGxG cmFtZUhlYWRlckJlZm9yZVByb2xvZ3VlKFRydXN0ZWRJbW0zMiB0YWcsIEpTU3RhY2s6OkNhbGxG cmFtZUhlYWRlckVudHJ5IGVudHJ5KQorICAgIHsKKyAgICAgICAgc3RvcmVQdHIodGFnLCBBZGRy ZXNzKHN0YWNrUG9pbnRlclJlZ2lzdGVyLCBlbnRyeSAqIHN0YXRpY19jYXN0PHB0cmRpZmZfdD4o c2l6ZW9mKFJlZ2lzdGVyKSkgLSBwcm9sb2d1ZVN0YWNrUG9pbnRlckRlbHRhKCkgKyBPQkpFQ1Rf T0ZGU0VUT0YoRW5jb2RlZFZhbHVlRGVzY3JpcHRvciwgYXNCaXRzLnRhZykpKTsKKyAgICB9Cisj ZW5kaWYKKwogICAgIEp1bXAgYnJhbmNoSWZOb3RDZWxsKEdQUlJlZyByZWcpCiAgICAgewogI2lm IFVTRShKU1ZBTFVFNjQpCg==