126417 2014-01-02 22:32:18 -0800 VibrationPattern should allocate an single vector instance for single integer input 2014-01-03 00:41:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song bunhere cdumez commit-queue gyuyoung.kim gyuyoung.kim kihong.kwon rakuco oldest_to_newest 964008 0 jinwoo7.song 2014-01-02 22:32:18 -0800 When the Vibration pattern is set with a single integer, the VibrationPattern should set the vibration time with this value. But the VibrationPattern(unsigned vector) was initialized with a single parameter, the vibration time, so the time was used to set the size of vector. 964012 1 220281 jinwoo7.song 2014-01-02 22:48:43 -0800 Created attachment 220281 Patch 964025 2 gyuyoung.kim 2014-01-02 23:44:31 -0800 CC'ing Kihong 964030 3 220281 gyuyoung.kim 2014-01-03 00:04:05 -0800 Comment on attachment 220281 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220281&action=review LGTM > Source/WebCore/Modules/vibration/NavigatorVibration.cpp:43 > + return NavigatorVibration::vibrate(navigator, VibrationPattern(1, time)); Good catch ! We have missed this one so far. 964046 4 220281 commit-queue 2014-01-03 00:41:19 -0800 Comment on attachment 220281 Patch Clearing flags on attachment: 220281 Committed r161257: <http://trac.webkit.org/changeset/161257> 964047 5 commit-queue 2014-01-03 00:41:22 -0800 All reviewed patches have been landed. Closing bug. 220281 2014-01-02 22:48:43 -0800 2014-01-03 00:41:19 -0800 Patch bug-126417-20140103154841.patch text/plain 6335 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQ5NDQyOWNjZjBjNDBl N2QyNTgyYjI5ZTk5ODg2ZjAxZTFhMTVkNS4uZGFmODc4NWExYmYwYTRjZjM3NTIzNDBiMTE2YzMy NGYzNGFmM2UxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAxLTAyICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBWaWJyYXRpb25Q YXR0ZXJuIHNob3VsZCBhbGxvY2F0ZSBhbiBzaW5nbGUgdmVjdG9yIGluc3RhbmNlIGZvciBzaW5n bGUgaW50ZWdlciBpbnB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI2NDE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiB0aGUgVmlicmF0aW9uIHBhdHRlcm4gaXMgc2V0IHdpdGggYSBzaW5nbGUg aW50ZWdlciwgdGhlIFZpYnJhdGlvblBhdHRlcm4gc2hvdWxkCisgICAgICAgIGJlIHNldCB3aXRo IHRoaXMgaW50ZWdlciBhcyBhIHZpYnJhdGlvbiB0aW1lLiBCdXQgdGhlIFZpYnJhdGlvblBhdHRl cm4odW5zaWduZWQgdmVjdG9yKSB3YXMKKyAgICAgICAgaW5pdGlhbGl6ZWQgd2l0aCBhIHNpbmds ZSBwYXJhbWV0ZXIsIHRoZSB2aWJyYXRpb24gdGltZSwgc28gdGhlIHRpbWUgd2FzIHVzZWQgdG8g c2V0CisgICAgICAgIHRoZSBzaXplIG9mIHZlY3Rvci4KKworICAgICAgICAqIE1vZHVsZXMvdmli cmF0aW9uL05hdmlnYXRvclZpYnJhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOYXZpZ2F0 b3JWaWJyYXRpb246OnZpYnJhdGUpOgorCiAyMDE0LTAxLTAyICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJHTF0gQ29ycmVjdCBzeW1ib2wgbG9va3Vw IGxvZ2ljIHRvIGhhbmRsZSAxLWVsZW1lbnQgYXJyYXlzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDUwZjNlYjZm ODJlYTg0M2JkMWY4OGY5NDU3YmIwMThiNTFlNzkzNy4uZGNmMjgwNzc3OTdhMjI3ZjY2ZTQ1NjM4 MmRiNmU0MDhiODIyNTZhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAxLTAy ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBWaWJy YXRpb25QYXR0ZXJuIHNob3VsZCBhbGxvY2F0ZSBhbiBzaW5nbGUgdmVjdG9yIGluc3RhbmNlIGZv ciBzaW5nbGUgaW50ZWdlciBpbnB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI2NDE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4IGEgdmlicmF0aW9uIHVuaXQgdGVzdCByZWdyZXNzaW9uIGFmdGVy IHIxNjExMzkuIEFsc28gcmVtb3ZlIHVubmVjZXNzYXJ5IHRlc3QgY2FzZXMuIAorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwOgorICAgICAgICAo RVdLMlZpZXdUZXN0Ojpsb2FkVmlicmF0aW9uSFRNTFN0cmluZyk6CisgICAgICAgIChURVNUX0Yp OgorCiAyMDE0LTAxLTAyICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNv bT4KIAogICAgICAgICBQcm9wYWdhdGUgV2luZG93U2VydmVyIG1vZGlmaWNhdGlvbnMgc3RhdGUg dG8gV2ViUHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy92aWJyYXRp b24vTmF2aWdhdG9yVmlicmF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvdmlicmF0 aW9uL05hdmlnYXRvclZpYnJhdGlvbi5jcHAKaW5kZXggODNiNjAyOGJkMDgwNDNmMGI0YmU2NzU5 MzUzYWEzZWQ1Yzk0ZTJhNC4uNGRjNzgwMzQzODNkZTdiNDU0YjhiNjJkNzdiZWRkMTJlM2I5Y2Iw YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy92aWJyYXRpb24vTmF2aWdhdG9y VmlicmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3ZpYnJhdGlvbi9OYXZp Z2F0b3JWaWJyYXRpb24uY3BwCkBAIC00MCw3ICs0MCw3IEBAIE5hdmlnYXRvclZpYnJhdGlvbjo6 fk5hdmlnYXRvclZpYnJhdGlvbigpCiAKIGJvb2wgTmF2aWdhdG9yVmlicmF0aW9uOjp2aWJyYXRl KE5hdmlnYXRvciogbmF2aWdhdG9yLCB1bnNpZ25lZCB0aW1lKQogewotICAgIHJldHVybiBOYXZp Z2F0b3JWaWJyYXRpb246OnZpYnJhdGUobmF2aWdhdG9yLCBWaWJyYXRpb25QYXR0ZXJuKHRpbWUp KTsKKyAgICByZXR1cm4gTmF2aWdhdG9yVmlicmF0aW9uOjp2aWJyYXRlKG5hdmlnYXRvciwgVmli cmF0aW9uUGF0dGVybigxLCB0aW1lKSk7CiB9CiAKIGJvb2wgTmF2aWdhdG9yVmlicmF0aW9uOjp2 aWJyYXRlKE5hdmlnYXRvciogbmF2aWdhdG9yLCBjb25zdCBWaWJyYXRpb25QYXR0ZXJuJiBwYXR0 ZXJuKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMv dGVzdF9ld2syX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVz dHMvdGVzdF9ld2syX3ZpZXcuY3BwCmluZGV4IGM0M2Y2NmU3NjI4ZDdkYmZmNTA5ZDQ5ZDdmZDQw ZmZlNmQxZGRiNTQuLmMxZWJmNGMwMDUwMWJlNTllMmVkYzNlMWYyYmNhYmI4NTEwYzZhMzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdr Ml92aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90 ZXN0X2V3azJfdmlldy5jcHAKQEAgLTE3Myw3ICsxNzMsNyBAQCBwdWJsaWM6CiAgICAgICAgIGRh dGEtPnRlc3RGaW5pc2hlZCA9IHRydWU7CiAgICAgfQogCi0gICAgc3RhdGljIHZvaWQgbG9hZFZp YnJhdGlvbkhUTUxTdHJpbmcoRXZhc19PYmplY3QqIHdlYlZpZXcsIGNvbnN0IGNoYXIqIHZpYnJh dGlvblBhdHRlcm4sIGJvb2wgd2FpdEZvclZpYnJhdGlvbkV2ZW50LCBWaWJyYXRpb25DYkRhdGEq IGRhdGEpCisgICAgc3RhdGljIHZvaWQgbG9hZFZpYnJhdGlvbkhUTUxTdHJpbmcoRXZhc19PYmpl Y3QqIHdlYlZpZXcsIGNvbnN0IGNoYXIqIHZpYnJhdGlvblBhdHRlcm4sIFZpYnJhdGlvbkNiRGF0 YSogZGF0YSkKICAgICB7CiAgICAgICAgIGNvbnN0IGNoYXIqIGNvbnRlbnQgPQogICAgICAgICAg ICAgIjxodG1sPjxoZWFkPjxzY3JpcHQgdHlwZT0ndGV4dC9qYXZhc2NyaXB0Jz5mdW5jdGlvbiB2 aWJyYXRlKCkgeyBuYXZpZ2F0b3IudmlicmF0ZSglcyk7IgpAQCAtMTg3LDkgKzE4Nyw2IEBAIHB1 YmxpYzoKICAgICAgICAgZWluYV9zdHJidWZfYXBwZW5kX3ByaW50ZihidWZmZXIsIGNvbnRlbnQs IHZpYnJhdGlvblBhdHRlcm4pOwogICAgICAgICBld2tfdmlld19odG1sX3N0cmluZ19sb2FkKHdl YlZpZXcsIGVpbmFfc3RyYnVmX3N0cmluZ19nZXQoYnVmZmVyKSwgMCwgMCk7CiAgICAgICAgIGVp bmFfc3RyYnVmX2ZyZWUoYnVmZmVyKTsKLQotICAgICAgICBpZiAoIXdhaXRGb3JWaWJyYXRpb25F dmVudCkKLSAgICAgICAgICAgIHJldHVybjsKICAgICB9CiAKICAgICBzdGF0aWMgdm9pZCBvbkNv bnRlbnRzU2l6ZUNoYW5nZWRQb3J0cmFpdCh2b2lkKiB1c2VyRGF0YSwgRXZhc19PYmplY3QqLCB2 b2lkKiBldmVudEluZm8pCkBAIC05MTgsNDggKzkxNSwzNCBAQCBURVNUX0YoRVdLMlZpZXdUZXN0 LCBld2tfdmlld19wYWdpbmF0aW9uKQogCiBURVNUX0YoRVdLMlZpZXdUZXN0LCBld2tfY29udGV4 dF92aWJyYXRpb25fY2xpZW50X2NhbGxiYWNrc19zZXQpCiB7Ci0gICAgVmlicmF0aW9uQ2JEYXRh IGRhdGEgPSB7IGZhbHNlLCBmYWxzZSwgMCwgNTAwMCB9OworICAgIFZpYnJhdGlvbkNiRGF0YSBk YXRhID0geyBmYWxzZSwgZmFsc2UsIGZhbHNlLCAwLCA1MDAwIH07CiAgICAgZXZhc19vYmplY3Rf c21hcnRfY2FsbGJhY2tfYWRkKHdlYlZpZXcoKSwgInZpYnJhdGUiLCBvblZpYnJhdGUsICZkYXRh KTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQod2ViVmlldygpLCAiY2FuY2Vs LHZpYnJhdGlvbiIsIG9uQ2FuY2VsVmlicmF0aW9uLCAmZGF0YSk7CiAKICAgICAvLyBWaWJyYXRl IGZvciA1IHNlY29uZHMuCi0gICAgbG9hZFZpYnJhdGlvbkhUTUxTdHJpbmcod2ViVmlldygpLCAi NTAwMCIsIHRydWUsICZkYXRhKTsKKyAgICBsb2FkVmlicmF0aW9uSFRNTFN0cmluZyh3ZWJWaWV3 KCksICI1MDAwIiwgJmRhdGEpOwogICAgIHdhaXRVbnRpbFRydWUoZGF0YS50ZXN0RmluaXNoZWQp OwogICAgIEFTU0VSVF9UUlVFKGRhdGEuZGlkUmVjZWl2ZVZpYnJhdGUpOwogCiAgICAgLy8gQ2Fu Y2VsIGFueSBleGlzdGluZyB2aWJyYXRpb25zLgotICAgIGxvYWRWaWJyYXRpb25IVE1MU3RyaW5n KHdlYlZpZXcoKSwgIjAiLCB0cnVlLCAmZGF0YSk7CisgICAgbG9hZFZpYnJhdGlvbkhUTUxTdHJp bmcod2ViVmlldygpLCAiMCIsICZkYXRhKTsKICAgICB3YWl0VW50aWxUcnVlKGRhdGEudGVzdEZp bmlzaGVkKTsKICAgICBBU1NFUlRfVFJVRShkYXRhLmRpZFJlY2VpdmVDYW5jZWxWaWJyYXRpb24p OwogCiAgICAgLy8gVGhpcyBjYXNlIHRoZSBwYXR0ZXJuIHdpbGwgY2F1c2UgdGhlIGRldmljZSB0 byB2aWJyYXRlIGZvciAyMDAgbXMsIGJlIHN0aWxsIGZvciAxMDAgbXMsIGFuZCB0aGVuIHZpYnJh dGUgZm9yIDUwMDAgbXMuCi0gICAgbG9hZFZpYnJhdGlvbkhUTUxTdHJpbmcod2ViVmlldygpLCAi WzIwMCwgMTAwLCA1MDAwXSIsIHRydWUsICZkYXRhKTsKKyAgICBsb2FkVmlicmF0aW9uSFRNTFN0 cmluZyh3ZWJWaWV3KCksICJbMjAwLCAxMDAsIDUwMDBdIiwgJmRhdGEpOwogICAgIHdhaXRVbnRp bFRydWUoZGF0YS50ZXN0RmluaXNoZWQpOwogICAgIEFTU0VSVF9FUSgyLCBkYXRhLnZpYnJhdGVD YWxsZWRDb3VudCk7CiAgICAgQVNTRVJUX1RSVUUoZGF0YS5kaWRSZWNlaXZlVmlicmF0ZSk7CiAK ICAgICAvLyBDYW5jZWwgb3V0c3RhbmRpbmcgdmlicmF0aW9uIHBhdHRlcm4uCi0gICAgbG9hZFZp YnJhdGlvbkhUTUxTdHJpbmcod2ViVmlldygpLCAiWzBdIiwgdHJ1ZSwgJmRhdGEpOworICAgIGxv YWRWaWJyYXRpb25IVE1MU3RyaW5nKHdlYlZpZXcoKSwgIlswXSIsICZkYXRhKTsKICAgICB3YWl0 VW50aWxUcnVlKGRhdGEudGVzdEZpbmlzaGVkKTsKICAgICBBU1NFUlRfVFJVRShkYXRhLmRpZFJl Y2VpdmVDYW5jZWxWaWJyYXRpb24pOwogCiAgICAgLy8gU3RvcCBsaXN0ZW5pbmcgZm9yIHZpYnJh dGlvbiBldmVudHMsIGJ5IGNhbGxpbmcgdGhlIGZ1bmN0aW9uIHdpdGggbnVsbCBmb3IgdGhlIGNh bGxiYWNrcy4KICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19kZWwod2ViVmlldygpLCAi dmlicmF0ZSIsIG9uVmlicmF0ZSk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfZGVs KHdlYlZpZXcoKSwgImNhbmNlbCx2aWJyYXRpb24iLCBvbkNhbmNlbFZpYnJhdGlvbik7Ci0KLSAg ICAvLyBNYWtlIHN1cmUgd2UgZG9uJ3QgcmVjZWl2ZSB2aWJyYXRpb24gZXZlbnQuCi0gICAgbG9h ZFZpYnJhdGlvbkhUTUxTdHJpbmcod2ViVmlldygpLCAiWzUwMDBdIiwgZmFsc2UsICZkYXRhKTsK LSAgICB3YWl0VW50aWxUcnVlKGRhdGEudGVzdEZpbmlzaGVkKTsKLSAgICBBU1NFUlRfVFJVRSh3 YWl0VW50aWxUaXRsZUNoYW5nZWRUbygiTG9hZGVkIikpOwotICAgIEFTU0VSVF9TVFJFUSgiTG9h ZGVkIiwgZXdrX3ZpZXdfdGl0bGVfZ2V0KHdlYlZpZXcoKSkpOwotICAgIEFTU0VSVF9GQUxTRShk YXRhLmRpZFJlY2VpdmVWaWJyYXRlKTsKLQotICAgIC8vIE1ha2Ugc3VyZSB3ZSBkb24ndCByZWNl aXZlIGNhbmNlbCB2aWJyYXRpb24gZXZlbnQuCi0gICAgbG9hZFZpYnJhdGlvbkhUTUxTdHJpbmco d2ViVmlldygpLCAiMCIsIGZhbHNlLCAmZGF0YSk7Ci0gICAgd2FpdFVudGlsVHJ1ZShkYXRhLnRl c3RGaW5pc2hlZCk7Ci0gICAgQVNTRVJUX1RSVUUod2FpdFVudGlsVGl0bGVDaGFuZ2VkVG8oIkxv YWRlZCIpKTsKLSAgICBBU1NFUlRfU1RSRVEoIkxvYWRlZCIsIGV3a192aWV3X3RpdGxlX2dldCh3 ZWJWaWV3KCkpKTsKLSAgICBBU1NFUlRfRkFMU0UoZGF0YS5kaWRSZWNlaXZlQ2FuY2VsVmlicmF0 aW9uKTsKIH0KIAogVEVTVF9GKEVXSzJWaWV3VGVzdCwgZXdrX3ZpZXdfY29udGVudHNfc2l6ZV9j aGFuZ2VkKQo=