<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126416</bug_id>
          
          <creation_ts>2014-01-02 20:45:25 -0800</creation_ts>
          <short_desc>[GTK] --enable-webkit2 fails on OS X</short_desc>
          <delta_ts>2015-05-10 14:09:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>126492</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Jeremy Huddleston Sequoia">jeremyhu</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>gustavo</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>mrobinson</cc>
    
    <cc>mrowe</cc>
    
    <cc>ossy</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>964003</commentid>
    <comment_count>0</comment_count>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2014-01-02 20:45:25 -0800</bug_when>
    <thetext>Source/WebKit2/Shared/API/c/WKBase.h has:

#if defined(__APPLE__) &amp;&amp; !defined(BUILDING_QT__)
#include &lt;WebKit2/WKBaseMac.h&gt;
#endif

so that will incorrecly try to include the non-existent WebKit2/WKBaseMac.h when building webkit-gtk on OSX.

Instead of saying &quot;apple &amp;&amp; !qt &amp;&amp; !gtk &amp;&amp; !...&quot; perhaps you should say &quot;apple &amp;&amp; cocoa&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964050</commentid>
    <comment_count>1</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-01-03 00:46:48 -0800</bug_when>
    <thetext>The code in trunk already seems to do that this way.
http://trac.webkit.org/browser/trunk/Source/WebKit2/Shared/API/c/WKBase.h

I assume you&apos;re building a specific release version?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964097</commentid>
    <comment_count>2</comment_count>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2014-01-03 07:41:02 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; The code in trunk already seems to do that this way.
&gt; http://trac.webkit.org/browser/trunk/Source/WebKit2/Shared/API/c/WKBase.h
&gt; 
&gt; I assume you&apos;re building a specific release version?

Yes, this is an issue with the current release version (2.2.3), as well as the last version to support Mountain Lion and earlier (2.0.4).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964099</commentid>
    <comment_count>3</comment_count>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2014-01-03 07:45:29 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; The code in trunk already seems to do that this way.
&gt; http://trac.webkit.org/browser/trunk/Source/WebKit2/Shared/API/c/WKBase.h

No, it looks like it&apos;s now including it when defined(__APPLE__) now (even for QT), but it should not be included when building for GTK/X11 on OS X.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1093574</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-05-10 14:09:20 -0700</bug_when>
    <thetext>I believe this issue is obsolete based on comments in bug #126492. If this issue is still present in 2.8.1 or 2.9.1 please leave a note so we can reopen.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>