126415 2014-01-02 20:34:15 -0800 IconController.cpp needs to include <wtf/text/CString.h> 2014-01-02 21:18:12 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ljaehun.lim webkit-unassigned commit-queue japhet oldest_to_newest 963999 0 ljaehun.lim 2014-01-02 20:34:15 -0800 Build fails in IconController.cpp when ICONDATABASE is disabled. WebKit/Source/WebCore/loader/icon/IconController.cpp:124:110: error: invalid use of incomplete type ‘class WTF::CString’ IconController.cpp needs #include <wtf/text/CString.h>. 964002 1 220278 ljaehun.lim 2014-01-02 20:38:26 -0800 Created attachment 220278 Patch 964004 2 220278 commit-queue 2014-01-02 21:18:10 -0800 Comment on attachment 220278 Patch Clearing flags on attachment: 220278 Committed r161252: <http://trac.webkit.org/changeset/161252> 964005 3 commit-queue 2014-01-02 21:18:12 -0800 All reviewed patches have been landed. Closing bug. 220278 2014-01-02 20:38:26 -0800 2014-01-02 21:18:10 -0800 Patch bug-126415-20140103133824.patch text/plain 1439 ljaehun.lim U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQ5NDQyOWNjZjBjNDBl N2QyNTgyYjI5ZTk5ODg2ZjAxZTFhMTVkNS4uYTcxNzU2NjZiNmE4NjZkYzhlNTIwMmM3NDAxMjli MjY1MDhlNTBmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAxLTAyICBKYWVo dW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgSWNvbkNvbnRyb2xs ZXIuY3BwIG5lZWRzIHRvIGluY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjQxNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkIGZhaWxzIGluIEljb25D b250cm9sbGVyLmNwcCB3aGVuIElDT05EQVRBQkFTRSBpcyBkaXNhYmxlZC4KKyAgICAgICAgV2Vi S2l0L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25Db250cm9sbGVyLmNwcDoxMjQ6MTEw OiBlcnJvcjogaW52YWxpZCB1c2Ugb2YgaW5jb21wbGV0ZSB0eXBlIOKAmGNsYXNzIFdURjo6Q1N0 cmluZ+KAmQorICAgICAgICBJY29uQ29udHJvbGxlci5jcHAgbmVlZHMgI2luY2x1ZGUgPHd0Zi90 ZXh0L0NTdHJpbmcuaD4uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBKdXN0IGJ1aWxkIGZpeC4K KworICAgICAgICAqIGxvYWRlci9pY29uL0ljb25Db250cm9sbGVyLmNwcDogQWRkICNpbmNsdWRl IHN0YXRlbWVudC4KKwogMjAxNC0wMS0wMiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxl LmNvbT4KIAogICAgICAgICBbV2ViR0xdIENvcnJlY3Qgc3ltYm9sIGxvb2t1cCBsb2dpYyB0byBo YW5kbGUgMS1lbGVtZW50IGFycmF5cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L2ljb24vSWNvbkNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNv bkNvbnRyb2xsZXIuY3BwCmluZGV4IDE3NmJmOTFhMmQxM2E5YjJjMmE4MjA5ZTQxMmU3NTY3ZTc0 YTY4NjYuLjkzYzFlYTZkNGI5NDdmMmNjNTMwYmM2Y2FmNmE3ZDBlNTIyZDAzNmMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25Db250cm9sbGVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uQ29udHJvbGxlci5jcHAKQEAgLTQ3LDYgKzQ3 LDcgQEAKICNpbmNsdWRlICJNYWluRnJhbWUuaCIKICNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVk ZSAiU2V0dGluZ3MuaCIKKyNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAo=