126407 2014-01-02 14:45:14 -0800 Set VSINSTALLDIR in win ews start script 2014-01-06 12:15:39 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 NEW P2 Normal --- 1 roger_fong webkit-unassigned bfulgham lforschler roger_fong oldest_to_newest 963901 0 roger_fong 2014-01-02 14:45:14 -0800 Set VSINSTALLDIR to where we install VS2013. Alternatively we can run VCVARSALL.bat in the script but the change seems to be equivalent and that'd mean we'd be running a batch script from a shell script which is being run from a batch script... maybe that's not that weird... 963902 1 220256 roger_fong 2014-01-02 14:49:03 -0800 Created attachment 220256 patch 963907 2 220257 roger_fong 2014-01-02 14:52:31 -0800 Created attachment 220257 vcvarsall version 963925 3 220257 bfulgham 2014-01-02 15:29:05 -0800 Comment on attachment 220257 vcvarsall version View in context: https://bugs.webkit.org/attachment.cgi?id=220257&action=review > Tools/EWSTools/start-queue-win.sh:25 > + cmd /c "$PROGRAMFILES\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" This should be "CALL "$PROGRAMFILES...." We want the queue to run with the contents of the batch file added to the shell environment. The 'cmd' version will spawn a new shell, which will cease to exist once the command finishes running. 963926 4 220256 bfulgham 2014-01-02 15:29:43 -0800 Comment on attachment 220256 patch View in context: https://bugs.webkit.org/attachment.cgi?id=220256&action=review > Tools/EWSTools/start-queue-win.sh:25 > + export VSINSTALLDIR="$PROGRAMFILES\Microsoft Visual Studio 12.0" I don't care for this version as much, because it doesn't set the other environment variables (such as LIBPATH, etc.) which might be useful for building. 963952 5 220265 roger_fong 2014-01-02 16:24:41 -0800 Created attachment 220265 vcvarsall version fixed 963953 6 roger_fong 2014-01-02 16:26:31 -0800 uh hold up, call command not found 963959 7 bfulgham 2014-01-02 16:34:20 -0800 Duh! Sorry -- I was thinking in DOS BATCH, not BASH. We want to introduce these variables to the Cygwin environment, so maybe we do need to go with your original version that just adds the environment variable. 964179 8 roger_fong 2014-01-03 10:58:59 -0800 (In reply to comment #7) > Duh! Sorry -- I was thinking in DOS BATCH, not BASH. > > We want to introduce these variables to the Cygwin environment, so maybe we do need to go with your original version that just adds the environment variable. Hmm, after some amount of research I don't think cygwin has anything that can save the environment settings set by a batch script. I could always convert the batch script to a bash script, check it in, and we can modify it as need be instead. 964278 9 roger_fong 2014-01-03 14:49:42 -0800 What do you think Brent? Think we should just go with setting VSINSTALLDIR ourselves? 964678 10 220256 bfulgham 2014-01-06 11:08:12 -0800 Comment on attachment 220256 patch Watch out for LIBPATH or INCLUDE_PATH problems in scripts since we aren't setting these, but this seems to work. 964680 11 roger_fong 2014-01-06 11:14:44 -0800 (In reply to comment #10) > (From update of attachment 220256 [details]) > Watch out for LIBPATH or INCLUDE_PATH problems in scripts since we aren't setting these, but this seems to work. Ok, I'll keep an eye out. 964711 12 roger_fong 2014-01-06 12:15:39 -0800 http://trac.webkit.org/changeset/161355 Keeping open until EWS bots are actually reporting working builds 220256 2014-01-02 14:49:03 -0800 2014-01-06 11:08:11 -0800 patch ewspatch.patch text/plain 1080 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MTIyOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE0LTAxLTAyICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgU2V0IFZTSU5TVEFMTERJUiBpbiB3aW4gZXdzIHN0YXJ0IHNjcmlwdC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjQwNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRVdTVG9vbHMv c3RhcnQtcXVldWUtd2luLnNoOgorCiAyMDE0LTAxLTAyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8 YXBAYXBwbGUuY29tPgogCiAgICAgICAgIEFjY2Vzc2luZyBUcmFjIGZyb20gYnVpbGQud2Via2l0 Lm9yZy9kYXNoYm9hcmQgc2hvdWxkIGVuYWJsZSBYTUxIdHRwUmVxdWVzdC53aXRoQ3JlZGVudGlh bHMKSW5kZXg6IFRvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLXdpbi5zaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9FV1NUb29scy9zdGFydC1xdWV1ZS13aW4uc2gJKHJldmlzaW9uIDE2MTE0OCkKKysr IFRvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLXdpbi5zaAkod29ya2luZyBjb3B5KQpAQCAtMjIs NiArMjIsNyBAQAogICAgICAgICBmaW5kIH4vd2luLWV3cy1sb2dzIC1tdGltZSArNyAtZXhlYyBy bSAtZiB7fSBcOwogICAgICAgICBlY2hvICJUQVNLOiBTdGFydGluZyB1cCIKICAgICAgICAgY2Qg fi9XZWJLaXQKKyAgICAgICAgZXhwb3J0IFZTSU5TVEFMTERJUj0iJFBST0dSQU1GSUxFU1xNaWNy b3NvZnQgVmlzdWFsIFN0dWRpbyAxMi4wIgogICAgICAgICBlY2hvICJUQVNLOiBDbGVhbmluZyBX ZWJLaXRCdWlsZCIKICAgICAgICAgcm0gLXJmIFdlYktpdEJ1aWxkCiAgICAgICAgIGRhdGUK 220257 2014-01-02 14:52:31 -0800 2014-01-02 16:24:41 -0800 vcvarsall version ewspatch.patch text/plain 1086 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MTIyOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE0LTAxLTAyICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgQ2FsbCB2Y3ZhcnNhbGwuYmF0IGluIHdpbiBld3Mgc3RhcnQgc2NyaXB0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2NDA3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBFV1NUb29s cy9zdGFydC1xdWV1ZS13aW4uc2g6CisKIDIwMTQtMDEtMDIgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgQWNjZXNzaW5nIFRyYWMgZnJvbSBidWlsZC53ZWJr aXQub3JnL2Rhc2hib2FyZCBzaG91bGQgZW5hYmxlIFhNTEh0dHBSZXF1ZXN0LndpdGhDcmVkZW50 aWFscwpJbmRleDogVG9vbHMvRVdTVG9vbHMvc3RhcnQtcXVldWUtd2luLnNoCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLXdpbi5zaAkocmV2aXNpb24gMTYxMTQ4KQor KysgVG9vbHMvRVdTVG9vbHMvc3RhcnQtcXVldWUtd2luLnNoCSh3b3JraW5nIGNvcHkpCkBAIC0y Miw2ICsyMiw3IEBACiAgICAgICAgIGZpbmQgfi93aW4tZXdzLWxvZ3MgLW10aW1lICs3IC1leGVj IHJtIC1mIHt9IFw7CiAgICAgICAgIGVjaG8gIlRBU0s6IFN0YXJ0aW5nIHVwIgogICAgICAgICBj ZCB+L1dlYktpdAorICAgICAgICBjbWQgL2MgIiRQUk9HUkFNRklMRVNcTWljcm9zb2Z0IFZpc3Vh bCBTdHVkaW8gMTIuMFxWQ1x2Y3ZhcnNhbGwuYmF0IgogICAgICAgICBlY2hvICJUQVNLOiBDbGVh bmluZyBXZWJLaXRCdWlsZCIKICAgICAgICAgcm0gLXJmIFdlYktpdEJ1aWxkCiAgICAgICAgIGRh dGUK 220265 2014-01-02 16:24:41 -0800 2014-01-02 16:33:02 -0800 vcvarsall version fixed ewspatch.patch text/plain 1084 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MTIyOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE0LTAxLTAyICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgQ2FsbCB2Y3ZhcnNhbGwuYmF0IGluIHdpbiBld3Mgc3RhcnQgc2NyaXB0Lgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2NDA3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBFV1NUb29s cy9zdGFydC1xdWV1ZS13aW4uc2g6CisKIDIwMTQtMDEtMDIgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgQWNjZXNzaW5nIFRyYWMgZnJvbSBidWlsZC53ZWJr aXQub3JnL2Rhc2hib2FyZCBzaG91bGQgZW5hYmxlIFhNTEh0dHBSZXF1ZXN0LndpdGhDcmVkZW50 aWFscwpJbmRleDogVG9vbHMvRVdTVG9vbHMvc3RhcnQtcXVldWUtd2luLnNoCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLXdpbi5zaAkocmV2aXNpb24gMTYxMTQ4KQor KysgVG9vbHMvRVdTVG9vbHMvc3RhcnQtcXVldWUtd2luLnNoCSh3b3JraW5nIGNvcHkpCkBAIC0y Miw2ICsyMiw3IEBACiAgICAgICAgIGZpbmQgfi93aW4tZXdzLWxvZ3MgLW10aW1lICs3IC1leGVj IHJtIC1mIHt9IFw7CiAgICAgICAgIGVjaG8gIlRBU0s6IFN0YXJ0aW5nIHVwIgogICAgICAgICBj ZCB+L1dlYktpdAorICAgICAgICBDQUxMICIkUFJPR1JBTUZJTEVTXE1pY3Jvc29mdCBWaXN1YWwg U3R1ZGlvIDEyLjBcVkNcdmN2YXJzYWxsLmJhdCIKICAgICAgICAgZWNobyAiVEFTSzogQ2xlYW5p bmcgV2ViS2l0QnVpbGQiCiAgICAgICAgIHJtIC1yZiBXZWJLaXRCdWlsZAogICAgICAgICBkYXRl Cg==