126401 2014-01-02 14:12:35 -0800 [iOS] Tapping any link crashes in WebCore::EventHandler::mouseMoved() (also crashes when scrolling certain sites) 2014-01-06 14:23:12 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates adele oldest_to_newest 963875 0 dbates 2014-01-02 14:12:35 -0800 Tapping a hyperlink or scrolling a page causes a crash. 963877 1 dbates 2014-01-02 14:12:55 -0800 <rdar://problem/15739334> 963879 2 220249 dbates 2014-01-02 14:16:34 -0800 Created attachment 220249 Patch 963888 3 dbates 2014-01-02 14:28:39 -0800 Committed r161227: <http://trac.webkit.org/changeset/161227> 964659 4 220249 joepeck 2014-01-06 10:10:02 -0800 Comment on attachment 220249 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220249&action=review > Source/WebCore/page/ios/EventHandlerIOS.mm:57 > static RetainPtr<WebEvent>& currentEventSlot() > { > - NeverDestroyed<RetainPtr<WebEvent>> event; > + static NeverDestroyed<RetainPtr<WebEvent>> event; > return event; Isn't a NeverDestroyed with a RetainPtr<> a bit overkill? Can we drop the RetainPtr wrapping? 964761 5 dbates 2014-01-06 14:23:12 -0800 (In reply to comment #4) > (From update of attachment 220249 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220249&action=review > > > Source/WebCore/page/ios/EventHandlerIOS.mm:57 > > static RetainPtr<WebEvent>& currentEventSlot() > > { > > - NeverDestroyed<RetainPtr<WebEvent>> event; > > + static NeverDestroyed<RetainPtr<WebEvent>> event; > > return event; > > Isn't a NeverDestroyed with a RetainPtr<> a bit overkill? Can we drop the RetainPtr wrapping? As mentioned in person today (01/06), we cannot drop the RetainPtr<> without having the caller retain the WebEvent before assigning to currentEventSlot(). It seems error prone to depend on the caller to explicitly retain the WebEvent as opposed to letting RetainPtr<> implicitly retain it on assignment. I am open to suggestions on how to clean up this code. 220249 2014-01-02 14:16:34 -0800 2014-01-06 10:10:02 -0800 Patch bug-126401-20140102141633.patch text/plain 1314 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODA5M2ViN2QzY2ExMjRh MzEwZTNkZDkxMzU0MzUwOWQ2ZTU0MjU3OS4uYjhhNDE5YWQ2NDg1ODZjMDNlNDNkZWY4ZjMxOTA0 N2FlNDgwMGZkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTAyICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBUYXBwaW5nIGFu eSBsaW5rIGNyYXNoZXMgaW4gV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjptb3VzZU1vdmVkKCkKKyAg ICAgICAgKGFsc28gY3Jhc2hlcyB3aGVuIHNjcm9sbGluZyBjZXJ0YWluIHNpdGVzKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2NDAxCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8xNTczOTMzND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvaW9zL0V2ZW50SGFuZGxlcklPUy5tbToKKyAgICAg ICAgKFdlYkNvcmU6OmN1cnJlbnRFdmVudFNsb3QpOiBNYWtlIHRoZSBzaGFyZWQgdmFyaWFibGUg aGF2ZSBzdGF0aWMtc3RvcmFnZSBkdXJhdGlvbi4KKwogMjAxNC0wMS0wMiAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBiaW5kaW5ncyB0ZXN0IHJlc3Vs dHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0V2ZW50SGFuZGxlcklPUy5t bSBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0V2ZW50SGFuZGxlcklPUy5tbQppbmRleCAxYzM3 YTM0MTVhODQ1NWUzZGRmOTljNjY3YWVlYmZkOTUxNjU4NDMwLi41YWM3NmZkODBkZDhmYzMzMWM5 OTIyOWMzN2Y1NDllZmFiYzE0NTJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL2lv cy9FdmVudEhhbmRsZXJJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvRXZlbnRI YW5kbGVySU9TLm1tCkBAIC01Myw3ICs1Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3Rh dGljIFJldGFpblB0cjxXZWJFdmVudD4mIGN1cnJlbnRFdmVudFNsb3QoKQogewotICAgIE5ldmVy RGVzdHJveWVkPFJldGFpblB0cjxXZWJFdmVudD4+IGV2ZW50OworICAgIHN0YXRpYyBOZXZlckRl c3Ryb3llZDxSZXRhaW5QdHI8V2ViRXZlbnQ+PiBldmVudDsKICAgICByZXR1cm4gZXZlbnQ7CiB9 CiAK