126397 2014-01-02 12:48:45 -0800 [GTK] Switch from WTF::Function to std::function in WebProcessTest 2014-01-02 23:36:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cgarcia commit-queue gustavo mrobinson oldest_to_newest 963843 0 zan 2014-01-02 12:48:45 -0800 [GTK] Switch from WTF::Function to std::function in WebProcessTest 963844 1 220244 zan 2014-01-02 12:52:17 -0800 Created attachment 220244 Patch 963847 2 commit-queue 2014-01-02 12:53:54 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 963989 3 220244 andersca 2014-01-02 18:09:01 -0800 Comment on attachment 220244 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220244&action=review > Source/WebKit2/ChangeLog:9 > + following the effor of using STL concepts where possible. Effort. (This is great btw, I'd really like to get rid of WTF::Function). We usually put a space between the return type and the left parenthesis for function types. > Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h:37 > + WebProcessTest::add(String::fromUTF8(TestName), std::bind(&ClassName::create)) Do you even need std::bind here? 964017 4 220244 zan 2014-01-02 23:24:27 -0800 Comment on attachment 220244 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220244&action=review >> Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h:37 >> + WebProcessTest::add(String::fromUTF8(TestName), std::bind(&ClassName::create)) > > Do you even need std::bind here? No, std::bind isn't needed. 964020 5 zan 2014-01-02 23:36:54 -0800 Committed r161253: <http://trac.webkit.org/changeset/161253> 220244 2014-01-02 12:52:17 -0800 2014-01-02 23:24:26 -0800 Patch bug-126397-20140102215215.patch text/plain 3247 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTViYTU1ZWUyZTc5ZGQ0 MWZmNzdiZDkwNDI5OTRhYzc3ODI5NWZkMy4uMmE2MmNkMzcwODExNWNhYjU3MGE1ZmFhOWU2MmU1 NDNlZjkyYTM3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTAyICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBTd2l0Y2gg ZnJvbSBXVEY6OkZ1bmN0aW9uIHRvIHN0ZDo6ZnVuY3Rpb24gaW4gV2ViUHJvY2Vzc1Rlc3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjM5NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBzdGQ6OmZ1 bmN0aW9uPD4gYW5kIHN0ZDo6YmluZCgpIGluc3RlYWQgb2YgV1RGOjpGdW5jdGlvbiBhbmQgV1RG OjpiaW5kLAorICAgICAgICBmb2xsb3dpbmcgdGhlIGVmZm9yIG9mIHVzaW5nIFNUTCBjb25jZXB0 cyB3aGVyZSBwb3NzaWJsZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1dl YlByb2Nlc3NUZXN0LmNwcDoKKyAgICAgICAgKFdlYlByb2Nlc3NUZXN0OjphZGQpOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1dlYlByb2Nlc3NUZXN0Lmg6CisKIDIwMTQtMDEt MDEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jl YXRlIGEgVGhyZWFkZWRTY3JvbGxpbmdUcmVlIHN1YmNsYXNzIG9mIFNjcm9sbGluZ1RyZWUsIGFu ZCBwdXNoIGFsbCBrbm93bGVkZ2Ugb2YgdGhlIHNjcm9sbGluZyB0aHJlYWQgaW50byBpdApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvV2ViUHJvY2Vz c1Rlc3QuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvV2ViUHJv Y2Vzc1Rlc3QuY3BwCmluZGV4IGU4ZTYzZGNmZjgzZGQ4YjczYzJiZWFhNWZhMzNiOTI4MzNlZDkx ZmEuLjNiNjM3NDdlZGU2NTQ3ZGUzMDZkMDIzMTdkZWU0M2VjZjljMmZiYjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1dlYlByb2Nlc3NUZXN0LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9XZWJQcm9jZXNz VGVzdC5jcHAKQEAgLTIzLDE2ICsyMywxNiBAQAogI2luY2x1ZGUgPGdpby9naW8uaD4KICNpbmNs dWRlIDx3dGYvZ29iamVjdC9HT3duUHRyLmg+CiAKLXR5cGVkZWYgSGFzaE1hcDxTdHJpbmcsIEZ1 bmN0aW9uPFBhc3NPd25QdHI8V2ViUHJvY2Vzc1Rlc3Q+KCk+PiBUZXN0c01hcDsKK3R5cGVkZWYg SGFzaE1hcDxTdHJpbmcsIHN0ZDo6ZnVuY3Rpb248UGFzc093blB0cjxXZWJQcm9jZXNzVGVzdD4o KT4+IFRlc3RzTWFwOwogc3RhdGljIFRlc3RzTWFwJiB0ZXN0c01hcCgpCiB7CiAgICAgREVGSU5F X1NUQVRJQ19MT0NBTChUZXN0c01hcCwgc190ZXN0c01hcCwgKCkpOwogICAgIHJldHVybiBzX3Rl c3RzTWFwOwogfQogCi12b2lkIFdlYlByb2Nlc3NUZXN0OjphZGQoY29uc3QgU3RyaW5nJiB0ZXN0 TmFtZSwgRnVuY3Rpb248UGFzc093blB0cjxXZWJQcm9jZXNzVGVzdD4oKT4gY2xvc3VyZSkKK3Zv aWQgV2ViUHJvY2Vzc1Rlc3Q6OmFkZChjb25zdCBTdHJpbmcmIHRlc3ROYW1lLCBzdGQ6OmZ1bmN0 aW9uPFBhc3NPd25QdHI8V2ViUHJvY2Vzc1Rlc3Q+KCk+IGNsb3N1cmUpCiB7Ci0gICAgdGVzdHNN YXAoKS5hZGQodGVzdE5hbWUsIGNsb3N1cmUpOworICAgIHRlc3RzTWFwKCkuYWRkKHRlc3ROYW1l LCBzdGQ6OmZvcndhcmQ8c3RkOjpmdW5jdGlvbjxQYXNzT3duUHRyPFdlYlByb2Nlc3NUZXN0Pigp Pj4oY2xvc3VyZSkpOwogfQogCiBQYXNzT3duUHRyPFdlYlByb2Nlc3NUZXN0PiBXZWJQcm9jZXNz VGVzdDo6Y3JlYXRlKGNvbnN0IFN0cmluZyYgdGVzdE5hbWUpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9XZWJQcm9jZXNzVGVzdC5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvV2ViUHJvY2Vzc1Rlc3QuaAppbmRleCAx MzMzMjdkNjA1NmZlMGVmNmJjY2YxNDc1YWVjZmI0M2JjM2UxZGZjLi5lZjE5NjRjOWEyNTUxMGVl MDg4Zjg3ZTQ4NWZhYjE0OTY0Y2M2MGMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay90ZXN0cy9XZWJQcm9jZXNzVGVzdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1dlYlByb2Nlc3NUZXN0LmgKQEAgLTE4LDcgKzE4LDYg QEAKICAqLwogCiAjaW5jbHVkZSA8d2Via2l0Mi93ZWJraXQtd2ViLWV4dGVuc2lvbi5oPgotI2lu Y2x1ZGUgPHd0Zi9GdW5jdGlvbmFsLmg+CiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNs dWRlIDx3dGYvUGFzc093blB0ci5oPgogI2luY2x1ZGUgPHd0Zi9nb2JqZWN0L0dSZWZQdHIuaD4K QEAgLTMwLDEwICsyOSwxMCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB+V2ViUHJvY2Vzc1Rlc3Qo KSB7IH0KICAgICB2aXJ0dWFsIGJvb2wgcnVuVGVzdChjb25zdCBjaGFyKiB0ZXN0TmFtZSwgV2Vi S2l0V2ViRXh0ZW5zaW9uKiwgR1ZhcmlhbnQqIGFyZ3MpID0gMDsKIAotICAgIHN0YXRpYyB2b2lk IGFkZChjb25zdCBTdHJpbmcmIHRlc3ROYW1lLCBGdW5jdGlvbjxQYXNzT3duUHRyPFdlYlByb2Nl c3NUZXN0PigpPik7CisgICAgc3RhdGljIHZvaWQgYWRkKGNvbnN0IFN0cmluZyYgdGVzdE5hbWUs IHN0ZDo6ZnVuY3Rpb248UGFzc093blB0cjxXZWJQcm9jZXNzVGVzdD4oKT4pOwogICAgIHN0YXRp YyBQYXNzT3duUHRyPFdlYlByb2Nlc3NUZXN0PiBjcmVhdGUoY29uc3QgU3RyaW5nJiB0ZXN0TmFt ZSk7CiB9OwogCiAjZGVmaW5lIFJFR0lTVEVSX1RFU1QoQ2xhc3NOYW1lLCBUZXN0TmFtZSkgXAot ICAgIFdlYlByb2Nlc3NUZXN0OjphZGQoU3RyaW5nOjpmcm9tVVRGOChUZXN0TmFtZSksIFdURjo6 YmluZCgmQ2xhc3NOYW1lOjpjcmVhdGUpKQorICAgIFdlYlByb2Nlc3NUZXN0OjphZGQoU3RyaW5n Ojpmcm9tVVRGOChUZXN0TmFtZSksIHN0ZDo6YmluZCgmQ2xhc3NOYW1lOjpjcmVhdGUpKQogCg==