126385 2014-01-02 08:42:38 -0800 Crash when trying to register a custom scheme before network process has been launched 2014-01-07 02:02:30 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned andersca beidson sam oldest_to_newest 963757 0 cgarcia 2014-01-02 08:42:38 -0800 WebContext::registerSchemeForCustomProtocol() uses sendToNetworkingProcess() to send the message to the appropriate networking process. In the case of using web process, sendToNetworkingProcess() first checks if there's already a web process, doing nothing otherwise, but when using the network process it assumes there's already a network process. In both cases it's safe to do nothing, because the schemes will be passed as creation parameters to the process when launched. 963758 1 220227 cgarcia 2014-01-02 08:43:54 -0800 Created attachment 220227 Patch 964929 2 cgarcia 2014-01-07 02:02:30 -0800 Committed r161416: <http://trac.webkit.org/changeset/161416> 220227 2014-01-02 08:43:54 -0800 2014-01-06 11:13:47 -0800 Patch wk-custom-protocol-crash.diff text/plain 2202 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhNDdlNDM3Li5lZjRlYTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTQtMDEtMDIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIENyYXNoIHdoZW4gdHJ5aW5nIHRvIHJlZ2lzdGVyIGEgY3VzdG9tIHNjaGVt ZSBiZWZvcmUgbmV0d29yayBwcm9jZXNzIGhhcyBiZWVuIGxhdW5jaGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYzODUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJDb250ZXh0OjpyZWdpc3RlclNj aGVtZUZvckN1c3RvbVByb3RvY29sKCkgdXNlcworICAgICAgICBzZW5kVG9OZXR3b3JraW5nUHJv Y2VzcygpIHRvIHNlbmQgdGhlIG1lc3NhZ2UgdG8gdGhlIGFwcHJvcHJpYXRlCisgICAgICAgIG5l dHdvcmtpbmcgcHJvY2Vzcy4gSW4gdGhlIGNhc2Ugb2YgdXNpbmcgd2ViIHByb2Nlc3MsCisgICAg ICAgIHNlbmRUb05ldHdvcmtpbmdQcm9jZXNzKCkgZmlyc3QgY2hlY2tzIGlmIHRoZXJlJ3MgYWxy ZWFkeSBhIHdlYgorICAgICAgICBwcm9jZXNzLCBkb2luZyBub3RoaW5nIG90aGVyd2lzZSwgYnV0 IHdoZW4gdXNpbmcgdGhlIG5ldHdvcmsKKyAgICAgICAgcHJvY2VzcyBpdCBhc3N1bWVzIHRoZXJl J3MgYWxyZWFkeSBhIG5ldHdvcmsgcHJvY2Vzcy4gSW4gYm90aAorICAgICAgICBjYXNlcyBpdCdz IHNhZmUgdG8gZG8gbm90aGluZywgYmVjYXVzZSB0aGUgc2NoZW1lcyB3aWxsIGJlIHBhc3NlZAor ICAgICAgICBhcyBjcmVhdGlvbiBwYXJhbWV0ZXJzIHRvIHRoZSBwcm9jZXNzIHdoZW4gbGF1bmNo ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5oOgorICAgICAgICAoV2ViS2l0 OjpXZWJDb250ZXh0OjpzZW5kVG9OZXR3b3JraW5nUHJvY2Vzcyk6CisKIDIwMTMtMTItMzEgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTT1VQ XSBQb3J0IGN1c3RvbSBVUkkgc2NoZW1lcyBpbXBsZW1lbnRhdGlvbiB0byBDVVNUT00gUFJPVE9D T0xTCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5oIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuaAppbmRleCBlZDQ3OTRjLi5lNjI4 M2MwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5oCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmgKQEAgLTUxNSw3ICs1MTUs NyBAQCB2b2lkIFdlYkNvbnRleHQ6OnNlbmRUb05ldHdvcmtpbmdQcm9jZXNzKFQmJiBtZXNzYWdl KQogICAgIGNhc2UgUHJvY2Vzc01vZGVsU2hhcmVkU2Vjb25kYXJ5UHJvY2VzczoKICNpZiBFTkFC TEUoTkVUV09SS19QUk9DRVNTKQogICAgICAgICBpZiAobV91c2VzTmV0d29ya1Byb2Nlc3MpIHsK LSAgICAgICAgICAgIGlmIChtX25ldHdvcmtQcm9jZXNzLT5jYW5TZW5kTWVzc2FnZSgpKQorICAg ICAgICAgICAgaWYgKG1fbmV0d29ya1Byb2Nlc3MgJiYgbV9uZXR3b3JrUHJvY2Vzcy0+Y2FuU2Vu ZE1lc3NhZ2UoKSkKICAgICAgICAgICAgICAgICBtX25ldHdvcmtQcm9jZXNzLT5zZW5kKHN0ZDo6 Zm9yd2FyZDxUPihtZXNzYWdlKSwgMCk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0K QEAgLTUyNSw3ICs1MjUsNyBAQCB2b2lkIFdlYkNvbnRleHQ6OnNlbmRUb05ldHdvcmtpbmdQcm9j ZXNzKFQmJiBtZXNzYWdlKQogICAgICAgICByZXR1cm47CiAgICAgY2FzZSBQcm9jZXNzTW9kZWxN dWx0aXBsZVNlY29uZGFyeVByb2Nlc3NlczoKICNpZiBFTkFCTEUoTkVUV09SS19QUk9DRVNTKQot ICAgICAgICBpZiAobV9uZXR3b3JrUHJvY2Vzcy0+Y2FuU2VuZE1lc3NhZ2UoKSkKKyAgICAgICAg aWYgKG1fbmV0d29ya1Byb2Nlc3MgJiYgbV9uZXR3b3JrUHJvY2Vzcy0+Y2FuU2VuZE1lc3NhZ2Uo KSkKICAgICAgICAgICAgIG1fbmV0d29ya1Byb2Nlc3MtPnNlbmQoc3RkOjpmb3J3YXJkPFQ+KG1l c3NhZ2UpLCAwKTsKICAgICAgICAgcmV0dXJuOwogI2Vsc2UK