126379 2014-01-02 04:00:06 -0800 Video-seek-with-negative-playback is flaky 2014-01-02 15:10:24 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 piotr.grad webkit-unassigned commit-queue eflews.bot eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble oldest_to_newest 963722 0 piotr.grad 2014-01-02 04:00:06 -0800 Already working on patch. Patch will be proposed soon. 963733 1 220219 piotr.grad 2014-01-02 05:09:03 -0800 Created attachment 220219 Patch 963751 2 220219 eric.carlson 2014-01-02 08:05:09 -0800 Comment on attachment 220219 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220219&action=review > Source/WebCore/ChangeLog:11 > + Decision if playback rate for platform media player should be set is performed by checking m_playbackRate > + in HTMLMediaElement::endedPlayback(), so that m_playbackRate must be changed later. I didn't understand this comment until I read through the sources several times. How about something like: Test to see if m_player->setRate() should be called before updating m_playbackRate, because potentiallyPlaying() depends on endedPlayback(), which checks m_playbackRate. 963756 3 220226 piotr.grad 2014-01-02 08:42:19 -0800 Created attachment 220226 Patch 963766 4 220226 eflews.bot 2014-01-02 09:20:05 -0800 Comment on attachment 220226 Patch Attachment 220226 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/5706750963482624 963774 5 piotr.grad 2014-01-02 10:09:47 -0800 (In reply to comment #4) > (From update of attachment 220226 [details]) > Attachment 220226 [details] did not pass efl-wk2-ews (efl-wk2): > Output: http://webkit-queues.appspot.com/results/5706750963482624 Source code is same as in first proposed patch, so don't know why it failed. 963775 6 eric.carlson 2014-01-02 10:15:42 -0800 It looks like CoordinatedDrawingArea.cpp failed to compile: [ 84%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp.o c++: internal compiler error: Killed (program cc1Failed to run "['Tools/Scripts/build-webkit', '--release', '--efl', '--update-efl', '--no-webkit1', '--makeargs="-j8"']" exit_code: 2 963861 7 piotr.grad 2014-01-02 13:29:29 -0800 (In reply to comment #6) > It looks like CoordinatedDrawingArea.cpp failed to compile: > > [ 84%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp.o > c++: internal compiler error: Killed (program cc1Failed to run "['Tools/Scripts/build-webkit', '--release', '--efl', '--update-efl', '--no-webkit1', '--makeargs="-j8"']" exit_code: 2 So this error is not related to patch proposed. 963914 8 220226 commit-queue 2014-01-02 15:10:21 -0800 Comment on attachment 220226 Patch Clearing flags on attachment: 220226 Committed r161231: <http://trac.webkit.org/changeset/161231> 963915 9 commit-queue 2014-01-02 15:10:24 -0800 All reviewed patches have been landed. Closing bug. 220219 2014-01-02 05:09:03 -0800 2014-01-02 08:42:56 -0800 Patch patch.txt text/plain 1708 piotr.grad ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZjlkOGNiLi5mZWY4NmM2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTAxLTAyICBQaW90ciBHcmFkICA8cC5ncmFkQHNhbXN1bmcuY29tPgorCisgICAg ICAgIFZpZGVvLXNlZWstd2l0aC1uZWdhdGl2ZS1wbGF5YmFjayB3YXMgZmxha3kuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYzNzkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIENv dmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgRGVjaXNpb24gaWYgcGxheWJhY2sg cmF0ZSBmb3IgcGxhdGZvcm0gbWVkaWEgcGxheWVyIHNob3VsZCBiZSBzZXQgaXMgcGVyZm9ybWVk IGJ5IGNoZWNraW5nIG1fcGxheWJhY2tSYXRlCisgICAgICAgIGluIEhUTUxNZWRpYUVsZW1lbnQ6 OmVuZGVkUGxheWJhY2soKSwgc28gdGhhdCBtX3BsYXliYWNrUmF0ZSBtdXN0IGJlIGNoYW5nZWQg bGF0ZXIuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6c2V0UGxheWJhY2tSYXRlKToKKwogMjAxNC0wMS0w MSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHB1 YmxpYyBhdHRhY2hSZW5kZXJUcmVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50 LmNwcAppbmRleCAyNWNhMjg5Li5hMGM5ZGRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1l ZGlhRWxlbWVudC5jcHAKQEAgLTI1NjUsMTUgKzI1NjUsMTUgQEAgZG91YmxlIEhUTUxNZWRpYUVs ZW1lbnQ6OnBsYXliYWNrUmF0ZSgpIGNvbnN0CiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNldFBs YXliYWNrUmF0ZShkb3VibGUgcmF0ZSkKIHsKICAgICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVt ZW50OjpzZXRQbGF5YmFja1JhdGUoJWYpIiwgcmF0ZSk7Ci0gICAgCisKKyAgICBpZiAobV9wbGF5 ZXIgJiYgcG90ZW50aWFsbHlQbGF5aW5nKCkgJiYgbV9wbGF5ZXItPnJhdGUoKSAhPSByYXRlICYm ICFtX21lZGlhQ29udHJvbGxlcikKKyAgICAgICAgbV9wbGF5ZXItPnNldFJhdGUocmF0ZSk7CisK ICAgICBpZiAobV9wbGF5YmFja1JhdGUgIT0gcmF0ZSkgewogICAgICAgICBtX3BsYXliYWNrUmF0 ZSA9IHJhdGU7CiAgICAgICAgIGludmFsaWRhdGVDYWNoZWRUaW1lKCk7CiAgICAgICAgIHNjaGVk dWxlRXZlbnQoZXZlbnROYW1lcygpLnJhdGVjaGFuZ2VFdmVudCk7CiAgICAgfQotCi0gICAgaWYg KG1fcGxheWVyICYmIHBvdGVudGlhbGx5UGxheWluZygpICYmIG1fcGxheWVyLT5yYXRlKCkgIT0g cmF0ZSAmJiAhbV9tZWRpYUNvbnRyb2xsZXIpCi0gICAgICAgIG1fcGxheWVyLT5zZXRSYXRlKHJh dGUpOwogfQogCiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZVBsYXliYWNrUmF0ZSgpCg== 220226 2014-01-02 08:42:19 -0800 2014-01-02 15:10:21 -0800 Patch patch2.txt text/plain 1912 piotr.grad Y29tbWl0IGM3MDdmYTY2OGUzNmZmNThjYjRkMTBlNmRlZTE2ZDM2NWI5MmFjZDEKQXV0aG9yOiBQ aW90ciBHcmFkIDxwLmdyYWRAc2Ftc3VuZy5jb20+CkRhdGU6ICAgVGh1IEphbiAyIDEzOjA5OjA4 IDIwMTQgKzAxMDAKCiAgICBWaWRlby1zZWVrLXdpdGgtbmVnYXRpdmUtcGxheWJhY2sgd2FzIGZs YWt5LgogICAgCiAgICBDaGFuZ2UtSWQ6IEk1NGQxNWVkNzU4ZmRhZmYzMTg3NGRmMWEwYjhhNTJk MjA0YWNlNzExCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGVmOWQ4Y2IuLmZlZjg2YzZmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTQtMDEtMDIgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5j b20+CisKKyAgICAgICAgVmlkZW8tc2Vlay13aXRoLW5lZ2F0aXZlLXBsYXliYWNrIHdhcyBmbGFr eS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjM3 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICBtX3BsYXllci0+ c2V0UmF0ZSgpIHNob3VsZCBiZSBjYWxsZWQgYmVmb3JlIHVwZGF0aW5nIG1fcGxheWJhY2tSYXRl LCBiZWNhdXNlIHBvdGVudGlhbGx5UGxheWluZygpIGRlcGVuZHMKKyAgICAgICAgb24gZW5kZWRQ bGF5YmFjaygpLCB3aGljaCBjaGVja3MgbV9wbGF5YmFja1JhdGUuCisKKyAgICAgICAgKiBodG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVu dDo6c2V0UGxheWJhY2tSYXRlKToKKwogMjAxNC0wMS0wMSAgQW50dGkgS29pdmlzdG8gIDxhbnR0 aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHB1YmxpYyBhdHRhY2hSZW5kZXJUcmVlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCAyNWNhMjg5Li5hMGM5 ZGRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTI1NjUs MTUgKzI1NjUsMTUgQEAgZG91YmxlIEhUTUxNZWRpYUVsZW1lbnQ6OnBsYXliYWNrUmF0ZSgpIGNv bnN0CiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNldFBsYXliYWNrUmF0ZShkb3VibGUgcmF0ZSkK IHsKICAgICBMT0coTWVkaWEsICJIVE1MTWVkaWFFbGVtZW50OjpzZXRQbGF5YmFja1JhdGUoJWYp IiwgcmF0ZSk7Ci0gICAgCisKKyAgICBpZiAobV9wbGF5ZXIgJiYgcG90ZW50aWFsbHlQbGF5aW5n KCkgJiYgbV9wbGF5ZXItPnJhdGUoKSAhPSByYXRlICYmICFtX21lZGlhQ29udHJvbGxlcikKKyAg ICAgICAgbV9wbGF5ZXItPnNldFJhdGUocmF0ZSk7CisKICAgICBpZiAobV9wbGF5YmFja1JhdGUg IT0gcmF0ZSkgewogICAgICAgICBtX3BsYXliYWNrUmF0ZSA9IHJhdGU7CiAgICAgICAgIGludmFs aWRhdGVDYWNoZWRUaW1lKCk7CiAgICAgICAgIHNjaGVkdWxlRXZlbnQoZXZlbnROYW1lcygpLnJh dGVjaGFuZ2VFdmVudCk7CiAgICAgfQotCi0gICAgaWYgKG1fcGxheWVyICYmIHBvdGVudGlhbGx5 UGxheWluZygpICYmIG1fcGxheWVyLT5yYXRlKCkgIT0gcmF0ZSAmJiAhbV9tZWRpYUNvbnRyb2xs ZXIpCi0gICAgICAgIG1fcGxheWVyLT5zZXRSYXRlKHJhdGUpOwogfQogCiB2b2lkIEhUTUxNZWRp YUVsZW1lbnQ6OnVwZGF0ZVBsYXliYWNrUmF0ZSgpCg==