126371 2014-01-01 19:20:59 -0800 [GTK] fixing .ycm_extra_conf.py file 2014-01-02 17:16:06 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danilo.eu webkit-unassigned commit-queue mrobinson oldest_to_newest 963660 0 danilo.eu 2014-01-01 19:20:59 -0800 It's an attempt to fix three problems with the current ycm_extra_conf file. The current implementation assumes that it's a symlink, which is not true. Usually python creates a pyc file, and this is what you get in __file__. the .pyc is not a symlink, and the current implementation doesn't work if that's the case. It also assumes that the user is in the root folder. If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work. Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an exception since "flag" doesn't exists. All those things were fixed and the current implementation works with the latest YouCompleteMe plugin. 963661 1 220201 danilo.eu 2014-01-01 19:29:34 -0800 Created attachment 220201 Patch 963662 2 220201 danilo.eu 2014-01-01 19:39:32 -0800 Comment on attachment 220201 Patch asking cq 963666 3 220203 danilo.eu 2014-01-01 20:26:34 -0800 Created attachment 220203 Patch 963668 4 220203 danilo.eu 2014-01-01 20:33:53 -0800 Comment on attachment 220203 Patch small fix to select the correct line inside the ycm-make-trace 963971 5 220203 commit-queue 2014-01-02 17:16:04 -0800 Comment on attachment 220203 Patch Clearing flags on attachment: 220203 Committed r161243: <http://trac.webkit.org/changeset/161243> 963972 6 commit-queue 2014-01-02 17:16:06 -0800 All reviewed patches have been landed. Closing bug. 220201 2014-01-01 19:29:34 -0800 2014-01-01 20:26:20 -0800 Patch bug-126371-20140102012931.patch text/plain 2863 danilo.eu U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMjAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2Y2MmExNTJkODExZTg1NTgxOWQwM2RjOTZmODk4ZjFm YzQ0YzIzMS4uZDlkZDQ2ODZjYzM5YzQzMGZkZmVhNTc4OTNkNDE2ZGJiNDQwMzdhYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDE0LTAxLTAxICBEYW5pbG8gQ2VzYXIgTGVtZXMgZGUgUGF1bGEgIDxkYW5pbG8uY2Vz YXJAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFtHVEtdIGZpeGluZyB5Y21fZXh0cmFfY29u Zi5weSBmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjYzNzEKKworICAgICAgICBJdCdzIGFuIGF0dGVtcHQgdG8gZml4IHRocmVlIHByb2JsZW1z IHdpdGggdGhlIGN1cnJlbnQgeWNtX2V4dHJhX2NvbmYgZmlsZS4KKyAgICAgICAgVGhlIGN1cnJl bnQgaW1wbGVtZW50YXRpb24gYXNzdW1lcyB0aGF0IGl0J3MgYSBzeW1saW5rLCB3aGljaCBpcyBu b3QgdHJ1ZS4KKyAgICAgICAgVXN1YWxseSBweXRob24gY3JlYXRlcyBhIHB5YyBmaWxlLCBhbmQg dGhpcyBpcyB3aGF0IHlvdSBnZXQgaW4gX19maWxlX18uCisgICAgICAgIHRoZSAucHljIGlzIG5v dCBhIHN5bWxpbmssIGFuZCB0aGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBkb2Vzbid0IHdvcmsK KyAgICAgICAgaWYgdGhhdCdzIHRoZSBjYXNlLgorCisgICAgICAgIEl0IGFsc28gYXNzdW1lcyB0 aGF0IHRoZSB1c2VyIGlzIGluIHRoZSByb290IGZvbGRlci4KKyAgICAgICAgSWYgdGhlIHVzZXIg aXMgaW4gV2Via2l0QnVpbGQvRGVidWcgYW5kIG9wZW4gYSBmaWxlIGFzIC4uLy4uL1NvdXJjZS8q IGl0IHdvbid0IHdvcmsuCisKKyAgICAgICAgTGFzdCBidXQgbm90IGxlYXN0LCAiZWxpZiBmbGFn IGluIEZMQUdTX1BSRUNFRElOR19QQVRIUyIgZW1pdHMgYW4KKyAgICAgICAgZXhjZXB0aW9uIHNp bmNlICJmbGFnIiBkb2Vzbid0IGV4aXN0cy4KKworICAgICAgICBBbGwgdGhvc2UgdGhpbmdzIHdl cmUgZml4ZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBndGsveWNtX2V4dHJhX2NvbmYucHk6CisgICAgICAgICh0cmFuc2Zvcm1fcmVsYXRpdmVf cGF0aHNfdG9fYWJzb2x1dGVfcGF0aHMpOgorCiAyMDE0LTAxLTAxICBNYXJ0aW4gUm9iaW5zb24g IDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZW5hbWUgbGlidGVzdG5l dHNjYXBlcGx1Z2luIHRvIGxpYlRlc3ROZXRzY2FwZVBsdWdpbgpkaWZmIC0tZ2l0IGEvVG9vbHMv Z3RrL3ljbV9leHRyYV9jb25mLnB5IGIvVG9vbHMvZ3RrL3ljbV9leHRyYV9jb25mLnB5CmluZGV4 IDIyNzU5MTc0ZDk4MDFmMTY4NjNmOWI3M2MzMDYwMGJlMGQxNjIwZjguLjFiNmYyODhhM2VlZjYy YmMzNjA0MTAzYTcwYzUyM2YzOTFkYzY5OWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay95Y21fZXh0 cmFfY29uZi5weQorKysgYi9Ub29scy9ndGsveWNtX2V4dHJhX2NvbmYucHkKQEAgLTIzLDEwICsy MywxNCBAQCBpbXBvcnQgc3lzCiAjIEl0J3MgdmVyeSBsaWtlbHkgdGhhdCB0aGlzIHNjcmlwdCBp cyBhIHN5bWxpbmsgc29tZXdoZXJlIGluIHRoZSBXZWJLaXQgZGlyZWN0b3J5LAogIyBzbyB3ZSB0 cnkgdG8gZmluZCB0aGUgYWN0dWFsIHNjcmlwdCBsb2NhdGlvbiBzbyB0aGF0IHdlIGNhbiBsb2Nh dGUgdGhlIHRvb2xzCiAjIGRpcmVjdG9yeS4KLWlmIG9zLnBhdGguaXNsaW5rKF9fZmlsZV9fKToK LSAgICBfX3Rvb2xzX2RpcmVjdG9yeSA9IG9zLnBhdGguZGlybmFtZShvcy5yZWFkbGluayhfX2Zp bGVfXykpCitvcmlnaW5hbF9maWxlID0gX19maWxlX19bOi0xXSBpZiBfX2ZpbGVfXy5lbmRzd2l0 aCgiLnB5YyIpIGVsc2UgX19maWxlX18KK2lmIG9zLnBhdGguaXNsaW5rKG9yaWdpbmFsX2ZpbGUp OgorICAgIHBhcmVudF9mb2xkZXIgPSBvcy5wYXRoLmFic3BhdGgob3MucGF0aC5kaXJuYW1lKG9y aWdpbmFsX2ZpbGUpKQorICAgIGxpbmtfZmlsZSA9IG9zLnBhdGguam9pbihwYXJlbnRfZm9sZGVy LCBvcy5yZWFkbGluayhvcmlnaW5hbF9maWxlKSkKKyAgICBfX3Rvb2xzX2RpcmVjdG9yeSA9IG9z LnBhdGguZGlybmFtZShsaW5rX2ZpbGUpCiBlbHNlOgotICAgIF9fdG9vbHNfZGlyZWN0b3J5ID0g b3MucGF0aC5kaXJuYW1lKF9fZmlsZV9fKQorICAgIF9fdG9vbHNfZGlyZWN0b3J5ID0gb3MucGF0 aC5kaXJuYW1lKG9yaWdpbmFsX2ZpbGUpCisKIHN5cy5wYXRoLmluc2VydCgwLCBvcy5wYXRoLmFi c3BhdGgoX190b29sc19kaXJlY3RvcnkpKQogaW1wb3J0IGNvbW1vbgogCkBAIC00Myw3ICs0Nyw3 IEBAIGRlZiB0cmFuc2Zvcm1fcmVsYXRpdmVfcGF0aHNfdG9fYWJzb2x1dGVfcGF0aHMoYXJndW1l bnRzLCBidWlsZF9wYXRoKToKICAgICAgICAgICAgIG1ha2VfbmV4dF9hYnNvbHV0ZSA9IEZhbHNl CiAgICAgICAgICAgICBpZiBub3QgYXJndW1lbnQuc3RhcnRzd2l0aCgnLycpOgogICAgICAgICAg ICAgICAgIGFyZ3VtZW50ID0gb3MucGF0aC5qb2luKGJ1aWxkX3BhdGgsIGFyZ3VtZW50KQotICAg ICAgICBlbGlmIGZsYWcgaW4gRkxBR1NfUFJFQ0VESU5HX1BBVEhTOgorICAgICAgICBlbGlmIGFy Z3VtZW50IGluIEZMQUdTX1BSRUNFRElOR19QQVRIUzoKICAgICAgICAgICAgICMgU29tZSBmbGFn cyBwcmVjZWRlIHRoZSBwYXRoIGluIHRoZSBsaXN0LiBGb3IgdGhvc2Ugd2UgbWFrZSB0aGUKICAg ICAgICAgICAgICMgbmV4dCBhcmd1bWVudCBhYnNvbHV0ZS4KICAgICAgICAgICAgIGlmIGFyZ3Vt ZW50ID09IGZsYWc6Cg== 220203 2014-01-01 20:26:34 -0800 2014-01-02 17:16:04 -0800 Patch bug-126371-20140102022631.patch text/plain 3331 danilo.eu U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMjAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2Y2MmExNTJkODExZTg1NTgxOWQwM2RjOTZmODk4ZjFm YzQ0YzIzMS4uZDlkZDQ2ODZjYzM5YzQzMGZkZmVhNTc4OTNkNDE2ZGJiNDQwMzdhYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDE0LTAxLTAxICBEYW5pbG8gQ2VzYXIgTGVtZXMgZGUgUGF1bGEgIDxkYW5pbG8uY2Vz YXJAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFtHVEtdIGZpeGluZyB5Y21fZXh0cmFfY29u Zi5weSBmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjYzNzEKKworICAgICAgICBJdCdzIGFuIGF0dGVtcHQgdG8gZml4IHRocmVlIHByb2JsZW1z IHdpdGggdGhlIGN1cnJlbnQgeWNtX2V4dHJhX2NvbmYgZmlsZS4KKyAgICAgICAgVGhlIGN1cnJl bnQgaW1wbGVtZW50YXRpb24gYXNzdW1lcyB0aGF0IGl0J3MgYSBzeW1saW5rLCB3aGljaCBpcyBu b3QgdHJ1ZS4KKyAgICAgICAgVXN1YWxseSBweXRob24gY3JlYXRlcyBhIHB5YyBmaWxlLCBhbmQg dGhpcyBpcyB3aGF0IHlvdSBnZXQgaW4gX19maWxlX18uCisgICAgICAgIHRoZSAucHljIGlzIG5v dCBhIHN5bWxpbmssIGFuZCB0aGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBkb2Vzbid0IHdvcmsK KyAgICAgICAgaWYgdGhhdCdzIHRoZSBjYXNlLgorCisgICAgICAgIEl0IGFsc28gYXNzdW1lcyB0 aGF0IHRoZSB1c2VyIGlzIGluIHRoZSByb290IGZvbGRlci4KKyAgICAgICAgSWYgdGhlIHVzZXIg aXMgaW4gV2Via2l0QnVpbGQvRGVidWcgYW5kIG9wZW4gYSBmaWxlIGFzIC4uLy4uL1NvdXJjZS8q IGl0IHdvbid0IHdvcmsuCisKKyAgICAgICAgTGFzdCBidXQgbm90IGxlYXN0LCAiZWxpZiBmbGFn IGluIEZMQUdTX1BSRUNFRElOR19QQVRIUyIgZW1pdHMgYW4KKyAgICAgICAgZXhjZXB0aW9uIHNp bmNlICJmbGFnIiBkb2Vzbid0IGV4aXN0cy4KKworICAgICAgICBBbGwgdGhvc2UgdGhpbmdzIHdl cmUgZml4ZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBndGsveWNtX2V4dHJhX2NvbmYucHk6CisgICAgICAgICh0cmFuc2Zvcm1fcmVsYXRpdmVf cGF0aHNfdG9fYWJzb2x1dGVfcGF0aHMpOgorCiAyMDE0LTAxLTAxICBNYXJ0aW4gUm9iaW5zb24g IDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZW5hbWUgbGlidGVzdG5l dHNjYXBlcGx1Z2luIHRvIGxpYlRlc3ROZXRzY2FwZVBsdWdpbgpkaWZmIC0tZ2l0IGEvVG9vbHMv Z3RrL3ljbV9leHRyYV9jb25mLnB5IGIvVG9vbHMvZ3RrL3ljbV9leHRyYV9jb25mLnB5CmluZGV4 IDIyNzU5MTc0ZDk4MDFmMTY4NjNmOWI3M2MzMDYwMGJlMGQxNjIwZjguLmZiZmE4ZDk3NjJiOTgy YjBiZjM2MzEyNTQ5YmM4OTViYzQ4ZmExNmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay95Y21fZXh0 cmFfY29uZi5weQorKysgYi9Ub29scy9ndGsveWNtX2V4dHJhX2NvbmYucHkKQEAgLTIzLDEwICsy MywxNCBAQCBpbXBvcnQgc3lzCiAjIEl0J3MgdmVyeSBsaWtlbHkgdGhhdCB0aGlzIHNjcmlwdCBp cyBhIHN5bWxpbmsgc29tZXdoZXJlIGluIHRoZSBXZWJLaXQgZGlyZWN0b3J5LAogIyBzbyB3ZSB0 cnkgdG8gZmluZCB0aGUgYWN0dWFsIHNjcmlwdCBsb2NhdGlvbiBzbyB0aGF0IHdlIGNhbiBsb2Nh dGUgdGhlIHRvb2xzCiAjIGRpcmVjdG9yeS4KLWlmIG9zLnBhdGguaXNsaW5rKF9fZmlsZV9fKToK LSAgICBfX3Rvb2xzX2RpcmVjdG9yeSA9IG9zLnBhdGguZGlybmFtZShvcy5yZWFkbGluayhfX2Zp bGVfXykpCitvcmlnaW5hbF9maWxlID0gX19maWxlX19bOi0xXSBpZiBfX2ZpbGVfXy5lbmRzd2l0 aCgiLnB5YyIpIGVsc2UgX19maWxlX18KK2lmIG9zLnBhdGguaXNsaW5rKG9yaWdpbmFsX2ZpbGUp OgorICAgIHBhcmVudF9mb2xkZXIgPSBvcy5wYXRoLmFic3BhdGgob3MucGF0aC5kaXJuYW1lKG9y aWdpbmFsX2ZpbGUpKQorICAgIGxpbmtfZmlsZSA9IG9zLnBhdGguam9pbihwYXJlbnRfZm9sZGVy LCBvcy5yZWFkbGluayhvcmlnaW5hbF9maWxlKSkKKyAgICBfX3Rvb2xzX2RpcmVjdG9yeSA9IG9z LnBhdGguZGlybmFtZShsaW5rX2ZpbGUpCiBlbHNlOgotICAgIF9fdG9vbHNfZGlyZWN0b3J5ID0g b3MucGF0aC5kaXJuYW1lKF9fZmlsZV9fKQorICAgIF9fdG9vbHNfZGlyZWN0b3J5ID0gb3MucGF0 aC5kaXJuYW1lKG9yaWdpbmFsX2ZpbGUpCisKIHN5cy5wYXRoLmluc2VydCgwLCBvcy5wYXRoLmFi c3BhdGgoX190b29sc19kaXJlY3RvcnkpKQogaW1wb3J0IGNvbW1vbgogCkBAIC00Myw3ICs0Nyw3 IEBAIGRlZiB0cmFuc2Zvcm1fcmVsYXRpdmVfcGF0aHNfdG9fYWJzb2x1dGVfcGF0aHMoYXJndW1l bnRzLCBidWlsZF9wYXRoKToKICAgICAgICAgICAgIG1ha2VfbmV4dF9hYnNvbHV0ZSA9IEZhbHNl CiAgICAgICAgICAgICBpZiBub3QgYXJndW1lbnQuc3RhcnRzd2l0aCgnLycpOgogICAgICAgICAg ICAgICAgIGFyZ3VtZW50ID0gb3MucGF0aC5qb2luKGJ1aWxkX3BhdGgsIGFyZ3VtZW50KQotICAg ICAgICBlbGlmIGZsYWcgaW4gRkxBR1NfUFJFQ0VESU5HX1BBVEhTOgorICAgICAgICBlbGlmIGFy Z3VtZW50IGluIEZMQUdTX1BSRUNFRElOR19QQVRIUzoKICAgICAgICAgICAgICMgU29tZSBmbGFn cyBwcmVjZWRlIHRoZSBwYXRoIGluIHRoZSBsaXN0LiBGb3IgdGhvc2Ugd2UgbWFrZSB0aGUKICAg ICAgICAgICAgICMgbmV4dCBhcmd1bWVudCBhYnNvbHV0ZS4KICAgICAgICAgICAgIGlmIGFyZ3Vt ZW50ID09IGZsYWc6CkBAIC0xMDMsNyArMTA3LDcgQEAgZGVmIGdldF9jb21waWxhdGlvbl9mbGFn c19mb3JfZmlsZShidWlsZF9wYXRoLCBmaWxlbmFtZSk6CiAKICAgICBiYXNlbmFtZSA9IG9zLnBh dGguYmFzZW5hbWUoZmlsZW5hbWUpCiAgICAgZm9yIGxpbmUgaW4gbGluZXM6Ci0gICAgICAgIGlm IGxpbmUuZmluZChiYXNlbmFtZSkgIT0gLTEgYW5kIGxpbmUuZmluZCgiQ0MiKSAhPSAtMSBvciBs aW5lLmZpbmQoIkNYWCIpICE9IC0xOgorICAgICAgICBpZiBsaW5lLmZpbmQoYmFzZW5hbWUpICE9 IC0xIGFuZCAobGluZS5maW5kKCJDQyIpICE9IC0xIG9yIGxpbmUuZmluZCgiQ1hYIikgIT0gLTEp OgogICAgICAgICAgICAgcmV0dXJuIGdldF9jb21waWxhdGlvbl9mbGFnc19mcm9tX2J1aWxkX2Nv bW1hbmRsaW5lKGxpbmUsIGJ1aWxkX3BhdGgpCiAKICAgICBwcmludCAiQ291bGQgbm90IGZpbmQg ZmxhZ3MgZm9yICVzIiAlIGZpbGVuYW1lCg==