126361 2014-01-01 12:28:46 -0800 [CMake] The forwarding headers generated by WebKitMacros.m4 are incompatible with the headers generated by generate-forwarding-headers.pl 2014-01-03 08:59:24 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson commit-queue gustavo gyuyoung.kim pnormand rakuco oldest_to_newest 963619 0 mrobinson 2014-01-01 12:28:46 -0800 The headers generated by the CMake macros in WebKitMacros.m4 use absolute paths, while generate-forwarding-headers.pl uses paths relative to the Source directory. This means that when the two paths generate headers into the same directory they will be overwritten unnecessarily if the CMake files change. 963620 1 220189 mrobinson 2014-01-01 12:31:24 -0800 Created attachment 220189 Patch 964037 2 pnormand 2014-01-03 00:21:22 -0800 Is the EWS green? I don't see the bubbles currently. 964038 3 220189 pnormand 2014-01-03 00:23:23 -0800 Comment on attachment 220189 Patch Ok yes it's green indeed :) the patch looks good as well! 964119 4 220189 mrobinson 2014-01-03 08:59:21 -0800 Comment on attachment 220189 Patch Clearing flags on attachment: 220189 Committed r161263: <http://trac.webkit.org/changeset/161263> 964120 5 mrobinson 2014-01-03 08:59:24 -0800 All reviewed patches have been landed. Closing bug. 220189 2014-01-01 12:31:24 -0800 2014-01-03 08:59:21 -0800 Patch bug-126361-20140101123123.patch text/plain 2805 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0TWFjcm9zLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQppbmRleCBm ZDZhYTk5OTY1YWUzNjE2NzQyOTQwMWQyZDU3NGMyMjIzZjlmNzY4Li5lZjM3OTIxMTJmNGUyNGJi NDc4NWY4ZTU3Y2Y2ZmU0ZDE3ZDc3YTI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 TWFjcm9zLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKQEAgLTIw MywxNyArMjAzLDI0IEBAIGVuZG1hY3JvKCkKIAogCiBtYWNybyhXRUJLSVRfQ1JFQVRFX0ZPUldB UkRJTkdfSEVBREVSIF90YXJnZXRfZGlyZWN0b3J5IF9maWxlKQorICAgIGdldF9maWxlbmFtZV9j b21wb25lbnQoX3NvdXJjZV9wYXRoICIke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZS8iIEFCU09M VVRFKQogICAgIGdldF9maWxlbmFtZV9jb21wb25lbnQoX2Fic29sdXRlICIke19maWxlfSIgQUJT T0xVVEUpCiAgICAgZ2V0X2ZpbGVuYW1lX2NvbXBvbmVudChfbmFtZSAiJHtfZmlsZX0iIE5BTUUp Ci0gICAgc2V0KF9jb250ZW50ICIjaW5jbHVkZSBcIiR7X2Fic29sdXRlfVwiXG4iKQotICAgIHNl dChfZmlsZW5hbWUgIiR7X3RhcmdldF9kaXJlY3Rvcnl9LyR7X25hbWV9IikKKyAgICBzZXQoX3Rh cmdldF9maWxlbmFtZSAiJHtfdGFyZ2V0X2RpcmVjdG9yeX0vJHtfbmFtZX0iKQogCi0gICAgaWYg KEVYSVNUUyAiJHtfZmlsZW5hbWV9IikKLSAgICAgICAgZmlsZShSRUFEICIke19maWxlbmFtZX0i IF9vbGRfY29udGVudCkKKyAgICAjIFRyeSB0byBtYWtlIHRoZSBwYXRoIGluIHRoZSBmb3J3YXJk aW5nIGhlYWRlciByZWxhdGl2ZSB0byB0aGUgU291cmNlIGRpcmVjdG9yeQorICAgICMgc28gdGhh dCB0aGVzZSBmb3J3YXJkaW5nIGhlYWRlcnMgYXJlIGNvbXBhdGlibGUgd2l0aCB0aGUgb25lcyBj cmVhdGVkIGJ5IHRoZQorICAgICMgV2ViS2l0MiBnZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMg c2NyaXB0LgorICAgIHN0cmluZyhSRUdFWCBSRVBMQUNFICIke19zb3VyY2VfcGF0aH0vIiAiIiBf cmVsYXRpdmUgJHtfYWJzb2x1dGV9KQorCisgICAgc2V0KF9jb250ZW50ICIjaW5jbHVkZSBcIiR7 X3JlbGF0aXZlfVwiXG4iKQorCisgICAgaWYgKEVYSVNUUyAiJHtfdGFyZ2V0X2ZpbGVuYW1lfSIp CisgICAgICAgIGZpbGUoUkVBRCAiJHtfdGFyZ2V0X2ZpbGVuYW1lfSIgX29sZF9jb250ZW50KQog ICAgIGVuZGlmICgpCiAKICAgICBpZiAoTk9UIF9vbGRfY29udGVudCBTVFJFUVVBTCBfY29udGVu dCkKLSAgICAgICAgZmlsZShXUklURSAiJHtfZmlsZW5hbWV9IiAiJHtfY29udGVudH0iKQorICAg ICAgICBmaWxlKFdSSVRFICIke190YXJnZXRfZmlsZW5hbWV9IiAiJHtfY29udGVudH0iKQogICAg IGVuZGlmICgpCiBlbmRtYWNybygpCiAKQEAgLTIyNiw3ICsyMzMsNyBAQCBtYWNybyhXRUJLSVRf Q1JFQVRFX0ZPUldBUkRJTkdfSEVBREVSUyBfZnJhbWV3b3JrKQogICAgIGZvcmVhY2ggKF9maWxl ICR7X2ZpbGVzfSkKICAgICAgICAgZmlsZShSRUFEICIke19maWxlfSIgX2NvbnRlbnQpCiAgICAg ICAgIHN0cmluZyhSRUdFWCBNQVRDSCAiXiNpbmNsdWRlIFwiKFteXCJdKilcIiIgX21hdGNoZWQg JHtfY29udGVudH0pCi0gICAgICAgIGlmIChfbWF0Y2hlZCBBTkQgTk9UIEVYSVNUUyAiJHtDTUFL RV9NQVRDSF8xfSIpCisgICAgICAgIGlmIChfbWF0Y2hlZCBBTkQgTk9UIEVYSVNUUyAiJHtDTUFL RV9TT1VSQ0VfRElSfS9Tb3VyY2UvJHtDTUFLRV9NQVRDSF8xfSIpCiAgICAgICAgICAgIGZpbGUo UkVNT1ZFICIke19maWxlfSIpCiAgICAgICAgIGVuZGlmICgpCiAgICAgZW5kZm9yZWFjaCAoKQpk aWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDgyYTZjZWIzMGQyMzM3OWU0 M2I1ZmY0YjkwNDc4NmQ1MDI5NTBjMzQuLmQ5NWQyZWUxNDZhN2ExZjQ2N2Q4ODhjMWIyMGY4OTg0 YzNkZjVhMDQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAxNC0wMS0wMSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5j b20+CisKKyAgICAgICAgW0NNYWtlXSBUaGUgZm9yd2FyZGluZyBoZWFkZXJzIGdlbmVyYXRlZCBi eSBXZWJLaXRNYWNyb3MubTQgYXJlIGluY29tcGF0aWJsZSB3aXRoIHRoZSBoZWFkZXJzIGdlbmVy YXRlZCBieSBnZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjM2MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgdGhlIGZvcndhcmRpbmcgaGVhZGVy cyBnZW5lcmF0ZWQgYnkgV2ViS2l0TWFjcm9zLm00IGNvbXBhdGlibGUgd2l0aCB0aGUgaGVhZGVy cworICAgICAgICBnZW5lcmF0ZWQgYnkgdGhlIFdlYktpdDIgZm9yd2FyZGluZyBoZWFkZXJzIGdl bmVyYXRpb24gc2NyaXB0LgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5j bWFrZTogVHJ5IHRvIGNvbnZlcnQgYWJzb2x1dGUgcGF0aHMgaW4gdGhlIGZvcndhcmRpbmcgaGVh ZGVycworICAgICAgICB0byBvbmVzIHRoYXQgYXJlIHJlbGF0aXZlIHRvIHRoZSBTb3VyY2UgZGly ZWN0b3J5LgorCiAyMDEzLTEyLTMwICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlh LmNvbT4KIAogICAgICAgICBbQ01ha2VdIFtHVEtdIEFkZCBzdXBwb3J0IGZvciBHT2JqZWN0IGlu dHJvc3BlY3Rpb24K