126358 2014-01-01 08:03:29 -0800 [CMake] Build TestWebKitAPI tests into a directory structure 2014-01-06 08:38:36 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson commit-queue gustavo gyuyoung.kim gyuyoung.kim rakuco oldest_to_newest 963605 0 mrobinson 2014-01-01 08:03:29 -0800 WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This is useful for keeping the "bin" directory tidy during building and will make it easier to integrate the CMake build into the existing WebKitGTK+ scripts. 963606 1 220185 mrobinson 2014-01-01 08:05:32 -0800 Created attachment 220185 Patch 963998 2 220185 gyuyoung.kim 2014-01-02 20:19:56 -0800 Comment on attachment 220185 Patch LGTM. 964117 3 220185 mrobinson 2014-01-03 08:58:27 -0800 Comment on attachment 220185 Patch Clearing flags on attachment: 220185 Committed r161262: <http://trac.webkit.org/changeset/161262> 964118 4 mrobinson 2014-01-03 08:58:30 -0800 All reviewed patches have been landed. Closing bug. 964574 5 gyuyoung.kim 2014-01-06 01:07:40 -0800 EFL API tests have broken since this patch. 964631 6 mrobinson 2014-01-06 08:38:36 -0800 (In reply to comment #5) > EFL API tests have broken since this patch. Sorry about that! How should I run the EFL API tests? 220185 2014-01-01 08:05:32 -0800 2014-01-03 08:58:27 -0800 Patch bug-126358-20140101080531.patch text/plain 5480 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMTgzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzdjNWFiZWRkODJhNGU1Y2U0YTFiMGRhZDgwODFkN2Jh NjQ5ZDlhYi4uMzNlYmRjNTUzOWZiNDY3ZDJlMWQ1NzUwZGM3MzlhNDE3OWRkNzllMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE0LTAxLTAxICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K KworICAgICAgICBbQ01ha2VdIEJ1aWxkIFRlc3RXZWJLaXRBUEkgdGVzdHMgaW50byBhIGRpcmVj dG9yeSBzdHJ1Y3R1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyNjM1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlYktpdEdUSysgYnVpbGRzIHRoZSBUZXN0V2ViS2l0QVBJIHRlc3RzIGludG8gYSAi VGVzdFdlYktpdEFQSSIgZGlyZWN0b3J5LiBUaGlzCisgICAgICAgIGlzIHVzZWZ1bCBmb3Iga2Vl cGluZyB0aGUgImJpbiIgZGlyZWN0b3J5IHRpZHkgZHVyaW5nIGJ1aWxkaW5nIGFuZCB3aWxsIG1h a2UgaXQgZWFzaWVyCisgICAgICAgIHRvIGludGVncmF0ZSB0aGUgQ01ha2UgYnVpbGQgaW50byB0 aGUgZXhpc3RpbmcgV2ViS2l0R1RLKyBzY3JpcHRzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQ SS9DTWFrZUxpc3RzLnR4dDogU2V0IHRoZSBvdXRwdXQgZGlyZWN0b3J5IG9mIGFsbCBUZXN0V2Vi S2l0QVBJIGJpbmFyaWVzCisgICAgICAgIGFuZCBtYWtlIHRoZSBuYW1lcyBzaW1wbGVyIG5vdyB0 aGF0IHRoZSBkaXJlY3RvcnkgaWRlbnRpZmllcyB3aGF0IGNhdGVnb3J5IHRoZSB0ZXN0IGlzIGlu LgorCiAyMDEzLTEyLTMxICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K IAogICAgICAgICBbR1RLXSBSZW5hbWUgbGlidGVzdG5ldHNjYXBlcGx1Z2luIHRvIGxpYlRlc3RO ZXRzY2FwZVBsdWdpbgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9DTWFrZUxpc3Rz LnR4dCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQKaW5kZXggNDJmYzg2ZGU2 NGM1OWE2MWUxYWZhYjBhYmZmMDRkYzU4N2NlYWE0NC4uMDE1N2NmYTdlNzliNzI4ZmFmZmM3YjUx ZGFjNmM0ODljZDc0ODZhOCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9DTWFrZUxp c3RzLnR4dAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL0NNYWtlTGlzdHMudHh0CkBAIC0xLDQg KzEsNSBAQAogc2V0KFRFU1RXRUJLSVRBUElfRElSICIke1RPT0xTX0RJUn0vVGVzdFdlYktpdEFQ SSIpCitzZXQoVEVTVFdFQktJVEFQSV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUlkgIiR7Q01BS0Vf UlVOVElNRV9PVVRQVVRfRElSRUNUT1JZfS9UZXN0V2ViS2l0QVBJIikKIAogaW5jbHVkZV9kaXJl Y3Rvcmllcygke0NNQUtFX0JJTkFSWV9ESVJ9CiAgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0KQEAg LTkwLDcgKzkxLDcgQEAgYWRkX2RlZmluaXRpb25zKC1ER1RFU1RfTElOS0VEX0FTX1NIQVJFRF9M SUJSQVJZPTEKICAgICAtRFRFU1RfSU5KRUNURURfQlVORExFX1BBVEg9XCIke1Rlc3RXZWJLaXRB UElJbmplY3RlZEJ1bmRsZV9QQVRIfVwiCiApCiAKLWFkZF9leGVjdXRhYmxlKHRlc3Rfd3RmCith ZGRfZXhlY3V0YWJsZShUZXN0V1RGCiAgICAgJHt0ZXN0X21haW5fU09VUkNFU30KICAgICAke1RF U1RXRUJLSVRBUElfRElSfS9UZXN0c0NvbnRyb2xsZXIuY3BwCiAgICAgJHtURVNUV0VCS0lUQVBJ X0RJUn0vVGVzdHMvV1RGL0F0b21pY1N0cmluZy5jcHAKQEAgLTExNywxNiArMTE4LDIyIEBAIGFk ZF9leGVjdXRhYmxlKHRlc3Rfd3RmCiAgICAgJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV1RG L1dURlN0cmluZy5jcHAKICkKIAotdGFyZ2V0X2xpbmtfbGlicmFyaWVzKHRlc3Rfd3RmICR7dGVz dF93dGZfTElCUkFSSUVTfSkKLWFkZF9kZXBlbmRlbmNpZXModGVzdF93dGYgJHtGb3J3YXJkaW5n SGVhZGVyc0ZvclRlc3RXZWJLaXRBUElfTkFNRX0gJHtGb3J3YXJkaW5nTmV0d29ya0hlYWRlcnNG b3JUZXN0V2ViS2l0QVBJX05BTUV9KQotYWRkX3Rlc3QodGVzdF93dGYgJHtDTUFLRV9SVU5USU1F X09VVFBVVF9ESVJFQ1RPUll9L3Rlc3Rfd3RmKQotc2V0X3Rlc3RzX3Byb3BlcnRpZXModGVzdF93 dGYgUFJPUEVSVElFUyBUSU1FT1VUIDYwKQordGFyZ2V0X2xpbmtfbGlicmFyaWVzKFRlc3RXVEYg JHt0ZXN0X3d0Zl9MSUJSQVJJRVN9KQorYWRkX2RlcGVuZGVuY2llcyhUZXN0V1RGICR7Rm9yd2Fy ZGluZ0hlYWRlcnNGb3JUZXN0V2ViS2l0QVBJX05BTUV9ICR7Rm9yd2FyZGluZ05ldHdvcmtIZWFk ZXJzRm9yVGVzdFdlYktpdEFQSV9OQU1FfSkKK2FkZF90ZXN0KFRlc3RXVEYgJHtURVNUV0VCS0lU QVBJX1JVTlRJTUVfT1VUUFVUX0RJUkVDVE9SWX0vV1RGL1Rlc3RXVEYpCitzZXRfdGVzdHNfcHJv cGVydGllcyhUZXN0V1RGIFBST1BFUlRJRVMgVElNRU9VVCA2MCkKKyAgICBzZXRfdGFyZ2V0X3By b3BlcnRpZXMoVGVzdFdURiBQUk9QRVJUSUVTCisgICAgICAgIFJVTlRJTUVfT1VUUFVUX0RJUkVD VE9SWSAke1RFU1RXRUJLSVRBUElfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZfS9XVEYKKyAgICAp CiAKIGZvcmVhY2ggKHRlc3ROYW1lICR7dGVzdF93ZWJjb3JlX0JJTkFSSUVTfSkKLSAgICBhZGRf ZXhlY3V0YWJsZSh0ZXN0X3dlYmNvcmVfJHt0ZXN0TmFtZX0gJHt0ZXN0X21haW5fU09VUkNFU30g JHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHNDb250cm9sbGVyLmNwcCAke1RFU1RXRUJLSVRBUElf RElSfS9UZXN0cy9XZWJDb3JlLyR7dGVzdE5hbWV9LmNwcCkKLSAgICBhZGRfdGVzdCh0ZXN0X3dl YmNvcmVfJHt0ZXN0TmFtZX0gJHtDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUll9L3Rlc3Rf d2ViY29yZV8ke3Rlc3ROYW1lfSkKLSAgICBzZXRfdGVzdHNfcHJvcGVydGllcyh0ZXN0X3dlYmNv cmVfJHt0ZXN0TmFtZX0gUFJPUEVSVElFUyBUSU1FT1VUIDYwKQotICAgIHRhcmdldF9saW5rX2xp YnJhcmllcyh0ZXN0X3dlYmNvcmVfJHt0ZXN0TmFtZX0gJHt0ZXN0X3dlYmNvcmVfTElCUkFSSUVT fSkKKyAgICBhZGRfZXhlY3V0YWJsZSgke3Rlc3ROYW1lfSAke3Rlc3RfbWFpbl9TT1VSQ0VTfSAk e1RFU1RXRUJLSVRBUElfRElSfS9UZXN0c0NvbnRyb2xsZXIuY3BwICR7VEVTVFdFQktJVEFQSV9E SVJ9L1Rlc3RzL1dlYkNvcmUvJHt0ZXN0TmFtZX0uY3BwKQorICAgIGFkZF90ZXN0KCR7dGVzdE5h bWV9ICR7VEVTVFdFQktJVEFQSV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUll9L1dlYkNvcmUvJHt0 ZXN0TmFtZX0pCisgICAgc2V0X3Rlc3RzX3Byb3BlcnRpZXMoJHt0ZXN0TmFtZX0gUFJPUEVSVElF UyBUSU1FT1VUIDYwKQorICAgIHRhcmdldF9saW5rX2xpYnJhcmllcygke3Rlc3ROYW1lfSAke3Rl c3Rfd2ViY29yZV9MSUJSQVJJRVN9KQorICAgIHNldF90YXJnZXRfcHJvcGVydGllcygke3Rlc3RO YW1lfSBQUk9QRVJUSUVTCisgICAgICAgIFJVTlRJTUVfT1VUUFVUX0RJUkVDVE9SWSAke1RFU1RX RUJLSVRBUElfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZfS9XZWJDb3JlCisgICAgKQogZW5kZm9y ZWFjaCAoKQogCiBhZGRfbGlicmFyeShUZXN0V2ViS2l0QVBJQmFzZQpAQCAtMTQxLDEwICsxNDgs MTMgQEAgYWRkX2RlcGVuZGVuY2llcyhUZXN0V2ViS2l0QVBJQmFzZSBXZWJLaXQyICR7Rm9yd2Fy ZGluZ0hlYWRlcnNGb3JUZXN0V2ViS2l0QVBJX04KIAogZm9yZWFjaCAodGVzdE5hbWUgJHt0ZXN0 X3dlYmtpdDJfYXBpX0JJTkFSSUVTfSkKICAgICBnZXRfZmlsZW5hbWVfY29tcG9uZW50KHRlc3RC YXNlTmFtZSAke3Rlc3ROYW1lfSBOQU1FKQotICAgIGFkZF9leGVjdXRhYmxlKHRlc3Rfd2Via2l0 Ml9hcGlfJHt0ZXN0QmFzZU5hbWV9ICR7VEVTVFdFQktJVEFQSV9ESVJ9L1Rlc3RzL1dlYktpdDIv JHt0ZXN0TmFtZX0uY3BwKQotICAgIGFkZF90ZXN0KHRlc3Rfd2Via2l0Ml9hcGlfJHt0ZXN0QmFz ZU5hbWV9ICR7Q01BS0VfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZfS90ZXN0X3dlYmtpdDJfYXBp XyR7dGVzdEJhc2VOYW1lfSkKLSAgICBzZXRfdGVzdHNfcHJvcGVydGllcyh0ZXN0X3dlYmtpdDJf YXBpXyR7dGVzdEJhc2VOYW1lfSBQUk9QRVJUSUVTIFRJTUVPVVQgNjApCi0gICAgdGFyZ2V0X2xp bmtfbGlicmFyaWVzKHRlc3Rfd2Via2l0Ml9hcGlfJHt0ZXN0QmFzZU5hbWV9ICR7dGVzdF93ZWJr aXQyX2FwaV9MSUJSQVJJRVN9KQorICAgIGFkZF9leGVjdXRhYmxlKCR7dGVzdEJhc2VOYW1lfSAk e1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyLyR7dGVzdE5hbWV9LmNwcCkKKyAgICBh ZGRfdGVzdCgke3Rlc3RCYXNlTmFtZX0gJHtURVNUV0VCS0lUQVBJX1JVTlRJTUVfT1VUUFVUX0RJ UkVDVE9SWX0vV2ViS2l0Mi8ke3Rlc3RCYXNlTmFtZX0pCisgICAgc2V0X3Rlc3RzX3Byb3BlcnRp ZXMoJHt0ZXN0QmFzZU5hbWV9IFBST1BFUlRJRVMgVElNRU9VVCA2MCkKKyAgICB0YXJnZXRfbGlu a19saWJyYXJpZXMoJHt0ZXN0QmFzZU5hbWV9ICR7dGVzdF93ZWJraXQyX2FwaV9MSUJSQVJJRVN9 KQorICAgIHNldF90YXJnZXRfcHJvcGVydGllcygke3Rlc3RCYXNlTmFtZX0gUFJPUEVSVElFUwor ICAgICAgICBSVU5USU1FX09VVFBVVF9ESVJFQ1RPUlkgJHtURVNUV0VCS0lUQVBJX1JVTlRJTUVf T1VUUFVUX0RJUkVDVE9SWX0vV2ViS2l0MgorICAgICkKIGVuZGZvcmVhY2ggKCkKIAogIyBXZSBk b24ndCBydW4gdGVzdHMgdGhhdCBhcmUgZXhwZWN0ZWQgdG8gZmFpbC4gV2UgY291bGQgdXNlIHRo ZSBXSUxMX0ZBSUwKQEAgLTE1Miw2ICsxNjIsOSBAQCBlbmRmb3JlYWNoICgpCiAjIG1ha2UgdGhl IGJvdCByZWQuCiAKIGZvcmVhY2ggKHRlc3ROYW1lICR7dGVzdF93ZWJraXQyX2FwaV9mYWlsX0JJ TkFSSUVTfSkKLSAgICBhZGRfZXhlY3V0YWJsZSh0ZXN0X3dlYmtpdDJfYXBpX2ZhaWxfJHt0ZXN0 TmFtZX0gJHtURVNUV0VCS0lUQVBJX0RJUn0vVGVzdHMvV2ViS2l0Mi8ke3Rlc3ROYW1lfS5jcHAp Ci0gICAgdGFyZ2V0X2xpbmtfbGlicmFyaWVzKHRlc3Rfd2Via2l0Ml9hcGlfZmFpbF8ke3Rlc3RO YW1lfSAke3Rlc3Rfd2Via2l0Ml9hcGlfTElCUkFSSUVTfSkKKyAgICBhZGRfZXhlY3V0YWJsZSgk e3Rlc3ROYW1lfSAke1RFU1RXRUJLSVRBUElfRElSfS9UZXN0cy9XZWJLaXQyLyR7dGVzdE5hbWV9 LmNwcCkKKyAgICB0YXJnZXRfbGlua19saWJyYXJpZXMoJHt0ZXN0TmFtZX0gJHt0ZXN0X3dlYmtp dDJfYXBpX0xJQlJBUklFU30pCisgICAgc2V0X3RhcmdldF9wcm9wZXJ0aWVzKCR7dGVzdEJhc2VO YW1lfSBQUk9QRVJUSUVTCisgICAgICAgIFJVTlRJTUVfT1VUUFVUX0RJUkVDVE9SWSAke1RFU1RX RUJLSVRBUElfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZfS9XZWJLaXQyCisgICAgKQogZW5kZm9y ZWFjaCAoKQo=