126354 2013-12-31 20:51:26 -0800 [GTK][WK2] Back items are shown in reverse order in MiniBrowser 2014-01-01 05:31:32 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 changseok changseok cgarcia commit-queue gustavo mrobinson oldest_to_newest 963569 0 changseok 2013-12-31 20:51:26 -0800 SSIA. 963571 1 220174 changseok 2013-12-31 21:11:35 -0800 Created attachment 220174 Patch 963572 2 commit-queue 2013-12-31 21:13:45 -0800 Attachment 220174 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/gtk/BrowserWindow.c', '--commit-queue']" exit_code: 1 ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:235: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 963573 3 changseok 2013-12-31 21:15:19 -0800 (In reply to comment #2) > Attachment 220174 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/gtk/BrowserWindow.c', '--commit-queue']" exit_code: 1 > ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:235: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Tools/MiniBrowser/gtk/BrowserWindow.c:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] > Total errors found: 2 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. A false positives, I didn't change the indentations. 963578 4 220174 mrobinson 2013-12-31 22:05:53 -0800 Comment on attachment 220174 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220174&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:199 > +static GtkWidget *browserWindowCreateBackForwardMenu(BrowserWindow *window, GList *list, gboolean back) I think that reverseMenuItemOrder might be a better name for this variable. > Tools/MiniBrowser/gtk/BrowserWindow.c:235 > - browserWindowCreateBackForwardMenu(window, list)); > + browserWindowCreateBackForwardMenu(window, list, true)); The indentation was wrong here before, please fix it when you change this line. > Tools/MiniBrowser/gtk/BrowserWindow.c:240 > - browserWindowCreateBackForwardMenu(window, list)); > + browserWindowCreateBackForwardMenu(window, list, false)); Ditto. 963580 5 220176 changseok 2013-12-31 22:20:44 -0800 Created attachment 220176 Patch 963581 6 220177 changseok 2013-12-31 22:29:38 -0800 Created attachment 220177 Patch 963582 7 220174 changseok 2013-12-31 22:30:43 -0800 Comment on attachment 220174 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220174&action=review >> Tools/MiniBrowser/gtk/BrowserWindow.c:199 >> +static GtkWidget *browserWindowCreateBackForwardMenu(BrowserWindow *window, GList *list, gboolean back) > > I think that reverseMenuItemOrder might be a better name for this variable. Done. >> Tools/MiniBrowser/gtk/BrowserWindow.c:235 >> + browserWindowCreateBackForwardMenu(window, list, true)); > > The indentation was wrong here before, please fix it when you change this line. O.K no problem. >> Tools/MiniBrowser/gtk/BrowserWindow.c:240 >> + browserWindowCreateBackForwardMenu(window, list, false)); > > Ditto. Done. 963597 8 220177 cgarcia 2014-01-01 04:13:20 -0800 Comment on attachment 220177 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220177&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:199 > +static GtkWidget *browserWindowCreateBackForwardMenu(BrowserWindow *window, GList *list, gboolean reverseMenuItemOrder) Use bool here instead of gboolean, you are indeed passing true/false not TRUE/FALSE. > Tools/MiniBrowser/gtk/BrowserWindow.c:235 > GList *list = webkit_back_forward_list_get_back_list_with_limit(backForwadlist, 10); > gtk_menu_tool_button_set_menu(GTK_MENU_TOOL_BUTTON(window->backItem), > - browserWindowCreateBackForwardMenu(window, list)); > + browserWindowCreateBackForwardMenu(window, list, true)); I think it would be easier to revert the back list, so that you don't need any change in browserWindowCreateBackForwardMenu nor the boolean parameter. GList *list = g_list_reverse(webkit_back_forward_list_get_back_list_with_limit(backForwadlist, 10)); 963598 9 220177 changseok 2014-01-01 04:35:46 -0800 Comment on attachment 220177 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220177&action=review >> Tools/MiniBrowser/gtk/BrowserWindow.c:235 >> + browserWindowCreateBackForwardMenu(window, list, true)); > > I think it would be easier to revert the back list, so that you don't need any change in browserWindowCreateBackForwardMenu nor the boolean parameter. > > GList *list = g_list_reverse(webkit_back_forward_list_get_back_list_with_limit(backForwadlist, 10)); Agree. It looks more elegant. Thanks 963599 10 220184 changseok 2014-01-01 04:36:06 -0800 Created attachment 220184 Patch 963600 11 220184 commit-queue 2014-01-01 05:31:30 -0800 Comment on attachment 220184 Patch Clearing flags on attachment: 220184 Committed r161187: <http://trac.webkit.org/changeset/161187> 963601 12 commit-queue 2014-01-01 05:31:32 -0800 All reviewed patches have been landed. Closing bug. 220174 2013-12-31 21:11:35 -0800 2013-12-31 22:30:43 -0800 Patch bug-126354-20140101141133.patch text/plain 3095 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMTg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGZjMDY4YjM1MzVhNTIwMTVjNzYxMWEzOGJjOGQ3NmY0 NTExMTI4MC4uOTQ2NDJhZjkyMTA1MTAxYjQwNjg0MmZkMGQzMDAyZDZjMDczNGJmNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTEyLTMxICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNv bT4KKworICAgICAgICBbR1RLXVtXSzJdIEJhY2sgaXRlbXMgYXJlIHNob3duIGluIHJldmVyc2Ug b3JkZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjYzNTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgbGF0ZXN0IHZpc2l0ZWQgc2l0ZSBmb3IgYmFja3dhcmQgaGlzdG9yeSBzaG91bGQgYmUgcGxh Y2VkIG9uIHRoZSB0b3Agb2YgYSBoaXN0b3J5IHN0YWNrCisgICAgICAgIGFzIGEgY29tbW9uIGJl aGF2aW9yLiBIb3dldmVyIGN1cnJlbnRseSBpdHMgb3JkZXIgaXMgcmV2ZXJzZS4KKworICAgICAg ICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAgICAgIChicm93c2VyV2lu ZG93Q3JlYXRlQmFja0ZvcndhcmRNZW51KTogQWRkIGEgYm9vbGVhbiB0byBmaWd1cmUgb3V0IGJh Y2t3YXJkIG9yIGZvcndhcmQuCisgICAgICAgIChicm93c2VyV2luZG93VXBkYXRlTmF2aWdhdGlv bkFjdGlvbnMpOiBBIGxpc3QgaXRlbSBmb3IgYSBiYWNrd2FyZCBoaXN0b3J5IGlzIGFkZGVkIHRv IG1lbnUgZnJvbSB0aGUgdGFpbCB0byBoZWFkLgorCiAyMDEzLTEyLTMwICBNYXJ0aW4gUm9iaW5z b24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBNYWtlIHRoZSBvdXRw dXQgZGlyZWN0b3J5IG9mIEdPYmplY3QgdW5pdCB0ZXN0cyBiaW5hcmllcyBjb25zaXN0ZW50IHdp dGggdGhlIENNYWtlIGJ1aWxkCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJv d3NlcldpbmRvdy5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwppbmRl eCAxZDNiNGZjZjQ1ZjQ0MTYyM2RmNjkwZDNjNTUyZGNiZjdiZjYwY2UyLi43ZGMyNjcyZmNiYmNk ZWMwYTI1NmU1MTFhNjc2YTNlMTViZDg5Y2VhIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nl ci9ndGsvQnJvd3NlcldpbmRvdy5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2Vy V2luZG93LmMKQEAgLTE5NiwxNCArMTk2LDE0IEBAIHN0YXRpYyB2b2lkIGJyb3dzZXJXaW5kb3dI aXN0b3J5SXRlbUFjdGl2YXRlZChCcm93c2VyV2luZG93ICp3aW5kb3csIEd0a0FjdGlvbiAqCiAg ICAgd2Via2l0X3dlYl92aWV3X2dvX3RvX2JhY2tfZm9yd2FyZF9saXN0X2l0ZW0od2luZG93LT53 ZWJWaWV3LCBpdGVtKTsKIH0KIAotc3RhdGljIEd0a1dpZGdldCAqYnJvd3NlcldpbmRvd0NyZWF0 ZUJhY2tGb3J3YXJkTWVudShCcm93c2VyV2luZG93ICp3aW5kb3csIEdMaXN0ICpsaXN0KQorc3Rh dGljIEd0a1dpZGdldCAqYnJvd3NlcldpbmRvd0NyZWF0ZUJhY2tGb3J3YXJkTWVudShCcm93c2Vy V2luZG93ICp3aW5kb3csIEdMaXN0ICpsaXN0LCBnYm9vbGVhbiBiYWNrKQogewogICAgIGlmICgh bGlzdCkKICAgICAgICAgcmV0dXJuIE5VTEw7CiAKICAgICBHdGtXaWRnZXQgKm1lbnUgPSBndGtf bWVudV9uZXcoKTsKICAgICBHTGlzdCAqbGlzdEl0ZW07Ci0gICAgZm9yIChsaXN0SXRlbSA9IGxp c3Q7IGxpc3RJdGVtOyBsaXN0SXRlbSA9IGdfbGlzdF9uZXh0KGxpc3RJdGVtKSkgeworICAgIGZv ciAobGlzdEl0ZW0gPSAoYmFjayA/IGdfbGlzdF9sYXN0KGxpc3QpIDogbGlzdCk7IGxpc3RJdGVt OyBsaXN0SXRlbSA9IChiYWNrID8gZ19saXN0X3ByZXZpb3VzKGxpc3RJdGVtKSA6IGdfbGlzdF9u ZXh0KGxpc3RJdGVtKSkpIHsKICAgICAgICAgV2ViS2l0QmFja0ZvcndhcmRMaXN0SXRlbSAqaXRl bSA9IChXZWJLaXRCYWNrRm9yd2FyZExpc3RJdGVtICopbGlzdEl0ZW0tPmRhdGE7CiAgICAgICAg IGNvbnN0IGNoYXIgKnVyaSA9IHdlYmtpdF9iYWNrX2ZvcndhcmRfbGlzdF9pdGVtX2dldF91cmko aXRlbSk7CiAgICAgICAgIGNvbnN0IGNoYXIgKnRpdGxlID0gd2Via2l0X2JhY2tfZm9yd2FyZF9s aXN0X2l0ZW1fZ2V0X3RpdGxlKGl0ZW0pOwpAQCAtMjMyLDEyICsyMzIsMTIgQEAgc3RhdGljIHZv aWQgYnJvd3NlcldpbmRvd1VwZGF0ZU5hdmlnYXRpb25BY3Rpb25zKEJyb3dzZXJXaW5kb3cgKndp bmRvdywgV2ViS2l0QmEKIAogICAgIEdMaXN0ICpsaXN0ID0gd2Via2l0X2JhY2tfZm9yd2FyZF9s aXN0X2dldF9iYWNrX2xpc3Rfd2l0aF9saW1pdChiYWNrRm9yd2FkbGlzdCwgMTApOwogICAgIGd0 a19tZW51X3Rvb2xfYnV0dG9uX3NldF9tZW51KEdUS19NRU5VX1RPT0xfQlVUVE9OKHdpbmRvdy0+ YmFja0l0ZW0pLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJyb3dzZXJXaW5k b3dDcmVhdGVCYWNrRm9yd2FyZE1lbnUod2luZG93LCBsaXN0KSk7CisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgYnJvd3NlcldpbmRvd0NyZWF0ZUJhY2tGb3J3YXJkTWVudSh3aW5k b3csIGxpc3QsIHRydWUpKTsKICAgICBnX2xpc3RfZnJlZShsaXN0KTsKIAogICAgIGxpc3QgPSB3 ZWJraXRfYmFja19mb3J3YXJkX2xpc3RfZ2V0X2ZvcndhcmRfbGlzdF93aXRoX2xpbWl0KGJhY2tG b3J3YWRsaXN0LCAxMCk7CiAgICAgZ3RrX21lbnVfdG9vbF9idXR0b25fc2V0X21lbnUoR1RLX01F TlVfVE9PTF9CVVRUT04od2luZG93LT5mb3J3YXJkSXRlbSksCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYnJvd3NlcldpbmRvd0NyZWF0ZUJhY2tGb3J3YXJkTWVudSh3aW5kb3cs IGxpc3QpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBicm93c2VyV2luZG93 Q3JlYXRlQmFja0ZvcndhcmRNZW51KHdpbmRvdywgbGlzdCwgZmFsc2UpKTsKICAgICBnX2xpc3Rf ZnJlZShsaXN0KTsKIH0KIAo= 220176 2013-12-31 22:20:44 -0800 2013-12-31 22:29:33 -0800 Patch bug-126354-20140101152043.patch text/plain 3043 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMTg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGZjMDY4YjM1MzVhNTIwMTVjNzYxMWEzOGJjOGQ3NmY0 NTExMTI4MC4uOTQ2NDJhZjkyMTA1MTAxYjQwNjg0MmZkMGQzMDAyZDZjMDczNGJmNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTEyLTMxICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNv bT4KKworICAgICAgICBbR1RLXVtXSzJdIEJhY2sgaXRlbXMgYXJlIHNob3duIGluIHJldmVyc2Ug b3JkZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjYzNTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgbGF0ZXN0IHZpc2l0ZWQgc2l0ZSBmb3IgYmFja3dhcmQgaGlzdG9yeSBzaG91bGQgYmUgcGxh Y2VkIG9uIHRoZSB0b3Agb2YgYSBoaXN0b3J5IHN0YWNrCisgICAgICAgIGFzIGEgY29tbW9uIGJl aGF2aW9yLiBIb3dldmVyIGN1cnJlbnRseSBpdHMgb3JkZXIgaXMgcmV2ZXJzZS4KKworICAgICAg ICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAgICAgIChicm93c2VyV2lu ZG93Q3JlYXRlQmFja0ZvcndhcmRNZW51KTogQWRkIGEgYm9vbGVhbiB0byBmaWd1cmUgb3V0IGJh Y2t3YXJkIG9yIGZvcndhcmQuCisgICAgICAgIChicm93c2VyV2luZG93VXBkYXRlTmF2aWdhdGlv bkFjdGlvbnMpOiBBIGxpc3QgaXRlbSBmb3IgYSBiYWNrd2FyZCBoaXN0b3J5IGlzIGFkZGVkIHRv IG1lbnUgZnJvbSB0aGUgdGFpbCB0byBoZWFkLgorCiAyMDEzLTEyLTMwICBNYXJ0aW4gUm9iaW5z b24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBNYWtlIHRoZSBvdXRw dXQgZGlyZWN0b3J5IG9mIEdPYmplY3QgdW5pdCB0ZXN0cyBiaW5hcmllcyBjb25zaXN0ZW50IHdp dGggdGhlIENNYWtlIGJ1aWxkCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJv d3NlcldpbmRvdy5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwppbmRl eCAxZDNiNGZjZjQ1ZjQ0MTYyM2RmNjkwZDNjNTUyZGNiZjdiZjYwY2UyLi4zZDFhN2ZkNWQwYzM0 OTE0YWY5Y2MyN2VhMTYwYmVhMzM0OGEzNjBmIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nl ci9ndGsvQnJvd3NlcldpbmRvdy5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2Vy V2luZG93LmMKQEAgLTE5NiwxNCArMTk2LDE0IEBAIHN0YXRpYyB2b2lkIGJyb3dzZXJXaW5kb3dI aXN0b3J5SXRlbUFjdGl2YXRlZChCcm93c2VyV2luZG93ICp3aW5kb3csIEd0a0FjdGlvbiAqCiAg ICAgd2Via2l0X3dlYl92aWV3X2dvX3RvX2JhY2tfZm9yd2FyZF9saXN0X2l0ZW0od2luZG93LT53 ZWJWaWV3LCBpdGVtKTsKIH0KIAotc3RhdGljIEd0a1dpZGdldCAqYnJvd3NlcldpbmRvd0NyZWF0 ZUJhY2tGb3J3YXJkTWVudShCcm93c2VyV2luZG93ICp3aW5kb3csIEdMaXN0ICpsaXN0KQorc3Rh dGljIEd0a1dpZGdldCAqYnJvd3NlcldpbmRvd0NyZWF0ZUJhY2tGb3J3YXJkTWVudShCcm93c2Vy V2luZG93ICp3aW5kb3csIEdMaXN0ICpsaXN0LCBnYm9vbGVhbiBiYWNrKQogewogICAgIGlmICgh bGlzdCkKICAgICAgICAgcmV0dXJuIE5VTEw7CiAKICAgICBHdGtXaWRnZXQgKm1lbnUgPSBndGtf bWVudV9uZXcoKTsKICAgICBHTGlzdCAqbGlzdEl0ZW07Ci0gICAgZm9yIChsaXN0SXRlbSA9IGxp c3Q7IGxpc3RJdGVtOyBsaXN0SXRlbSA9IGdfbGlzdF9uZXh0KGxpc3RJdGVtKSkgeworICAgIGZv ciAobGlzdEl0ZW0gPSAoYmFjayA/IGdfbGlzdF9sYXN0KGxpc3QpIDogbGlzdCk7IGxpc3RJdGVt OyBsaXN0SXRlbSA9IChiYWNrID8gZ19saXN0X3ByZXZpb3VzKGxpc3RJdGVtKSA6IGdfbGlzdF9u ZXh0KGxpc3RJdGVtKSkpIHsKICAgICAgICAgV2ViS2l0QmFja0ZvcndhcmRMaXN0SXRlbSAqaXRl bSA9IChXZWJLaXRCYWNrRm9yd2FyZExpc3RJdGVtICopbGlzdEl0ZW0tPmRhdGE7CiAgICAgICAg IGNvbnN0IGNoYXIgKnVyaSA9IHdlYmtpdF9iYWNrX2ZvcndhcmRfbGlzdF9pdGVtX2dldF91cmko aXRlbSk7CiAgICAgICAgIGNvbnN0IGNoYXIgKnRpdGxlID0gd2Via2l0X2JhY2tfZm9yd2FyZF9s aXN0X2l0ZW1fZ2V0X3RpdGxlKGl0ZW0pOwpAQCAtMjMyLDEyICsyMzIsMTIgQEAgc3RhdGljIHZv aWQgYnJvd3NlcldpbmRvd1VwZGF0ZU5hdmlnYXRpb25BY3Rpb25zKEJyb3dzZXJXaW5kb3cgKndp bmRvdywgV2ViS2l0QmEKIAogICAgIEdMaXN0ICpsaXN0ID0gd2Via2l0X2JhY2tfZm9yd2FyZF9s aXN0X2dldF9iYWNrX2xpc3Rfd2l0aF9saW1pdChiYWNrRm9yd2FkbGlzdCwgMTApOwogICAgIGd0 a19tZW51X3Rvb2xfYnV0dG9uX3NldF9tZW51KEdUS19NRU5VX1RPT0xfQlVUVE9OKHdpbmRvdy0+ YmFja0l0ZW0pLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJyb3dzZXJXaW5k b3dDcmVhdGVCYWNrRm9yd2FyZE1lbnUod2luZG93LCBsaXN0KSk7CisgICAgICAgIGJyb3dzZXJX aW5kb3dDcmVhdGVCYWNrRm9yd2FyZE1lbnUod2luZG93LCBsaXN0LCB0cnVlKSk7CiAgICAgZ19s aXN0X2ZyZWUobGlzdCk7CiAKICAgICBsaXN0ID0gd2Via2l0X2JhY2tfZm9yd2FyZF9saXN0X2dl dF9mb3J3YXJkX2xpc3Rfd2l0aF9saW1pdChiYWNrRm9yd2FkbGlzdCwgMTApOwogICAgIGd0a19t ZW51X3Rvb2xfYnV0dG9uX3NldF9tZW51KEdUS19NRU5VX1RPT0xfQlVUVE9OKHdpbmRvdy0+Zm9y d2FyZEl0ZW0pLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJyb3dzZXJXaW5k b3dDcmVhdGVCYWNrRm9yd2FyZE1lbnUod2luZG93LCBsaXN0KSk7CisgICAgICAgIGJyb3dzZXJX aW5kb3dDcmVhdGVCYWNrRm9yd2FyZE1lbnUod2luZG93LCBsaXN0LCBmYWxzZSkpOwogICAgIGdf bGlzdF9mcmVlKGxpc3QpOwogfQogCg== 220177 2013-12-31 22:29:38 -0800 2014-01-01 04:36:00 -0800 Patch bug-126354-20140101152937.patch text/plain 3087 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMTg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGZjMDY4YjM1MzVhNTIwMTVjNzYxMWEzOGJjOGQ3NmY0 NTExMTI4MC4uNzQzZGNjZDEzODdiYWI0ZmFiZmJmMTY3ZTg3MGI3YmJiMGU2MTg5NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTEyLTMxICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNv bT4KKworICAgICAgICBbR1RLXVtXSzJdIEJhY2sgaXRlbXMgYXJlIHNob3duIGluIHJldmVyc2Ug b3JkZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjYzNTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgbGF0ZXN0IHZpc2l0ZWQgc2l0ZSBmb3IgYmFja3dhcmQgaGlzdG9yeSBzaG91bGQgYmUgcGxh Y2VkIG9uIHRoZSB0b3Agb2YgYSBoaXN0b3J5IHN0YWNrCisgICAgICAgIGFzIGEgY29tbW9uIGJl aGF2aW9yLiBIb3dldmVyIGN1cnJlbnRseSBpdHMgb3JkZXIgaXMgcmV2ZXJzZS4KKworICAgICAg ICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAgICAgIChicm93c2VyV2lu ZG93Q3JlYXRlQmFja0ZvcndhcmRNZW51KTogQWRkIGEgYm9vbGVhbiB0byBmaWd1cmUgb3V0IGJh Y2t3YXJkIG9yIGZvcndhcmQuCisgICAgICAgIChicm93c2VyV2luZG93VXBkYXRlTmF2aWdhdGlv bkFjdGlvbnMpOiBBIGxpc3QgaXRlbSBmb3IgYSBiYWNrd2FyZCBoaXN0b3J5IGlzIGFkZGVkIHRv IG1lbnUgZnJvbSB0YWlsIHRvIGhlYWQuCisKIDIwMTMtMTItMzAgIE1hcnRpbiBSb2JpbnNvbiAg PG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIE1ha2UgdGhlIG91dHB1dCBk aXJlY3Rvcnkgb2YgR09iamVjdCB1bml0IHRlc3RzIGJpbmFyaWVzIGNvbnNpc3RlbnQgd2l0aCB0 aGUgQ01ha2UgYnVpbGQKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2Vy V2luZG93LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCmluZGV4IDFk M2I0ZmNmNDVmNDQxNjIzZGY2OTBkM2M1NTJkY2JmN2JmNjBjZTIuLjY3YzlhNjQzNDlkNmY3NzVh MjQwN2Q2MzYyNGQ5MmE1NzBkMWU4NGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0 ay9Ccm93c2VyV2luZG93LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5k b3cuYwpAQCAtMTk2LDE0ICsxOTYsMTQgQEAgc3RhdGljIHZvaWQgYnJvd3NlcldpbmRvd0hpc3Rv cnlJdGVtQWN0aXZhdGVkKEJyb3dzZXJXaW5kb3cgKndpbmRvdywgR3RrQWN0aW9uICoKICAgICB3 ZWJraXRfd2ViX3ZpZXdfZ29fdG9fYmFja19mb3J3YXJkX2xpc3RfaXRlbSh3aW5kb3ctPndlYlZp ZXcsIGl0ZW0pOwogfQogCi1zdGF0aWMgR3RrV2lkZ2V0ICpicm93c2VyV2luZG93Q3JlYXRlQmFj a0ZvcndhcmRNZW51KEJyb3dzZXJXaW5kb3cgKndpbmRvdywgR0xpc3QgKmxpc3QpCitzdGF0aWMg R3RrV2lkZ2V0ICpicm93c2VyV2luZG93Q3JlYXRlQmFja0ZvcndhcmRNZW51KEJyb3dzZXJXaW5k b3cgKndpbmRvdywgR0xpc3QgKmxpc3QsIGdib29sZWFuIHJldmVyc2VNZW51SXRlbU9yZGVyKQog ewogICAgIGlmICghbGlzdCkKICAgICAgICAgcmV0dXJuIE5VTEw7CiAKICAgICBHdGtXaWRnZXQg Km1lbnUgPSBndGtfbWVudV9uZXcoKTsKICAgICBHTGlzdCAqbGlzdEl0ZW07Ci0gICAgZm9yIChs aXN0SXRlbSA9IGxpc3Q7IGxpc3RJdGVtOyBsaXN0SXRlbSA9IGdfbGlzdF9uZXh0KGxpc3RJdGVt KSkgeworICAgIGZvciAobGlzdEl0ZW0gPSAocmV2ZXJzZU1lbnVJdGVtT3JkZXIgPyBnX2xpc3Rf bGFzdChsaXN0KSA6IGxpc3QpOyBsaXN0SXRlbTsgbGlzdEl0ZW0gPSAocmV2ZXJzZU1lbnVJdGVt T3JkZXIgPyBnX2xpc3RfcHJldmlvdXMobGlzdEl0ZW0pIDogZ19saXN0X25leHQobGlzdEl0ZW0p KSkgewogICAgICAgICBXZWJLaXRCYWNrRm9yd2FyZExpc3RJdGVtICppdGVtID0gKFdlYktpdEJh Y2tGb3J3YXJkTGlzdEl0ZW0gKilsaXN0SXRlbS0+ZGF0YTsKICAgICAgICAgY29uc3QgY2hhciAq dXJpID0gd2Via2l0X2JhY2tfZm9yd2FyZF9saXN0X2l0ZW1fZ2V0X3VyaShpdGVtKTsKICAgICAg ICAgY29uc3QgY2hhciAqdGl0bGUgPSB3ZWJraXRfYmFja19mb3J3YXJkX2xpc3RfaXRlbV9nZXRf dGl0bGUoaXRlbSk7CkBAIC0yMzIsMTIgKzIzMiwxMiBAQCBzdGF0aWMgdm9pZCBicm93c2VyV2lu ZG93VXBkYXRlTmF2aWdhdGlvbkFjdGlvbnMoQnJvd3NlcldpbmRvdyAqd2luZG93LCBXZWJLaXRC YQogCiAgICAgR0xpc3QgKmxpc3QgPSB3ZWJraXRfYmFja19mb3J3YXJkX2xpc3RfZ2V0X2JhY2tf bGlzdF93aXRoX2xpbWl0KGJhY2tGb3J3YWRsaXN0LCAxMCk7CiAgICAgZ3RrX21lbnVfdG9vbF9i dXR0b25fc2V0X21lbnUoR1RLX01FTlVfVE9PTF9CVVRUT04od2luZG93LT5iYWNrSXRlbSksCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJvd3NlcldpbmRvd0NyZWF0ZUJhY2tG b3J3YXJkTWVudSh3aW5kb3csIGxpc3QpKTsKKyAgICAgICAgYnJvd3NlcldpbmRvd0NyZWF0ZUJh Y2tGb3J3YXJkTWVudSh3aW5kb3csIGxpc3QsIHRydWUpKTsKICAgICBnX2xpc3RfZnJlZShsaXN0 KTsKIAogICAgIGxpc3QgPSB3ZWJraXRfYmFja19mb3J3YXJkX2xpc3RfZ2V0X2ZvcndhcmRfbGlz dF93aXRoX2xpbWl0KGJhY2tGb3J3YWRsaXN0LCAxMCk7CiAgICAgZ3RrX21lbnVfdG9vbF9idXR0 b25fc2V0X21lbnUoR1RLX01FTlVfVE9PTF9CVVRUT04od2luZG93LT5mb3J3YXJkSXRlbSksCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJvd3NlcldpbmRvd0NyZWF0ZUJhY2tG b3J3YXJkTWVudSh3aW5kb3csIGxpc3QpKTsKKyAgICAgICAgYnJvd3NlcldpbmRvd0NyZWF0ZUJh Y2tGb3J3YXJkTWVudSh3aW5kb3csIGxpc3QsIGZhbHNlKSk7CiAgICAgZ19saXN0X2ZyZWUobGlz dCk7CiB9CiAK 220184 2014-01-01 04:36:06 -0800 2014-01-01 05:31:29 -0800 Patch bug-126354-20140101213604.patch text/plain 2246 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMTg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGZjMDY4YjM1MzVhNTIwMTVjNzYxMWEzOGJjOGQ3NmY0 NTExMTI4MC4uMjc3MDEyYWU1MjE4Yjc2NzFjNTVhYTc3ZDM2YWY0ZjAxNjZjNGZlYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTAxLTAxICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNv bT4KKworICAgICAgICBbR1RLXVtXSzJdIEJhY2sgaXRlbXMgYXJlIHNob3duIGluIHJldmVyc2Ug b3JkZXIgaW4gTWluaUJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNjM1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBsYXRlc3QgdmlzaXRlZCBzaXRlIGZvciBiYWNrd2FyZCBoaXN0b3J5 IHNob3VsZCBiZSBwbGFjZWQgb24gdGhlIHRvcCBvZiBhIGhpc3Rvcnkgc3RhY2sKKyAgICAgICAg YXMgYSBjb21tb24gYmVoYXZpb3IuIEhvd2V2ZXIgY3VycmVudGx5IGl0cyBvcmRlciBpcyByZXZl cnNlLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYzoKKyAgICAg ICAgKGJyb3dzZXJXaW5kb3dVcGRhdGVOYXZpZ2F0aW9uQWN0aW9ucyk6CisKIDIwMTMtMTItMzAg IE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtd IE1ha2UgdGhlIG91dHB1dCBkaXJlY3Rvcnkgb2YgR09iamVjdCB1bml0IHRlc3RzIGJpbmFyaWVz IGNvbnNpc3RlbnQgd2l0aCB0aGUgQ01ha2UgYnVpbGQKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlC cm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3Nl cldpbmRvdy5jCmluZGV4IDFkM2I0ZmNmNDVmNDQxNjIzZGY2OTBkM2M1NTJkY2JmN2JmNjBjZTIu Ljg1ODZmZTU0ZWU5ZDhkODUyY2I1OWJkN2VhZTIxNGE2MWQ4ZGExZDQgMTAwNjQ0Ci0tLSBhL1Rv b2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKKysrIGIvVG9vbHMvTWluaUJyb3dz ZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwpAQCAtMjMwLDE0ICsyMzAsMTQgQEAgc3RhdGljIHZvaWQg YnJvd3NlcldpbmRvd1VwZGF0ZU5hdmlnYXRpb25BY3Rpb25zKEJyb3dzZXJXaW5kb3cgKndpbmRv dywgV2ViS2l0QmEKICAgICBndGtfd2lkZ2V0X3NldF9zZW5zaXRpdmUod2luZG93LT5iYWNrSXRl bSwgd2Via2l0X3dlYl92aWV3X2Nhbl9nb19iYWNrKHdpbmRvdy0+d2ViVmlldykpOwogICAgIGd0 a193aWRnZXRfc2V0X3NlbnNpdGl2ZSh3aW5kb3ctPmZvcndhcmRJdGVtLCB3ZWJraXRfd2ViX3Zp ZXdfY2FuX2dvX2ZvcndhcmQod2luZG93LT53ZWJWaWV3KSk7CiAKLSAgICBHTGlzdCAqbGlzdCA9 IHdlYmtpdF9iYWNrX2ZvcndhcmRfbGlzdF9nZXRfYmFja19saXN0X3dpdGhfbGltaXQoYmFja0Zv cndhZGxpc3QsIDEwKTsKKyAgICBHTGlzdCAqbGlzdCA9IGdfbGlzdF9yZXZlcnNlKHdlYmtpdF9i YWNrX2ZvcndhcmRfbGlzdF9nZXRfYmFja19saXN0X3dpdGhfbGltaXQoYmFja0ZvcndhZGxpc3Qs IDEwKSk7CiAgICAgZ3RrX21lbnVfdG9vbF9idXR0b25fc2V0X21lbnUoR1RLX01FTlVfVE9PTF9C VVRUT04od2luZG93LT5iYWNrSXRlbSksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgYnJvd3NlcldpbmRvd0NyZWF0ZUJhY2tGb3J3YXJkTWVudSh3aW5kb3csIGxpc3QpKTsKKyAg ICAgICAgYnJvd3NlcldpbmRvd0NyZWF0ZUJhY2tGb3J3YXJkTWVudSh3aW5kb3csIGxpc3QpKTsK ICAgICBnX2xpc3RfZnJlZShsaXN0KTsKIAogICAgIGxpc3QgPSB3ZWJraXRfYmFja19mb3J3YXJk X2xpc3RfZ2V0X2ZvcndhcmRfbGlzdF93aXRoX2xpbWl0KGJhY2tGb3J3YWRsaXN0LCAxMCk7CiAg ICAgZ3RrX21lbnVfdG9vbF9idXR0b25fc2V0X21lbnUoR1RLX01FTlVfVE9PTF9CVVRUT04od2lu ZG93LT5mb3J3YXJkSXRlbSksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJv d3NlcldpbmRvd0NyZWF0ZUJhY2tGb3J3YXJkTWVudSh3aW5kb3csIGxpc3QpKTsKKyAgICAgICAg YnJvd3NlcldpbmRvd0NyZWF0ZUJhY2tGb3J3YXJkTWVudSh3aW5kb3csIGxpc3QpKTsKICAgICBn X2xpc3RfZnJlZShsaXN0KTsKIH0KIAo=