126353 2013-12-31 15:03:07 -0800 [Gtk] WebKitWebInspector has build warnings due to uninitialized didChangeAttachedWidth member 2013-12-31 17:04:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 self webkit-unassigned b.long cgarcia commit-queue gustavo mrobinson oldest_to_newest 963555 0 self 2013-12-31 15:03:07 -0800 [Gtk] WebKitWebInspector has build warnings due to uninitialized didChangeAttachedWidth member 963556 1 220172 self 2013-12-31 15:06:32 -0800 Created attachment 220172 Patch 963557 2 commit-queue 2013-12-31 15:09:15 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 963558 3 b.long 2013-12-31 15:11:18 -0800 This is part of my personal quest to destroy all build warnings. With changes like this, should I be landing them myself now? Build output: CXX Source/JavaScriptCore/disassembler/libjavascriptcoregtk_3_0_la-ARM64Disassembler.lo In file included from ../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp:27:0: ../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h: In member function 'void JSC::ARM64Disassembler::A64DOpcode::appendUnsignedImmediate64(uint64_t)': ../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:175:42: error: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'uint64_t {aka long unsigned int}' [-Werror=format=] bufferPrintf("#0x%llx", immediate); ^ ../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h: In member function 'void JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset(uint32_t*, int32_t)': ../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:180:74: error: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'uint64_t {aka long unsigned int}' [-Werror=format=] bufferPrintf("0x%llx", reinterpret_cast<uint64_t>(pc + immediate)); 963559 4 b.long 2013-12-31 15:12:25 -0800 Er wrong build output. This is what it fixes: ../../Source/WebKit2/UIProcess/API/gtk/WebKitWebInspector.cpp: In function 'WebKitWebInspector* webkitWebInspectorCreate(WebKit::WebInspectorProxy*)': ../../Source/WebKit2/UIProcess/API/gtk/WebKitWebInspector.cpp:331:5: error: missing initializer for member 'WKInspectorClientGtkV0::didChangeAttachedWidth' [-Werror=missing-field-initializers] }; 963565 5 220172 commit-queue 2013-12-31 17:04:32 -0800 Comment on attachment 220172 Patch Clearing flags on attachment: 220172 Committed r161186: <http://trac.webkit.org/changeset/161186> 963566 6 commit-queue 2013-12-31 17:04:35 -0800 All reviewed patches have been landed. Closing bug. 220172 2013-12-31 15:06:32 -0800 2013-12-31 17:04:31 -0800 Patch bug-126353-20131231170631.patch text/plain 1532 self U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2NlNTk2ZDI4MDJhMjY4 MTRmODQ5NzA4M2ViZjEwMjIxZTNiNTc2Yi4uOTkxODFmODg0ZmU1NmYxNGZkNTQ4Zjg2NjgwMzQ4 NzQ1NDNlMTQ1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTMxICBCcmVu ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBbR3RrXSBXZWJLaXRX ZWJJbnNwZWN0b3IgaGFzIGJ1aWxkIHdhcm5pbmdzIGR1ZSB0byB1bmluaXRpYWxpemVkIGRpZENo YW5nZUF0dGFjaGVkV2lkdGggbWVtYmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjYzNTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkluc3BlY3Rvci5j cHA6CisgICAgICAgICh3ZWJraXRXZWJJbnNwZWN0b3JDcmVhdGUpOiBJbml0aWFsaXplIGRpZENo YW5nZUF0dGFjaGVkV2lkdGggdG8gbnVsbC4KKwogMjAxMy0xMi0zMCAgTWFydGluIFJvYmluc29u ICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gTWFrZSB0aGUgb3V0cHV0 IGRpcmVjdG9yeSBvZiBHT2JqZWN0IHVuaXQgdGVzdHMgYmluYXJpZXMgY29uc2lzdGVudCB3aXRo IHRoZSBDTWFrZSBidWlsZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2ViSW5zcGVjdG9yLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYkluc3BlY3Rvci5jcHAKaW5kZXggYjQwMWM1YmM2YWM5ZTg5MDM2NzJk ODNkNjJiYmJkNDQ1MTAwZTQ3Ny4uMDgzZDI3Yzg0Zjc4M2MwNTJjZTY4NWVkZTJmNTcwMmFmM2Zm NTU3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 V2ViSW5zcGVjdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJJbnNwZWN0b3IuY3BwCkBAIC0zMjcsNyArMzI3LDggQEAgV2ViS2l0V2ViSW5zcGVj dG9yKiB3ZWJraXRXZWJJbnNwZWN0b3JDcmVhdGUoV2ViSW5zcGVjdG9yUHJveHkqIHdlYkluc3Bl Y3RvcikKICAgICAgICAgaW5zcGVjdGVkVVJMQ2hhbmdlZCwKICAgICAgICAgYXR0YWNoLAogICAg ICAgICBkZXRhY2gsCi0gICAgICAgIGRpZENoYW5nZUF0dGFjaGVkSGVpZ2h0CisgICAgICAgIGRp ZENoYW5nZUF0dGFjaGVkSGVpZ2h0LAorICAgICAgICBudWxscHRyIC8vIGRpZENoYW5nZUF0dGFj aGVkV2lkdGgKICAgICB9OwogICAgIFdLSW5zcGVjdG9yU2V0SW5zcGVjdG9yQ2xpZW50R3RrKHRv QVBJKHdlYkluc3BlY3RvciksICZ3a0luc3BlY3RvckNsaWVudEd0ay5iYXNlKTsKIAo=