<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126352</bug_id>
          
          <creation_ts>2013-12-31 14:56:37 -0800</creation_ts>
          <short_desc>JSC disassembler warns about incorrect printf format on 64-bit Linux</short_desc>
          <delta_ts>2015-01-28 11:12:37 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>136089</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brendan Long">b.long</reporter>
          <assigned_to name="Brendan Long">self</assigned_to>
          <cc>eflews.bot</cc>
    
    <cc>gtk-ews</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>philn</cc>
    
    <cc>rego+ews</cc>
    
    <cc>xan.lopez</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>963552</commentid>
    <comment_count>0</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2013-12-31 14:56:37 -0800</bug_when>
    <thetext>In A64DOpcode.h, we use &apos;%llx&apos; for uint64_t&apos;s. On 64-bit Linux, uint64_t is a long unsigned, not a long long unsigned. This may occur on other platforms.

I&apos;m not sure if this actually matters, but I&apos;m trying to get rid of build warnings in WebKitGTK.

The PRIx64 macro should expand to the correct format for each platform. I think it doesn&apos;t work on Visual Studio, but it&apos;s defined in Source/JavaScriptCore/os-win32/inttypes.h. I&apos;m hoping the build will automatically pick that up, but I can add a special import for it if necessary.

Build output:

  CXX      Source/JavaScriptCore/disassembler/libjavascriptcoregtk_3_0_la-ARM64Disassembler.lo
In file included from ../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp:27:0:
../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h: In member function &apos;void JSC::ARM64Disassembler::A64DOpcode::appendUnsignedImmediate64(uint64_t)&apos;:
../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:175:42: error: format &apos;%llx&apos; expects argument of type &apos;long long unsigned int&apos;, but argument 3 has type &apos;uint64_t {aka long unsigned int}&apos; [-Werror=format=]
         bufferPrintf(&quot;#0x%llx&quot;, immediate);
                                          ^
../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h: In member function &apos;void JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset(uint32_t*, int32_t)&apos;:
../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:180:74: error: format &apos;%llx&apos; expects argument of type &apos;long long unsigned int&apos;, but argument 3 has type &apos;uint64_t {aka long unsigned int}&apos; [-Werror=format=]
         bufferPrintf(&quot;0x%llx&quot;, reinterpret_cast&lt;uint64_t&gt;(pc + immediate));</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963553</commentid>
    <comment_count>1</comment_count>
      <attachid>220171</attachid>
    <who name="Brendan Long">self</who>
    <bug_when>2013-12-31 14:59:08 -0800</bug_when>
    <thetext>Created attachment 220171
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963554</commentid>
    <comment_count>2</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2013-12-31 15:00:20 -0800</bug_when>
    <thetext>Does EWS not test Windows anymore? I really don&apos;t want to find a Windows computer to test this :\</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963560</commentid>
    <comment_count>3</comment_count>
      <attachid>220173</attachid>
    <who name="Brendan Long">self</who>
    <bug_when>2013-12-31 15:14:43 -0800</bug_when>
    <thetext>Created attachment 220173
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963561</commentid>
    <comment_count>4</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2013-12-31 15:15:16 -0800</bug_when>
    <thetext>The gtk-wk2 failure is interesting, since it works on my machine :\ I&apos;m trying adding #include &lt;inttypes.h&gt; to see if that&apos;s what it&apos;s angry about.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963562</commentid>
    <comment_count>5</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2013-12-31 15:25:38 -0800</bug_when>
    <thetext>Looks like I might need to setup a VM to figure out why EWS doesn&apos;t like this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963563</commentid>
    <comment_count>6</comment_count>
      <attachid>220173</attachid>
    <who name="kov&apos;s GTK+ EWS bot">gtk-ews</who>
    <bug_when>2013-12-31 15:37:39 -0800</bug_when>
    <thetext>Comment on attachment 220173
Patch

Attachment 220173 did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/4911444084654080</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963602</commentid>
    <comment_count>7</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-01-01 06:01:36 -0800</bug_when>
    <thetext>The __STDC_FORMAT_MACROS macro define is required before the &lt;inttypes.h&gt; include for the PRIx64 macro to be usable in C++ code.
http://stackoverflow.com/questions/8132399/how-to-printf-uint64-t</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963950</commentid>
    <comment_count>8</comment_count>
      <attachid>220264</attachid>
    <who name="Brendan Long">self</who>
    <bug_when>2014-01-02 16:20:54 -0800</bug_when>
    <thetext>Created attachment 220264
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963951</commentid>
    <comment_count>9</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2014-01-02 16:21:43 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; The __STDC_FORMAT_MACROS macro define is required before the &lt;inttypes.h&gt; include for the PRIx64 macro to be usable in C++ code.
&gt; http://stackoverflow.com/questions/8132399/how-to-printf-uint64-t

It looks like gcc doesn&apos;t require that anymore, which is why it works on my machine (Fedora 20), but now EWS (Ubuntu 12.04?).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963992</commentid>
    <comment_count>10</comment_count>
      <attachid>220264</attachid>
    <who name="EFL EWS Bot">eflews.bot</who>
    <bug_when>2014-01-02 18:10:49 -0800</bug_when>
    <thetext>Comment on attachment 220264
Patch

Attachment 220264 did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5151989633646592</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964064</commentid>
    <comment_count>11</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2014-01-03 02:28:53 -0800</bug_when>
    <thetext>(In reply to comment #10)
&gt; (From update of attachment 220264 [details])
&gt; Attachment 220264 [details] did not pass efl-wk2-ews (efl-wk2):
&gt; Output: http://webkit-queues.appspot.com/results/5151989633646592

When I build this patch locally, there is no build break. Could you test this again ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964070</commentid>
    <comment_count>12</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-01-03 03:33:55 -0800</bug_when>
    <thetext>(In reply to comment #11)
&gt; (In reply to comment #10)
&gt; &gt; (From update of attachment 220264 [details] [details])
&gt; &gt; Attachment 220264 [details] [details] did not pass efl-wk2-ews (efl-wk2):
&gt; &gt; Output: http://webkit-queues.appspot.com/results/5151989633646592
&gt; 
&gt; When I build this patch locally, there is no build break. Could you test this again ?

I got a similar compiler crash in bug #126388 -- there&apos;s an issue with the EWS it seems, perhaps a corrupted ccache entry?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964073</commentid>
    <comment_count>13</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-01-03 03:42:40 -0800</bug_when>
    <thetext>(In reply to comment #9)
&gt; (In reply to comment #7)
&gt; &gt; The __STDC_FORMAT_MACROS macro define is required before the &lt;inttypes.h&gt; include for the PRIx64 macro to be usable in C++ code.
&gt; &gt; http://stackoverflow.com/questions/8132399/how-to-printf-uint64-t
&gt; 
&gt; It looks like gcc doesn&apos;t require that anymore, which is why it works on my machine (Fedora 20), but now EWS (Ubuntu 12.04?).

What GCC/libstdc++ version are you using on your system?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964093</commentid>
    <comment_count>14</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2014-01-03 07:21:08 -0800</bug_when>
    <thetext>(In reply to comment #13)
&gt; What GCC/libstdc++ version are you using on your system?

I&apos;m on 4.8.2 (Ubuntu 12.04 uses 4.6.3 apparently).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964094</commentid>
    <comment_count>15</comment_count>
      <attachid>220302</attachid>
    <who name="Brendan Long">self</who>
    <bug_when>2014-01-03 07:21:41 -0800</bug_when>
    <thetext>Created attachment 220302
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964123</commentid>
    <comment_count>16</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2014-01-03 09:04:38 -0800</bug_when>
    <thetext>Now it passes (same patch though).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>969202</commentid>
    <comment_count>17</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2014-01-17 12:20:17 -0800</bug_when>
    <thetext>Can someone review this so we can commit it?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972317</commentid>
    <comment_count>18</comment_count>
      <attachid>220302</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2014-01-26 20:30:22 -0800</bug_when>
    <thetext>Comment on attachment 220302
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220302&amp;action=review

&gt; Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp:27
&gt; +#define __STDC_FORMAT_MACROS

Is there a good reason to have this here instead of just before the inttypes.h include?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972441</commentid>
    <comment_count>19</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2014-01-27 09:58:39 -0800</bug_when>
    <thetext>(In reply to comment #18)
&gt; (From update of attachment 220302 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=220302&amp;action=review
&gt; 
&gt; &gt; Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp:27
&gt; &gt; +#define __STDC_FORMAT_MACROS
&gt; 
&gt; Is there a good reason to have this here instead of just before the inttypes.h include?

I thought the style checker would complain about that, but apparently not. I&apos;ll change it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972443</commentid>
    <comment_count>20</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2014-01-27 10:03:30 -0800</bug_when>
    <thetext>(In reply to comment #18)
&gt; (From update of attachment 220302 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=220302&amp;action=review
&gt; 
&gt; &gt; Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp:27
&gt; &gt; +#define __STDC_FORMAT_MACROS
&gt; 
&gt; Is there a good reason to have this here instead of just before the inttypes.h include?

Oh, I see what you mean. It should be before inttypes.h, not before stdint.h. I&apos;m not sure why putting it there worked, but I&apos;ll move it before inttypes.h, since that&apos;s where it&apos;s supposed to be.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972446</commentid>
    <comment_count>21</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2014-01-27 10:11:36 -0800</bug_when>
    <thetext>(In reply to comment #20)
&gt; (In reply to comment #18)
&gt; &gt; (From update of attachment 220302 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=220302&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp:27
&gt; &gt; &gt; +#define __STDC_FORMAT_MACROS
&gt; &gt; 
&gt; &gt; Is there a good reason to have this here instead of just before the inttypes.h include?
&gt; 
&gt; Oh, I see what you mean. It should be before inttypes.h, not before stdint.h. I&apos;m not sure why putting it there worked, but I&apos;ll move it before inttypes.h, since that&apos;s where it&apos;s supposed to be.

Apparently the fixed-width types are also available in stdint.h if you define that macro. There&apos;s also a duplicate include of stdint.h in the .cpp file. I&apos;m simplifying this a bit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972449</commentid>
    <comment_count>22</comment_count>
      <attachid>222332</attachid>
    <who name="Brendan Long">self</who>
    <bug_when>2014-01-27 10:15:53 -0800</bug_when>
    <thetext>Created attachment 222332
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972454</commentid>
    <comment_count>23</comment_count>
      <attachid>222335</attachid>
    <who name="Brendan Long">self</who>
    <bug_when>2014-01-27 10:24:25 -0800</bug_when>
    <thetext>Created attachment 222335
Patch

Hm, apparently the build bot&apos;s version of GCC doesn&apos;t like that either. How about using inttypes.h, with the macro where it should be?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972455</commentid>
    <comment_count>24</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2014-01-27 10:27:00 -0800</bug_when>
    <thetext>Oh, I see why I originally put in the .cpp file, but I think this version should work too. I was trying to get the macro defined before we imported *anything*, since there&apos;s some danger that any std*.h could put in inttypes.h or stdint.h. I think since the relevant code is in the .h file, it would be best if we can define it there too though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972458</commentid>
    <comment_count>25</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2014-01-27 10:36:21 -0800</bug_when>
    <thetext>Or maybe it only works if it&apos;s defined in the .cpp file.. :\</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>972506</commentid>
    <comment_count>26</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2014-01-27 11:48:47 -0800</bug_when>
    <thetext>Maybe I should #define __STDC_FORMAT_MACROS in Platform.h? Or Compiler.h?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1064961</commentid>
    <comment_count>27</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2015-01-28 11:12:37 -0800</bug_when>
    <thetext>Looks like someone else fixed this as a side effect of using this code in EFL.

*** This bug has been marked as a duplicate of bug 136089 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220171</attachid>
            <date>2013-12-31 14:59:08 -0800</date>
            <delta_ts>2013-12-31 15:14:39 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-126352-20131231165907.patch</filename>
            <type>text/plain</type>
            <size>1703</size>
            <attacher name="Brendan Long">self</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2
MTQ2NDQ3OGE1NjcyNmE5ZjRhNjA4MzBkNjJhNTgyMGQzOWMxYmZlLi45YmRmYmE5Y2NiN2U1NmE5
ZmVjMGY5NWU5ZGEwODgyNTg5ZTQwOWFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxMy0xMi0zMSAgQnJlbmRhbiBMb25nICA8Yi5sb25nQGNhYmxlbGFicy5j
b20+CisKKyAgICAgICAgSlNDIGRpc2Fzc2VtYmxlciB3YXJucyBhYm91dCBpbmNvcnJlY3QgcHJp
bnRmIGZvcm1hdCBvbiA2NC1iaXQgTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTEyNjM1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaDoKKyAg
ICAgICAgKEpTQzo6QVJNNjREaXNhc3NlbWJsZXI6OkE2NERPcGNvZGU6OmFwcGVuZFVuc2lnbmVk
SW1tZWRpYXRlNjQpOiBVc2UgIiUiIFBSSXg2NCBpbnN0ZWFkIG9mICIlbGx4Ii4KKyAgICAgICAg
KEpTQzo6QVJNNjREaXNhc3NlbWJsZXI6OkE2NERPcGNvZGU6OmFwcGVuZFBDUmVsYXRpdmVPZmZz
ZXQpOiBTYW1lLgorCiAyMDEzLTEyLTMwICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Vi
a2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTYxMTU3LCByMTYx
MTU4LCByMTYxMTYwLCByMTYxMTYxLApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl
L2Rpc2Fzc2VtYmxlci9BUk02NC9BNjRET3Bjb2RlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
ZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaAppbmRleCBlZDE4ZDMwZGZkY2ZjOTljOThm
NTcyODNjZjg2Yzc2M2M3M2JjNmU3Li4xNTllMmVkMGJkZWJiZDE1OTRkNzc3ZDI2MzI0Yjg0ZTY2
YjRiOThhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0FS
TTY0L0E2NERPcGNvZGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVy
L0FSTTY0L0E2NERPcGNvZGUuaApAQCAtMTcyLDEyICsxNzIsMTIgQEAgcHJvdGVjdGVkOgogCiAg
ICAgdm9pZCBhcHBlbmRVbnNpZ25lZEltbWVkaWF0ZTY0KHVpbnQ2NF90IGltbWVkaWF0ZSkKICAg
ICB7Ci0gICAgICAgIGJ1ZmZlclByaW50ZigiIzB4JWxseCIsIGltbWVkaWF0ZSk7CisgICAgICAg
IGJ1ZmZlclByaW50ZigiIzB4JSIgUFJJeDY0LCBpbW1lZGlhdGUpOwogICAgIH0KIAogICAgIHZv
aWQgYXBwZW5kUENSZWxhdGl2ZU9mZnNldCh1aW50MzJfdCogcGMsIGludDMyX3QgaW1tZWRpYXRl
KQogICAgIHsKLSAgICAgICAgYnVmZmVyUHJpbnRmKCIweCVsbHgiLCByZWludGVycHJldF9jYXN0
PHVpbnQ2NF90PihwYyArIGltbWVkaWF0ZSkpOworICAgICAgICBidWZmZXJQcmludGYoIjB4JSIg
UFJJeDY0LCByZWludGVycHJldF9jYXN0PHVpbnQ2NF90PihwYyArIGltbWVkaWF0ZSkpOwogICAg
IH0KIAogICAgIHZvaWQgYXBwZW5kU2hpZnRBbW91bnQodW5zaWduZWQgYW1vdW50KQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220173</attachid>
            <date>2013-12-31 15:14:43 -0800</date>
            <delta_ts>2014-01-02 16:20:50 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-126352-20131231171442.patch</filename>
            <type>text/plain</type>
            <size>1842</size>
            <attacher name="Brendan Long">self</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2
MTQ2NDQ3OGE1NjcyNmE5ZjRhNjA4MzBkNjJhNTgyMGQzOWMxYmZlLi45YmRmYmE5Y2NiN2U1NmE5
ZmVjMGY5NWU5ZGEwODgyNTg5ZTQwOWFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxMy0xMi0zMSAgQnJlbmRhbiBMb25nICA8Yi5sb25nQGNhYmxlbGFicy5j
b20+CisKKyAgICAgICAgSlNDIGRpc2Fzc2VtYmxlciB3YXJucyBhYm91dCBpbmNvcnJlY3QgcHJp
bnRmIGZvcm1hdCBvbiA2NC1iaXQgTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTEyNjM1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaDoKKyAg
ICAgICAgKEpTQzo6QVJNNjREaXNhc3NlbWJsZXI6OkE2NERPcGNvZGU6OmFwcGVuZFVuc2lnbmVk
SW1tZWRpYXRlNjQpOiBVc2UgIiUiIFBSSXg2NCBpbnN0ZWFkIG9mICIlbGx4Ii4KKyAgICAgICAg
KEpTQzo6QVJNNjREaXNhc3NlbWJsZXI6OkE2NERPcGNvZGU6OmFwcGVuZFBDUmVsYXRpdmVPZmZz
ZXQpOiBTYW1lLgorCiAyMDEzLTEyLTMwICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Vi
a2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTYxMTU3LCByMTYx
MTU4LCByMTYxMTYwLCByMTYxMTYxLApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl
L2Rpc2Fzc2VtYmxlci9BUk02NC9BNjRET3Bjb2RlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
ZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaAppbmRleCBlZDE4ZDMwZGZkY2ZjOTljOThm
NTcyODNjZjg2Yzc2M2M3M2JjNmU3Li4zYzUyOTUwZTQ5MjM2YjQwNDA3NTdiNGM5M2U2YmM2OGIx
NTI2YzA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0FS
TTY0L0E2NERPcGNvZGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVy
L0FSTTY0L0E2NERPcGNvZGUuaApAQCAtMjYsNiArMjYsNyBAQAogI2lmbmRlZiBBNjRET3Bjb2Rl
X2gKICNkZWZpbmUgQTY0RE9wY29kZV9oCiAKKyNpbmNsdWRlIDxpbnR0eXBlcy5oPgogI2luY2x1
ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CiAjaW5jbHVkZSA8c3RkaW50Lmg+CiAKQEAgLTE3MiwxMiAr
MTczLDEyIEBAIHByb3RlY3RlZDoKIAogICAgIHZvaWQgYXBwZW5kVW5zaWduZWRJbW1lZGlhdGU2
NCh1aW50NjRfdCBpbW1lZGlhdGUpCiAgICAgewotICAgICAgICBidWZmZXJQcmludGYoIiMweCVs
bHgiLCBpbW1lZGlhdGUpOworICAgICAgICBidWZmZXJQcmludGYoIiMweCUiIFBSSXg2NCwgaW1t
ZWRpYXRlKTsKICAgICB9CiAKICAgICB2b2lkIGFwcGVuZFBDUmVsYXRpdmVPZmZzZXQodWludDMy
X3QqIHBjLCBpbnQzMl90IGltbWVkaWF0ZSkKICAgICB7Ci0gICAgICAgIGJ1ZmZlclByaW50Zigi
MHglbGx4IiwgcmVpbnRlcnByZXRfY2FzdDx1aW50NjRfdD4ocGMgKyBpbW1lZGlhdGUpKTsKKyAg
ICAgICAgYnVmZmVyUHJpbnRmKCIweCUiIFBSSXg2NCwgcmVpbnRlcnByZXRfY2FzdDx1aW50NjRf
dD4ocGMgKyBpbW1lZGlhdGUpKTsKICAgICB9CiAKICAgICB2b2lkIGFwcGVuZFNoaWZ0QW1vdW50
KHVuc2lnbmVkIGFtb3VudCkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220264</attachid>
            <date>2014-01-02 16:20:54 -0800</date>
            <delta_ts>2014-01-03 07:21:34 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-126352-20140102182053.patch</filename>
            <type>text/plain</type>
            <size>2468</size>
            <attacher name="Brendan Long">self</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0
YzVmMDM2Y2Q3NDk4MGUzYTdiMzE1ZmU1YTM4NTAzNDQ1YjFmYWEwLi5hNzc4ODYwM2VkNDlkMTg2
MWIzNjQ1MmY3MTYxOGJlOTUxM2NmNzBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxMy0xMi0zMSAgQnJlbmRhbiBMb25nICA8Yi5sb25nQGNhYmxlbGFicy5j
b20+CisKKyAgICAgICAgSlNDIGRpc2Fzc2VtYmxlciB3YXJucyBhYm91dCBpbmNvcnJlY3QgcHJp
bnRmIGZvcm1hdCBvbiA2NC1iaXQgTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTEyNjM1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaDoKKyAg
ICAgICAgKEpTQzo6QVJNNjREaXNhc3NlbWJsZXI6OkE2NERPcGNvZGU6OmFwcGVuZFVuc2lnbmVk
SW1tZWRpYXRlNjQpOiBVc2UgIiUiIFBSSXg2NCBpbnN0ZWFkIG9mICIlbGx4Ii4KKyAgICAgICAg
KEpTQzo6QVJNNjREaXNhc3NlbWJsZXI6OkE2NERPcGNvZGU6OmFwcGVuZFBDUmVsYXRpdmVPZmZz
ZXQpOiBTYW1lLgorCiAyMDE0LTAxLTAyICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0Bh
cHBsZS5jb20+CiAKICAgICAgICAgU3RvcmluZyBuZXcgQ29waWVkU3BhY2UgbWVtb3J5IGludG8g
YSBKU09iamVjdCBzaG91bGQgZmlyZSBhIHdyaXRlIGJhcnJpZXIKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9wY29kZS5jcHAgYi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuY3BwCmluZGV4
IDBlYTgxN2E0NjFhZDUyYWRhMGYyNzJhZjc0MzVjMjVhMWE5MTU4YzMuLjg3ZGU0ZTAzZGMzYWFi
Nzk4YWYxNmZkN2QwOTA0NzQ5ZTA1NDhjOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9kaXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9wY29kZS5jcHAKKysrIGIvU291cmNlL0phdmFT
Y3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci9BUk02NC9BNjRET3Bjb2RlLmNwcApAQCAtMjMsNiArMjMs
OSBAQAogICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJ
TElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCisvLyBPbGRlciB2ZXJzaW9ucyBvZiBnY2MgcmVx
dWlyZSB0aGlzIGZvciBQUkkqNjQgbWFjcm9zIHRvIGJlIGRlZmluZWQgaW4gaW50dHlwZXMuaAor
I2RlZmluZSBfX1NURENfRk9STUFUX01BQ1JPUworCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5j
bHVkZSAiQTY0RE9wY29kZS5oIgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
ZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9k
aXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9wY29kZS5oCmluZGV4IGVkMThkMzBkZmRjZmM5OWM5OGY1
NzI4M2NmODZjNzYzYzczYmM2ZTcuLjNjNTI5NTBlNDkyMzZiNDA0MDc1N2I0YzkzZTZiYzY4YjE1
MjZjMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJN
NjQvQTY0RE9wY29kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIv
QVJNNjQvQTY0RE9wY29kZS5oCkBAIC0yNiw2ICsyNiw3IEBACiAjaWZuZGVmIEE2NERPcGNvZGVf
aAogI2RlZmluZSBBNjRET3Bjb2RlX2gKIAorI2luY2x1ZGUgPGludHR5cGVzLmg+CiAjaW5jbHVk
ZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDxzdGRpbnQuaD4KIApAQCAtMTcyLDEyICsx
NzMsMTIgQEAgcHJvdGVjdGVkOgogCiAgICAgdm9pZCBhcHBlbmRVbnNpZ25lZEltbWVkaWF0ZTY0
KHVpbnQ2NF90IGltbWVkaWF0ZSkKICAgICB7Ci0gICAgICAgIGJ1ZmZlclByaW50ZigiIzB4JWxs
eCIsIGltbWVkaWF0ZSk7CisgICAgICAgIGJ1ZmZlclByaW50ZigiIzB4JSIgUFJJeDY0LCBpbW1l
ZGlhdGUpOwogICAgIH0KIAogICAgIHZvaWQgYXBwZW5kUENSZWxhdGl2ZU9mZnNldCh1aW50MzJf
dCogcGMsIGludDMyX3QgaW1tZWRpYXRlKQogICAgIHsKLSAgICAgICAgYnVmZmVyUHJpbnRmKCIw
eCVsbHgiLCByZWludGVycHJldF9jYXN0PHVpbnQ2NF90PihwYyArIGltbWVkaWF0ZSkpOworICAg
ICAgICBidWZmZXJQcmludGYoIjB4JSIgUFJJeDY0LCByZWludGVycHJldF9jYXN0PHVpbnQ2NF90
PihwYyArIGltbWVkaWF0ZSkpOwogICAgIH0KIAogICAgIHZvaWQgYXBwZW5kU2hpZnRBbW91bnQo
dW5zaWduZWQgYW1vdW50KQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220302</attachid>
            <date>2014-01-03 07:21:41 -0800</date>
            <delta_ts>2014-01-27 10:15:45 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-126352-20140103092140.patch</filename>
            <type>text/plain</type>
            <size>2468</size>
            <attacher name="Brendan Long">self</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0
YzVmMDM2Y2Q3NDk4MGUzYTdiMzE1ZmU1YTM4NTAzNDQ1YjFmYWEwLi5hNzc4ODYwM2VkNDlkMTg2
MWIzNjQ1MmY3MTYxOGJlOTUxM2NmNzBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxMy0xMi0zMSAgQnJlbmRhbiBMb25nICA8Yi5sb25nQGNhYmxlbGFicy5j
b20+CisKKyAgICAgICAgSlNDIGRpc2Fzc2VtYmxlciB3YXJucyBhYm91dCBpbmNvcnJlY3QgcHJp
bnRmIGZvcm1hdCBvbiA2NC1iaXQgTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTEyNjM1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaDoKKyAg
ICAgICAgKEpTQzo6QVJNNjREaXNhc3NlbWJsZXI6OkE2NERPcGNvZGU6OmFwcGVuZFVuc2lnbmVk
SW1tZWRpYXRlNjQpOiBVc2UgIiUiIFBSSXg2NCBpbnN0ZWFkIG9mICIlbGx4Ii4KKyAgICAgICAg
KEpTQzo6QVJNNjREaXNhc3NlbWJsZXI6OkE2NERPcGNvZGU6OmFwcGVuZFBDUmVsYXRpdmVPZmZz
ZXQpOiBTYW1lLgorCiAyMDE0LTAxLTAyICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0Bh
cHBsZS5jb20+CiAKICAgICAgICAgU3RvcmluZyBuZXcgQ29waWVkU3BhY2UgbWVtb3J5IGludG8g
YSBKU09iamVjdCBzaG91bGQgZmlyZSBhIHdyaXRlIGJhcnJpZXIKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9wY29kZS5jcHAgYi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuY3BwCmluZGV4
IDBlYTgxN2E0NjFhZDUyYWRhMGYyNzJhZjc0MzVjMjVhMWE5MTU4YzMuLjg3ZGU0ZTAzZGMzYWFi
Nzk4YWYxNmZkN2QwOTA0NzQ5ZTA1NDhjOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9kaXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9wY29kZS5jcHAKKysrIGIvU291cmNlL0phdmFT
Y3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci9BUk02NC9BNjRET3Bjb2RlLmNwcApAQCAtMjMsNiArMjMs
OSBAQAogICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJ
TElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCisvLyBPbGRlciB2ZXJzaW9ucyBvZiBnY2MgcmVx
dWlyZSB0aGlzIGZvciBQUkkqNjQgbWFjcm9zIHRvIGJlIGRlZmluZWQgaW4gaW50dHlwZXMuaAor
I2RlZmluZSBfX1NURENfRk9STUFUX01BQ1JPUworCiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5j
bHVkZSAiQTY0RE9wY29kZS5oIgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
ZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9k
aXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9wY29kZS5oCmluZGV4IGVkMThkMzBkZmRjZmM5OWM5OGY1
NzI4M2NmODZjNzYzYzczYmM2ZTcuLjNjNTI5NTBlNDkyMzZiNDA0MDc1N2I0YzkzZTZiYzY4YjE1
MjZjMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJN
NjQvQTY0RE9wY29kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIv
QVJNNjQvQTY0RE9wY29kZS5oCkBAIC0yNiw2ICsyNiw3IEBACiAjaWZuZGVmIEE2NERPcGNvZGVf
aAogI2RlZmluZSBBNjRET3Bjb2RlX2gKIAorI2luY2x1ZGUgPGludHR5cGVzLmg+CiAjaW5jbHVk
ZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDxzdGRpbnQuaD4KIApAQCAtMTcyLDEyICsx
NzMsMTIgQEAgcHJvdGVjdGVkOgogCiAgICAgdm9pZCBhcHBlbmRVbnNpZ25lZEltbWVkaWF0ZTY0
KHVpbnQ2NF90IGltbWVkaWF0ZSkKICAgICB7Ci0gICAgICAgIGJ1ZmZlclByaW50ZigiIzB4JWxs
eCIsIGltbWVkaWF0ZSk7CisgICAgICAgIGJ1ZmZlclByaW50ZigiIzB4JSIgUFJJeDY0LCBpbW1l
ZGlhdGUpOwogICAgIH0KIAogICAgIHZvaWQgYXBwZW5kUENSZWxhdGl2ZU9mZnNldCh1aW50MzJf
dCogcGMsIGludDMyX3QgaW1tZWRpYXRlKQogICAgIHsKLSAgICAgICAgYnVmZmVyUHJpbnRmKCIw
eCVsbHgiLCByZWludGVycHJldF9jYXN0PHVpbnQ2NF90PihwYyArIGltbWVkaWF0ZSkpOworICAg
ICAgICBidWZmZXJQcmludGYoIjB4JSIgUFJJeDY0LCByZWludGVycHJldF9jYXN0PHVpbnQ2NF90
PihwYyArIGltbWVkaWF0ZSkpOwogICAgIH0KIAogICAgIHZvaWQgYXBwZW5kU2hpZnRBbW91bnQo
dW5zaWduZWQgYW1vdW50KQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>222332</attachid>
            <date>2014-01-27 10:15:53 -0800</date>
            <delta_ts>2014-01-27 10:24:19 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-126352-20140127121552.patch</filename>
            <type>text/plain</type>
            <size>2426</size>
            <attacher name="Brendan Long">self</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy
MTFmZWZiYWIzOTJiYWQ4ODM1YTU5ODkwMGJhMTIyMmFhN2JiZTMzLi45NzZkNzA1MDNmMDIyYWIx
MDczYjAyZWYxOTkyNjQyZWNjM2YxMThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxMy0xMi0zMSAgQnJlbmRhbiBMb25nICA8Yi5sb25nQGNhYmxlbGFicy5j
b20+CisKKyAgICAgICAgSlNDIGRpc2Fzc2VtYmxlciB3YXJucyBhYm91dCBpbmNvcnJlY3QgcHJp
bnRmIGZvcm1hdCBvbiA2NC1iaXQgTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTEyNjM1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaDoKKyAg
ICAgICAgKEpTQzo6QVJNNjREaXNhc3NlbWJsZXI6OkE2NERPcGNvZGU6OmFwcGVuZFVuc2lnbmVk
SW1tZWRpYXRlNjQpOiBVc2UgIiUiIFBSSXg2NCBpbnN0ZWFkIG9mICIlbGx4Ii4KKyAgICAgICAg
KEpTQzo6QVJNNjREaXNhc3NlbWJsZXI6OkE2NERPcGNvZGU6OmFwcGVuZFBDUmVsYXRpdmVPZmZz
ZXQpOiBTYW1lLgorCiAyMDE0LTAxLTI2ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNv
bT4KIAogICAgICAgICBKU0M6IFBhY2sgdW5saW5rZWQgaW5zdHJ1Y3Rpb25zIGhhcmRlci4KZGlm
ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9w
Y29kZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERP
cGNvZGUuY3BwCmluZGV4IDBlYTgxN2E0NjFhZDUyYWRhMGYyNzJhZjc0MzVjMjVhMWE5MTU4YzMu
LjVhNDIwOGE4OTBlNWFmNmU0ZDY0ZDMyN2YzZDQ2NzBmMTI4NDIzN2EgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9wY29kZS5jcHAKKysr
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci9BUk02NC9BNjRET3Bjb2RlLmNw
cApAQCAtMjcsNyArMjcsNiBAQAogI2luY2x1ZGUgIkE2NERPcGNvZGUuaCIKIAogI2luY2x1ZGUg
PHN0ZGFyZy5oPgotI2luY2x1ZGUgPHN0ZGludC5oPgogI2luY2x1ZGUgPHN0ZGlvLmg+CiAKIG5h
bWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgQVJNNjREaXNhc3NlbWJsZXIgewpkaWZmIC0tZ2l0IGEv
U291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci9BUk02NC9BNjRET3Bjb2RlLmggYi9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaAppbmRl
eCBlZDE4ZDMwZGZkY2ZjOTljOThmNTcyODNjZjg2Yzc2M2M3M2JjNmU3Li5jMmZkNDQ4ZWUyZWQ2
NDNlZmRjOGVmM2I5OWYwMjJkMjdjOGZkNzJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaAorKysgYi9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaApAQCAtMjYsNiArMjYsOSBA
QAogI2lmbmRlZiBBNjRET3Bjb2RlX2gKICNkZWZpbmUgQTY0RE9wY29kZV9oCiAKKy8vIE9sZGVy
IHZlcnNpb25zIG9mIGdjYyByZXF1aXJlIHRoaXMgZm9yIFBSSSo2NCBtYWNyb3MgdG8gYmUgZGVm
aW5lZCBpbiBpbnR0eXBlcy5oIGFuZCBzdGRpbnQuaAorI2RlZmluZSBfX1NURENfRk9STUFUX01B
Q1JPUworCiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDxzdGRpbnQuaD4K
IApAQCAtMTcyLDEyICsxNzUsMTIgQEAgcHJvdGVjdGVkOgogCiAgICAgdm9pZCBhcHBlbmRVbnNp
Z25lZEltbWVkaWF0ZTY0KHVpbnQ2NF90IGltbWVkaWF0ZSkKICAgICB7Ci0gICAgICAgIGJ1ZmZl
clByaW50ZigiIzB4JWxseCIsIGltbWVkaWF0ZSk7CisgICAgICAgIGJ1ZmZlclByaW50ZigiIzB4
JSIgUFJJeDY0LCBpbW1lZGlhdGUpOwogICAgIH0KIAogICAgIHZvaWQgYXBwZW5kUENSZWxhdGl2
ZU9mZnNldCh1aW50MzJfdCogcGMsIGludDMyX3QgaW1tZWRpYXRlKQogICAgIHsKLSAgICAgICAg
YnVmZmVyUHJpbnRmKCIweCVsbHgiLCByZWludGVycHJldF9jYXN0PHVpbnQ2NF90PihwYyArIGlt
bWVkaWF0ZSkpOworICAgICAgICBidWZmZXJQcmludGYoIjB4JSIgUFJJeDY0LCByZWludGVycHJl
dF9jYXN0PHVpbnQ2NF90PihwYyArIGltbWVkaWF0ZSkpOwogICAgIH0KIAogICAgIHZvaWQgYXBw
ZW5kU2hpZnRBbW91bnQodW5zaWduZWQgYW1vdW50KQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>222335</attachid>
            <date>2014-01-27 10:24:25 -0800</date>
            <delta_ts>2014-01-27 10:36:38 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-126352-20140127122424.patch</filename>
            <type>text/plain</type>
            <size>2450</size>
            <attacher name="Brendan Long">self</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy
MTFmZWZiYWIzOTJiYWQ4ODM1YTU5ODkwMGJhMTIyMmFhN2JiZTMzLi45NzZkNzA1MDNmMDIyYWIx
MDczYjAyZWYxOTkyNjQyZWNjM2YxMThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxMy0xMi0zMSAgQnJlbmRhbiBMb25nICA8Yi5sb25nQGNhYmxlbGFicy5j
b20+CisKKyAgICAgICAgSlNDIGRpc2Fzc2VtYmxlciB3YXJucyBhYm91dCBpbmNvcnJlY3QgcHJp
bnRmIGZvcm1hdCBvbiA2NC1iaXQgTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTEyNjM1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaDoKKyAg
ICAgICAgKEpTQzo6QVJNNjREaXNhc3NlbWJsZXI6OkE2NERPcGNvZGU6OmFwcGVuZFVuc2lnbmVk
SW1tZWRpYXRlNjQpOiBVc2UgIiUiIFBSSXg2NCBpbnN0ZWFkIG9mICIlbGx4Ii4KKyAgICAgICAg
KEpTQzo6QVJNNjREaXNhc3NlbWJsZXI6OkE2NERPcGNvZGU6OmFwcGVuZFBDUmVsYXRpdmVPZmZz
ZXQpOiBTYW1lLgorCiAyMDE0LTAxLTI2ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNv
bT4KIAogICAgICAgICBKU0M6IFBhY2sgdW5saW5rZWQgaW5zdHJ1Y3Rpb25zIGhhcmRlci4KZGlm
ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9w
Y29kZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERP
cGNvZGUuY3BwCmluZGV4IDBlYTgxN2E0NjFhZDUyYWRhMGYyNzJhZjc0MzVjMjVhMWE5MTU4YzMu
LjVhNDIwOGE4OTBlNWFmNmU0ZDY0ZDMyN2YzZDQ2NzBmMTI4NDIzN2EgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9wY29kZS5jcHAKKysr
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci9BUk02NC9BNjRET3Bjb2RlLmNw
cApAQCAtMjcsNyArMjcsNiBAQAogI2luY2x1ZGUgIkE2NERPcGNvZGUuaCIKIAogI2luY2x1ZGUg
PHN0ZGFyZy5oPgotI2luY2x1ZGUgPHN0ZGludC5oPgogI2luY2x1ZGUgPHN0ZGlvLmg+CiAKIG5h
bWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgQVJNNjREaXNhc3NlbWJsZXIgewpkaWZmIC0tZ2l0IGEv
U291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci9BUk02NC9BNjRET3Bjb2RlLmggYi9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaAppbmRl
eCBlZDE4ZDMwZGZkY2ZjOTljOThmNTcyODNjZjg2Yzc2M2M3M2JjNmU3Li4wNmU4MjNmOGE1M2Zk
Y2ExY2U1YzhlY2Q2YzI1ZTU2MDVhZTFjOWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaAorKysgYi9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaApAQCAtMjYsNiArMjYsMTAg
QEAKICNpZm5kZWYgQTY0RE9wY29kZV9oCiAjZGVmaW5lIEE2NERPcGNvZGVfaAogCisvLyBPbGRl
ciB2ZXJzaW9ucyBvZiBnY2MgcmVxdWlyZSB0aGlzIGZvciBQUkkqNjQgbWFjcm9zIHRvIGJlIGRl
ZmluZWQgaW4gaW50dHlwZXMuaCBhbmQgc3RkaW50LmgKKyNkZWZpbmUgX19TVERDX0ZPUk1BVF9N
QUNST1MKKworI2luY2x1ZGUgPGludHR5cGVzLmg+CiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMu
aD4KICNpbmNsdWRlIDxzdGRpbnQuaD4KIApAQCAtMTcyLDEyICsxNzYsMTIgQEAgcHJvdGVjdGVk
OgogCiAgICAgdm9pZCBhcHBlbmRVbnNpZ25lZEltbWVkaWF0ZTY0KHVpbnQ2NF90IGltbWVkaWF0
ZSkKICAgICB7Ci0gICAgICAgIGJ1ZmZlclByaW50ZigiIzB4JWxseCIsIGltbWVkaWF0ZSk7Cisg
ICAgICAgIGJ1ZmZlclByaW50ZigiIzB4JSIgUFJJeDY0LCBpbW1lZGlhdGUpOwogICAgIH0KIAog
ICAgIHZvaWQgYXBwZW5kUENSZWxhdGl2ZU9mZnNldCh1aW50MzJfdCogcGMsIGludDMyX3QgaW1t
ZWRpYXRlKQogICAgIHsKLSAgICAgICAgYnVmZmVyUHJpbnRmKCIweCVsbHgiLCByZWludGVycHJl
dF9jYXN0PHVpbnQ2NF90PihwYyArIGltbWVkaWF0ZSkpOworICAgICAgICBidWZmZXJQcmludGYo
IjB4JSIgUFJJeDY0LCByZWludGVycHJldF9jYXN0PHVpbnQ2NF90PihwYyArIGltbWVkaWF0ZSkp
OwogICAgIH0KIAogICAgIHZvaWQgYXBwZW5kU2hpZnRBbW91bnQodW5zaWduZWQgYW1vdW50KQo=
</data>
<flag name="review"
          id="246321"
          type_id="1"
          status="+"
          setter="msaboff"
    />
          </attachment>
      

    </bug>

</bugzilla>