126351 2013-12-31 14:03:18 -0800 GtkXtBin uses deprecated gdk_threads_enter() and gdk_threads_leave() 2015-01-28 11:15:17 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 b.long webkit-unassigned oldest_to_newest 963551 0 b.long 2013-12-31 14:03:18 -0800 As far as I can tell, these two functions were deprecated because everyone uses them incorrectly, and the new correct way of doing this is to do everything in a main-loop callback. See: https://developer.gnome.org/gdk3/unstable/gdk3-Threads.html#GDK-THREADS-ENTER:CAPS GtkXtBin doesn't seem to have an upstream as far as I can tell, but Firefox also uses it, so if we fix this, we might want to share the result with them. Build output: ../../Source/WebCore/plugins/gtk/gtk2xtbin.c: In function 'xt_event_prepare': ../../Source/WebCore/plugins/gtk/gtk2xtbin.c:138:3: warning: 'gdk_threads_enter' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:46) [-Wdeprecated-declarations] gdk_threads_enter(); ^ ../../Source/WebCore/plugins/gtk/gtk2xtbin.c:140:3: warning: 'gdk_threads_leave' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:48) [-Wdeprecated-declarations] gdk_threads_leave(); ^ ../../Source/WebCore/plugins/gtk/gtk2xtbin.c: In function 'xt_event_check': ../../Source/WebCore/plugins/gtk/gtk2xtbin.c:148:3: warning: 'gdk_threads_enter' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:46) [-Wdeprecated-declarations] gdk_threads_enter(); ^ ../../Source/WebCore/plugins/gtk/gtk2xtbin.c:153:5: warning: 'gdk_threads_leave' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:48) [-Wdeprecated-declarations] gdk_threads_leave(); ^ ../../Source/WebCore/plugins/gtk/gtk2xtbin.c:157:3: warning: 'gdk_threads_leave' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:48) [-Wdeprecated-declarations] gdk_threads_leave(); ^ ../../Source/WebCore/plugins/gtk/gtk2xtbin.c: In function 'xt_event_dispatch': ../../Source/WebCore/plugins/gtk/gtk2xtbin.c:171:3: warning: 'gdk_threads_enter' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:46) [-Wdeprecated-declarations] gdk_threads_enter(); ^ ../../Source/WebCore/plugins/gtk/gtk2xtbin.c:182:3: warning: 'gdk_threads_leave' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:48) [-Wdeprecated-declarations] gdk_threads_leave(); 1064963 1 b.long 2015-01-28 11:15:17 -0800 This file doesn't seem to exist anymore.