126350 2013-12-31 13:48:35 -0800 [GTK] [CMake] Fix the WEBKIT_SRC_DIR define when building the WebKit2 GObject API unit tests 2014-01-01 07:38:07 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson cdumez cgarcia commit-queue gustavo gyuyoung.kim rakuco oldest_to_newest 963548 0 mrobinson 2013-12-31 13:48:35 -0800 The define is wrong, so the tests are failing. 963549 1 220170 mrobinson 2013-12-31 13:50:05 -0800 Created attachment 220170 Patch 963550 2 commit-queue 2013-12-31 13:50:56 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 963596 3 220170 cgarcia 2014-01-01 02:55:35 -0800 Comment on attachment 220170 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220170&action=review > Source/WebKit2/ChangeLog:3 > + [GTK] [CMake] Fix the WEBKIT_SRC_DIR define when building the WebKi2 GObject API unit tests btw, please fix the typo in the changelog before landing 963604 4 mrobinson 2014-01-01 07:38:07 -0800 Committed r161189: <http://trac.webkit.org/changeset/161189> 220170 2013-12-31 13:50:05 -0800 2014-01-01 02:55:35 -0800 Patch bug-126350-20131231135004.patch text/plain 1533 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTBjMmQ4OWFhYzY5ZDk5 M2EyMWRkN2FkYWQxNmQ0NzBhYTRlZjg3Yi4uZjMwMjMxM2JmZjY1NmJiN2YzNWJlMjMwYjg3MjVl MWQwYjI2NDhiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEzLTEyLTMxICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBbQ01h a2VdIEZpeCB0aGUgV0VCS0lUX1NSQ19ESVIgZGVmaW5lIHdoZW4gYnVpbGRpbmcgdGhlIFdlYktp MiBHT2JqZWN0IEFQSSB1bml0IHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjYzNTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL0NNYWtlTGlzdHMudHh0 OiBGaXggdGhlIGRlZmluZS4KKworMjAxMy0xMi0zMSAgTWFydGluIFJvYmluc29uICA8bXJvYmlu c29uQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gUmVuYW1lIGxpYnRlc3RuZXRzY2FwZXBs dWdpbiB0byBsaWJUZXN0TmV0c2NhcGVQbHVnaW4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjM0OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL0NNYWtlTGlzdHMudHh0CmluZGV4IDJjYTg0NzgwOWYx MDFhOTVhZGJiN2ZlNjhiMjQwYTdlYjE4ODg4ZjAuLmJjYjBjZmRiY2I2YTFlMTY2YWNhNTRlYTky YzQwMTQyZTgxNmFlN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL3Rlc3RzL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL3Rlc3RzL0NNYWtlTGlzdHMudHh0CkBAIC01LDcgKzUsNyBAQCBmaWxlKE1BS0VfRElS RUNUT1JZICR7VEVTVF9SRVNPVVJDRVNfRElSfSkKIGFkZF9kZWZpbml0aW9ucygKICAgICAtRFdF QktJVF9URVNUX1BMVUdJTl9ESVI9IiR7Q01BS0VfTElCUkFSWV9PVVRQVVRfRElSRUNUT1JZfSIK ICAgICAtRFdFQktJVF9FWEVDX1BBVEg9IiR7Q01BS0VfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZ fSIKLSAgICAtRFdFQktJVF9TUkNfRElSPSIke0NNQUtFX1NSQ19ESVJ9IgorICAgIC1EV0VCS0lU X1NSQ19ESVI9IiR7Q01BS0VfU09VUkNFX0RJUn0iCiAgICAgLURXRUJLSVRfVEVTVF9XRUJfRVhU RU5TSU9OU19ESVI9IiR7VEVTVF9MSUJSQVJZX0RJUn0iCiAgICAgLURXRUJLSVRfSU5KRUNURURf QlVORExFX1BBVEg9IiR7Q01BS0VfTElCUkFSWV9PVVRQVVRfRElSRUNUT1JZfSIKICkK