126335 2013-12-30 23:30:34 -0800 CStack: the GC should not be assuming any limit on the stack size. 2014-01-13 17:59:38 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126320 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 963485 0 mark.lam 2013-12-30 23:30:34 -0800 Patch coming. 963486 1 220152 mark.lam 2013-12-30 23:33:27 -0800 Created attachment 220152 the patch. 963487 2 mark.lam 2013-12-30 23:36:10 -0800 Landed in r161175 on the jsCStack branch: <http://trac.webkit.org/r161175>. 963874 3 220152 ggaren 2014-01-02 14:05:32 -0800 Comment on attachment 220152 the patch. This ChangeLog doesn't explain why you did what you did, so it doesn't meet the minimum bar for a WebKit patch. 966026 4 mark.lam 2014-01-09 12:34:35 -0800 Will add a comment to the ChangeLog to indicate that we removed this assertion because we don't know the proper size of the stack that the span came from, and hence, we are not able to do a meaningful assertion for it here. 967568 5 mark.lam 2014-01-13 17:16:29 -0800 (In reply to comment #4) > Will add a comment to the ChangeLog to indicate that we removed this assertion because we don't know the proper size of the stack that the span came from, and hence, we are not able to do a meaningful assertion for it here. The following comment was added as part of r161575: <http://trac.webkit.org/r161575> "We cannot do a meaningful assertion here on the size of the stack span because we don't know the stack bounds that the span came from. Hence, the assertion is now removed." 967592 6 mark.lam 2014-01-13 17:59:38 -0800 Per our offline discussion, the added comment was satisfactory. ChangeLog review status updated in r161934 on the jsCStack branch: <http://trac.webkit.org/r161934>. 220152 2013-12-30 23:33:27 -0800 2014-01-02 14:05:32 -0800 the patch. bug-126335.patch text/plain 1160 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMTc0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTEyLTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD U3RhY2s6IHRoZSBHQyBzaG91bGQgbm90IGJlIGFzc3VtaW5nIGFueSBsaW1pdCBvbiB0aGUgc3Rh Y2sgc2l6ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNjMzNS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGhlYXAvQ29uc2VydmF0aXZlUm9vdHMuY3BwOgorICAgICAgICAoSlNDOjpDb25zZXJ2YXRp dmVSb290czo6Z2VuZXJpY0FkZFNwYW4pOgorCiAyMDEzLTEyLTMwICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBDU3RhY2s6IEludHJvZHVjZSB0cmFja2luZyBvZiB0 aGUgdG9wIFZNRW50cnlTY29wZS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0Nv bnNlcnZhdGl2ZVJvb3RzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9Db25zZXJ2YXRpdmVSb290cy5jcHAJKHJldmlzaW9uIDE2MTE2OCkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0NvbnNlcnZhdGl2ZVJvb3RzLmNwcAkod29ya2luZyBjb3B5KQpA QCAtOTksNyArOTksNiBAQCB2b2lkIENvbnNlcnZhdGl2ZVJvb3RzOjpnZW5lcmljQWRkU3Bhbih2 CiAgICAgICAgIGVuZCA9IHN3YXBUZW1wOwogICAgIH0KIAotICAgIEFTU0VSVCgoc3RhdGljX2Nh c3Q8Y2hhcio+KGVuZCkgLSBzdGF0aWNfY2FzdDxjaGFyKj4oYmVnaW4pKSA8IDB4MTAwMDAwMCk7 CiAgICAgQVNTRVJUKGlzUG9pbnRlckFsaWduZWQoYmVnaW4pKTsKICAgICBBU1NFUlQoaXNQb2lu dGVyQWxpZ25lZChlbmQpKTsKIAo=