126328 2013-12-30 21:32:04 -0800 CStack: Fix JSStack::ensureCapacity() to match LLINT and JIT stack checks 2014-01-02 15:21:30 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126320 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 963454 0 mark.lam 2013-12-30 21:32:04 -0800 JSStack::ensureCapacity() is doing its stack check in a complicated way that can result in it yielding different results than the LLINT and JIT stack checks. So, we'll simplify this code to do the same single pointer comparison against VM::m_jsStackLimit just like the LLINT and JIT does. This is a step towards https://bugs.webkit.org/show_bug.cgi?id=126320. 963455 1 220147 mark.lam 2013-12-30 21:36:07 -0800 Created attachment 220147 the patch. 963456 2 mark.lam 2013-12-30 21:38:47 -0800 Landed in r161170 on the jsCStack branch: <http://trac.webkit.org/r161170>. 963854 3 220147 ggaren 2014-01-02 13:16:28 -0800 Comment on attachment 220147 the patch. r=me 963921 4 mark.lam 2014-01-02 15:21:30 -0800 Thanks for the review. Status updated in r161232: <http://trac.webkit.org/r161232>. 220147 2013-12-30 21:36:07 -0800 2014-01-02 13:16:28 -0800 the patch. bug-126328.patch text/plain 2663 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMTY5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTEyLTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD U3RhY2s6IEZpeCBKU1N0YWNrOjplbnN1cmVDYXBhY2l0eSgpIHRvIG1hdGNoIExMSU5UIGFuZCBK SVQgc3RhY2sgY2hlY2tzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI2MzI4LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFsc28gcmVtb3ZlZCB0aGUgbm93IHVudXNlZCBKU1NUYWNrOjp0b3BPZlN0YWNr Rm9yQ2FwYWNpdHlDaGVjaygpLgorCisgICAgICAgICogaW50ZXJwcmV0ZXIvSlNTdGFjay5oOgor ICAgICAgICAqIGludGVycHJldGVyL0pTU3RhY2tJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkpT U3RhY2s6OmVuc3VyZUNhcGFjaXR5Rm9yKToKKwogMjAxMy0xMi0zMCAgTWFyayBMYW0gIDxtYXJr LmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQ1N0YWNrOiBJbnRyb2R1Y2luZyBPcHRpb25zOjpt YXhTdGFja1NpemUoKS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9K U1N0YWNrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVy L0pTU3RhY2suaAkocmV2aXNpb24gMTYxMTY5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2lu dGVycHJldGVyL0pTU3RhY2suaAkod29ya2luZyBjb3B5KQpAQCAtMTI3LDcgKzEyNyw2IEBAIG5h bWVzcGFjZSBKU0MgewogCiAgICAgICAgIGlubGluZSBSZWdpc3RlciogdG9wT2ZGcmFtZUZvcihD YWxsRnJhbWUqKTsKICAgICAgICAgaW5saW5lIFJlZ2lzdGVyKiB0b3BPZlN0YWNrKCk7Ci0gICAg ICAgIGlubGluZSBSZWdpc3RlciogdG9wT2ZTdGFja0ZvckNhcGFjaXR5Q2hlY2soKTsKIAogI2lm IEVOQUJMRShMTElOVF9DX0xPT1ApCiAgICAgICAgIFJlZ2lzdGVyKiBsb3dBZGRyZXNzKCkgY29u c3QKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9KU1N0YWNrSW5saW5l cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9KU1N0 YWNrSW5saW5lcy5oCShyZXZpc2lvbiAxNjExNjgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aW50ZXJwcmV0ZXIvSlNTdGFja0lubGluZXMuaAkod29ya2luZyBjb3B5KQpAQCAtMzksMjggKzM5 LDggQEAgaW5saW5lIGJvb2wgSlNTdGFjazo6ZW5zdXJlQ2FwYWNpdHlGb3IoUgogICAgIHJldHVy biBncm93KG5ld1RvcE9mU3RhY2spOwogI2Vsc2UKICAgICBBU1NFUlQod3RmVGhyZWFkRGF0YSgp LnN0YWNrKCkuaXNHcm93aW5nRG93bndhcmQoKSk7Ci0gICAgUmVnaXN0ZXIqIHRvcE9mU3RhY2sg PSB0b3BPZlN0YWNrRm9yQ2FwYWNpdHlDaGVjaygpOwotICAgIGlmIChuZXdUb3BPZlN0YWNrID4g dG9wT2ZTdGFjaykKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgc2l6ZV90IG5lZWRlZENhcGFj aXR5ID0gKHRvcE9mU3RhY2sgLSBuZXdUb3BPZlN0YWNrKSAqIHNpemVvZihSZWdpc3Rlcik7Ci0g ICAgcmV0dXJuIG1fdm0uaXNTYWZlVG9SZWN1cnNlKG5lZWRlZENhcGFjaXR5KTsKLSNlbmRpZgot fQotCi1pbmxpbmUgUmVnaXN0ZXIqIEpTU3RhY2s6OnRvcE9mU3RhY2tGb3JDYXBhY2l0eUNoZWNr KCkKLXsKLSNpZiAhRU5BQkxFKExMSU5UX0NfTE9PUCkKLSAgICAvLyBXZSdyZSB0cnlpbmcgdG8g Z2V0IGFuIGVzdGltYXRlIG9mIHRoZSB0b3Agb2YgdGhlIHN0YWNrIGZvciB0aGUgcHVycG9zZQot ICAgIC8vIG9mIGEgY2FwYWNpdHkgY2hlY2suIElmIG1fdG9wQ2FsbEZyYW1lIGlzIDAsIHRoZW4g d2UgY2FuJ3QgY2FsY3VsYXRlIGFuCi0gICAgLy8gYWNjdXJhdGUgdG9wIG9mIHN0YWNrIHZhbHVl LiBKdXN0IHVzZSB0aGUgY3VycmVudCBzdGFjayBwb3NpdGlvbiBhcyBhbgotICAgIC8vIGVzdGlt YXRlIGZvciB0aGUgdG9wIG9mIHRoZSBzdGFjayBmcm9tIHdoZXJlIEpTIGNvZGUgd2lsbCBzdGFy dCBleGVjdXRpbmcuCi0gICAgLy8gVGhpcyBpcyBjb25zZXJ2YXRpdmUsIGJ1dCBpdCB3aWxsIGJl IHNhZmUuCi0gICAgaWYgKCFtX3RvcENhbGxGcmFtZSkgewotICAgICAgICBSZWdpc3RlciogcCA9 IHJlaW50ZXJwcmV0X2Nhc3Q8UmVnaXN0ZXIqPigmcCk7Ci0gICAgICAgIHJldHVybiBwOwotICAg IH0KKyAgICByZXR1cm4gbmV3VG9wT2ZTdGFjayA+PSBtX3ZtLmpzU3RhY2tMaW1pdCgpOwogI2Vu ZGlmCi0gICAgcmV0dXJuIHRvcE9mU3RhY2soKSArIDE7CiB9CiAKIGlubGluZSBSZWdpc3Rlciog SlNTdGFjazo6dG9wT2ZGcmFtZUZvcihDYWxsRnJhbWUqIGZyYW1lKQo=