126327 2013-12-30 21:29:41 -0800 Use getc rather than getbyte on older ruby 2015-05-10 14:07:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://trac.macports.org/ticket/37740 P2 Normal --- 126492 1 jeremyhu webkit-unassigned fpizlo mcatanzaro ossy oldest_to_newest 963453 0 220146 jeremyhu 2013-12-30 21:29:41 -0800 Created attachment 220146 patch to check ruby version first You should use getc on older ruby (or update configure to abort if ruby is older than 1.8.7) Trivial patch attached. 967265 1 ossy 2014-01-13 06:01:03 -0800 Please add changelog and set r? if you would like to ask review. 967420 2 220146 fpizlo 2014-01-13 11:05:37 -0800 Comment on attachment 220146 patch to check ruby version first This looks fine. Can you prepare-ChangeLog and resubmit the patch? I'll be happy to r+ with appropriate ChangeLog text. 977344 3 ossy 2014-02-06 08:12:37 -0800 ping 977415 4 fpizlo 2014-02-06 10:21:01 -0800 (In reply to comment #3) > ping Do you want to do the honors and land this with a changelog? R=me. 1093572 5 mcatanzaro 2015-05-10 14:07:57 -0700 Looks like 1.8.7 is the minimum required nowadays, so closing. 220146 2013-12-30 21:29:41 -0800 2014-01-13 11:05:37 -0800 patch to check ruby version first ruby-1.8.patch text/plain 500 jeremyhu LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL29mZnNldHMucmIub3JpZwkyMDEy LTExLTIzIDE0OjEyOjE2LjAwMDAwMDAwMCAtMDYwMAorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L29mZmxpbmVhc20vb2Zmc2V0cy5yYgkyMDEzLTAxLTIyIDE5OjM1OjQ3LjAwMDAwMDAwMCAtMDYw MApAQCAtMTA5LDcgKzEwOSwxMSBAQAogICAgIEZpbGUub3BlbihmaWxlLCAiciIpIHsKICAgICAg ICAgfCBpbnAgfAogICAgICAgICBsb29wIHsKLSAgICAgICAgICAgIGJ5dGUgPSBpbnAuZ2V0Ynl0 ZQorICAgICAgICAgICAgaWYgUlVCWV9WRVJTSU9OID49ICcxLjguNycKKyAgICAgICAgICAgICAg Ynl0ZSA9IGlucC5nZXRieXRlCisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgIGJ5dGUg PSBpbnAuZ2V0YworICAgICAgICAgICAgZW5kCiAgICAgICAgICAgICBicmVhayB1bmxlc3MgYnl0 ZQogICAgICAgICAgICAgZmlsZUJ5dGVzIDw8IGJ5dGUKICAgICAgICAgfQo=