<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126326</bug_id>
          
          <creation_ts>2013-12-30 21:21:58 -0800</creation_ts>
          <short_desc>[PATCH] webkit-gtk + quartz build fails on X11/xresource.h code dependencies</short_desc>
          <delta_ts>2015-05-10 14:02:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://trac.macports.org/ticket/39898</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>126492</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Jeremy Huddleston Sequoia">jeremyhu</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>963451</commentid>
    <comment_count>0</comment_count>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2013-12-30 21:21:58 -0800</bug_when>
    <thetext>Issue reported via MacPorts with patch available.  See http://trac.macports.org/ticket/39898 for further information

:info:build In file included from Source/WebCore/bridge/NP_jsobject.cpp:30:
:info:build In file included from ./Source/WebCore/bridge/NP_jsobject.h:31:
:info:build ./Source/WebCore/bridge/npruntime_internal.h:33:14: fatal error: &apos;X11/Xresource.h&apos; file not found
:info:build     #include &lt;X11/Xresource.h&gt;
:info:build              ^
:info:build In file included from Source/WebCore/bridge/npruntime.cpp:31:
:info:build ./Source/WebCore/bridge/npruntime_internal.h:33:14: fatal error: &apos;X11/Xresource.h&apos; file not found
:info:build     #include &lt;X11/Xresource.h&gt;
:info:build              ^
:info:build 1 error generated.

When gtk/Quartz is used, X11/Xresource.h is still incorrectly pulled in.

Trivial patch attached.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>963452</commentid>
    <comment_count>1</comment_count>
      <attachid>220145</attachid>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2013-12-30 21:24:40 -0800</bug_when>
    <thetext>Created attachment 220145
trivial patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>967267</commentid>
    <comment_count>2</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-01-13 06:02:20 -0800</bug_when>
    <thetext>Please add changelog and set r? if you would like to ask for review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1093569</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-05-10 14:02:33 -0700</bug_when>
    <thetext>I believe this issue is obsolete based on comments in bug #126492. If this issue is still present in 2.8.1 or 2.9.1 please leave a note so we can reopen.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220145</attachid>
            <date>2013-12-30 21:24:40 -0800</date>
            <delta_ts>2013-12-30 21:24:40 -0800</delta_ts>
            <desc>trivial patch</desc>
            <filename>quartz-webcore.patch</filename>
            <type>text/plain</type>
            <size>868</size>
            <attacher name="Jeremy Huddleston Sequoia">jeremyhu</attacher>
            
              <data encoding="base64">LS0tIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy1vcmlnLmNwcAkyMDEzLTA3LTE5
IDAwOjA0OjExLjAwMDAwMDAwMCAtMDcwMAorKysgU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVn
aW5WaWV3LmNwcAkyMDEzLTA4LTEyIDE3OjQ4OjIwLjAwMDAwMDAwMCAtMDcwMApAQCAtODY1LDcg
Kzg2NSw3IEBACiAgICAgLCBtX2NvbnRleHRSZWYoMCkKICAgICAsIG1fZmFrZVdpbmRvdygwKQog
I2VuZGlmCi0jaWYgZGVmaW5lZChYUF9VTklYKSAmJiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQ
SSkKKyNpZiBQTEFURk9STShYMTEpICYmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQogICAg
ICwgbV9oYXNQZW5kaW5nR2VvbWV0cnlDaGFuZ2UodHJ1ZSkKICAgICAsIG1fZHJhd2FibGUoMCkK
ICAgICAsIG1fdmlzdWFsKDApCi0tLSBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXct
b3JpZy5oCTIwMTMtMDctMTkgMDA6MDQ6MTEuMDAwMDAwMDAwIC0wNzAwCisrKyBTb3VyY2UvV2Vi
Q29yZS9wbHVnaW5zL1BsdWdpblZpZXcuaAkyMDEzLTA4LTEyIDE2OjA5OjIxLjAwMDAwMDAwMCAt
MDcwMApAQCAtNDI3LDcgKzQyNyw3IEBACiAgICAgICAgIFBvaW50IG1vdXNlUG9zRm9yUGx1Z2lu
KE1vdXNlRXZlbnQqIGV2ZW50ID0gMCkgY29uc3Q7CiAjZW5kaWYKIAotI2lmIGRlZmluZWQoWFBf
VU5JWCkgJiYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCisjaWYgUExBVEZPUk0oWDExKSAm
JiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICAgICAgYm9vbCBtX2hhc1BlbmRpbmdH
ZW9tZXRyeUNoYW5nZTsKICAgICAgICAgUGl4bWFwIG1fZHJhd2FibGU7CiAgICAgICAgIFZpc3Vh
bCogbV92aXN1YWw7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>