126325 2013-12-30 21:15:24 -0800 [GTK] Use libc++ for C++11 on darwin 2014-01-06 00:52:57 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126492 126431 1 jeremyhu zan cgarcia mcatanzaro zan oldest_to_newest 963448 0 jeremyhu 2013-12-30 21:15:24 -0800 webkit-gtk tries to use libstdc++ for C++11 even though OS X's libstdc++ doesn't support C++11. What is the point of this? The comment makes it look intentional. # Use the C++11 standard. Do not warn about C++11 incompatibilities. CXXFLAGS="$CXXFLAGS -pthread -std=c++11 -Wno-c++11-compat" ... # libstdc++ is at the moment the only option as the C++ standard library when compiling with Clang. # -Wno-c++11-extensions, currently only usable with Clang, suppresses warnings of C++11 extensions in use. # Suppress unused arguments warnings for C++ files as well. if test "$cxx_compiler" = "clang++"; then CXXFLAGS="$CXXFLAGS -stdlib=libstdc++ -Wno-c++11-extensions -Qunused-arguments" fi --- /usr/bin/clang++ -DHAVE_CONFIG_H -I. -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wno-parentheses -fno-exceptions -DBUILDING_CAIRO__ -DBUILDING_GTK__ -I./Source -I./Source/WTF -I./Source/WTF/wtf -DGTEST_USE_OWN_TR1_TUPLE=1 -fno-rtti -fstrict-aliasing -O3 -D_REENTRANT -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include -pipe -Os -Wno-c++11-extensions -arch x86_64 -pthread -std=c++11 -Wno-c++11-compat -stdlib=libstdc++ -Wno-c++11-extensions -Qunused-arguments -O2 -MT Source/WTF/wtf/libWTF_la-Compression.lo -MD -MP -MF Source/WTF/wtf/.deps/libWTF_la-Compression.Tpo -c Source/WTF/wtf/Compression.cpp -fno-common -DPIC -o Source/WTF/wtf/.libs/libWTF_la-Compression.o In file included from Source/WTF/wtf/Compression.cpp:28: In file included from ./Source/WTF/wtf/Compression.h:30: In file included from ./Source/WTF/wtf/Vector.h:31: In file included from ./Source/WTF/wtf/VectorTraits.h:26: ./Source/WTF/wtf/RefPtr.h:149:27: error: no member named 'move' in namespace 'std' RefPtr ptr = std::move(o); ~~~~~^ ./Source/WTF/wtf/RefPtr.h:156:27: error: no member named 'move' in namespace 'std' RefPtr ptr = std::move(o); ~~~~~^ 2 errors generated. $ sudo /usr/bin/clang++ -DHAVE_CONFIG_H -I. -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wno-parentheses -fno-exceptions -DBUILDING_CAIRO__ -DBUILDING_GTK__ -I./Source -I./Source/WTF -I./Source/WTF/wtf -DGTEST_USE_OWN_TR1_TUPLE=1 -fno-rtti -fstrict-aliasing -O3 -D_REENTRANT -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include -pipe -Os -Wno-c++11-extensions -arch x86_64 -pthread -std=c++11 -Wno-c++11-compat -stdlib=libc++ -Wno-c++11-extensions -Qunused-arguments -O2 -MT Source/WTF/wtf/libWTF_la-Compression.lo -MD -MP -MF Source/WTF/wtf/.deps/libWTF_la-Compression.Tpo -c Source/WTF/wtf/Compression.cpp -fno-common -DPIC -o Source/WTF/wtf/.libs/libWTF_la-Compression.o --- We're using libc++ for webkit-gtk-2.2.x in MacPorts without any issues reported. 963494 1 zan 2013-12-31 01:22:20 -0800 I think we can switch to libc++ on all platforms when compiling with Clang. 963528 2 mcatanzaro 2013-12-31 08:38:42 -0800 Some distributions (e.g. Fedora) ship Clang but not libc++. 964161 3 jeremyhu 2014-01-03 10:28:32 -0800 Related to https://bugs.webkit.org/show_bug.cgi?id=126431 964476 4 zan 2014-01-05 01:24:07 -0800 I think we could default to libc++ on Darwin and stop passing the -stdlib option to the Clang compiler on other platforms. The option could still be enforced manually through the CXXFLAGS env. 964477 5 220392 zan 2014-01-05 01:39:54 -0800 Created attachment 220392 Patch 964491 6 jeremyhu 2014-01-05 03:03:58 -0800 My one suggestion is that you don't add -stdlib=libc++ if CXXFLAGS already contains "-stdlib=" 964495 7 220396 zan 2014-01-05 05:07:21 -0800 Created attachment 220396 Patch 964503 8 220396 mrobinson 2014-01-05 09:58:12 -0800 Comment on attachment 220396 Patch I'm actually a bit surprised we need the standard library. 964570 9 220396 zan 2014-01-06 00:52:51 -0800 Comment on attachment 220396 Patch Clearing flags on attachment: 220396 Committed r161333: <http://trac.webkit.org/changeset/161333> 964571 10 zan 2014-01-06 00:52:57 -0800 All reviewed patches have been landed. Closing bug. 220392 2014-01-05 01:39:54 -0800 2014-01-05 05:07:16 -0800 Patch bug-126325-20140105103951.patch text/plain 1786 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0b3Rvb2xz L1NldHVwQ29tcGlsZXJGbGFncy5tNCBiL1NvdXJjZS9hdXRvdG9vbHMvU2V0dXBDb21waWxlckZs YWdzLm00CmluZGV4IDNhMGRlZThhZjVjYzBmOGJhOTAyNjNlNmVhMDc1MmUzZDQ2Mjk1MGQuLmQ2 NmZiOTcyZTM5ZTk0MjJhYzg1NWQ4ZDA5ZTU3YmFjNWY5NGJkOTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9hdXRvdG9vbHMvU2V0dXBDb21waWxlckZsYWdzLm00CisrKyBiL1NvdXJjZS9hdXRvdG9vbHMv U2V0dXBDb21waWxlckZsYWdzLm00CkBAIC04LDEwICs4LDE0IEBAIGlmIHRlc3QgIiRjX2NvbXBp bGVyIiA9ICJjbGFuZyI7IHRoZW4KICAgICBDRkxBR1M9IiRDRkxBR1MgLVF1bnVzZWQtYXJndW1l bnRzIgogZmkKIAotIyBsaWJzdGRjKysgaXMgYXQgdGhlIG1vbWVudCB0aGUgb25seSBvcHRpb24g YXMgdGhlIEMrKyBzdGFuZGFyZCBsaWJyYXJ5IHdoZW4gY29tcGlsaW5nIHdpdGggQ2xhbmcuCiAj IFN1cHByZXNzIHVudXNlZCBhcmd1bWVudHMgd2FybmluZ3MgZm9yIEMrKyBmaWxlcyBhcyB3ZWxs LgogaWYgdGVzdCAiJGN4eF9jb21waWxlciIgPSAiY2xhbmcrKyI7IHRoZW4KLSAgICBDWFhGTEFH Uz0iJENYWEZMQUdTIC1zdGRsaWI9bGlic3RkYysrIC1RdW51c2VkLWFyZ3VtZW50cyIKKyAgICBD WFhGTEFHUz0iJENYWEZMQUdTIC1RdW51c2VkLWFyZ3VtZW50cyIKKworICAgICMgRGVmYXVsdCB0 byBsaWJjKysgYXMgdGhlIHN0YW5kYXJkIGxpYnJhcnkgb24gRGFyd2luLgorICAgIGlmIHRlc3Qg IiRvc19kYXJ3aW4iID0gInllcyI7IHRoZW4KKyAgICAgICAgQ1hYRkxBR1M9IiRDWFhGTEFHUyAt c3RkbGliPWxpYmMrKyIKKyAgICBmaQogZmkKIAogaWYgdGVzdCAiJGhvc3RfY3B1IiA9ICJzaDQi OyB0aGVuCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggOGQ5YmQzMmQ1 Mjc4NGNlMTdkMjAzMWYzYjk4ODNkZWFkMzM4NTAwMC4uNzgxMDM3YTczNWQxMDZmN2VjNGFlZjc1 ZWFjMTYyYWJjYTlhNGMxMiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTA1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdh bGlhLmNvbT4KKworICAgICAgICBbR1RLXSBVc2UgbGliYysrIGZvciBDKysxMSBvbiBkYXJ3aW4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjMyNQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNl L2F1dG90b29scy9TZXR1cENvbXBpbGVyRmxhZ3MubTQ6IERvbid0IGRlZmF1bHQgdG8gbGlic3Rk YysrIHdoZW4gY29tcGlsaW5nIHdpdGggQ2xhbmcuCisgICAgICAgIEluc3RlYWQsIHRoZSBjb21w aWxlciBzaG91bGQgZGV0ZXJtaW5lIGl0c2VsZiB3aGF0IHN0YW5kYXJkIGxpYnJhcnkgdG8gdXNl LCBleGNlcHQgb24gRGFyd2luLAorICAgICAgICB3aGVyZSBsaWJjKysgc2hvdWxkIGJlIGVuZm9y Y2VkLiBUaGUgc3RhbmRhcmQgbGlicmFyeSBvZiB1c2VyJ3MgY2hvb3NpbmcgY2FuIHN0aWxsIGJl IGVuZm9yY2VkCisgICAgICAgIHRocm91Z2ggdGhlIENYWEZMQUdTIGVudmlyb25tZW50IHZhcmlh YmxlLgorCiAyMDE0LTAxLTA0ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLXSBbQ01ha2VdIEltcHJvdmUgdGhlIHdheSB3ZSBsb2NhdGUgZ29i amVjdC1pbnRyb3NwZWN0aW9uCg== 220396 2014-01-05 05:07:21 -0800 2014-01-06 00:52:50 -0800 Patch bug-126325-20140105050720.patch text/plain 1769 zan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTMy MykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAx LTA1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XSBVc2UgbGliYysrIGZvciBDKysxMSBvbiBkYXJ3aW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjMyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2F1dG90b29scy9TZXR1cENvbXBpbGVy RmxhZ3MubTQ6IERvbid0IGRlZmF1bHQgdG8gbGlic3RkYysrIHdoZW4gY29tcGlsaW5nIHdpdGgg Q2xhbmcuCisgICAgICAgIEluc3RlYWQsIHRoZSBjb21waWxlciBzaG91bGQgZGV0ZXJtaW5lIGl0 c2VsZiB3aGF0IHN0YW5kYXJkIGxpYnJhcnkgdG8gdXNlLCBleGNlcHQgb24gRGFyd2luLAorICAg ICAgICB3aGVyZSBsaWJjKysgc2hvdWxkIGJlIGVuZm9yY2VkLiBUaGUgc3RhbmRhcmQgbGlicmFy eSBvZiB1c2VyJ3MgY2hvb3NpbmcgY2FuIHN0aWxsIGJlIGVuZm9yY2VkCisgICAgICAgIHRocm91 Z2ggdGhlIENYWEZMQUdTIGVudmlyb25tZW50IHZhcmlhYmxlLgorCiAyMDE0LTAxLTA1ICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBT dG9wIGluc3RhbGxpbmcgV2ViS2l0MiBDIEFQSSBoZWFkZXJzCkluZGV4OiBTb3VyY2UvYXV0b3Rv b2xzL1NldHVwQ29tcGlsZXJGbGFncy5tNAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYXV0b3Rvb2xz L1NldHVwQ29tcGlsZXJGbGFncy5tNAkocmV2aXNpb24gMTYxMzIzKQorKysgU291cmNlL2F1dG90 b29scy9TZXR1cENvbXBpbGVyRmxhZ3MubTQJKHdvcmtpbmcgY29weSkKQEAgLTgsMTAgKzgsMTQg QEAgaWYgdGVzdCAiJGNfY29tcGlsZXIiID0gImNsYW5nIjsgdGhlbgogICAgIENGTEFHUz0iJENG TEFHUyAtUXVudXNlZC1hcmd1bWVudHMiCiBmaQogCi0jIGxpYnN0ZGMrKyBpcyBhdCB0aGUgbW9t ZW50IHRoZSBvbmx5IG9wdGlvbiBhcyB0aGUgQysrIHN0YW5kYXJkIGxpYnJhcnkgd2hlbiBjb21w aWxpbmcgd2l0aCBDbGFuZy4KICMgU3VwcHJlc3MgdW51c2VkIGFyZ3VtZW50cyB3YXJuaW5ncyBm b3IgQysrIGZpbGVzIGFzIHdlbGwuCiBpZiB0ZXN0ICIkY3h4X2NvbXBpbGVyIiA9ICJjbGFuZysr IjsgdGhlbgotICAgIENYWEZMQUdTPSIkQ1hYRkxBR1MgLXN0ZGxpYj1saWJzdGRjKysgLVF1bnVz ZWQtYXJndW1lbnRzIgorICAgIENYWEZMQUdTPSIkQ1hYRkxBR1MgLVF1bnVzZWQtYXJndW1lbnRz IgorCisgICAgIyBEZWZhdWx0IHRvIGxpYmMrKyBhcyB0aGUgc3RhbmRhcmQgbGlicmFyeSBvbiBE YXJ3aW4sIGlmIGl0IGlzbid0IGFscmVhZHkgZW5mb3JjZWQgdGhyb3VnaCBDWFhGTEFHUy4KKyAg ICBpZiB0ZXN0ICIkb3NfZGFyd2luIiA9ICJ5ZXMiOyB0aGVuCisgICAgICAgIEFTX0NBU0UoWyRD WFhGTEFHU10sIFsqLXN0ZGxpYj0qXSwgW10sIFtDWFhGTEFHUz0iJENYWEZMQUdTIC1zdGRsaWI9 bGliYysrIl0pCisgICAgZmkKIGZpCiAKIGlmIHRlc3QgIiRob3N0X2NwdSIgPSAic2g0IjsgdGhl bgo=