<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126324</bug_id>
          
          <creation_ts>2013-12-30 21:13:05 -0800</creation_ts>
          <short_desc>configure check for clang version is incorrect</short_desc>
          <delta_ts>2015-04-07 02:29:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>126492</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Jeremy Huddleston Sequoia">jeremyhu</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>andersca</cc>
    
    <cc>berto</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>ossy</cc>
    
    <cc>philip.chimento</cc>
    
    <cc>tpopela</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>963447</commentid>
    <comment_count>0</comment_count>
      <attachid>220144</attachid>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2013-12-30 21:13:05 -0800</bug_when>
    <thetext>Created attachment 220144
trivial patch

The logic to verify &gt;= clang-3.2 is incorrect:
 1) It does not correctly check Apple clang versions
 2) It forces minor version &gt;= 2 even when major version &gt; 3 (eg 4.0 will fail)

Trivial patch attached</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>967266</commentid>
    <comment_count>1</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-01-13 06:01:51 -0800</bug_when>
    <thetext>Please add changelog and set r? if you would like to ask for review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>977164</commentid>
    <comment_count>2</comment_count>
      <attachid>223284</attachid>
    <who name="Jeremy Huddleston Sequoia">jeremyhu</who>
    <bug_when>2014-02-05 17:32:48 -0800</bug_when>
    <thetext>Created attachment 223284
clang-check.patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>977165</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-02-05 17:34:53 -0800</bug_when>
    <thetext>Attachment 223284 did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1039160</commentid>
    <comment_count>4</comment_count>
      <attachid>239190</attachid>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2014-10-03 01:09:59 -0700</bug_when>
    <thetext>Created attachment 239190
Updated patch

The same logic error was made with GCC versions too. Here&apos;s an updated patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1039205</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2014-10-03 07:22:47 -0700</bug_when>
    <thetext>Note that the autotools build was removed for 2.6.

The version check is indeed incorrect and will break when GCC 5 is released next spring, but the proposed fix is wrong too. The right hand side of the || will always be short-circuited:

(__GNUC__ &gt;= 4 || (__GNUC__ == 4 &amp;&amp; __GNUC_MINOR__ &gt;= 7)

You want:

(__GNUC__ &gt; 4 || (__GNUC__ == 4 &amp;&amp; __GNUC_MINOR__ &gt;= 7)

The altered Clang version check is correct.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1039648</commentid>
    <comment_count>6</comment_count>
      <attachid>239312</attachid>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2014-10-05 20:17:18 -0700</bug_when>
    <thetext>Created attachment 239312
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1039649</commentid>
    <comment_count>7</comment_count>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2014-10-05 20:19:14 -0700</bug_when>
    <thetext>Thanks for catching that. Here&apos;s another one. I know the autotools build is obsolete but it would be nice if this could be committed to the 2.4 branch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046718</commentid>
    <comment_count>8</comment_count>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2014-11-05 22:06:03 -0800</bug_when>
    <thetext>Would it be possible to get this reviewed for 2.4.8?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1062215</commentid>
    <comment_count>9</comment_count>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-01-18 12:17:11 -0800</bug_when>
    <thetext>Would it be possible to review this for 2.4.9?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1068227</commentid>
    <comment_count>10</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2015-02-10 18:47:04 -0800</bug_when>
    <thetext>Carlos, if you&apos;re planning to do another 2.4 release, can you take this patch please? We&apos;re going to use this patch in Fedora now that we&apos;ve upgraded to the GCC 5.0 prerelease.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1068289</commentid>
    <comment_count>11</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-02-11 00:19:15 -0800</bug_when>
    <thetext>Yes, I will. I already had this in my todo list for the next 2.4, but please, remember that the best way to make sure I don&apos;t forget a bug/patch is adding it to the list of proposed merges in http://trac.webkit.org/wiki/WebKitGTK/2.4.x</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1068550</commentid>
    <comment_count>12</comment_count>
    <who name="Philip Chimento">philip.chimento</who>
    <bug_when>2015-02-11 22:19:25 -0800</bug_when>
    <thetext>Sure thing. I somehow thought that that page was only for reviewed patches, but I&apos;ll add them there in the future.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1068575</commentid>
    <comment_count>13</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-02-12 00:07:37 -0800</bug_when>
    <thetext>(In reply to comment #12)
&gt; Sure thing. I somehow thought that that page was only for reviewed patches,
&gt; but I&apos;ll add them there in the future.

Not necessarily, the rule might be something like this:

  - If it has landed, add it as proposed merge for next release
  - If it&apos;s important bug, add it as proposed merge for next release
  - Otherwise, or in doubt, add it as changes on track
  - When adding a landed patch, please use the trac changeset instead of the bug url

Note that I&apos;ll check every change before merging, so it&apos;s better to add something there even if you are not sure, that not adding it. But, please, make sure the change hasn&apos;t been merged yet (not all changes merged are in the wiki)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1068620</commentid>
    <comment_count>14</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2015-02-12 08:21:38 -0800</bug_when>
    <thetext>I confirm that 2.4.8 builds fine with gcc 5 and these changes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1083275</commentid>
    <comment_count>15</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-04-07 02:29:50 -0700</bug_when>
    <thetext>Committed &lt;http://trac.webkit.org/changeset/182457&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220144</attachid>
            <date>2013-12-30 21:13:05 -0800</date>
            <delta_ts>2014-02-05 17:32:48 -0800</delta_ts>
            <desc>trivial patch</desc>
            <filename>clang-check.patch</filename>
            <type>text/plain</type>
            <size>1131</size>
            <attacher name="Jeremy Huddleston Sequoia">jeremyhu</attacher>
            
              <data encoding="base64">LS0tIFNvdXJjZS9hdXRvdG9vbHMvQ2hlY2tTeXN0ZW1BbmRCYXNpY0RlcGVuZGVuY2llcy5tNC5v
cmlnCTIwMTMtMTEtMTAgMTc6NDQ6NTcuMDAwMDAwMDAwIC0wODAwCisrKyBTb3VyY2UvYXV0b3Rv
b2xzL0NoZWNrU3lzdGVtQW5kQmFzaWNEZXBlbmRlbmNpZXMubTQJMjAxMy0xMS0xMCAxNzo0NTo1
Ny4wMDAwMDAwMDAgLTA4MDAKQEAgLTg3LDcgKzg3LDcgQEAgQUNfQ09NUElMRV9JRkVMU0UoW0FD
X0xBTkdfUFJPR1JBTShbCiAjZW5kaWYKIF0pXSwgW2NfY29tcGlsZXI9ImdjYyJdLCBbXSkKIEFD
X0NPTVBJTEVfSUZFTFNFKFtBQ19MQU5HX1BST0dSQU0oWwotI2lmICEoZGVmaW5lZChfX2NsYW5n
X18pICYmIF9fY2xhbmdfbWFqb3JfXyA+PSAzICYmIF9fY2xhbmdfbWlub3JfXyA+PSAyKQorI2lm
ICEoZGVmaW5lZChfX2NsYW5nX18pICYmIChfX2FwcGxlX2J1aWxkX3ZlcnNpb25fXyA+PSA0MjUw
MDI0IHx8ICghZGVmaW5lZChfX2FwcGxlX2J1aWxkX3ZlcnNpb25fXykgJiYgKF9fY2xhbmdfbWFq
b3JfXyA+IDMgfHwgKF9fY2xhbmdfbWFqb3JfXyA9PSAzICYmIF9fY2xhbmdfbWlub3JfXyA+PSAy
KSkpKSkKICNlcnJvciBOb3QgYSBzdXBwb3J0ZWQgQ2xhbmcgY29tcGlsZXIKICNlbmRpZgogXSld
LCBbY19jb21waWxlcj0iY2xhbmciXSwgW10pCkBAIC0xMDYsNyArMTA2LDcgQEAgQUNfQ09NUElM
RV9JRkVMU0UoW0FDX0xBTkdfUFJPR1JBTShbCiAjZW5kaWYKIF0pXSwgW2N4eF9jb21waWxlcj0i
ZysrIl0sIFtdKQogQUNfQ09NUElMRV9JRkVMU0UoW0FDX0xBTkdfUFJPR1JBTShbCi0jaWYgIShk
ZWZpbmVkKF9fY2xhbmdfXykgJiYgX19jbGFuZ19tYWpvcl9fID49IDMgJiYgX19jbGFuZ19taW5v
cl9fID49IDIpCisjaWYgIShkZWZpbmVkKF9fY2xhbmdfXykgJiYgKF9fYXBwbGVfYnVpbGRfdmVy
c2lvbl9fID49IDQyNTAwMjQgfHwgKCFkZWZpbmVkKF9fYXBwbGVfYnVpbGRfdmVyc2lvbl9fKSAm
JiAoX19jbGFuZ19tYWpvcl9fID4gMyB8fCAoX19jbGFuZ19tYWpvcl9fID09IDMgJiYgX19jbGFu
Z19taW5vcl9fID49IDIpKSkpKQogI2Vycm9yIE5vdCBhIHN1cHBvcnRlZCBDbGFuZysrIGNvbXBp
bGVyCiAjZW5kaWYKIF0pXSwgW2N4eF9jb21waWxlcj0iY2xhbmcrKyJdLCBbXSkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>223284</attachid>
            <date>2014-02-05 17:32:48 -0800</date>
            <delta_ts>2015-02-10 18:47:19 -0800</delta_ts>
            <desc>clang-check.patch</desc>
            <filename>clang-check.patch</filename>
            <type>text/plain</type>
            <size>1582</size>
            <attacher name="Jeremy Huddleston Sequoia">jeremyhu</attacher>
            
              <data encoding="base64">LS0tIENoYW5nZUxvZy5vcmlnCTIwMTQtMDItMDQgMDg6Mzg6MDMuMDAwMDAwMDAwIC0wODAwCisr
KyBDaGFuZ2VMb2cJMjAxNC0wMi0wNSAxNzozMTozMy4wMDAwMDAwMDAgLTA4MDAKQEAgLTEsMyAr
MSwxMCBAQAorMjAxNC0wMi0wNSAgSmVyZW15IEh1ZGRsZXN0b24gU2VxdW9pYSAgPGplcmVteWh1
QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggY2xhbmcgdmVyc2lvbiBjaGVja2luZworICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MzI0CisKKyAgICAg
ICAgKiBTb3VyY2UvYXV0b3Rvb2xzL0NoZWNrU3lzdGVtQW5kQmFzaWNEZXBlbmRlbmNpZXMubTQK
KwogMjAxNC0wMS0yOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAg
ICAgICAgIFJlbW92ZSBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikgbGVmdG92ZXJzCi0tLSBT
b3VyY2UvYXV0b3Rvb2xzL0NoZWNrU3lzdGVtQW5kQmFzaWNEZXBlbmRlbmNpZXMubTQub3JpZwky
MDE0LTAxLTIzIDA4OjQ5OjU5LjAwMDAwMDAwMCAtMDgwMAorKysgU291cmNlL2F1dG90b29scy9D
aGVja1N5c3RlbUFuZEJhc2ljRGVwZW5kZW5jaWVzLm00CTIwMTQtMDItMDUgMTc6Mjk6MzkuMDAw
MDAwMDAwIC0wODAwCkBAIC05Miw3ICs5Miw3IEBAIEFDX0NPTVBJTEVfSUZFTFNFKFtBQ19MQU5H
X1BST0dSQU0oWwogI2VuZGlmCiBdKV0sIFtjX2NvbXBpbGVyPSJnY2MiXSwgW10pCiBBQ19DT01Q
SUxFX0lGRUxTRShbQUNfTEFOR19QUk9HUkFNKFsKLSNpZiAhKGRlZmluZWQoX19jbGFuZ19fKSAm
JiBfX2NsYW5nX21ham9yX18gPj0gMyAmJiBfX2NsYW5nX21pbm9yX18gPj0gMykKKyNpZiAhKGRl
ZmluZWQoX19jbGFuZ19fKSAmJiAoX19hcHBsZV9idWlsZF92ZXJzaW9uX18gPj0gNDI1MDAyNCB8
fCAoIWRlZmluZWQoX19hcHBsZV9idWlsZF92ZXJzaW9uX18pICYmIChfX2NsYW5nX21ham9yX18g
PiAzIHx8IChfX2NsYW5nX21ham9yX18gPT0gMyAmJiBfX2NsYW5nX21pbm9yX18gPj0gMykpKSkp
CiAjZXJyb3IgTm90IGEgc3VwcG9ydGVkIENsYW5nIGNvbXBpbGVyCiAjZW5kaWYKIF0pXSwgW2Nf
Y29tcGlsZXI9ImNsYW5nIl0sIFtdKQpAQCAtMTExLDcgKzExMSw3IEBAIEFDX0NPTVBJTEVfSUZF
TFNFKFtBQ19MQU5HX1BST0dSQU0oWwogI2VuZGlmCiBdKV0sIFtjeHhfY29tcGlsZXI9ImcrKyJd
LCBbXSkKIEFDX0NPTVBJTEVfSUZFTFNFKFtBQ19MQU5HX1BST0dSQU0oWwotI2lmICEoZGVmaW5l
ZChfX2NsYW5nX18pICYmIF9fY2xhbmdfbWFqb3JfXyA+PSAzICYmIF9fY2xhbmdfbWlub3JfXyA+
PSAzKQorI2lmICEoZGVmaW5lZChfX2NsYW5nX18pICYmIChfX2FwcGxlX2J1aWxkX3ZlcnNpb25f
XyA+PSA0MjUwMDI0IHx8ICghZGVmaW5lZChfX2FwcGxlX2J1aWxkX3ZlcnNpb25fXykgJiYgKF9f
Y2xhbmdfbWFqb3JfXyA+IDMgfHwgKF9fY2xhbmdfbWFqb3JfXyA9PSAzICYmIF9fY2xhbmdfbWlu
b3JfXyA+PSAzKSkpKSkKICNlcnJvciBOb3QgYSBzdXBwb3J0ZWQgQ2xhbmcrKyBjb21waWxlcgog
I2VuZGlmCiBdKV0sIFtjeHhfY29tcGlsZXI9ImNsYW5nKysiXSwgW10pCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>239190</attachid>
            <date>2014-10-03 01:09:59 -0700</date>
            <delta_ts>2014-10-05 20:17:08 -0700</delta_ts>
            <desc>Updated patch</desc>
            <filename>webkit-126324-clang-check.patch</filename>
            <type>text/plain</type>
            <size>2067</size>
            <attacher name="Philip Chimento">philip.chimento</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL3JlbGVhc2VzL1dlYktpdEdUSy93ZWJraXQtMi40LjYvU291cmNlL2F1dG90
b29scy9DaGVja1N5c3RlbUFuZEJhc2ljRGVwZW5kZW5jaWVzLm00IGIvcmVsZWFzZXMvV2ViS2l0
R1RLL3dlYmtpdC0yLjQuNi9Tb3VyY2UvYXV0b3Rvb2xzL0NoZWNrU3lzdGVtQW5kQmFzaWNEZXBl
bmRlbmNpZXMubTQKLS0tIGEvcmVsZWFzZXMvV2ViS2l0R1RLL3dlYmtpdC0yLjQuNi9Tb3VyY2Uv
YXV0b3Rvb2xzL0NoZWNrU3lzdGVtQW5kQmFzaWNEZXBlbmRlbmNpZXMubTQgICAocmV2aXNpb24g
MTc0MjU4KQorKysgYi9yZWxlYXNlcy9XZWJLaXRHVEsvd2Via2l0LTIuNC42L1NvdXJjZS9hdXRv
dG9vbHMvQ2hlY2tTeXN0ZW1BbmRCYXNpY0RlcGVuZGVuY2llcy5tNCAgICh3b3JraW5nIGNvcHkp
CkBAIC04NywxMiArODcsMTIgQEAKIGNfY29tcGlsZXI9InVua25vd24iCiBBQ19MQU5HX1BVU0go
W0NdKQogQUNfQ09NUElMRV9JRkVMU0UoW0FDX0xBTkdfUFJPR1JBTShbCi0jaWYgIShkZWZpbmVk
KF9fR05VQ19fKSAmJiAhZGVmaW5lZChfX2NsYW5nX18pICYmICFkZWZpbmVkKF9fSU5URUxfQ09N
UElMRVIpICYmIF9fR05VQ19fID49IDQgJiYgX19HTlVDX01JTk9SX18gPj0gNykKKyNpZiAhKGRl
ZmluZWQoX19HTlVDX18pICYmICFkZWZpbmVkKF9fY2xhbmdfXykgJiYgIWRlZmluZWQoX19JTlRF
TF9DT01QSUxFUikgJiYgKF9fR05VQ19fID49IDQgfHwgKF9fR05VQ19fID09IDQgJiYgX19HTlVD
X01JTk9SX18gPj0gNykpKQogI2Vycm9yIE5vdCBhIHN1cHBvcnRlZCBHQ0MgY29tcGlsZXIKICNl
bmRpZgogXSldLCBbY19jb21waWxlcj0iZ2NjIl0sIFtdKQogQUNfQ09NUElMRV9JRkVMU0UoW0FD
X0xBTkdfUFJPR1JBTShbCi0jaWYgIShkZWZpbmVkKF9fY2xhbmdfXykgJiYgX19jbGFuZ19tYWpv
cl9fID49IDMgJiYgX19jbGFuZ19taW5vcl9fID49IDMpCisjaWYgIShkZWZpbmVkKF9fY2xhbmdf
XykgJiYgKF9fYXBwbGVfYnVpbGRfdmVyc2lvbl9fID49IDQyNTAwMjQgfHwgKCFkZWZpbmVkKF9f
YXBwbGVfYnVpbGRfdmVyc2lvbl9fKSAmJiAoX19jbGFuZ19tYWpvcl9fID4gMyB8fCAoX19jbGFu
Z19tYWpvcl9fID09IDMgJiYgX19jbGFuZ19taW5vcl9fID49IDMpKSkpKQogI2Vycm9yIE5vdCBh
IHN1cHBvcnRlZCBDbGFuZyBjb21waWxlcgogI2VuZGlmCiBdKV0sIFtjX2NvbXBpbGVyPSJjbGFu
ZyJdLCBbXSkKQEAgLTEwNiwxMiArMTA2LDEyIEBACiBjeHhfY29tcGlsZXI9InVua25vd24iCiBB
Q19MQU5HX1BVU0goW0MrK10pCiBBQ19DT01QSUxFX0lGRUxTRShbQUNfTEFOR19QUk9HUkFNKFsK
LSNpZiAhKGRlZmluZWQoX19HTlVHX18pICYmIGRlZmluZWQoX19HTlVDX18pICYmICFkZWZpbmVk
KF9fY2xhbmdfXykgJiYgIWRlZmluZWQoX19JTlRFTF9DT01QSUxFUikgJiYgX19HTlVDX18gPj0g
NCAmJiBfX0dOVUNfTUlOT1JfXyA+PSA3KQorI2lmICEoZGVmaW5lZChfX0dOVUdfXykgJiYgZGVm
aW5lZChfX0dOVUNfXykgJiYgIWRlZmluZWQoX19jbGFuZ19fKSAmJiAhZGVmaW5lZChfX0lOVEVM
X0NPTVBJTEVSKSAmJiAoX19HTlVDX18gPj0gNCB8fCAoX19HTlVDX18gPT0gNCAmJiBfX0dOVUNf
TUlOT1JfXyA+PSA3KSkpCiAjZXJyb3IgTm90IGEgc3VwcG9ydGVkIEcrKyBjb21waWxlcgogI2Vu
ZGlmCiBdKV0sIFtjeHhfY29tcGlsZXI9ImcrKyJdLCBbXSkKIEFDX0NPTVBJTEVfSUZFTFNFKFtB
Q19MQU5HX1BST0dSQU0oWwotI2lmICEoZGVmaW5lZChfX2NsYW5nX18pICYmIF9fY2xhbmdfbWFq
b3JfXyA+PSAzICYmIF9fY2xhbmdfbWlub3JfXyA+PSAzKQorI2lmICEoZGVmaW5lZChfX2NsYW5n
X18pICYmIChfX2FwcGxlX2J1aWxkX3ZlcnNpb25fXyA+PSA0MjUwMDI0IHx8ICghZGVmaW5lZChf
X2FwcGxlX2J1aWxkX3ZlcnNpb25fXykgJiYgKF9fY2xhbmdfbWFqb3JfXyA+IDMgfHwgKF9fY2xh
bmdfbWFqb3JfXyA9PSAzICYmIF9fY2xhbmdfbWlub3JfXyA+PSAzKSkpKSkKICNlcnJvciBOb3Qg
YSBzdXBwb3J0ZWQgQ2xhbmcrKyBjb21waWxlcgogI2VuZGlmCiBdKV0sIFtjeHhfY29tcGlsZXI9
ImNsYW5nKysiXSwgW10p
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>239312</attachid>
            <date>2014-10-05 20:17:18 -0700</date>
            <delta_ts>2015-04-07 02:29:12 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-126324-20141005201717.patch</filename>
            <type>text/plain</type>
            <size>2621</size>
            <attacher name="Philip Chimento">philip.chimento</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDMz
NSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEw
LTA1ICBQaGlsaXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAg
ICAgIGNvbmZpZ3VyZSBjaGVjayBmb3IgY2xhbmcgdmVyc2lvbiBpcyBpbmNvcnJlY3QKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjMyNAorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2F1dG90
b29scy9DaGVja1N5c3RlbUFuZEJhc2ljRGVwZW5kZW5jaWVzLm00OgorICAgICAgICBDaGFuZ2Ug
Y29tcGlsZXIgdmVyc2lvbiBjaGVja3Mgb2YgQ2xhbmcgYW5kIEdDQyBzbyB0aGF0IHRoZXkKKyAg
ICAgICAgaGFuZGxlIG1ham9yL21pbm9yIHZlcnNpb25zIGNvcnJlY3RseS4KKwogMjAxNC0wNy0x
MSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAg
W0dUS10gRW5hYmxlIFZJREVPX1RSQUNLIGJ5IGRlZmF1bHQKSW5kZXg6IFNvdXJjZS9hdXRvdG9v
bHMvQ2hlY2tTeXN0ZW1BbmRCYXNpY0RlcGVuZGVuY2llcy5tNAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy
Y2UvYXV0b3Rvb2xzL0NoZWNrU3lzdGVtQW5kQmFzaWNEZXBlbmRlbmNpZXMubTQJKHJldmlzaW9u
IDE3NDMwNykKKysrIFNvdXJjZS9hdXRvdG9vbHMvQ2hlY2tTeXN0ZW1BbmRCYXNpY0RlcGVuZGVu
Y2llcy5tNAkod29ya2luZyBjb3B5KQpAQCAtODcsMTIgKzg3LDEyIEBAIEFDX1NZU19MQVJHRUZJ
TEUKIGNfY29tcGlsZXI9InVua25vd24iCiBBQ19MQU5HX1BVU0goW0NdKQogQUNfQ09NUElMRV9J
RkVMU0UoW0FDX0xBTkdfUFJPR1JBTShbCi0jaWYgIShkZWZpbmVkKF9fR05VQ19fKSAmJiAhZGVm
aW5lZChfX2NsYW5nX18pICYmICFkZWZpbmVkKF9fSU5URUxfQ09NUElMRVIpICYmIF9fR05VQ19f
ID49IDQgJiYgX19HTlVDX01JTk9SX18gPj0gNykKKyNpZiAhKGRlZmluZWQoX19HTlVDX18pICYm
ICFkZWZpbmVkKF9fY2xhbmdfXykgJiYgIWRlZmluZWQoX19JTlRFTF9DT01QSUxFUikgJiYgKF9f
R05VQ19fID4gNCB8fCAoX19HTlVDX18gPT0gNCAmJiBfX0dOVUNfTUlOT1JfXyA+PSA3KSkpCiAj
ZXJyb3IgTm90IGEgc3VwcG9ydGVkIEdDQyBjb21waWxlcgogI2VuZGlmCiBdKV0sIFtjX2NvbXBp
bGVyPSJnY2MiXSwgW10pCiBBQ19DT01QSUxFX0lGRUxTRShbQUNfTEFOR19QUk9HUkFNKFsKLSNp
ZiAhKGRlZmluZWQoX19jbGFuZ19fKSAmJiBfX2NsYW5nX21ham9yX18gPj0gMyAmJiBfX2NsYW5n
X21pbm9yX18gPj0gMykKKyNpZiAhKGRlZmluZWQoX19jbGFuZ19fKSAmJiAoX19hcHBsZV9idWls
ZF92ZXJzaW9uX18gPj0gNDI1MDAyNCB8fCAoIWRlZmluZWQoX19hcHBsZV9idWlsZF92ZXJzaW9u
X18pICYmIChfX2NsYW5nX21ham9yX18gPiAzIHx8IChfX2NsYW5nX21ham9yX18gPT0gMyAmJiBf
X2NsYW5nX21pbm9yX18gPj0gMykpKSkpCiAjZXJyb3IgTm90IGEgc3VwcG9ydGVkIENsYW5nIGNv
bXBpbGVyCiAjZW5kaWYKIF0pXSwgW2NfY29tcGlsZXI9ImNsYW5nIl0sIFtdKQpAQCAtMTA2LDEy
ICsxMDYsMTIgQEAgZmkKIGN4eF9jb21waWxlcj0idW5rbm93biIKIEFDX0xBTkdfUFVTSChbQysr
XSkKIEFDX0NPTVBJTEVfSUZFTFNFKFtBQ19MQU5HX1BST0dSQU0oWwotI2lmICEoZGVmaW5lZChf
X0dOVUdfXykgJiYgZGVmaW5lZChfX0dOVUNfXykgJiYgIWRlZmluZWQoX19jbGFuZ19fKSAmJiAh
ZGVmaW5lZChfX0lOVEVMX0NPTVBJTEVSKSAmJiBfX0dOVUNfXyA+PSA0ICYmIF9fR05VQ19NSU5P
Ul9fID49IDcpCisjaWYgIShkZWZpbmVkKF9fR05VR19fKSAmJiBkZWZpbmVkKF9fR05VQ19fKSAm
JiAhZGVmaW5lZChfX2NsYW5nX18pICYmICFkZWZpbmVkKF9fSU5URUxfQ09NUElMRVIpICYmIChf
X0dOVUNfXyA+IDQgfHwgKF9fR05VQ19fID09IDQgJiYgX19HTlVDX01JTk9SX18gPj0gNykpKQog
I2Vycm9yIE5vdCBhIHN1cHBvcnRlZCBHKysgY29tcGlsZXIKICNlbmRpZgogXSldLCBbY3h4X2Nv
bXBpbGVyPSJnKysiXSwgW10pCiBBQ19DT01QSUxFX0lGRUxTRShbQUNfTEFOR19QUk9HUkFNKFsK
LSNpZiAhKGRlZmluZWQoX19jbGFuZ19fKSAmJiBfX2NsYW5nX21ham9yX18gPj0gMyAmJiBfX2Ns
YW5nX21pbm9yX18gPj0gMykKKyNpZiAhKGRlZmluZWQoX19jbGFuZ19fKSAmJiAoX19hcHBsZV9i
dWlsZF92ZXJzaW9uX18gPj0gNDI1MDAyNCB8fCAoIWRlZmluZWQoX19hcHBsZV9idWlsZF92ZXJz
aW9uX18pICYmIChfX2NsYW5nX21ham9yX18gPiAzIHx8IChfX2NsYW5nX21ham9yX18gPT0gMyAm
JiBfX2NsYW5nX21pbm9yX18gPj0gMykpKSkpCiAjZXJyb3IgTm90IGEgc3VwcG9ydGVkIENsYW5n
KysgY29tcGlsZXIKICNlbmRpZgogXSldLCBbY3h4X2NvbXBpbGVyPSJjbGFuZysrIl0sIFtdKQo=
</data>
<flag name="review"
          id="264032"
          type_id="1"
          status="+"
          setter="cgarcia"
    />
    <flag name="commit-queue"
          id="275078"
          type_id="3"
          status="-"
          setter="cgarcia"
    />
          </attachment>
      

    </bug>

</bugzilla>