126323 2013-12-30 21:10:59 -0800 Tools/gtk/generate-feature-defines-files doesn't work with older versions of python 2014-01-16 06:56:54 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jeremyhu webkit-unassigned commit-queue evab.u-szeged galpeter ossy oldest_to_newest 963446 0 jeremyhu 2013-12-30 21:10:59 -0800 With Leopard's python (2.5.1), this script fails: Tools/gtk/generate-feature-defines-files Tools/gtk/generate-feature-defines-files:13: Warning: 'with' will become a reserved keyword in Python 2.6 File "Tools/gtk/generate-feature-defines-files", line 13 with open(feature_defines_overriding_file) as f: ^ SyntaxError: invalid syntax This causes build failures down the line due to missing headers. You should have this cause an error during configure. 968265 1 221256 evab.u-szeged 2014-01-15 03:49:56 -0800 Created attachment 221256 Patch 968649 2 galpeter 2014-01-16 01:23:56 -0800 LGTM 968732 3 221256 ossy 2014-01-16 06:44:31 -0800 Comment on attachment 221256 Patch r=me 968739 4 221256 commit-queue 2014-01-16 06:56:52 -0800 Comment on attachment 221256 Patch Clearing flags on attachment: 221256 Committed r162125: <http://trac.webkit.org/changeset/162125> 968740 5 commit-queue 2014-01-16 06:56:54 -0800 All reviewed patches have been landed. Closing bug. 221256 2014-01-15 03:49:56 -0800 2014-01-16 06:56:52 -0800 Patch bug-126323-20140115124955.patch text/plain 1068 evab.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMDYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzFhYzk5YWM0MmE0MDk0YTRkMjRmNWEzYzBiMTNkZTNj YmY0NjA3Ny4uZWU4YWI1MGY1MTg4OTM1OGQ0MzNkNTczMmMzYTA4MjM1ZTZhOTEzMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE0LTAxLTE1ICBFdmEgQmFsYXpzZmFsdmkgIDxiYWxhenNmYWx2aS5ldmFAc3R1ZC51 LXN6ZWdlZC5odT4KKworICAgICAgICBUb29scy9ndGsvZ2VuZXJhdGUtZmVhdHVyZS1kZWZpbmVz LWZpbGVzIGRvZXNuJ3Qgd29yayB3aXRoIG9sZGVyIHZlcnNpb25zIG9mIHB5dGhvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MzIzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBndGsvZ2VuZXJhdGUt ZmVhdHVyZS1kZWZpbmVzLWZpbGVzOgorCiAyMDE0LTAxLTE1ICBDaGFuZ1Nlb2sgT2ggIDxjaGFu Z3Nlb2sub2hAY29sbGFib3JhLmNvbT4KIAogICAgICAgICBbRUZMXSBDaGFuZ2UgdGVzdCBmb250 IGluc3RhbGxlZCBwYXRoIHRvIHdlYmtpdGd0ay1mb250LXRlc3RzCmRpZmYgLS1naXQgYS9Ub29s cy9ndGsvZ2VuZXJhdGUtZmVhdHVyZS1kZWZpbmVzLWZpbGVzIGIvVG9vbHMvZ3RrL2dlbmVyYXRl LWZlYXR1cmUtZGVmaW5lcy1maWxlcwppbmRleCBmNWIyYzdlNjFlYWIxMmJmMGViMjViMGY5YzU5 NWYyZmQ4M2ViYmU5Li4xN2Q1MmU2NWE0NTBlMzY4N2Q4ZjgwYTcyOTE3ZGRlYzM0YTA4Y2FhIDEw MDc1NQotLS0gYS9Ub29scy9ndGsvZ2VuZXJhdGUtZmVhdHVyZS1kZWZpbmVzLWZpbGVzCisrKyBi L1Rvb2xzL2d0ay9nZW5lcmF0ZS1mZWF0dXJlLWRlZmluZXMtZmlsZXMKQEAgLTEsNSArMSw1IEBA CiAjIS91c3IvYmluL2VudiBweXRob24KLQorZnJvbSBfX2Z1dHVyZV9fIGltcG9ydCB3aXRoX3N0 YXRlbWVudAogaW1wb3J0IG9zCiBpbXBvcnQgcmUKIGltcG9ydCBzeXMK