126308 2013-12-30 15:22:51 -0800 Move more of Connection over to STL threading primitives 2013-12-30 22:49:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 126332 1 andersca andersca commit-queue oldest_to_newest 963389 0 andersca 2013-12-30 15:22:51 -0800 Move more of Connection over to STL threading primitives 963390 1 220130 andersca 2013-12-30 15:25:16 -0800 Created attachment 220130 Patch 963391 2 commit-queue 2013-12-30 15:28:16 -0800 Attachment 220130 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/IPC/Connection.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebKit2/Platform/IPC/Connection.cpp:60: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 963394 3 220130 kling 2013-12-30 15:36:26 -0800 Comment on attachment 220130 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220130&action=review r=me > Source/WebKit2/Platform/IPC/Connection.cpp:597 > - timedOut = currentTime() >= absoluteTime; > + timedOut = std::chrono::steady_clock::now() >= timeoutTime; Oh god why. 963395 4 andersca 2013-12-30 15:42:51 -0800 Committed r161157: <http://trac.webkit.org/changeset/161157> 963471 5 commit-queue 2013-12-30 22:47:23 -0800 Re-opened since this is blocked by bug 126332 963474 6 220130 ap 2013-12-30 22:49:41 -0800 Comment on attachment 220130 Patch Rolling out, because Mountain Lion is still broken after follow-up fixes: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20(Tests)?numbuilds=50 220130 2013-12-30 15:25:16 -0800 2013-12-30 22:49:41 -0800 Patch bug-126308-20131230152516.patch text/plain 5358 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDVlZTVkMzc3NjA0NDM5 NmZmODdjMzVmY2QzOTU3ZjRjNzQwODYwOC4uNTMzNGJmMzNlOTY5MmM2NmVlMTg1ZDgyMWZlYTVk NDM0NzQyZmFiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMyIEBACiAyMDEzLTEyLTMwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgTW92ZSBtb3JlIG9m IENvbm5lY3Rpb24gb3ZlciB0byBTVEwgdGhyZWFkaW5nIHByaW1pdGl2ZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjMwOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUGxhdGZvcm0vSVBDL0Nvbm5l Y3Rpb24uY3BwOgorICAgICAgICAoSVBDOjpCaW5hcnlTZW1hcGhvcmU6OkJpbmFyeVNlbWFwaG9y ZSk6CisgICAgICAgIChJUEM6OkJpbmFyeVNlbWFwaG9yZTo6fkJpbmFyeVNlbWFwaG9yZSk6Cisg ICAgICAgIChJUEM6OkJpbmFyeVNlbWFwaG9yZTo6c2lnbmFsKToKKyAgICAgICAgKElQQzo6Qmlu YXJ5U2VtYXBob3JlOjp3YWl0KToKKyAgICAgICAgQWRkIGEgbmV3IEJpbmFyeVNlbWFwaG9yZSBj bGFzcyB0aGF0IHVzZXMgU1RMIHRocmVhZGluZyBwcmltaXRpdmVzLgorCisgICAgICAgIChJUEM6 OkNvbm5lY3Rpb246OlN5bmNNZXNzYWdlU3RhdGU6OndhaXQpOgorICAgICAgICBDaGFuZ2UgdGhp cyB0byB0YWtlIGEgc3RkOjpjaHJvbm86OnN0ZWFkeV9jbG9jazo6dGltZV9wb2ludC4KKworICAg ICAgICAoSVBDOjphYnNvbHV0ZVRpbWVvdXRUaW1lKToKKyAgICAgICAgQWRkIGEgbmV3IGhlbHBl ciBmdW5jdGlvbiB0aGF0IHJldHVybnMgYSB0aW1lIHBvaW50IGZyb20gdGhlIGEgZ2l2ZW4gdGlt ZW91dCBkdXJhdGlvbiwKKyAgICAgICAgY29ycmVjdGx5IGhhbmRsaW5nIHRoZSBtYXggZHVyYXRp b24uCisKKyAgICAgICAgKElQQzo6Q29ubmVjdGlvbjo6c2VuZFN5bmNNZXNzYWdlRnJvbVNlY29u ZGFyeVRocmVhZCk6CisgICAgICAgIFBhc3MgYSB0aW1lIHBvaW50IHRvIFN5bmNNZXNzYWdlU3Rh dGU6OndhaXQuCisKKyAgICAgICAgKElQQzo6Q29ubmVjdGlvbjo6d2FpdEZvclN5bmNSZXBseSk6 CisgICAgICAgIERpdHRvLgorCisyMDEzLTEyLTMwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNj YUBhcHBsZS5jb20+CisKICAgICAgICAgVXNlIHN0ZDo6Y2hyb25vOjptaWxsaXNlY29uZHMgZm9y IGFsbCBJUEMgbWVzc2FnZSB0aW1lb3V0cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MzAzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtL0lQQy9Db25uZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9D b25uZWN0aW9uLmNwcAppbmRleCA0NmQxMzhjMmE5MTM1Yzk3OWJiZTA5Y2QyNWRmODRkNTBmNDdi NzY5Li5mMWMwODM2YjM0NjZlZTJkOTMxMDUzYzRiOGE0MmI2MmNlMjkxN2QwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwCkBAIC0zMSwxMCArMzEsNDQgQEAK ICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KICNpbmNsdWRlIDx3dGYvUnVuTG9vcC5o PgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgotI2luY2x1ZGUgPHd0Zi90aHJlYWRz L0JpbmFyeVNlbWFwaG9yZS5oPgogCiBuYW1lc3BhY2UgSVBDIHsKIAorY2xhc3MgQmluYXJ5U2Vt YXBob3JlIHsKK3B1YmxpYzoKKyAgICBCaW5hcnlTZW1hcGhvcmUoKQorICAgICAgICA6IG1faXNT ZXQoZmFsc2UpCisgICAgeworICAgIH0KKyAgICAKKyAgICB+QmluYXJ5U2VtYXBob3JlKCkKKyAg ICB7CisgICAgfQorCisgICAgdm9pZCBzaWduYWwoKQorICAgIHsKKyAgICAgICAgc3RkOjpsb2Nr X2d1YXJkPHN0ZDo6bXV0ZXg+IGxvY2sobV9tdXRleCk7CisgICAgCisgICAgICAgIG1faXNTZXQg PSB0cnVlOworICAgICAgICBtX2NvbmRpdGlvblZhcmlhYmxlLm5vdGlmeV9hbGwoKTsKKyAgICB9 CisgICAgCisgICAgYm9vbCB3YWl0KHN0ZDo6Y2hyb25vOjpzdGVhZHlfY2xvY2s6OnRpbWVfcG9p bnQgYWJzb2x1dGVUaW1lKQorICAgIHsKKyAgICAgICAgc3RkOjp1bmlxdWVfbG9jazxzdGQ6Om11 dGV4PiBsb2NrKG1fbXV0ZXgpOworICAgIAorICAgICAgICBib29sIHZhbHVlID0gbV9jb25kaXRp b25WYXJpYWJsZS53YWl0X3VudGlsKGxvY2ssIGFic29sdXRlVGltZSwgW3RoaXNdIHsgcmV0dXJu IG1faXNTZXQ7IH0pOworICAgICAgICAKKyAgICAgICAgcmV0dXJuIHZhbHVlOworICAgIH0KKwor cHJpdmF0ZToKKyAgICBib29sIG1faXNTZXQ7CisgICAgCisgICAgc3RkOjptdXRleCBtX211dGV4 OworICAgIHN0ZDo6Y29uZGl0aW9uX3ZhcmlhYmxlIG1fY29uZGl0aW9uVmFyaWFibGU7Cit9Owor CiBjbGFzcyBDb25uZWN0aW9uOjpTeW5jTWVzc2FnZVN0YXRlIDogcHVibGljIFRocmVhZFNhZmVS ZWZDb3VudGVkPENvbm5lY3Rpb246OlN5bmNNZXNzYWdlU3RhdGU+IHsKIHB1YmxpYzoKICAgICBz dGF0aWMgUGFzc1JlZlB0cjxTeW5jTWVzc2FnZVN0YXRlPiBnZXRPckNyZWF0ZShSdW5Mb29wKik7 CkBAIC00NSw3ICs3OSw3IEBAIHB1YmxpYzoKICAgICAgICAgbV93YWl0Rm9yU3luY1JlcGx5U2Vt YXBob3JlLnNpZ25hbCgpOwogICAgIH0KIAotICAgIGJvb2wgd2FpdChkb3VibGUgYWJzb2x1dGVU aW1lKQorICAgIGJvb2wgd2FpdChzdGQ6OmNocm9ubzo6c3RlYWR5X2Nsb2NrOjp0aW1lX3BvaW50 IGFic29sdXRlVGltZSkKICAgICB7CiAgICAgICAgIHJldHVybiBtX3dhaXRGb3JTeW5jUmVwbHlT ZW1hcGhvcmUud2FpdChhYnNvbHV0ZVRpbWUpOwogICAgIH0KQEAgLTM3Niw2ICs0MTAsMTUgQEAg Ym9vbCBDb25uZWN0aW9uOjpzZW5kU3luY1JlcGx5KHN0ZDo6dW5pcXVlX3B0cjxNZXNzYWdlRW5j b2Rlcj4gZW5jb2RlcikKICAgICByZXR1cm4gc2VuZE1lc3NhZ2Uoc3RkOjptb3ZlKGVuY29kZXIp KTsKIH0KIAorc3RhdGljIHN0ZDo6Y2hyb25vOjpzdGVhZHlfY2xvY2s6OnRpbWVfcG9pbnQgYWJz b2x1dGVUaW1lb3V0VGltZShzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzIHRpbWVvdXQpCit7Cisg ICAgLy8gV2UgdXNlIHN0ZDo6Y2hyb25vOjptaWxsaXNlY29uZHM6Om1heCgpIHRvIG1lYW4gbm8g dGltZW91dC4KKyAgICBpZiAodGltZW91dCA9PSBzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzOjpt YXgoKSkKKyAgICAgICAgcmV0dXJuIHN0ZDo6Y2hyb25vOjpzdGVhZHlfY2xvY2s6OnRpbWVfcG9p bnQ6Om1heCgpOworICAgIAorICAgIHJldHVybiBzdGQ6OmNocm9ubzo6c3RlYWR5X2Nsb2NrOjpu b3coKSArIHRpbWVvdXQ7Cit9CisgICAgCiBzdGQ6OnVuaXF1ZV9wdHI8TWVzc2FnZURlY29kZXI+ IENvbm5lY3Rpb246OndhaXRGb3JNZXNzYWdlKFN0cmluZ1JlZmVyZW5jZSBtZXNzYWdlUmVjZWl2 ZXJOYW1lLCBTdHJpbmdSZWZlcmVuY2UgbWVzc2FnZU5hbWUsIHVpbnQ2NF90IGRlc3RpbmF0aW9u SUQsIHN0ZDo6Y2hyb25vOjptaWxsaXNlY29uZHMgdGltZW91dCkKIHsKICAgICAvLyBGaXJzdCwg Y2hlY2sgaWYgdGhpcyBtZXNzYWdlIGlzIGFscmVhZHkgaW4gdGhlIGluY29taW5nIG1lc3NhZ2Vz IHF1ZXVlLgpAQCAtNTAwLDcgKzU0Myw4IEBAIHN0ZDo6dW5pcXVlX3B0cjxNZXNzYWdlRGVjb2Rl cj4gQ29ubmVjdGlvbjo6c2VuZFN5bmNNZXNzYWdlRnJvbVNlY29uZGFyeVRocmVhZCh1CiAKICAg ICBzZW5kTWVzc2FnZShzdGQ6Om1vdmUoZW5jb2RlciksIDApOwogCi0gICAgcGVuZGluZ1JlcGx5 LnNlbWFwaG9yZS53YWl0KGN1cnJlbnRUaW1lKCkgKyAodGltZW91dC5jb3VudCgpIC8gMTAwMC4w KSk7CisgICAgYXV0byB0aW1lb3V0VGltZSA9IGFic29sdXRlVGltZW91dFRpbWUodGltZW91dCk7 CisgICAgcGVuZGluZ1JlcGx5LnNlbWFwaG9yZS53YWl0KHRpbWVvdXRUaW1lKTsKIAogICAgIC8v IEZpbmFsbHksIHBvcCB0aGUgcGVuZGluZyBzeW5jIHJlcGx5IGluZm9ybWF0aW9uLgogICAgIHsK QEAgLTUxNCw3ICs1NTgsNyBAQCBzdGQ6OnVuaXF1ZV9wdHI8TWVzc2FnZURlY29kZXI+IENvbm5l Y3Rpb246OnNlbmRTeW5jTWVzc2FnZUZyb21TZWNvbmRhcnlUaHJlYWQodQogCiBzdGQ6OnVuaXF1 ZV9wdHI8TWVzc2FnZURlY29kZXI+IENvbm5lY3Rpb246OndhaXRGb3JTeW5jUmVwbHkodWludDY0 X3Qgc3luY1JlcXVlc3RJRCwgc3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcyB0aW1lb3V0LCB1bnNp Z25lZCBzeW5jU2VuZEZsYWdzKQogewotICAgIGRvdWJsZSBhYnNvbHV0ZVRpbWUgPSBjdXJyZW50 VGltZSgpICsgKHRpbWVvdXQuY291bnQoKSAvIDEwMDAuMCk7CisgICAgYXV0byB0aW1lb3V0VGlt ZSA9IGFic29sdXRlVGltZW91dFRpbWUodGltZW91dCk7CiAKICAgICBib29sIHRpbWVkT3V0ID0g ZmFsc2U7CiAgICAgd2hpbGUgKCF0aW1lZE91dCkgewpAQCAtNTUwLDEwICs1OTQsMTAgQEAgc3Rk Ojp1bmlxdWVfcHRyPE1lc3NhZ2VEZWNvZGVyPiBDb25uZWN0aW9uOjp3YWl0Rm9yU3luY1JlcGx5 KHVpbnQ2NF90IHN5bmNSZXF1ZXMKICAgICAgICAgICAgIC8vIEZJWE1FOiBBbHRob3VnaCB3ZSBy dW4gZm9yZXZlciwgYW55IGV2ZW50cyBpbmNvbWluZyB3aWxsIGNhdXNlIHVzIHRvIGRyb3Agb3V0 IGFuZCBleGl0IG91dC4gVGhpcyBob3dldmVyIGRvZXNuJ3QKICAgICAgICAgICAgIC8vIGFjY291 bnQgZm9yIGEgdGltZW91dCB2YWx1ZSBwYXNzZWQgaW4uIFRpbWVvdXQgaXMgYWx3YXlzIE5vVGlt ZW91dCBpbiB0aGVzZSBjYXNlcywgYnV0IHRoYXQgY291bGQgY2hhbmdlLgogICAgICAgICAgICAg UnVuTG9vcDo6Y3VycmVudCgpLT5ydW5Gb3JEdXJhdGlvbigxZTEwKTsKLSAgICAgICAgICAgIHRp bWVkT3V0ID0gY3VycmVudFRpbWUoKSA+PSBhYnNvbHV0ZVRpbWU7CisgICAgICAgICAgICB0aW1l ZE91dCA9IHN0ZDo6Y2hyb25vOjpzdGVhZHlfY2xvY2s6Om5vdygpID49IHRpbWVvdXRUaW1lOwog I2VuZGlmCiAgICAgICAgIH0gZWxzZQotICAgICAgICAgICAgdGltZWRPdXQgPSAhbV9zeW5jTWVz c2FnZVN0YXRlLT53YWl0KGFic29sdXRlVGltZSk7CisgICAgICAgICAgICB0aW1lZE91dCA9ICFt X3N5bmNNZXNzYWdlU3RhdGUtPndhaXQodGltZW91dFRpbWUpOwogICAgICAgICAKICAgICB9CiAK