126302 2013-12-30 12:52:49 -0800 RenderButton should store its text renderer in a RenderPtr. 2023-05-10 07:32:22 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 kling kling ahmad.saleem792 commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser zalan oldest_to_newest 963370 0 kling 2013-12-30 12:52:49 -0800 RenderButton should store its text renderer in a RenderPtr. 963372 1 220122 kling 2013-12-30 12:54:02 -0800 Created attachment 220122 Patch 1954100 2 ahmad.saleem792 2023-05-09 12:07:28 -0700 https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderButton.cpp#101 _____ void RenderButton::setText(const String& str) { if (!m_buttonText && str.isEmpty()) return; if (!m_buttonText) { auto newButtonText = createRenderer<RenderTextFragment>(document(), str); m_buttonText = *newButtonText; // FIXME: This mutation should go through the normal RenderTreeBuilder path. if (RenderTreeBuilder::current()) RenderTreeBuilder::current()->attach(*this, WTFMove(newButtonText)); else RenderTreeBuilder(*document().renderView()).attach(*this, WTFMove(newButtonText)); return; } if (!str.isEmpty()) { m_buttonText->setText(str.impl()); return; } if (RenderTreeBuilder::current()) RenderTreeBuilder::current()->destroy(*m_buttonText); else RenderTreeBuilder(*document().renderView()).destroy(*m_buttonText); } _______ The obsolete patch was modify this above function. 1954318 3 zalan 2023-05-10 07:32:22 -0700 This has already been dealt with by switching over to WeakPtr<RenderTextFragment>. 220122 2013-12-30 12:54:02 -0800 2013-12-30 12:56:58 -0800 Patch bug-126302.diff text/plain 2298 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1OGRmODhiLi5jOWFlYjAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUg QEAKIDIwMTMtMTItMzAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFJlbmRlckJ1dHRvbiBzaG91bGQgc3RvcmUgaXRzIHRleHQgcmVuZGVyZXIgaW4gYSBSZW5k ZXJQdHIuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjYzMDI+CisKKyAgICAgICAg TWFrZSBSZW5kZXJCdXR0b246Om1fYnV0dG9uVGV4dCBhIFJlbmRlclB0ciBhbmQgcmVtb3ZlIG9u ZSBtYW51YWwKKyAgICAgICAgZGVzdHJveSgpIGNhbGwuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKzIwMTMtMTItMzAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBw bGUuY29tPgorCiAgICAgICAgIERvY3VtZW50IHNob3VsZCBzdG9yZSBpdHMgUmVuZGVyVmlldyBp biBhIFJlbmRlclB0ci4KICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyNjI5OT4KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJ1dHRvbi5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9uLmNwcAppbmRleCA4Y2Y3M2Y2Li42 YTQ3NmY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9u LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQnV0dG9uLmNwcApAQCAt MzksNyArMzksNiBAQCB1c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogCiBSZW5kZXJCdXR0b246 OlJlbmRlckJ1dHRvbihIVE1MRm9ybUNvbnRyb2xFbGVtZW50JiBlbGVtZW50LCBQYXNzUmVmPFJl bmRlclN0eWxlPiBzdHlsZSkKICAgICA6IFJlbmRlckZsZXhpYmxlQm94KGVsZW1lbnQsIHN0ZDo6 bW92ZShzdHlsZSkpCi0gICAgLCBtX2J1dHRvblRleHQoMCkKICAgICAsIG1faW5uZXIoMCkKICAg ICAsIG1fZGVmYXVsdChmYWxzZSkKIHsKQEAgLTE1MSwxNyArMTUwLDE1IEBAIHZvaWQgUmVuZGVy QnV0dG9uOjp1cGRhdGVGcm9tRWxlbWVudCgpCiB2b2lkIFJlbmRlckJ1dHRvbjo6c2V0VGV4dChj b25zdCBTdHJpbmcmIHN0cikKIHsKICAgICBpZiAoc3RyLmlzRW1wdHkoKSkgewotICAgICAgICBp ZiAobV9idXR0b25UZXh0KSB7Ci0gICAgICAgICAgICBtX2J1dHRvblRleHQtPmRlc3Ryb3koKTsK LSAgICAgICAgICAgIG1fYnV0dG9uVGV4dCA9IDA7Ci0gICAgICAgIH0KLSAgICB9IGVsc2Ugewot ICAgICAgICBpZiAobV9idXR0b25UZXh0KQotICAgICAgICAgICAgbV9idXR0b25UZXh0LT5zZXRU ZXh0KHN0ci5pbXBsKCkpOwotICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgIG1fYnV0dG9uVGV4 dCA9IG5ldyBSZW5kZXJUZXh0RnJhZ21lbnQoZG9jdW1lbnQoKSwgc3RyKTsKLSAgICAgICAgICAg IGFkZENoaWxkKG1fYnV0dG9uVGV4dCk7Ci0gICAgICAgIH0KKyAgICAgICAgbV9idXR0b25UZXh0 ID0gbnVsbHB0cjsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIGlmIChtX2J1dHRvblRl eHQpCisgICAgICAgIG1fYnV0dG9uVGV4dC0+c2V0VGV4dChzdHIuaW1wbCgpKTsKKyAgICBlbHNl IHsKKyAgICAgICAgbV9idXR0b25UZXh0ID0gY3JlYXRlUmVuZGVyT2JqZWN0PFJlbmRlclRleHRG cmFnbWVudD4oZG9jdW1lbnQoKSwgc3RyKTsKKyAgICAgICAgYWRkQ2hpbGQobV9idXR0b25UZXh0 LmdldCgpKTsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCdXR0b24uaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCdXR0b24u aAppbmRleCA1MGUwM2M1MzEuLmQ1YWFlYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCdXR0b24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQnV0dG9uLmgKQEAgLTcyLDcgKzcyLDcgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgdGltZXJG aXJlZChUaW1lcjxSZW5kZXJCdXR0b24+Kik7CiAKLSAgICBSZW5kZXJUZXh0RnJhZ21lbnQqIG1f YnV0dG9uVGV4dDsKKyAgICBSZW5kZXJQdHI8UmVuZGVyVGV4dEZyYWdtZW50PiBtX2J1dHRvblRl eHQ7CiAgICAgUmVuZGVyQmxvY2sqIG1faW5uZXI7CiAKICAgICBPd25QdHI8VGltZXI8UmVuZGVy QnV0dG9uPj4gbV90aW1lcjsK