12630 2007-02-06 01:34:41 -0800 <use> cursor not changing (to hand) on hover 2007-06-01 04:31:14 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED http://www.peepo.co.uk P2 Normal --- 1 jay webkit-unassigned zimmermann oldest_to_newest 26875 0 jay 2007-02-06 01:34:41 -0800 cursor should cahnge to hand on hover over a link in default case. 26876 1 12962 jay 2007-02-06 01:41:34 -0800 Created attachment 12962 look: No Hands 26812 2 12967 eric 2007-02-06 05:00:29 -0800 Created attachment 12967 A much nicer test case 26773 3 eric 2007-02-06 05:02:07 -0800 A few things were wrong with the original test case: 1. it was uploaded as image/svg-xml. That's incorrect. The final SVG 1.1 spec uses image/svg+xml. 2. it used fill='eee', that worked OK in Safari (and would have in IE) but it isn't valid by the SVG spec. fill='#eee' would have been correct. 26776 4 jay 2007-02-06 05:28:27 -0800 bugzilla autodetect for mozilla and safari uploads as image/svg-xml 26779 5 eric 2007-02-06 05:40:10 -0800 The patch attached to bug 12580 is a step in the right direction. However it's still not quite fixed. This shouldn't be hard to fix, but I should probably speak with WildFox first. 26768 6 eric 2007-02-06 05:40:59 -0800 That's odd. When I upload from Safari, bugzilla correctly autodetects image/svg+xml 26758 7 jay 2007-02-06 07:17:37 -0800 likely Opera... 26751 8 ddkilzer 2007-02-06 08:14:41 -0800 (In reply to comment #7) > likely Opera... Usually the operating system plays a role in file types as well. In Windows, it's the registry. In Linux, it's /etc/mime.types. 8473 9 14824 eric 2007-06-01 03:57:55 -0700 Created attachment 14824 fix and manual test I'm pretty certain this is the correct fix. The only thing which could possibly be wrong is if Layer::hitTest has some caller which wouldn't want to know the URLElement ignoring shadow nodes. Such a caller seems highly unlikely since URLElement is only used by link hover code AFAIK. 8474 10 eric 2007-06-01 04:31:14 -0700 Landed as r21937 on the feature-branch. Yet another change which probably should move to TOT. 12962 2007-02-06 01:41:34 -0800 2007-02-06 05:00:29 -0800 look: No Hands bug-webkit-hover.svg image/svg+xml 678 jay PD94bWwgdmVyc2lvbj0nMS4wJyBzdGFuZGFsb25lPSdubyc/Pgo8IURPQ1RZUEUgc3ZnIFBVQkxJ QyAnLS8vVzNDLy9EVEQgU1ZHIDEuMS8vRU4nCiAgJ2h0dHA6Ly93d3cudzMub3JnL0dyYXBoaWNz L1NWRy8xLjEvRFREL3N2ZzExLmR0ZCc+CjxzdmcgeG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzIw MDAvc3ZnJyB4bWxuczp4bGluaz0naHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluaycKICAgd2lk dGg9JzEwMCUnIGhlaWdodD0nMTAwJScgdmlld0JveD0nMCAwIDQ4MCA0NDAnCj4KCjxkZWZzPgo8 c3ltYm9sIGlkPSdyZWN0XzAnIHZpZXdCb3g9IjAgMCAxNTAgMTUwIiAgc3Ryb2tlPSJub25lIiAg ZmlsbD0ibm9uZSI+CiAgICAgIDxyZWN0ICAgICAgeD0nMzUnIGN5PScyNScgd2lkdGg9JzMwMCcg aGVpZ2h0PSIyMDAiIGZpbGw9J2VlZSc+CiAgICAgIDwvcmVjdD4KPC9zeW1ib2w+CjwvZGVmcz4K ICAgCiAgIDxnIHRyYW5zZm9ybT0ndHJhbnNsYXRlKDE3MCwgMTApJyB3aWR0aD0nMzAwJyBoZWln aHQ9IjIwMCIgPgoKIDxhIHhsaW5rOmhyZWY9Imh0dHA6Ly93d3cucGVlcG8uY28udWsiID4NCiAg ICAgICAgICAgIDx1c2UgeGxpbms6aHJlZj0icmVjdF8wIiB4PSIwJSIgeT0iMjUlIiB3aWR0aD0i MjAlIiBoZWlnaHQ9IjMwJSIgZmlsbD0icmVkIiAvPgo8L2E+CjwvZz4KICAgPC9zdmc+ 12967 2007-02-06 05:00:29 -0800 2007-02-06 05:00:29 -0800 A much nicer test case link.svg image/svg+xml 352 eric PHN2ZyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcnIHhtbG5zOnhsaW5rPSdodHRw Oi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rJz4KICA8ZGVmcz4KICAgIDxyZWN0IGlkPSdyZWN0JyB3 aWR0aD0nMTAwJyBoZWlnaHQ9IjEwMCIgZmlsbD0nYmx1ZScgLz4KICA8L2RlZnM+CiAgPGEgeGxp bms6aHJlZj0iaHR0cDovL3d3dy5wZWVwby5jby51ayIgPgogICAgICA8dXNlIHhsaW5rOmhyZWY9 InJlY3QiLz4KICA8L2E+CiAgPHRleHQgeT0nMTIwJyB4PScxMCc+VGhlIGFib3ZlIGJsdWUgc3F1 YXJlIGlzIGEgbGluaywgdGhlIGN1cnNvciBzaG91bGQgYmUgYSBoYW5kIGFib3ZlIGl0LjwvdGV4 dD4KPC9zdmc+Cg== 14824 2007-06-01 03:57:55 -0700 2007-06-01 04:28:30 -0700 fix and manual test hover.patch text/plain 1959 eric SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIxOTM2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDctMDYt MDEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQ3Vyc29yIGRvZXMgbm90IGNoYW5n ZSB0byBoYW5kIG92ZXIgbGlua3MgY29udGFpbmluZyA8dXNlPgorICAgICAgICBodHRwOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYzMAorCisgICAgICAgIFRlc3Q6IG1hbnVh bC10ZXN0cy9zdmctbGluay1ob3Zlci11c2Uuc3ZnCisKKyAgICAgICAgKiBtYW51YWwtdGVzdHMv c3ZnLWxpbmstaG92ZXItdXNlLnN2ZzogQWRkZWQuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpoaXRUZXN0KTogdXNl IGV2ZW50UGFyZW50Tm9kZSBpbnN0ZWFkIG9mIHBhcmVudE5vZGUKKwogMjAwNy0wNi0wMSAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgb2xsaWVq LgpJbmRleDogbWFudWFsLXRlc3RzL3N2Zy1saW5rLWhvdmVyLXVzZS5zdmcKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gbWFudWFsLXRlc3RzL3N2Zy1saW5rLWhvdmVyLXVzZS5zdmcJKHJldmlzaW9uIDApCisrKyBt YW51YWwtdGVzdHMvc3ZnLWxpbmstaG92ZXItdXNlLnN2ZwkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSw5IEBACis8c3ZnIHhtbG5zPSdodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZycgeG1sbnM6eGxp bms9J2h0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsnPgorICA8ZGVmcz4KKyAgICA8cmVjdCBp ZD0ncmVjdCcgd2lkdGg9JzEwMCcgaGVpZ2h0PSIxMDAiIGZpbGw9J2JsdWUnIC8+CisgIDwvZGVm cz4KKyAgPGEgeGxpbms6aHJlZj0iaHR0cDovL3d3dy53ZWJraXQub3JnIiA+CisgICAgICA8dXNl IHhsaW5rOmhyZWY9InJlY3QiIG9ubW91c2VvdmVyPSJhbGVydCgnZm9vJykiIC8+CisgIDwvYT4K KyAgPHRleHQgeT0nMTIwJyB4PScxMCc+VGhlIGFib3ZlIGJsdWUgc3F1YXJlIGlzIGEgbGluaywg dGhlIGN1cnNvciBzaG91bGQgYmUgYSBoYW5kIGFib3ZlIGl0LjwvdGV4dD4KKzwvc3ZnPgpJbmRl eDogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSByZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuY3BwCShyZXZpc2lvbiAyMTkzNSkKKysrIHJlbmRlcmluZy9SZW5kZXJMYXllci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE1NjEsNyArMTU2MSw3IEBAIGJvb2wgUmVuZGVyTGF5ZXI6 OmhpdFRlc3QoY29uc3QgSGl0VGVzdFIKICAgICAgICAgLy8gZm9yIGltYWdlbWFwcywgVVJMRWxl bWVudCBpcyB0aGUgYXNzb2NpYXRlZCBhcmVhIGVsZW1lbnQgbm90IHRoZSBpbWFnZSBpdHNlbGYK ICAgICAgICAgaWYgKG5vZGUtPmlzTGluaygpICYmICFyZXN1bHQuVVJMRWxlbWVudCgpICYmICFu b2RlLT5oYXNUYWdOYW1lKGltZ1RhZykpCiAgICAgICAgICAgICByZXN1bHQuc2V0VVJMRWxlbWVu dChzdGF0aWNfY2FzdDxFbGVtZW50Kj4obm9kZSkpOwotICAgICAgICBub2RlID0gbm9kZS0+cGFy ZW50Tm9kZSgpOworICAgICAgICBub2RlID0gbm9kZS0+ZXZlbnRQYXJlbnROb2RlKCk7CiAgICAg fQogCiAgICAgLy8gTmV4dCBzZXQgdXAgdGhlIGNvcnJlY3QgOmhvdmVyLzphY3RpdmUgc3RhdGUg YWxvbmcgdGhlIG5ldyBjaGFpbi4K