126299 2013-12-30 11:56:07 -0800 Document should store its RenderView in a RenderPtr. 2013-12-30 13:02:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc kangil.han kling oldest_to_newest 963362 0 kling 2013-12-30 11:56:07 -0800 Document should store its RenderView in a RenderPtr. 963363 1 220118 kling 2013-12-30 11:56:40 -0800 Created attachment 220118 Patch 963373 2 kling 2013-12-30 13:02:20 -0800 Committed r161151: <http://trac.webkit.org/changeset/161151> 220118 2013-12-30 11:56:40 -0800 2013-12-30 12:58:39 -0800 Patch bug-126299.diff text/plain 3804 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYzk1MmMyLi41OGRmODhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTMtMTItMzAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIERvY3VtZW50IHNob3VsZCBzdG9yZSBpdHMgUmVuZGVyVmlldyBpbiBhIFJlbmRlclB0ci4K KyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyNjI5OT4KKworICAgICAgICBNYWtlIERv Y3VtZW50OjptX3JlbmRlclZpZXcgYSBSZW5kZXJQdHI8UmVuZGVyVmlldz4gYW5kIHJlbW92ZSBv bmUKKyAgICAgICAgbWFudWFsIGRlc3Ryb3koKSBjYWxsLiBBbHNvIHJlbW92ZWQgdGhlIHNldFJl bmRlclZpZXcoKSBoZWxwZXIgYW5kCisgICAgICAgIGlubGluZWQgaXQgYXQgdGhlIHR3byBjYWxs IHNpdGVzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisyMDEzLTEy LTMwICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKwogICAgICAgICBSZW5kZXJM aXN0SXRlbSBzaG91bGQgc3RvcmUgaXRzIG1hcmtlciBpbiBhIFJlbmRlclB0ci4KICAgICAgICAg PGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyNjI5OD4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5k ZXggOTkzYjNmZi4uMjg1MDY3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3Vt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC00NTcsNyAr NDU3LDYgQEAgRG9jdW1lbnQ6OkRvY3VtZW50KEZyYW1lKiBmcmFtZSwgY29uc3QgVVJMJiB1cmws IHVuc2lnbmVkIGRvY3VtZW50Q2xhc3NlcywgYm9vbAogICAgICwgbV9pc1ZpZXdTb3VyY2UoZmFs c2UpCiAgICAgLCBtX3Nhd0VsZW1lbnRzSW5Lbm93bk5hbWVzcGFjZXMoZmFsc2UpCiAgICAgLCBt X2lzU3JjZG9jRG9jdW1lbnQoZmFsc2UpCi0gICAgLCBtX3JlbmRlclZpZXcobnVsbHB0cikKICAg ICAsIG1fZXZlbnRRdWV1ZSgqdGhpcykKICAgICAsIG1fd2Vha0ZhY3RvcnkodGhpcykKICAgICAs IG1faWRBdHRyaWJ1dGVOYW1lKGlkQXR0cikKQEAgLTE5NDUsMTIgKzE5NDQsNiBAQCB2b2lkIERv Y3VtZW50OjpjbGVhclN0eWxlUmVzb2x2ZXIoKQogICAgIG1fc3R5bGVSZXNvbHZlci5jbGVhcigp OwogfQogCi12b2lkIERvY3VtZW50OjpzZXRSZW5kZXJWaWV3KFJlbmRlclZpZXcqIHJlbmRlclZp ZXcpCi17Ci0gICAgbV9yZW5kZXJWaWV3ID0gcmVuZGVyVmlldzsKLSAgICBOb2RlOjpzZXRSZW5k ZXJlcihyZW5kZXJWaWV3KTsKLX0KLQogdm9pZCBEb2N1bWVudDo6Y3JlYXRlUmVuZGVyVHJlZSgp CiB7CiAgICAgQVNTRVJUKCFyZW5kZXJWaWV3KCkpOwpAQCAtMTk1OCw3ICsxOTUxLDkgQEAgdm9p ZCBEb2N1bWVudDo6Y3JlYXRlUmVuZGVyVHJlZSgpCiAgICAgQVNTRVJUKCFtX2F4T2JqZWN0Q2Fj aGUgfHwgdGhpcyAhPSB0b3BEb2N1bWVudCgpKTsKIAogICAgIC8vIEZJWE1FOiBJdCB3b3VsZCBi ZSBiZXR0ZXIgaWYgd2UgY291bGQgcGFzcyB0aGUgcmVzb2x2ZWQgZG9jdW1lbnQgc3R5bGUgZGly ZWN0bHkgaGVyZS4KLSAgICBzZXRSZW5kZXJWaWV3KG5ldyBSZW5kZXJWaWV3KCp0aGlzLCBSZW5k ZXJTdHlsZTo6Y3JlYXRlKCkpKTsKKyAgICBtX3JlbmRlclZpZXcgPSBjcmVhdGVSZW5kZXJPYmpl Y3Q8UmVuZGVyVmlldz4oKnRoaXMsIFJlbmRlclN0eWxlOjpjcmVhdGUoKSk7CisgICAgTm9kZTo6 c2V0UmVuZGVyZXIobV9yZW5kZXJWaWV3LmdldCgpKTsKKwogI2lmIFVTRShBQ0NFTEVSQVRFRF9D T01QT1NJVElORykKICAgICByZW5kZXJWaWV3KCktPnNldElzSW5XaW5kb3codHJ1ZSk7CiAjZW5k aWYKQEAgLTIwNjIsOSArMjA1Nyw4IEBAIHZvaWQgRG9jdW1lbnQ6OmRlc3Ryb3lSZW5kZXJUcmVl KCkKIAogICAgIHVuc2NoZWR1bGVTdHlsZVJlY2FsYygpOwogCi0gICAgaWYgKHJlbmRlclZpZXco KSkKLSAgICAgICAgcmVuZGVyVmlldygpLT5kZXN0cm95KCk7Ci0gICAgc2V0UmVuZGVyVmlldyhu dWxscHRyKTsKKyAgICBtX3JlbmRlclZpZXcgPSBudWxscHRyOworICAgIE5vZGU6OnNldFJlbmRl cmVyKG51bGxwdHIpOwogCiAjaWYgRU5BQkxFKElPU19URVhUX0FVVE9TSVpJTkcpCiAgICAgLy8g RG8gdGhpcyBiZWZvcmUgdGhlIGFyZW5hIGlzIGNsZWFyZWQsIHdoaWNoIGlzIG5lZWRlZCB0byBk ZXJlZiB0aGUgUmVuZGVyU3R5bGUgb24gVGV4dEF1dG9TaXppbmdLZXkuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5oCmluZGV4IDcwOWU2MWYuLjc2OGQzOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC00Myw2 ICs0Myw3IEBACiAjaW5jbHVkZSAiUGxhdGZvcm1TY3JlZW4uaCIKICNpbmNsdWRlICJRdWFsaWZp ZWROYW1lLmgiCiAjaW5jbHVkZSAiUmVmZXJyZXJQb2xpY3kuaCIKKyNpbmNsdWRlICJSZW5kZXJQ dHIuaCIKICNpbmNsdWRlICJTY3JpcHRFeGVjdXRpb25Db250ZXh0LmgiCiAjaW5jbHVkZSAiU3Ry aW5nV2l0aERpcmVjdGlvbi5oIgogI2luY2x1ZGUgIlN0eWxlUmVzb2x2ZVRyZWUuaCIKQEAgLTU2 NSw3ICs1NjYsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHJlc3VtZUFjdGl2ZURPTU9i amVjdHMoQWN0aXZlRE9NT2JqZWN0OjpSZWFzb25Gb3JTdXNwZW5zaW9uKSBPVkVSUklERTsKICAg ICB2aXJ0dWFsIHZvaWQgc3RvcEFjdGl2ZURPTU9iamVjdHMoKSBPVkVSUklERTsKIAotICAgIFJl bmRlclZpZXcqIHJlbmRlclZpZXcoKSBjb25zdCB7IHJldHVybiBtX3JlbmRlclZpZXc7IH0KKyAg ICBSZW5kZXJWaWV3KiByZW5kZXJWaWV3KCkgY29uc3QgeyByZXR1cm4gbV9yZW5kZXJWaWV3Lmdl dCgpOyB9CiAKICAgICBib29sIHJlbmRlclRyZWVCZWluZ0Rlc3Ryb3llZCgpIGNvbnN0IHsgcmV0 dXJuIG1fcmVuZGVyVHJlZUJlaW5nRGVzdHJveWVkOyB9CiAgICAgYm9vbCBoYXNMaXZpbmdSZW5k ZXJUcmVlKCkgY29uc3QgeyByZXR1cm4gcmVuZGVyVmlldygpICYmICFyZW5kZXJUcmVlQmVpbmdE ZXN0cm95ZWQoKTsgfQpAQCAtMTIzMyw3ICsxMjM0LDYgQEAgcHJpdmF0ZToKIAogICAgIFJlbmRl ck9iamVjdCogcmVuZGVyZXIoKSBjb25zdCBXVEZfREVMRVRFRF9GVU5DVElPTjsKICAgICB2b2lk IHNldFJlbmRlcmVyKFJlbmRlck9iamVjdCopIFdURl9ERUxFVEVEX0ZVTkNUSU9OOwotICAgIHZv aWQgc2V0UmVuZGVyVmlldyhSZW5kZXJWaWV3Kik7CiAKICAgICB2aXJ0dWFsIHZvaWQgY3JlYXRl UmVuZGVyVHJlZSgpOwogICAgIHZpcnR1YWwgdm9pZCBkcm9wQ2hpbGRyZW4oKSBPVkVSUklERTsK QEAgLTE1MDIsNyArMTUwMiw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX3Nhd0VsZW1lbnRzSW5L bm93bk5hbWVzcGFjZXM7CiAgICAgYm9vbCBtX2lzU3JjZG9jRG9jdW1lbnQ7CiAKLSAgICBSZW5k ZXJWaWV3KiBtX3JlbmRlclZpZXc7CisgICAgUmVuZGVyUHRyPFJlbmRlclZpZXc+IG1fcmVuZGVy VmlldzsKICAgICBtdXRhYmxlIERvY3VtZW50RXZlbnRRdWV1ZSBtX2V2ZW50UXVldWU7CiAKICAg ICBXZWFrUHRyRmFjdG9yeTxEb2N1bWVudD4gbV93ZWFrRmFjdG9yeTsK