126298 2013-12-30 10:49:52 -0800 RenderListItem should store its marker in a RenderPtr. 2013-12-31 08:13:05 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling buildbot commit-queue esprehn+autocc glenn kling kondapallykalyan rniwa oldest_to_newest 963352 0 kling 2013-12-30 10:49:52 -0800 RenderListItem should store its marker in a RenderPtr. 963355 1 220117 kling 2013-12-30 11:15:33 -0800 Created attachment 220117 Patch 963396 2 220117 buildbot 2013-12-30 16:02:31 -0800 Comment on attachment 220117 Patch Attachment 220117 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6297786244923392 963520 3 kling 2013-12-31 08:13:05 -0800 Committed r161183: <http://trac.webkit.org/changeset/161183> 220117 2013-12-30 11:15:33 -0800 2013-12-30 16:02:31 -0800 Patch bug-126298.diff text/plain 5119 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwZWIxM2M1Li5mYzk1MmMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUg QEAKIDIwMTMtMTItMzAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFJlbmRlckxpc3RJdGVtIHNob3VsZCBzdG9yZSBpdHMgbWFya2VyIGluIGEgUmVuZGVyUHRy LgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI2Mjk4PgorCisgICAgICAgIE1ha2Ug UmVuZGVyTGlzdEl0ZW06Om1fbWFya2VyIGEgUmVuZGVyUHRyPFJlbmRlckxpc3RNYXJrZXI+IGFu ZAorICAgICAgICByZW1vdmUgdHdvIG1hbnVhbCBkZXN0cm95KCkgY2FsbHMuIFR3ZWFrZWQgY29k ZSB0byByZWR1Y2UgbmVzdGluZy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworMjAxMy0xMi0zMCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CisKICAg ICAgICAgVGV4dDo6Y3JlYXRlVGV4dFJlbmRlcmVyKCkgc2hvdWxkIHJldHVybiBhIFJlbmRlclB0 ci4KICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyNjI5Mj4KIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJdGVtLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5jcHAKaW5kZXggYWFmZWQyZi4uZDMzMTg1NCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJdGVtLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3BwCkBAIC00Miw3 ICs0Miw2IEBAIHVzaW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7CiAKIFJlbmRlckxpc3RJdGVtOjpS ZW5kZXJMaXN0SXRlbShFbGVtZW50JiBlbGVtZW50LCBQYXNzUmVmPFJlbmRlclN0eWxlPiBzdHls ZSkKICAgICA6IFJlbmRlckJsb2NrRmxvdyhlbGVtZW50LCBzdGQ6Om1vdmUoc3R5bGUpKQotICAg ICwgbV9tYXJrZXIoMCkKICAgICAsIG1faGFzRXhwbGljaXRWYWx1ZShmYWxzZSkKICAgICAsIG1f aXNWYWx1ZVVwVG9EYXRlKGZhbHNlKQogICAgICwgbV9ub3RJbkxpc3QoZmFsc2UpCkBAIC01NCwy OSArNTMsMjUgQEAgdm9pZCBSZW5kZXJMaXN0SXRlbTo6c3R5bGVEaWRDaGFuZ2UoU3R5bGVEaWZm ZXJlbmNlIGRpZmYsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGQKIHsKICAgICBSZW5kZXJCbG9ja0Zs b3c6OnN0eWxlRGlkQ2hhbmdlKGRpZmYsIG9sZFN0eWxlKTsKIAotICAgIGlmIChzdHlsZSgpLmxp c3RTdHlsZVR5cGUoKSAhPSBOb25lTGlzdFN0eWxlCi0gICAgICAgIHx8IChzdHlsZSgpLmxpc3RT dHlsZUltYWdlKCkgJiYgIXN0eWxlKCkubGlzdFN0eWxlSW1hZ2UoKS0+ZXJyb3JPY2N1cnJlZCgp KSkgewotICAgICAgICBhdXRvIG5ld1N0eWxlID0gUmVuZGVyU3R5bGU6OmNyZWF0ZSgpOwotICAg ICAgICAvLyBUaGUgbWFya2VyIGFsd2F5cyBpbmhlcml0cyBmcm9tIHRoZSBsaXN0IGl0ZW0sIHJl Z2FyZGxlc3Mgb2Ygd2hlcmUgaXQgbWlnaHQgZW5kCi0gICAgICAgIC8vIHVwIChlLmcuLCBpbiBz b21lIGRlZXBseSBuZXN0ZWQgbGluZSBib3gpLiBTZWUgQ1NTMyBzcGVjLgotICAgICAgICBuZXdT dHlsZS5nZXQoKS5pbmhlcml0RnJvbSgmc3R5bGUoKSk7Ci0gICAgICAgIGlmICghbV9tYXJrZXIp IHsKLSAgICAgICAgICAgIG1fbWFya2VyID0gbmV3IFJlbmRlckxpc3RNYXJrZXIoKnRoaXMsIHN0 ZDo6bW92ZShuZXdTdHlsZSkpOwotICAgICAgICAgICAgbV9tYXJrZXItPmluaXRpYWxpemVTdHls ZSgpOwotICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgIG1fbWFya2VyLT5zZXRTdHlsZShzdGQ6 Om1vdmUobmV3U3R5bGUpKTsKLSAgICB9IGVsc2UgaWYgKG1fbWFya2VyKSB7Ci0gICAgICAgIG1f bWFya2VyLT5kZXN0cm95KCk7Ci0gICAgICAgIG1fbWFya2VyID0gMDsKKyAgICBpZiAoc3R5bGUo KS5saXN0U3R5bGVUeXBlKCkgPT0gTm9uZUxpc3RTdHlsZSAmJiAoIXN0eWxlKCkubGlzdFN0eWxl SW1hZ2UoKSB8fCBzdHlsZSgpLmxpc3RTdHlsZUltYWdlKCktPmVycm9yT2NjdXJyZWQoKSkpIHsK KyAgICAgICAgbV9tYXJrZXIgPSBudWxscHRyOworICAgICAgICByZXR1cm47CiAgICAgfQorCisg ICAgYXV0byBuZXdTdHlsZSA9IFJlbmRlclN0eWxlOjpjcmVhdGUoKTsKKyAgICAvLyBUaGUgbWFy a2VyIGFsd2F5cyBpbmhlcml0cyBmcm9tIHRoZSBsaXN0IGl0ZW0sIHJlZ2FyZGxlc3Mgb2Ygd2hl cmUgaXQgbWlnaHQgZW5kCisgICAgLy8gdXAgKGUuZy4sIGluIHNvbWUgZGVlcGx5IG5lc3RlZCBs aW5lIGJveCkuIFNlZSBDU1MzIHNwZWMuCisgICAgbmV3U3R5bGUuZ2V0KCkuaW5oZXJpdEZyb20o JnN0eWxlKCkpOworICAgIGlmICghbV9tYXJrZXIpIHsKKyAgICAgICAgbV9tYXJrZXIgPSBjcmVh dGVSZW5kZXJPYmplY3Q8UmVuZGVyTGlzdE1hcmtlcj4oKnRoaXMsIHN0ZDo6bW92ZShuZXdTdHls ZSkpOworICAgICAgICBtX21hcmtlci0+aW5pdGlhbGl6ZVN0eWxlKCk7CisgICAgfSBlbHNlCisg ICAgICAgIG1fbWFya2VyLT5zZXRTdHlsZShzdGQ6Om1vdmUobmV3U3R5bGUpKTsKIH0KIAogdm9p ZCBSZW5kZXJMaXN0SXRlbTo6d2lsbEJlRGVzdHJveWVkKCkKLXsgICAgCi0gICAgaWYgKG1fbWFy a2VyKSB7Ci0gICAgICAgIG1fbWFya2VyLT5kZXN0cm95KCk7Ci0gICAgICAgIG1fbWFya2VyID0g MDsKLSAgICB9Cit7CisgICAgbV9tYXJrZXIgPSBudWxscHRyOwogICAgIFJlbmRlckJsb2NrRmxv dzo6d2lsbEJlRGVzdHJveWVkKCk7CiB9CiAKQEAgLTI3Niw3ICsyNzEsNyBAQCB2b2lkIFJlbmRl ckxpc3RJdGVtOjppbnNlcnRPck1vdmVNYXJrZXJSZW5kZXJlcklmTmVlZGVkKCkKICAgICAgICAg cmV0dXJuOwogCiAgICAgUmVuZGVyRWxlbWVudCogY3VycmVudFBhcmVudCA9IG1fbWFya2VyLT5w YXJlbnQoKTsKLSAgICBSZW5kZXJCbG9jayogbmV3UGFyZW50ID0gZ2V0UGFyZW50T2ZGaXJzdExp bmVCb3godGhpcywgbV9tYXJrZXIpOworICAgIFJlbmRlckJsb2NrKiBuZXdQYXJlbnQgPSBnZXRQ YXJlbnRPZkZpcnN0TGluZUJveCh0aGlzLCBtX21hcmtlci5nZXQoKSk7CiAgICAgaWYgKCFuZXdQ YXJlbnQpIHsKICAgICAgICAgLy8gSWYgdGhlIG1hcmtlciBpcyBjdXJyZW50bHkgY29udGFpbmVk IGluc2lkZSBhbiBhbm9ueW1vdXMgYm94LAogICAgICAgICAvLyB0aGVuIHdlIGFyZSB0aGUgb25s eSBpdGVtIGluIHRoYXQgYW5vbnltb3VzIGJveCAoc2luY2Ugbm8gbGluZSBib3gKQEAgLTI5Miw3 ICsyODcsNyBAQCB2b2lkIFJlbmRlckxpc3RJdGVtOjppbnNlcnRPck1vdmVNYXJrZXJSZW5kZXJl cklmTmVlZGVkKCkKICAgICAgICAgLy8gY29udGFpbmVycyBvdGhlciB0aGFuIG91cnNlbHZlcywg c28gd2UgbmVlZCB0byBkaXNhYmxlIExheW91dFN0YXRlLgogICAgICAgICBMYXlvdXRTdGF0ZURp c2FibGVyIGxheW91dFN0YXRlRGlzYWJsZXIoJnZpZXcoKSk7CiAgICAgICAgIG1fbWFya2VyLT5y ZW1vdmVGcm9tUGFyZW50KCk7Ci0gICAgICAgIG5ld1BhcmVudC0+YWRkQ2hpbGQobV9tYXJrZXIs IGZpcnN0Tm9uTWFya2VyQ2hpbGQobmV3UGFyZW50KSk7CisgICAgICAgIG5ld1BhcmVudC0+YWRk Q2hpbGQobV9tYXJrZXIuZ2V0KCksIGZpcnN0Tm9uTWFya2VyQ2hpbGQobmV3UGFyZW50KSk7CiAg ICAgICAgIG1fbWFya2VyLT51cGRhdGVNYXJnaW5zQW5kQ29udGVudCgpOwogICAgICAgICAvLyBJ ZiBjdXJyZW50IHBhcmVudCBpcyBhbiBhbm9ueW1vdXMgYmxvY2sgdGhhdCBoYXMgbG9zdCBhbGwg aXRzIGNoaWxkcmVuLCBkZXN0cm95IGl0LgogICAgICAgICBpZiAoY3VycmVudFBhcmVudCAmJiBj dXJyZW50UGFyZW50LT5pc0Fub255bW91c0Jsb2NrKCkgJiYgIWN1cnJlbnRQYXJlbnQtPmZpcnN0 Q2hpbGQoKSAmJiAhdG9SZW5kZXJCbG9jayhjdXJyZW50UGFyZW50KS0+Y29udGludWF0aW9uKCkp CkBAIC00MDAsNyArMzk1LDcgQEAgdm9pZCBSZW5kZXJMaXN0SXRlbTo6cG9zaXRpb25MaXN0TWFy a2VyKCkKICAgICAgICAgICAgIExheW91dFJlY3QgbWFya2VyUmVjdChtYXJrZXJMb2dpY2FsTGVm dCArIGxpbmVPZmZzZXQsIGJsb2NrT2Zmc2V0LCBtX21hcmtlci0+d2lkdGgoKSwgbV9tYXJrZXIt PmhlaWdodCgpKTsKICAgICAgICAgICAgIGlmICghc3R5bGUoKS5pc0hvcml6b250YWxXcml0aW5n TW9kZSgpKQogICAgICAgICAgICAgICAgIG1hcmtlclJlY3QgPSBtYXJrZXJSZWN0LnRyYW5zcG9z ZWRSZWN0KCk7Ci0gICAgICAgICAgICBSZW5kZXJCb3gqIG8gPSBtX21hcmtlcjsKKyAgICAgICAg ICAgIFJlbmRlckJveCogbyA9IG1fbWFya2VyLmdldCgpOwogICAgICAgICAgICAgYm9vbCBwcm9w YWdhdGVWaXN1YWxPdmVyZmxvdyA9IHRydWU7CiAgICAgICAgICAgICBib29sIHByb3BhZ2F0ZUxh eW91dE92ZXJmbG93ID0gdHJ1ZTsKICAgICAgICAgICAgIGRvIHsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0SXRlbS5oIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxpc3RJdGVtLmgKaW5kZXggOGI0YmE5Yy4uNGQ3NjFmMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJdGVtLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpc3RJdGVtLmgKQEAgLTI0LDYgKzI0LDcgQEAKICNk ZWZpbmUgUmVuZGVyTGlzdEl0ZW1faAogCiAjaW5jbHVkZSAiUmVuZGVyQmxvY2tGbG93LmgiCisj aW5jbHVkZSAiUmVuZGVyUHRyLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtODQsNyAr ODUsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgZXhwbGljaXRWYWx1ZUNoYW5nZWQoKTsKIAogICAg IGludCBtX2V4cGxpY2l0VmFsdWU7Ci0gICAgUmVuZGVyTGlzdE1hcmtlciogbV9tYXJrZXI7Cisg ICAgUmVuZGVyUHRyPFJlbmRlckxpc3RNYXJrZXI+IG1fbWFya2VyOwogICAgIG11dGFibGUgaW50 IG1fdmFsdWU7CiAKICAgICBib29sIG1faGFzRXhwbGljaXRWYWx1ZSA6IDE7Cg==