126292 2013-12-30 08:22:42 -0800 Text::createTextRenderer() should return a RenderPtr. 2013-12-30 08:38:06 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc kangil.han kling oldest_to_newest 963325 0 kling 2013-12-30 08:22:42 -0800 Text::createTextRenderer() should return a RenderPtr. 963326 1 220111 kling 2013-12-30 08:23:09 -0800 Created attachment 220111 Patch 963329 2 kling 2013-12-30 08:38:06 -0800 Committed r161143: <http://trac.webkit.org/changeset/161143> 220111 2013-12-30 08:23:09 -0800 2013-12-30 08:24:19 -0800 Patch bug-126292.diff text/plain 3761 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ZGRjODkwLi4zMTUyNGQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTMtMTItMzAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFRleHQ6OmNyZWF0ZVRleHRSZW5kZXJlcigpIHNob3VsZCByZXR1cm4gYSBSZW5kZXJQdHIu CisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjYyOTI+CisKKyAgICAgICAgTWFrZSBj cmVhdGVUZXh0UmVuZGVyZXIoKSByZXR1cm4gYSBSZW5kZXJQdHIgYW5kIHJlbW92ZSBvbmUgbWFu dWFsCisgICAgICAgIGRlc3Ryb3koKSBjYWxsLiBBbHNvLCBzaW5jZSBpdCBzaG91bGQgYWx3YXlz IHJldHVybiBhIHZhbGlkIG9iamVjdCwKKyAgICAgICAgSSB0dXJuZWQgYSBudWxsIGNoZWNrIGlu dG8gYW4gYXNzZXJ0aW9uIGluc3RlYWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKIDIwMTMtMTItMjkgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgog CiAgICAgICAgIFJlbmRlckxheWVyOiBTdG9yZSBjb3JuZXIgYW5kIHJlc2l6ZXIgcmVuZGVyZXJz IGluIFJlbmRlclB0cnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vVGV4dC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vVGV4dC5jcHAKaW5kZXggMDYxNzYxNS4uODM4ZjU0MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1RleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9UZXh0LmNwcApAQCAtMTg3LDE2ICsxODcsMTYgQEAgc3RhdGljIGJvb2wgaXNTVkdUZXh0 KFRleHQqIHRleHQpCiB9CiAjZW5kaWYKIAotUmVuZGVyVGV4dCogVGV4dDo6Y3JlYXRlVGV4dFJl bmRlcmVyKGNvbnN0IFJlbmRlclN0eWxlJiBzdHlsZSkKK1JlbmRlclB0cjxSZW5kZXJUZXh0PiBU ZXh0OjpjcmVhdGVUZXh0UmVuZGVyZXIoY29uc3QgUmVuZGVyU3R5bGUmIHN0eWxlKQogewogI2lm IEVOQUJMRShTVkcpCiAgICAgaWYgKGlzU1ZHVGV4dCh0aGlzKSB8fCBpc1NWR1NoYWRvd1RleHQo dGhpcykpCi0gICAgICAgIHJldHVybiBuZXcgUmVuZGVyU1ZHSW5saW5lVGV4dCgqdGhpcywgZGF0 YUltcGwoKSk7CisgICAgICAgIHJldHVybiBjcmVhdGVSZW5kZXJPYmplY3Q8UmVuZGVyU1ZHSW5s aW5lVGV4dD4oKnRoaXMsIGRhdGFJbXBsKCkpOwogI2VuZGlmCiAgICAgaWYgKHN0eWxlLmhhc1Rl eHRDb21iaW5lKCkpCi0gICAgICAgIHJldHVybiBuZXcgUmVuZGVyQ29tYmluZVRleHQoKnRoaXMs IGRhdGFJbXBsKCkpOworICAgICAgICByZXR1cm4gY3JlYXRlUmVuZGVyT2JqZWN0PFJlbmRlckNv bWJpbmVUZXh0PigqdGhpcywgZGF0YUltcGwoKSk7CiAKLSAgICByZXR1cm4gbmV3IFJlbmRlclRl eHQoKnRoaXMsIGRhdGFJbXBsKCkpOworICAgIHJldHVybiBjcmVhdGVSZW5kZXJPYmplY3Q8UmVu ZGVyVGV4dD4oKnRoaXMsIGRhdGFJbXBsKCkpOwogfQogCiBib29sIFRleHQ6OmNoaWxkVHlwZUFs bG93ZWQoTm9kZVR5cGUpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vVGV4 dC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL1RleHQuaAppbmRleCAxNGFmZDE0Li5lMjM0MjdlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vVGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9UZXh0LmgKQEAgLTI0LDYgKzI0LDcgQEAKICNkZWZpbmUgVGV4dF9oCiAKICNpbmNsdWRl ICJDaGFyYWN0ZXJEYXRhLmgiCisjaW5jbHVkZSAiUmVuZGVyUHRyLmgiCiAjaW5jbHVkZSAiU3R5 bGVSZXNvbHZlVHJlZS5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC00Nyw3ICs0OCw3IEBA IHB1YmxpYzoKICAgICBTdHJpbmcgd2hvbGVUZXh0KCkgY29uc3Q7CiAgICAgUGFzc1JlZlB0cjxU ZXh0PiByZXBsYWNlV2hvbGVUZXh0KGNvbnN0IFN0cmluZyYsIEV4Y2VwdGlvbkNvZGUmKTsKICAg ICAKLSAgICBSZW5kZXJUZXh0KiBjcmVhdGVUZXh0UmVuZGVyZXIoY29uc3QgUmVuZGVyU3R5bGUm KTsKKyAgICBSZW5kZXJQdHI8UmVuZGVyVGV4dD4gY3JlYXRlVGV4dFJlbmRlcmVyKGNvbnN0IFJl bmRlclN0eWxlJik7CiAgICAgCiAgICAgdmlydHVhbCBib29sIGNhbkNvbnRhaW5SYW5nZUVuZFBv aW50KCkgY29uc3QgT1ZFUlJJREUgRklOQUwgeyByZXR1cm4gdHJ1ZTsgfQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVJlc29sdmVUcmVlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3N0eWxlL1N0eWxlUmVzb2x2ZVRyZWUuY3BwCmluZGV4IGExM2NmNjEuLmVhYjU3MGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlUmVzb2x2ZVRyZWUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlUmVzb2x2ZVRyZWUuY3BwCkBAIC0zODIsMjIgKzM4 MiwyMSBAQCBzdGF0aWMgdm9pZCBjcmVhdGVUZXh0UmVuZGVyZXJJZk5lZWRlZChUZXh0JiB0ZXh0 Tm9kZSkKIAogICAgIGlmICghdGV4dFJlbmRlcmVySXNOZWVkZWQodGV4dE5vZGUsICpwYXJlbnRS ZW5kZXJlciwgc3R5bGUpKQogICAgICAgICByZXR1cm47Ci0gICAgUmVuZGVyVGV4dCogbmV3UmVu ZGVyZXIgPSB0ZXh0Tm9kZS5jcmVhdGVUZXh0UmVuZGVyZXIoc3R5bGUpOwotICAgIGlmICghbmV3 UmVuZGVyZXIpCi0gICAgICAgIHJldHVybjsKLSAgICBpZiAoIXBhcmVudFJlbmRlcmVyLT5pc0No aWxkQWxsb3dlZCgqbmV3UmVuZGVyZXIsIHN0eWxlKSkgewotICAgICAgICBuZXdSZW5kZXJlci0+ ZGVzdHJveSgpOworCisgICAgYXV0byBuZXdSZW5kZXJlciA9IHRleHROb2RlLmNyZWF0ZVRleHRS ZW5kZXJlcihzdHlsZSk7CisgICAgQVNTRVJUKG5ld1JlbmRlcmVyKTsKKworICAgIGlmICghcGFy ZW50UmVuZGVyZXItPmlzQ2hpbGRBbGxvd2VkKCpuZXdSZW5kZXJlciwgc3R5bGUpKQogICAgICAg ICByZXR1cm47Ci0gICAgfQogCiAgICAgLy8gTWFrZSBzdXJlIHRoZSBSZW5kZXJPYmplY3QgYWxy ZWFkeSBrbm93cyBpdCBpcyBnb2luZyB0byBiZSBhZGRlZCB0byBhIFJlbmRlckZsb3dUaHJlYWQg YmVmb3JlIHdlIHNldCB0aGUgc3R5bGUKICAgICAvLyBmb3IgdGhlIGZpcnN0IHRpbWUuIE90aGVy d2lzZSBjb2RlIHVzaW5nIGluUmVuZGVyRmxvd1RocmVhZCgpIGluIHRoZSBzdHlsZVdpbGxDaGFu Z2UgYW5kIHN0eWxlRGlkQ2hhbmdlIHdpbGwgZmFpbC4KICAgICBuZXdSZW5kZXJlci0+c2V0Rmxv d1RocmVhZFN0YXRlKHBhcmVudFJlbmRlcmVyLT5mbG93VGhyZWFkU3RhdGUoKSk7CiAKICAgICBS ZW5kZXJPYmplY3QqIG5leHRSZW5kZXJlciA9IG5leHRTaWJsaW5nUmVuZGVyZXIodGV4dE5vZGUp OwotICAgIHRleHROb2RlLnNldFJlbmRlcmVyKG5ld1JlbmRlcmVyKTsKKyAgICB0ZXh0Tm9kZS5z ZXRSZW5kZXJlcihuZXdSZW5kZXJlci5nZXQoKSk7CiAgICAgLy8gUGFyZW50IHRha2VzIGNhcmUg b2YgdGhlIGFuaW1hdGlvbnMsIG5vIG5lZWQgdG8gY2FsbCBzZXRBbmltYXRhYmxlU3R5bGUuCi0g ICAgcGFyZW50UmVuZGVyZXItPmFkZENoaWxkKG5ld1JlbmRlcmVyLCBuZXh0UmVuZGVyZXIpOwor ICAgIHBhcmVudFJlbmRlcmVyLT5hZGRDaGlsZChuZXdSZW5kZXJlci5sZWFrUHRyKCksIG5leHRS ZW5kZXJlcik7CiB9CiAKIHZvaWQgYXR0YWNoVGV4dFJlbmRlcmVyKFRleHQmIHRleHROb2RlKQo=