126288 2013-12-30 06:19:09 -0800 Remove attachChild 2013-12-30 06:45:12 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue esprehn+autocc kangil.han oldest_to_newest 963314 0 koivisto 2013-12-30 06:19:09 -0800 We now create renderers lazily 963315 1 220107 koivisto 2013-12-30 06:24:03 -0800 Created attachment 220107 patch 963316 2 220108 koivisto 2013-12-30 06:34:37 -0800 Created attachment 220108 better patch 963317 3 koivisto 2013-12-30 06:45:12 -0800 https://trac.webkit.org/r161142 220107 2013-12-30 06:24:03 -0800 2013-12-30 06:34:37 -0800 patch remove-attach-child.patch text/plain 1699 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTE0MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTMwICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgYXR0YWNoQ2hpbGQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjI4OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0Nv bnRhaW5lck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGFpbmVyTm9kZTo6dGFrZUFs bENoaWxkcmVuRnJvbSk6CisgICAgICAgIAorICAgICAgICAgICAgTm8gbmVlZCB0byBjYWxsIGF0 dGFjaFJlbmRlclRyZWUgZXhwbGljaXRseSBhbnltb3JlLgorCiAyMDEzLTEyLTI5ICBBbmRyZWFz IEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5kZXJMYXllcjogU3RvcmUg Y29ybmVyIGFuZCByZXNpemVyIHJlbmRlcmVycyBpbiBSZW5kZXJQdHJzLgpJbmRleDogU291cmNl L1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAkocmV2aXNpb24gMTYxMTM3KQorKysgU291cmNlL1dl YkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDQsMTQgKzEw NCw2IEBAIHZvaWQgQ29udGFpbmVyTm9kZTo6cmVtb3ZlRGV0YWNoZWRDaGlsZHIKICAgICByZW1v dmVEZXRhY2hlZENoaWxkcmVuSW5Db250YWluZXI8Tm9kZSwgQ29udGFpbmVyTm9kZT4oKnRoaXMp OwogfQogCi1zdGF0aWMgaW5saW5lIHZvaWQgYXR0YWNoQ2hpbGQoTm9kZSYgY2hpbGQpCi17Ci0g ICAgaWYgKGNoaWxkLmlzRWxlbWVudE5vZGUoKSkKLSAgICAgICAgU3R5bGU6OmF0dGFjaFJlbmRl clRyZWUodG9FbGVtZW50KGNoaWxkKSk7Ci0gICAgZWxzZSBpZiAoY2hpbGQuaXNUZXh0Tm9kZSgp KQotICAgICAgICBTdHlsZTo6YXR0YWNoVGV4dFJlbmRlcmVyKHRvVGV4dChjaGlsZCkpOwotfQot CiBzdGF0aWMgaW5saW5lIHZvaWQgZGV0YWNoQ2hpbGQoTm9kZSYgY2hpbGQpCiB7CiAgICAgaWYg KGNoaWxkLmlzRWxlbWVudE5vZGUoKSkKQEAgLTE1MCw4ICsxNDIsNiBAQCB2b2lkIENvbnRhaW5l ck5vZGU6OnRha2VBbGxDaGlsZHJlbkZyb20oCiAgICAgICAgIC8vIChpZiB0aGUgZG9jdW1lbnQg Y2hhbmdlZCBvciBvbGRQYXJlbnQgd2FzIGluIGEgc2hhZG93IHRyZWUsIEFORCAqdGhpcyBpcyBp biBhIHNoYWRvdyB0cmVlKS4KICAgICAgICAgLy8gQ2FuIHdlIGRvIGJldHRlcj8KICAgICAgICAg dHJlZVNjb3BlKCkuYWRvcHRJZk5lZWRlZChhZG9wdGVkQ2hpbGQuZ2V0KCkpOwotICAgICAgICBp ZiAocmVuZGVyZXIoKSAmJiAhYWRvcHRlZENoaWxkLT5yZW5kZXJlcigpKQotICAgICAgICAgICAg YXR0YWNoQ2hpbGQoKmFkb3B0ZWRDaGlsZC5nZXQoKSk7CiAgICAgfQogfQogCg== 220108 2013-12-30 06:34:37 -0800 2013-12-30 06:35:58 -0800 better patch remove-attach-child-2.patch text/plain 2971 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTE0MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTEyLTMwICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgYXR0YWNoQ2hpbGQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjI4OAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0Nv bnRhaW5lck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dGVhckRvd25SZW5kZXJUcmVlSWZO ZWVkZWQpOgorICAgICAgICAKKyAgICAgICAgICAgIFJlbmFtZSBkZXRhY2hDaGlsZCBhbmQgbW92 ZSB0aGUgdGVzdHMgaGVyZS4KKworICAgICAgICAoV2ViQ29yZTo6Q29udGFpbmVyTm9kZTo6dGFr ZUFsbENoaWxkcmVuRnJvbSk6CisgICAgICAgIAorICAgICAgICAgICAgTm8gbmVlZCB0byBjYWxs IGF0dGFjaFJlbmRlclRyZWUgZXhwbGljaXRseSBhbnltb3JlLgorCisgICAgICAgIChXZWJDb3Jl OjpDb250YWluZXJOb2RlOjpyZW1vdmVCZXR3ZWVuKToKKwogMjAxMy0xMi0yOSAgQW5kcmVhcyBL bGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVuZGVyTGF5ZXI6IFN0b3JlIGNv cm5lciBhbmQgcmVzaXplciByZW5kZXJlcnMgaW4gUmVuZGVyUHRycy4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9kb20vQ29udGFpbmVyTm9kZS5jcHAJKHJldmlzaW9uIDE2MTEzNykKKysrIFNvdXJjZS9XZWJD b3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA0LDE2ICsxMDQs MTEgQEAgdm9pZCBDb250YWluZXJOb2RlOjpyZW1vdmVEZXRhY2hlZENoaWxkcgogICAgIHJlbW92 ZURldGFjaGVkQ2hpbGRyZW5JbkNvbnRhaW5lcjxOb2RlLCBDb250YWluZXJOb2RlPigqdGhpcyk7 CiB9CiAKLXN0YXRpYyBpbmxpbmUgdm9pZCBhdHRhY2hDaGlsZChOb2RlJiBjaGlsZCkKLXsKLSAg ICBpZiAoY2hpbGQuaXNFbGVtZW50Tm9kZSgpKQotICAgICAgICBTdHlsZTo6YXR0YWNoUmVuZGVy VHJlZSh0b0VsZW1lbnQoY2hpbGQpKTsKLSAgICBlbHNlIGlmIChjaGlsZC5pc1RleHROb2RlKCkp Ci0gICAgICAgIFN0eWxlOjphdHRhY2hUZXh0UmVuZGVyZXIodG9UZXh0KGNoaWxkKSk7Ci19Ci0K LXN0YXRpYyBpbmxpbmUgdm9pZCBkZXRhY2hDaGlsZChOb2RlJiBjaGlsZCkKK3N0YXRpYyBpbmxp bmUgdm9pZCB0ZWFyRG93blJlbmRlclRyZWVJZk5lZWRlZChOb2RlJiBjaGlsZCkKIHsKKyAgICAv LyBGSVhNRTogR2V0IHJpZCBvZiB0aGUgbmFtZWQgZmxvdyB0ZXN0LgorICAgIGlmICghY2hpbGQu cmVuZGVyZXIoKSAmJiAhY2hpbGQuaW5OYW1lZEZsb3coKSkKKyAgICAgICAgcmV0dXJuOwogICAg IGlmIChjaGlsZC5pc0VsZW1lbnROb2RlKCkpCiAgICAgICAgIFN0eWxlOjpkZXRhY2hSZW5kZXJU cmVlKHRvRWxlbWVudChjaGlsZCkpOwogICAgIGVsc2UgaWYgKGNoaWxkLmlzVGV4dE5vZGUoKSkK QEAgLTE0MCw4ICsxMzUsOCBAQCB2b2lkIENvbnRhaW5lck5vZGU6OnRha2VBbGxDaGlsZHJlbkZy b20oCiAKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgY2hpbGRyZW4uc2l6ZSgpOyArK2kp IHsKICAgICAgICAgTm9kZSYgY2hpbGQgPSBjaGlsZHJlbltpXS5nZXQoKTsKLSAgICAgICAgaWYg KGNoaWxkLnJlbmRlcmVyKCkpCi0gICAgICAgICAgICBkZXRhY2hDaGlsZChjaGlsZCk7CisKKyAg ICAgICAgdGVhckRvd25SZW5kZXJUcmVlSWZOZWVkZWQoY2hpbGQpOwogCiAgICAgICAgIC8vIEZJ WE1FOiBXZSBuZWVkIGEgbm8gbXV0YXRpb24gZXZlbnQgdmVyc2lvbiBvZiBhZG9wdE5vZGUuCiAg ICAgICAgIFJlZlB0cjxOb2RlPiBhZG9wdGVkQ2hpbGQgPSBkb2N1bWVudCgpLmFkb3B0Tm9kZSgm Y2hpbGRyZW5baV0uZ2V0KCksIEFTU0VSVF9OT19FWENFUFRJT04pOwpAQCAtMTUwLDggKzE0NSw2 IEBAIHZvaWQgQ29udGFpbmVyTm9kZTo6dGFrZUFsbENoaWxkcmVuRnJvbSgKICAgICAgICAgLy8g KGlmIHRoZSBkb2N1bWVudCBjaGFuZ2VkIG9yIG9sZFBhcmVudCB3YXMgaW4gYSBzaGFkb3cgdHJl ZSwgQU5EICp0aGlzIGlzIGluIGEgc2hhZG93IHRyZWUpLgogICAgICAgICAvLyBDYW4gd2UgZG8g YmV0dGVyPwogICAgICAgICB0cmVlU2NvcGUoKS5hZG9wdElmTmVlZGVkKGFkb3B0ZWRDaGlsZC5n ZXQoKSk7Ci0gICAgICAgIGlmIChyZW5kZXJlcigpICYmICFhZG9wdGVkQ2hpbGQtPnJlbmRlcmVy KCkpCi0gICAgICAgICAgICBhdHRhY2hDaGlsZCgqYWRvcHRlZENoaWxkLmdldCgpKTsKICAgICB9 CiB9CiAKQEAgLTU5MywxMCArNTg2LDcgQEAgdm9pZCBDb250YWluZXJOb2RlOjpyZW1vdmVCZXR3 ZWVuKE5vZGUqIAogCiAgICAgQVNTRVJUKG9sZENoaWxkLnBhcmVudE5vZGUoKSA9PSB0aGlzKTsK IAotICAgIC8vIFJlbW92ZSBmcm9tIHJlbmRlcmluZyB0cmVlCi0gICAgLy8gRklYTUU6IEdldCBy aWQgb2YgdGhlIG5hbWVkIGZsb3cgdGVzdC4KLSAgICBpZiAob2xkQ2hpbGQucmVuZGVyZXIoKSB8 fCBvbGRDaGlsZC5pbk5hbWVkRmxvdygpKQotICAgICAgICBkZXRhY2hDaGlsZChvbGRDaGlsZCk7 CisgICAgdGVhckRvd25SZW5kZXJUcmVlSWZOZWVkZWQob2xkQ2hpbGQpOwogCiAgICAgaWYgKG5l eHRDaGlsZCkKICAgICAgICAgbmV4dENoaWxkLT5zZXRQcmV2aW91c1NpYmxpbmcocHJldmlvdXND aGlsZCk7Cg==