126287 2013-12-30 03:41:30 -0800 [SOUP] Return early in ResourceHandle::receivedCancellation if the load has already cancelled 2013-12-31 00:31:03 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Soup P2 Normal --- 1 cgarcia webkit-unassigned cdumez commit-queue danw gustavo mrobinson rakuco svillar oldest_to_newest 963307 0 cgarcia 2013-12-30 03:41:30 -0800 This situation can happen when using the network process, because the ReceivedCancellation message can be received when the resource loader has already been removed, but the authentication challenge still has a reference to the ResourceHandleClient. $ WEBKIT_USE_NETWORK_PROCESS=1 Programs/WebKit2APITests/TestAuthentication /webkit2/WebKitWebView/authentication-request: OK /webkit2/WebKitWebView/authentication-cancel: OK /webkit2/WebKitWebView/authentication-load-cancelled: (process:1716): libsoup-CRITICAL **: soup_session_unpause_message: assertion 'item != NULL' failed OK /webkit2/WebKitWebView/authentication-failure: OK /webkit2/WebKitWebView/authentication-no-credential: OK /webkit2/WebKitWebView/authentication-storage: (process:1843): libsoup-CRITICAL **: soup_session_unpause_message: assertion 'item != NULL' failed 963308 1 220106 cgarcia 2013-12-30 03:45:06 -0800 Created attachment 220106 Patch 963492 2 cgarcia 2013-12-31 00:31:03 -0800 Committed r161179: <http://trac.webkit.org/changeset/161179> 220106 2013-12-30 03:45:06 -0800 2013-12-30 08:37:47 -0800 Patch wk-soup-early-return.diff text/plain 1736 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwMDBlMDdhLi4xYjBiYjYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMTItMzAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtTT1VQXSBSZXR1cm4gZWFybHkgaW4gUmVzb3VyY2VIYW5kbGU6OnJlY2Vp dmVkQ2FuY2VsbGF0aW9uIGlmIHRoZSBsb2FkIGhhcyBhbHJlYWR5IGNhbmNlbGxlZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2Mjg3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBzaXR1YXRpb24g Y2FuIGhhcHBlbiB3aGVuIHVzaW5nIHRoZSBuZXR3b3JrIHByb2Nlc3MsIGJlY2F1c2UKKyAgICAg ICAgdGhlIFJlY2VpdmVkQ2FuY2VsbGF0aW9uIG1lc3NhZ2UgY2FuIGJlIHJlY2VpdmVkIHdoZW4g dGhlIHJlc291cmNlCisgICAgICAgIGxvYWRlciBoYXMgYWxyZWFkeSBiZWVuIHJlbW92ZWQsIGJ1 dCB0aGUgYXV0aGVudGljYXRpb24gY2hhbGxlbmdlCisgICAgICAgIHN0aWxsIGhhcyBhIHJlZmVy ZW5jZSB0byB0aGUgUmVzb3VyY2VIYW5kbGVDbGllbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl c291cmNlSGFuZGxlOjpyZWNlaXZlZENhbmNlbGxhdGlvbik6CisKIDIwMTMtMTItMjkgIEpvb25l IEh1ciAgPGpvb25lLmh1ckBpbnRlbC5jb20+CiAKICAgICAgICAgUmV2ZXJ0ZWQgcjE1Njc0Mi4g VGhlIHNhbWUgZml4IHdhcyByZXZlcnRlZCBmcm9tIEJsaW5rIGR1ZSB0byBoZWFwLXVzZS1hZnRl ci1mcmVlIG9uIENsdXN0ZXJGdXp6LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCBkZTc4OTAy Li5lM2VjN2I5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtMTI1MSw2ICsxMjUxLDEzIEBA IHZvaWQgUmVzb3VyY2VIYW5kbGU6OnJlY2VpdmVkQ2FuY2VsbGF0aW9uKGNvbnN0IEF1dGhlbnRp Y2F0aW9uQ2hhbGxlbmdlJiBjaGFsbGVuCiAgICAgaWYgKGNoYWxsZW5nZSAhPSBkLT5tX2N1cnJl bnRXZWJDaGFsbGVuZ2UpCiAgICAgICAgIHJldHVybjsKIAorICAgIGlmIChjYW5jZWxsZWRPckNs aWVudGxlc3MoKSkgeworICAgICAgICBjbGVhckF1dGhlbnRpY2F0aW9uKCk7CisgICAgICAgIHJl dHVybjsKKyAgICB9CisKKyAgICBBU1NFUlQoY2hhbGxlbmdlLnNvdXBTZXNzaW9uKCkpOworICAg IEFTU0VSVChjaGFsbGVuZ2Uuc291cE1lc3NhZ2UoKSk7CiAgICAgc291cF9zZXNzaW9uX3VucGF1 c2VfbWVzc2FnZShjaGFsbGVuZ2Uuc291cFNlc3Npb24oKSwgY2hhbGxlbmdlLnNvdXBNZXNzYWdl KCkpOwogCiAgICAgaWYgKGNsaWVudCgpKQo=