126281 2013-12-29 15:49:37 -0800 Provide a visual clue when element has a popover at build.webkit.org/dashboard 2014-01-03 08:57:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue timothy oldest_to_newest 963249 0 ap 2013-12-29 15:49:37 -0800 Currently it's not discoverable that positioning mouse over on an element is worth a try. I'm not quite sure what the best way to show it is. I'm going to propose a patch that adds an outline shadow on hover. Not that it's super self explanatory, but probably better that nothing. Thoughts? 963253 1 220094 ap 2013-12-29 16:17:00 -0800 Created attachment 220094 proposed patch 963706 2 220212 ap 2014-01-02 00:49:20 -0800 Created attachment 220212 poposed patch Updated to work with popovers on bubbles. 963947 3 220212 timothy 2014-01-02 16:11:13 -0800 Comment on attachment 220212 poposed patch This is fine. Maybe a dotted/dashed bottom border in the link color would be better? 964106 4 ap 2014-01-03 08:29:28 -0800 > This is fine. Maybe a dotted/dashed bottom border in the link color would be better? I'm not sure if that would look right on bubbles, or on elements that are also links. 964115 5 220212 commit-queue 2014-01-03 08:57:02 -0800 Comment on attachment 220212 poposed patch Clearing flags on attachment: 220212 Committed r161261: <http://trac.webkit.org/changeset/161261> 964116 6 commit-queue 2014-01-03 08:57:04 -0800 All reviewed patches have been landed. Closing bug. 220094 2013-12-29 16:17:00 -0800 2014-01-02 00:49:20 -0800 proposed patch Highlight.txt text/plain 3431 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MTEzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIzIEBACisyMDEzLTEyLTI5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFByb3ZpZGUgYSB2aXN1YWwgY2x1ZSB3aGVuIGVsZW1lbnQgaGFzIGEgcG9w b3ZlciBhdCBidWlsZC53ZWJraXQub3JnL2Rhc2hib2FyZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MjgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9Qb3BvdmVyVHJhY2tl ci5qczoKKyAgICAgICAgKFBvcG92ZXJUcmFja2VyKTogQWRkIGEgY2xhc3MgbmFtZSB0byBlbGVt ZW50cyB3aXRoIHBvcG92ZXJzLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9NYWluLmNzczoK KyAgICAgICAgKCopOiBXZSBoYXZlIC13ZWJraXQtdXNlci1zZWxlY3Q6bm9uZSwgc28gbGV0J3Mg YWxzbyBub3Qgc2hvdyB0ZXh0IHNlbGVjdGlvbiBjdXJzb3IuCisgICAgICAgIEkgbWlnaHQgaGF2 ZSBicm9rZSB0aGF0IHJlY2VudGx5LgorICAgICAgICAoKjpsaW5rKTogU2hvdyBoYW5kIGN1cnNv ciBvdmVyIGxpbmtzLgorICAgICAgICAoLnBvcG92ZXItdHJhY2tpbmc6aG92ZXIpOiBQdXQgYSBz aGFkb3cgb24gaG92ZXIgb3ZlciBlbGVtZW50IHdpdGggcG9wb3ZlcnMuCisKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNo Ym9hcmQvU3R5bGVzL1N0YXR1c0xpbmVWaWV3LmNzczoKKyAgICAgICAgKC5zdGF0dXMtbGluZSAu bWVzc2FnZSAucmV2aXNpb24tbnVtYmVyKTogU2hvdyB0ZXh0IHNlbGVjdGlvbiBjdXJzb3Igb24g b3VyIG9ubHkKKyAgICAgICAgc2VsZWN0YWJsZSB0ZXh0IGVsZW1lbnQuCisKIDIwMTMtMTItMjkg IEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgSW50ZXJydXB0 ZWQgdGVzdCBydW5zIHNob3VsZCBub3QgY291bnQgYXQgYnVpbGQud2Via2l0Lm9yZy9kYXNoYm9h cmQKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL1BvcG92ZXJUcmFja2VyLmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL1BvcG92ZXJUcmFja2VyLmpzCShyZXZpc2lvbiAx NjExMjQpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9Qb3BvdmVyVHJhY2tlci5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMzUsNiArMzUsNyBAQCBQb3BvdmVyVHJhY2tlciA9IGZ1bmN0aW9uKGVsZW1l bnQsIHByZXNlCiAgICAgdGhpcy5fY29udGV4dCA9IGNvbnRleHQ7CiAgICAgdGhpcy5fYWN0aXZl ID0gZmFsc2U7CiAKKyAgICBlbGVtZW50LmNsYXNzTGlzdC5hZGQoInBvcG92ZXItdHJhY2tpbmci KTsKICAgICBlbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlZW50ZXIiLCB0aGlzLl9tb3Vz ZUVudGVyZWRQb3BvdmVyT3JFbGVtZW50LmJpbmQodGhpcyksIHRydWUpOwogICAgIGVsZW1lbnQu YWRkRXZlbnRMaXN0ZW5lcigibW91c2VsZWF2ZSIsIHRoaXMuX21vdXNlRXhpdGVkUG9wb3Zlck9y RWxlbWVudC5iaW5kKHRoaXMpLCB0cnVlKTsKIH07CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVz L01haW4uY3NzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndl YmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TdHlsZXMvTWFpbi5jc3MJKHJl dmlzaW9uIDE2MTEyNCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TdHlsZXMvTWFpbi5jc3MJKHdvcmtpbmcg Y29weSkKQEAgLTI3LDYgKzI3LDExIEBACiAgICAgYm94LXNpemluZzogYm9yZGVyLWJveDsKICAg ICAtd2Via2l0LXVzZXItc2VsZWN0OiBub25lOwogICAgIC13ZWJraXQtdXNlci1kcmFnOiBub25l OworICAgIGN1cnNvcjogZGVmYXVsdDsKK30KKworKjpsaW5rIHsKKyAgICBjdXJzb3I6IHBvaW50 ZXI7CiB9CiAKIGEgewpAQCAtMTkxLDMgKzE5Niw3IEBAIHRhYmxlLnF1ZXVlLWdyaWQgdHIucGxh dGZvcm0ubGludXgtZWZsIGkKICAgICBjb250ZW50OiAtd2Via2l0LWltYWdlLXNldCh1cmwoLi4v SW1hZ2VzL0VGTEAyeC5wbmcpIDJ4LCB1cmwoLi4vSW1hZ2VzL0VGTC5wbmcpIDF4KTsKIH0KIAor LnBvcG92ZXItdHJhY2tpbmc6aG92ZXIgeworICAgIHRleHQtc2hhZG93OiAwcHggMHB4IDFweCBy Z2JhKDAsIDAsIDAsIDAuNCkKK30KKwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9TdGF0dXNM aW5lVmlldy5jc3MKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9TdGF0dXNMaW5l Vmlldy5jc3MJKHJldmlzaW9uIDE2MTEyNCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TdHlsZXMvU3RhdHVz TGluZVZpZXcuY3NzCSh3b3JraW5nIGNvcHkpCkBAIC0xMDMsNiArMTAzLDcgQEAKIAogLnN0YXR1 cy1saW5lIC5tZXNzYWdlIC5yZXZpc2lvbi1udW1iZXIgewogICAgIC13ZWJraXQtdXNlci1zZWxl Y3Q6IGF1dG87CisgICAgY3Vyc29yOiB0ZXh0OwogfQogCiAuc3RhdHVzLWxpbmUubm8tbGFiZWwg Lm1lc3NhZ2Ugewo= 220212 2014-01-02 00:49:20 -0800 2014-01-03 08:57:02 -0800 poposed patch Highlight.txt text/plain 3759 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MTIwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI1IEBACisyMDE0LTAxLTAyICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFByb3ZpZGUgYSB2aXN1YWwgY2x1ZSB3aGVuIGVsZW1lbnQgaGFzIGEgcG9w b3ZlciBhdCBidWlsZC53ZWJraXQub3JnL2Rhc2hib2FyZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MjgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9Qb3BvdmVyVHJhY2tl ci5qczoKKyAgICAgICAgKFBvcG92ZXJUcmFja2VyKTogQWRkIGEgY2xhc3MgbmFtZSB0byBlbGVt ZW50cyB3aXRoIHBvcG92ZXJzLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9NYWluLmNzczoK KyAgICAgICAgKCopOiBXZSBoYXZlIC13ZWJraXQtdXNlci1zZWxlY3Q6bm9uZSwgc28gbGV0J3Mg YWxzbyBub3Qgc2hvdyB0ZXh0IHNlbGVjdGlvbiBjdXJzb3IuCisgICAgICAgIEkgbWlnaHQgaGF2 ZSBicm9rZSB0aGF0IHJlY2VudGx5LgorICAgICAgICAoKjpsaW5rKTogU2hvdyBoYW5kIGN1cnNv ciBvdmVyIGxpbmtzLgorICAgICAgICAoLnBvcG92ZXItdHJhY2tpbmc6aG92ZXIpOiBQdXQgYSBz aGFkb3cgb24gaG92ZXIgb3ZlciBlbGVtZW50IHdpdGggcG9wb3ZlcnMuCisKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNo Ym9hcmQvU3R5bGVzL1N0YXR1c0xpbmVWaWV3LmNzczoKKyAgICAgICAgKC5zdGF0dXMtbGluZSAu bWVzc2FnZSAucmV2aXNpb24tbnVtYmVyKTogU2hvdyB0ZXh0IHNlbGVjdGlvbiBjdXJzb3Igb24g b3VyIG9ubHkKKyAgICAgICAgc2VsZWN0YWJsZSB0ZXh0IGVsZW1lbnQuCisgICAgICAgICguc3Rh dHVzLWxpbmUgLmJ1YmJsZS5wb3BvdmVyLXRyYWNraW5nOmhvdmVyKTogVGV4dCBpbiBhIGJ1YmJs ZSBsb29rcyBiZXR0ZXIgd2l0aAorICAgICAgICBhIHdoaXRlIHNoYWRvdyB0aGFuIHdpdGggYSBk YXJrIG9uZSBvbiBob3Zlci4KKwogMjAxNC0wMS0wMSAgTWFydGluIFJvYmluc29uICA8bXJvYmlu c29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVuYW1lIGxpYnRlc3RuZXRzY2FwZXBs dWdpbiB0byBsaWJUZXN0TmV0c2NhcGVQbHVnaW4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRz L1BvcG92ZXJUcmFja2VyLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL1Bv cG92ZXJUcmFja2VyLmpzCShyZXZpc2lvbiAxNjExMzEpCisrKyBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0 cy9Qb3BvdmVyVHJhY2tlci5qcwkod29ya2luZyBjb3B5KQpAQCAtMzUsNiArMzUsNyBAQCBQb3Bv dmVyVHJhY2tlciA9IGZ1bmN0aW9uKGVsZW1lbnQsIHByZXNlCiAgICAgdGhpcy5fY29udGV4dCA9 IGNvbnRleHQ7CiAgICAgdGhpcy5fYWN0aXZlID0gZmFsc2U7CiAKKyAgICBlbGVtZW50LmNsYXNz TGlzdC5hZGQoInBvcG92ZXItdHJhY2tpbmciKTsKICAgICBlbGVtZW50LmFkZEV2ZW50TGlzdGVu ZXIoIm1vdXNlZW50ZXIiLCB0aGlzLl9tb3VzZUVudGVyZWRQb3BvdmVyT3JFbGVtZW50LmJpbmQo dGhpcyksIHRydWUpOwogICAgIGVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2VsZWF2ZSIs IHRoaXMuX21vdXNlRXhpdGVkUG9wb3Zlck9yRWxlbWVudC5iaW5kKHRoaXMpLCB0cnVlKTsKIH07 CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL01haW4uY3NzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rh c2hib2FyZC9TdHlsZXMvTWFpbi5jc3MJKHJldmlzaW9uIDE2MTEzMSkKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2Fy ZC9TdHlsZXMvTWFpbi5jc3MJKHdvcmtpbmcgY29weSkKQEAgLTI3LDYgKzI3LDExIEBACiAgICAg Ym94LXNpemluZzogYm9yZGVyLWJveDsKICAgICAtd2Via2l0LXVzZXItc2VsZWN0OiBub25lOwog ICAgIC13ZWJraXQtdXNlci1kcmFnOiBub25lOworICAgIGN1cnNvcjogZGVmYXVsdDsKK30KKwor KjpsaW5rIHsKKyAgICBjdXJzb3I6IHBvaW50ZXI7CiB9CiAKIGEgewpAQCAtMTkxLDMgKzE5Niw2 IEBAIHRhYmxlLnF1ZXVlLWdyaWQgdHIucGxhdGZvcm0ubGludXgtZWZsIGkKICAgICBjb250ZW50 OiAtd2Via2l0LWltYWdlLXNldCh1cmwoLi4vSW1hZ2VzL0VGTEAyeC5wbmcpIDJ4LCB1cmwoLi4v SW1hZ2VzL0VGTC5wbmcpIDF4KTsKIH0KIAorLnBvcG92ZXItdHJhY2tpbmc6aG92ZXIgeworICAg IHRleHQtc2hhZG93OiAwcHggMHB4IDNweCByZ2JhKDAsIDAsIDAsIDAuMikKK30KSW5kZXg6IFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L2Rhc2hib2FyZC9TdHlsZXMvU3RhdHVzTGluZVZpZXcuY3NzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rh c2hib2FyZC9TdHlsZXMvU3RhdHVzTGluZVZpZXcuY3NzCShyZXZpc2lvbiAxNjExMzEpCisrKyBU b29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRt bC9kYXNoYm9hcmQvU3R5bGVzL1N0YXR1c0xpbmVWaWV3LmNzcwkod29ya2luZyBjb3B5KQpAQCAt MTAzLDYgKzEwMyw3IEBACiAKIC5zdGF0dXMtbGluZSAubWVzc2FnZSAucmV2aXNpb24tbnVtYmVy IHsKICAgICAtd2Via2l0LXVzZXItc2VsZWN0OiBhdXRvOworICAgIGN1cnNvcjogdGV4dDsKIH0K IAogLnN0YXR1cy1saW5lLm5vLWxhYmVsIC5tZXNzYWdlIHsKQEAgLTEzNCwzICsxMzUsNyBAQAog LnN0YXR1cy1saW5lLmJhZCAubWVzc2FnZSB7CiAgICAgY29sb3I6IHJnYigxOTEsIDY3LCA0MSk7 CiB9CisKKy5zdGF0dXMtbGluZSAuYnViYmxlLnBvcG92ZXItdHJhY2tpbmc6aG92ZXIgeworICAg IHRleHQtc2hhZG93OiAwcHggMHB4IDVweCByZ2JhKDI1NSwgMjU1LCAyNTUsIDAuNykKK30K