126274 2013-12-29 05:51:37 -0800 RenderLayer: Store corner and resizer renderers in RenderPtrs. 2013-12-30 11:21:14 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn kling kondapallykalyan simon.fraser oldest_to_newest 963202 0 kling 2013-12-29 05:51:37 -0800 RenderLayer: Store corner and resizer renderers in RenderPtrs. 963261 1 220096 kling 2013-12-29 16:54:51 -0800 Created attachment 220096 Patch 963312 2 kling 2013-12-30 06:09:45 -0800 Committed r161141: <http://trac.webkit.org/changeset/161141> 963359 3 220096 simon.fraser 2013-12-30 11:21:14 -0800 Comment on attachment 220096 Patch Are you going to tell us all about RenderPtrs at some point? 220096 2013-12-29 16:54:51 -0800 2013-12-30 11:21:14 -0800 Patch bug-126274.diff text/plain 4600 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMGM3M2IyLi4zMDNjNGE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTMtMTItMjkgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFJlbmRlckxheWVyOiBTdG9yZSBjb3JuZXIgYW5kIHJlc2l6ZXIgcmVuZGVyZXJzIGluIFJl bmRlclB0cnMuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjYyNzQ+CisKKyAgICAg ICAgVHVybiBSZW5kZXJMYXllcjo6bV9zY3JvbGxDb3JuZXIgYW5kIG1fcmVzaXplciBpbnRvIFJl bmRlclB0cnMuCisgICAgICAgIFJlbW92ZWQgbWFudWFsIGRlc3Ryb3koKSBjYWxscyBhcyBhcHBy b3ByaWF0ZS4gQWxzbyB0d2Vha2VkIHNvbWUKKyAgICAgICAgY29kZSB0byByZWR1Y2UgbmVzdGlu Zy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworMjAxMy0xMi0yOSAg QW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CisKICAgICAgICAgUmVuZGVyTGF5ZXI6 IFN0b3JlIHJlZmxlY3Rpb24gcmVuZGVyZXIgaW4gYSBSZW5kZXJQdHIuCiAgICAgICAgIDxodHRw czovL3dlYmtpdC5vcmcvYi8xMjYyNzM+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXIuY3BwCmluZGV4IDJlOWM1NjQuLmE1MDczNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckxheWVyLmNwcApAQCAtMjA3LDggKzIwNyw2IEBAIFJlbmRlckxheWVyOjpSZW5k ZXJMYXllcihSZW5kZXJMYXllck1vZGVsT2JqZWN0JiByZW5kZXJlckxheWVyTW9kZWxPYmplY3Qp CiAgICAgLCBtX2xhc3QoMCkKICAgICAsIG1fc3RhdGljSW5saW5lUG9zaXRpb24oMCkKICAgICAs IG1fc3RhdGljQmxvY2tQb3NpdGlvbigwKQotICAgICwgbV9zY3JvbGxDb3JuZXIoMCkKLSAgICAs IG1fcmVzaXplcigwKQogICAgICwgbV9lbmNsb3NpbmdQYWdpbmF0aW9uTGF5ZXIoMCkKIHsKICAg ICBtX2lzTm9ybWFsRmxvd09ubHkgPSBzaG91bGRCZU5vcm1hbEZsb3dPbmx5KCk7CkBAIC0yNzAs MTEgKzI2OCw2IEBAIFJlbmRlckxheWVyOjp+UmVuZGVyTGF5ZXIoKQogI2lmIFVTRShBQ0NFTEVS QVRFRF9DT01QT1NJVElORykKICAgICBjbGVhckJhY2tpbmcodHJ1ZSk7CiAjZW5kaWYKLSAgICAK LSAgICBpZiAobV9zY3JvbGxDb3JuZXIpCi0gICAgICAgIG1fc2Nyb2xsQ29ybmVyLT5kZXN0cm95 KCk7Ci0gICAgaWYgKG1fcmVzaXplcikKLSAgICAgICAgbV9yZXNpemVyLT5kZXN0cm95KCk7CiB9 CiAKIFN0cmluZyBSZW5kZXJMYXllcjo6bmFtZSgpIGNvbnN0CkBAIC02Njk1LDM0ICs2Njg4LDM2 IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbENvcm5lclN0eWxlKCkKIHsKICAgICBS ZW5kZXJFbGVtZW50KiBhY3R1YWxSZW5kZXJlciA9IHJlbmRlcmVyRm9yU2Nyb2xsYmFyKHJlbmRl cmVyKCkpOwogICAgIFJlZlB0cjxSZW5kZXJTdHlsZT4gY29ybmVyID0gcmVuZGVyZXIoKS5oYXNP dmVyZmxvd0NsaXAoKSA/IGFjdHVhbFJlbmRlcmVyLT5nZXRVbmNhY2hlZFBzZXVkb1N0eWxlKFBz ZXVkb1N0eWxlUmVxdWVzdChTQ1JPTExCQVJfQ09STkVSKSwgJmFjdHVhbFJlbmRlcmVyLT5zdHls ZSgpKSA6IFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+KDApOwotICAgIGlmIChjb3JuZXIpIHsKLSAg ICAgICAgaWYgKCFtX3Njcm9sbENvcm5lcikgewotICAgICAgICAgICAgbV9zY3JvbGxDb3JuZXIg PSBuZXcgUmVuZGVyU2Nyb2xsYmFyUGFydChyZW5kZXJlcigpLmRvY3VtZW50KCksIGNvcm5lci5y ZWxlYXNlTm9uTnVsbCgpKTsKLSAgICAgICAgICAgIG1fc2Nyb2xsQ29ybmVyLT5zZXRQYXJlbnQo JnJlbmRlcmVyKCkpOwotICAgICAgICAgICAgbV9zY3JvbGxDb3JuZXItPmluaXRpYWxpemVTdHls ZSgpOwotICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgIG1fc2Nyb2xsQ29ybmVyLT5zZXRTdHls ZShjb3JuZXIucmVsZWFzZU5vbk51bGwoKSk7Ci0gICAgfSBlbHNlIGlmIChtX3Njcm9sbENvcm5l cikgewotICAgICAgICBtX3Njcm9sbENvcm5lci0+ZGVzdHJveSgpOwotICAgICAgICBtX3Njcm9s bENvcm5lciA9IDA7CisKKyAgICBpZiAoIWNvcm5lcikgeworICAgICAgICBtX3Njcm9sbENvcm5l ciA9IG51bGxwdHI7CisgICAgICAgIHJldHVybjsKICAgICB9CisKKyAgICBpZiAoIW1fc2Nyb2xs Q29ybmVyKSB7CisgICAgICAgIG1fc2Nyb2xsQ29ybmVyID0gY3JlYXRlUmVuZGVyT2JqZWN0PFJl bmRlclNjcm9sbGJhclBhcnQ+KHJlbmRlcmVyKCkuZG9jdW1lbnQoKSwgY29ybmVyLnJlbGVhc2VO b25OdWxsKCkpOworICAgICAgICBtX3Njcm9sbENvcm5lci0+c2V0UGFyZW50KCZyZW5kZXJlcigp KTsKKyAgICAgICAgbV9zY3JvbGxDb3JuZXItPmluaXRpYWxpemVTdHlsZSgpOworICAgIH0gZWxz ZQorICAgICAgICBtX3Njcm9sbENvcm5lci0+c2V0U3R5bGUoY29ybmVyLnJlbGVhc2VOb25OdWxs KCkpOwogfQogCiB2b2lkIFJlbmRlckxheWVyOjp1cGRhdGVSZXNpemVyU3R5bGUoKQogewogICAg IFJlbmRlckVsZW1lbnQqIGFjdHVhbFJlbmRlcmVyID0gcmVuZGVyZXJGb3JTY3JvbGxiYXIocmVu ZGVyZXIoKSk7CiAgICAgUmVmUHRyPFJlbmRlclN0eWxlPiByZXNpemVyID0gcmVuZGVyZXIoKS5o YXNPdmVyZmxvd0NsaXAoKSA/IGFjdHVhbFJlbmRlcmVyLT5nZXRVbmNhY2hlZFBzZXVkb1N0eWxl KFBzZXVkb1N0eWxlUmVxdWVzdChSRVNJWkVSKSwgJmFjdHVhbFJlbmRlcmVyLT5zdHlsZSgpKSA6 IFBhc3NSZWZQdHI8UmVuZGVyU3R5bGU+KDApOwotICAgIGlmIChyZXNpemVyKSB7Ci0gICAgICAg IGlmICghbV9yZXNpemVyKSB7Ci0gICAgICAgICAgICBtX3Jlc2l6ZXIgPSBuZXcgUmVuZGVyU2Ny b2xsYmFyUGFydChyZW5kZXJlcigpLmRvY3VtZW50KCksIHJlc2l6ZXIucmVsZWFzZU5vbk51bGwo KSk7Ci0gICAgICAgICAgICBtX3Jlc2l6ZXItPnNldFBhcmVudCgmcmVuZGVyZXIoKSk7Ci0gICAg ICAgICAgICBtX3Jlc2l6ZXItPmluaXRpYWxpemVTdHlsZSgpOwotICAgICAgICB9IGVsc2UKLSAg ICAgICAgICAgIG1fcmVzaXplci0+c2V0U3R5bGUocmVzaXplci5yZWxlYXNlTm9uTnVsbCgpKTsK LSAgICB9IGVsc2UgaWYgKG1fcmVzaXplcikgewotICAgICAgICBtX3Jlc2l6ZXItPmRlc3Ryb3ko KTsKLSAgICAgICAgbV9yZXNpemVyID0gMDsKKworICAgIGlmICghcmVzaXplcikgeworICAgICAg ICBtX3Jlc2l6ZXIgPSBudWxscHRyOworICAgICAgICByZXR1cm47CiAgICAgfQorCisgICAgaWYg KCFtX3Jlc2l6ZXIpIHsKKyAgICAgICAgbV9yZXNpemVyID0gY3JlYXRlUmVuZGVyT2JqZWN0PFJl bmRlclNjcm9sbGJhclBhcnQ+KHJlbmRlcmVyKCkuZG9jdW1lbnQoKSwgcmVzaXplci5yZWxlYXNl Tm9uTnVsbCgpKTsKKyAgICAgICAgbV9yZXNpemVyLT5zZXRQYXJlbnQoJnJlbmRlcmVyKCkpOwor ICAgICAgICBtX3Jlc2l6ZXItPmluaXRpYWxpemVTdHlsZSgpOworICAgIH0gZWxzZQorICAgICAg ICBtX3Jlc2l6ZXItPnNldFN0eWxlKHJlc2l6ZXIucmVsZWFzZU5vbk51bGwoKSk7CiB9CiAKIFJl bmRlckxheWVyKiBSZW5kZXJMYXllcjo6cmVmbGVjdGlvbkxheWVyKCkgY29uc3QKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKaW5kZXggOGFmYjA1OS4uZTFlNzUwZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTEzMTcsMTAgKzEzMTcsMTAgQEAg cHJpdmF0ZToKICAgICAKICAgICAvLyBNYXkgdWx0aW1hdGVseSBiZSBleHRlbmRlZCB0byBtYW55 IHJlcGxpY2FzICh3aXRoIHRoZWlyIG93biBwYWludCBvcmRlcikuCiAgICAgUmVuZGVyUHRyPFJl bmRlclJlcGxpY2E+IG1fcmVmbGVjdGlvbjsKLSAgICAgICAgCisKICAgICAvLyBSZW5kZXJlcnMg dG8gaG9sZCBvdXIgY3VzdG9tIHNjcm9sbCBjb3JuZXIgYW5kIHJlc2l6ZXIuCi0gICAgUmVuZGVy U2Nyb2xsYmFyUGFydCogbV9zY3JvbGxDb3JuZXI7Ci0gICAgUmVuZGVyU2Nyb2xsYmFyUGFydCog bV9yZXNpemVyOworICAgIFJlbmRlclB0cjxSZW5kZXJTY3JvbGxiYXJQYXJ0PiBtX3Njcm9sbENv cm5lcjsKKyAgICBSZW5kZXJQdHI8UmVuZGVyU2Nyb2xsYmFyUGFydD4gbV9yZXNpemVyOwogCiAg ICAgLy8gUG9pbnRlciB0byB0aGUgZW5jbG9zaW5nIFJlbmRlckxheWVyIHRoYXQgY2F1c2VkIHVz IHRvIGJlIHBhZ2luYXRlZC4gSXQgaXMgMCBpZiB3ZSBhcmUgbm90IHBhZ2luYXRlZC4KICAgICBS ZW5kZXJMYXllciogbV9lbmNsb3NpbmdQYWdpbmF0aW9uTGF5ZXI7Cg==