126271 2013-12-28 05:14:22 -0800 Attempt to fix the build of WebCore's code generator on CMake based system 2014-01-02 03:41:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue dbates gyuyoung.kim gyuyoung.kim laszlo.gombos mrobinson rakuco oldest_to_newest 963171 0 benjamin 2013-12-28 05:14:22 -0800 Attempt to fix the build of WebCore's code generator on CMake based system 963172 1 220073 benjamin 2013-12-28 05:18:16 -0800 Created attachment 220073 Patch 963357 2 220073 dbates 2013-12-30 11:16:19 -0800 Comment on attachment 220073 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220073&action=review > Source/JavaScriptCore/ChangeLog:3 > + Attempt to fix the build of WebCore's code generator on CMake based system Can you elaborate? Do we know what revision broke the build? Or is this more of a correctness issue than a build fix? As of the time of writing, looking at <http://build.webkit.org/console> and the stdio of the compile step on EFL Linux 64-bit Release WK1/WK2 and GTK Linux 64-bit Debug WK1/Release, the bots seem to be building without any JavaScriptCore header-related errors. 963374 3 benjamin 2013-12-30 13:11:25 -0800 (In reply to comment #2) > (From update of attachment 220073 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220073&action=review > > > Source/JavaScriptCore/ChangeLog:3 > > + Attempt to fix the build of WebCore's code generator on CMake based system > > Can you elaborate? Do we know what revision broke the build? Or is this more of a correctness issue than a build fix? As of the time of writing, looking at <http://build.webkit.org/console> and the stdio of the compile step on EFL Linux 64-bit Release WK1/WK2 and GTK Linux 64-bit Debug WK1/Release, the bots seem to be building without any JavaScriptCore header-related errors. I am trying to fix the build consistency to land https://bugs.webkit.org/show_bug.cgi?id=126185 963717 4 benjamin 2014-01-02 03:41:33 -0800 Committed r161206: <http://trac.webkit.org/changeset/161206> 220073 2013-12-28 05:18:16 -0800 2013-12-30 15:57:52 -0800 Patch bug-126271-20131228141815.patch text/plain 1233 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk NGNiZDRmNGNlY2YwY2Y0OWNhYjJjZTI0NzgyNTcwYmNhOTUzZmUyLi43MWRjMmYxY2M4NWE1ZmZi MjRjYTgwZTFmOGMwMjQyOWY5MDUyNzJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMy0xMi0yOCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgQXR0ZW1wdCB0byBmaXggdGhlIGJ1aWxkIG9mIFdlYkNvcmUncyBj b2RlIGdlbmVyYXRvciBvbiBDTWFrZSBiYXNlZCBzeXN0ZW0KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjI3MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTMtMTIt MjUgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNjEwMzMgYW5kIHIxNjEwNzQuCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ01ha2VMaXN0cy50eHQKaW5kZXggMjBiNWQxNGUxNWVkZDg4MjJlM2QxOWMyZTFlZTJjNmRl MzkwMThhZC4uMjI0MDA3ZmIyMTcxNzYzZDZhMzRkMTY5NzRlYmYzNDE5ZmMwMGNiMCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtNjMxLDYgKzYzMSwxMiBAQCBzZXQoSmF2 YVNjcmlwdENvcmVfRk9SV0FSRElOR19IRUFERVJTX0ZJTEVTCiAgICAgQVBJL0phdmFTY3JpcHRD b3JlLmgKICAgICBBUEkvT3BhcXVlSlNTdHJpbmcuaAogICAgIEFQSS9XZWJLaXRBdmFpbGFiaWxp dHkuaAorCisgICAgYXNzZW1ibGVyL0xpbmtCdWZmZXIuaAorICAgIGFzc2VtYmxlci9NYWNyb0Fz c2VtYmxlci5oCisgICAgYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQ29kZVJlZi5oCisgICAgaml0 L0dQUkluZm8uaAorICAgIHJ1bnRpbWUvVk0uaAogKQogCiAK