126258 2013-12-27 01:15:23 -0800 Crash when starting a download before the network process has been launched 2014-01-09 09:51:48 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126131 1 cgarcia webkit-unassigned andersca ap beidson sam oldest_to_newest 963094 0 cgarcia 2013-12-27 01:15:23 -0800 We need to ensure there's a network process running before starting a new download like we do when using the web process. This makes all WebKit2GTK+ download unit tests to crash. 963095 1 220054 cgarcia 2013-12-27 01:19:50 -0800 Created attachment 220054 Patch 963097 2 220054 svillar 2013-12-27 01:30:55 -0800 Comment on attachment 220054 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220054&action=review Good job! > Source/WebKit2/UIProcess/WebContext.cpp:766 > + networkProcess()->send(Messages::NetworkProcess::DownloadRequest(downloadProxy->downloadID(), request), 0); I guess this is totally unrelated and just to keep consistency with the rest of the file > Source/WebKit2/UIProcess/WebContext.cpp:946 > #endif Looks correct. I understand that this might be difficult to reproduce in real life situations (as a webprocess should have been spawned and a networkprocess with it) but easily in the unit tests. 963098 3 cgarcia 2013-12-27 01:35:02 -0800 (In reply to comment #2) > (From update of attachment 220054 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220054&action=review > > Good job! > > > Source/WebKit2/UIProcess/WebContext.cpp:766 > > + networkProcess()->send(Messages::NetworkProcess::DownloadRequest(downloadProxy->downloadID(), request), 0); > > I guess this is totally unrelated and just to keep consistency with the rest of the file No, it's not, see the ChageLog. "Use ChildProcessProxy::send() instead of using the connection to make sure messages are queued" > > Source/WebKit2/UIProcess/WebContext.cpp:946 > > #endif > > Looks correct. I understand that this might be difficult to reproduce in real life situations (as a webprocess should have been spawned and a networkprocess with it) but easily in the unit tests. It's difficult to happen in a web browser, yes, but our API allows to start a download from a WebContext without any web page involved. 963099 4 220054 svillar 2013-12-27 01:37:08 -0800 Comment on attachment 220054 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220054&action=review >>> Source/WebKit2/UIProcess/WebContext.cpp:766 >>> + networkProcess()->send(Messages::NetworkProcess::DownloadRequest(downloadProxy->downloadID(), request), 0); >> >> I guess this is totally unrelated and just to keep consistency with the rest of the file > > No, it's not, see the ChageLog. > > "Use ChildProcessProxy::send() instead of using the connection to make sure messages are queued" Oh yeah I totally overlooked it 965954 5 cgarcia 2014-01-09 09:51:48 -0800 Committed r161559: <http://trac.webkit.org/changeset/161559> 220054 2013-12-27 01:19:50 -0800 2014-01-09 09:23:35 -0800 Patch wk2-network-process-download-crash.diff text/plain 2307 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiZTA2ZDg4Li4yYzdlZDVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMTItMjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIENyYXNoIHdoZW4gc3RhcnRpbmcgYSBkb3dubG9hZCBiZWZvcmUgdGhlIG5l dHdvcmsgcHJvY2VzcyBoYXMgYmVlbiBsYXVuY2hlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2MjU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0byBlbnN1cmUgdGhlcmUncyBhIG5ldHdv cmsgcHJvY2VzcyBydW5uaW5nIGJlZm9yZQorICAgICAgICBzdGFydGluZyBhIG5ldyBkb3dubG9h ZCBsaWtlIHdlIGRvIHdoZW4gdXNpbmcgdGhlIHdlYiBwcm9jZXNzLgorCisgICAgICAgICogVUlQ cm9jZXNzL1dlYkNvbnRleHQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0Ojpkb3du bG9hZCk6IFVzZSBDaGlsZFByb2Nlc3NQcm94eTo6c2VuZCgpCisgICAgICAgIGluc3RlYWQgb2Yg dXNpbmcgdGhlIGNvbm5lY3Rpb24gdG8gbWFrZSBzdXJlIG1lc3NhZ2VzIGFyZSBxdWV1ZWQKKyAg ICAgICAgaWYgdGhlIHByb2Nlc3MgaXMgc3RpbGwgbGF1bmNoaW5nLgorICAgICAgICAoV2ViS2l0 OjpXZWJDb250ZXh0OjpjcmVhdGVEb3dubG9hZFByb3h5KTogQ2FsbAorICAgICAgICBlbnN1cmVO ZXR3b3JrUHJvY2VzcygpIGJlZm9yZSBjcmVhdGluZyB0aGUgZG93bmxvYWQgcHJveHkuCisKIDIw MTMtMTItMjQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtHVEtdIFRlc3QgL3dlYmtpdDIvV2ViS2l0V2ViQ29udGV4dC9sYW5ndWFnZXMgY3Jh c2hlcyB3aXRoIG5ldHdvcmsgcHJvY2VzcyBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViQ29udGV4dC5jcHAKaW5kZXggOGVlY2YxYS4uZGQyYzI1NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJDb250ZXh0LmNwcApAQCAtNzYzLDcgKzc2Myw3IEBAIERvd25sb2FkUHJveHkq IFdlYkNvbnRleHQ6OmRvd25sb2FkKFdlYlBhZ2VQcm94eSogaW5pdGlhdGluZ1BhZ2UsIGNvbnN0 IFJlc291cmNlCiAjaWYgRU5BQkxFKE5FVFdPUktfUFJPQ0VTUykKICAgICBpZiAodXNlc05ldHdv cmtQcm9jZXNzKCkgJiYgbmV0d29ya1Byb2Nlc3MoKSkgewogICAgICAgICAvLyBGSVhNRSAoTmV0 d29ya1Byb2Nlc3MpOiBSZXBsaWNhdGUgd2hhdGV2ZXIgRnJhbWVMb2FkZXI6OnNldE9yaWdpbmFs VVJMRm9yRG93bmxvYWRSZXF1ZXN0IGRvZXMgd2l0aCB0aGUgcmVxdWVzdCBoZXJlLgotICAgICAg ICBuZXR3b3JrUHJvY2VzcygpLT5jb25uZWN0aW9uKCktPnNlbmQoTWVzc2FnZXM6Ok5ldHdvcmtQ cm9jZXNzOjpEb3dubG9hZFJlcXVlc3QoZG93bmxvYWRQcm94eS0+ZG93bmxvYWRJRCgpLCByZXF1 ZXN0KSwgMCk7CisgICAgICAgIG5ldHdvcmtQcm9jZXNzKCktPnNlbmQoTWVzc2FnZXM6Ok5ldHdv cmtQcm9jZXNzOjpEb3dubG9hZFJlcXVlc3QoZG93bmxvYWRQcm94eS0+ZG93bmxvYWRJRCgpLCBy ZXF1ZXN0KSwgMCk7CiAgICAgICAgIHJldHVybiBkb3dubG9hZFByb3h5OwogICAgIH0KICNlbmRp ZgpAQCAtOTM4LDggKzkzOCwxMSBAQCB2b2lkIFdlYkNvbnRleHQ6OmFkZFZpc2l0ZWRMaW5rSGFz aChMaW5rSGFzaCBsaW5rSGFzaCkKIERvd25sb2FkUHJveHkqIFdlYkNvbnRleHQ6OmNyZWF0ZURv d25sb2FkUHJveHkoKQogewogI2lmIEVOQUJMRShORVRXT1JLX1BST0NFU1MpCi0gICAgaWYgKHVz ZXNOZXR3b3JrUHJvY2VzcygpKQorICAgIGlmICh1c2VzTmV0d29ya1Byb2Nlc3MoKSkgeworICAg ICAgICBlbnN1cmVOZXR3b3JrUHJvY2VzcygpOworICAgICAgICBBU1NFUlQobV9uZXR3b3JrUHJv Y2Vzcyk7CiAgICAgICAgIHJldHVybiBtX25ldHdvcmtQcm9jZXNzLT5jcmVhdGVEb3dubG9hZFBy b3h5KCk7CisgICAgfQogI2VuZGlmCiAKICAgICByZXR1cm4gZW5zdXJlU2hhcmVkV2ViUHJvY2Vz cygpLmNyZWF0ZURvd25sb2FkUHJveHkoKTsK