126249 2013-12-26 16:37:30 -0800 [EFL][WK2] Remove defaultPageGroupIdentifier not to make the confusion 2014-01-02 23:44:23 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez commit-queue enmi.lee gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 963042 0 ryuan.choi 2013-12-26 16:37:30 -0800 ewk_page_group_create always creates new page group, but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "". It is unnecessary and just makes the confusion. 963044 1 220039 ryuan.choi 2013-12-26 16:47:59 -0800 Created attachment 220039 Patch 963045 2 220039 gyuyoung.kim 2013-12-26 16:57:33 -0800 Comment on attachment 220039 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220039&action=review > Source/WebKit2/ChangeLog:9 > + but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "". How will the identifiers be same with "defaultPageGroupIdentifier" when passing null ? 963048 3 220039 ryuan.choi 2013-12-26 17:05:26 -0800 Comment on attachment 220039 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220039&action=review >> Source/WebKit2/ChangeLog:9 >> + but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "". > > How will the identifiers be same with "defaultPageGroupIdentifier" when passing null ? The identifier of WebPageGroup is just what user passed or generated one if user passed empty string. But, our previous logic only passed "defaultPageGroupIdentifier" when we passed empty string. In fact, WebPageGroup uses pageGroupID(generated one) and identifier (string which user passed). 963262 4 220039 jinwoo7.song 2013-12-29 16:56:51 -0800 Comment on attachment 220039 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220039&action=review >>> Source/WebKit2/ChangeLog:9 >>> + but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "". >> >> How will the identifiers be same with "defaultPageGroupIdentifier" when passing null ? > > The identifier of WebPageGroup is just what user passed or generated one if user passed empty string. > But, our previous logic only passed "defaultPageGroupIdentifier" when we passed empty string. > > In fact, WebPageGroup uses pageGroupID(generated one) and identifier (string which user passed). If the same identifier is passed, WebCore's page get same page group identifier even a new WebPageGroup is created. WebPage.cpp m_page->setGroupName(m_pageGroup->identifier()); The reason I added "defaultPageGroupIdentifier" was to make pages have same group identifier even though developer did not set the identifier. But it would be better to remove this default identifier because it conflict the behavior of WebPageGroup. 964015 5 220039 gyuyoung.kim 2014-01-02 23:11:18 -0800 Comment on attachment 220039 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220039&action=review >>>> Source/WebKit2/ChangeLog:9 >>>> + but the identifiers of page groups will be same as "defaultPageGroupIdentifier" when passed 0 or "". >>> >>> How will the identifiers be same with "defaultPageGroupIdentifier" when passing null ? >> >> The identifier of WebPageGroup is just what user passed or generated one if user passed empty string. >> But, our previous logic only passed "defaultPageGroupIdentifier" when we passed empty string. >> >> In fact, WebPageGroup uses pageGroupID(generated one) and identifier (string which user passed). > > If the same identifier is passed, WebCore's page get same page group identifier even a new WebPageGroup is created. > > WebPage.cpp > m_page->setGroupName(m_pageGroup->identifier()); > > The reason I added "defaultPageGroupIdentifier" was to make pages have same group identifier even though developer did not set the identifier. > But it would be better to remove this default identifier because it conflict the behavior of WebPageGroup. If WebPageGroup already support to generate an unique identifier when passing null as argument, I agree to remove the default identifier. 964023 6 220039 commit-queue 2014-01-02 23:44:19 -0800 Comment on attachment 220039 Patch Clearing flags on attachment: 220039 Committed r161254: <http://trac.webkit.org/changeset/161254> 964024 7 commit-queue 2014-01-02 23:44:23 -0800 All reviewed patches have been landed. Closing bug. 220039 2013-12-26 16:47:59 -0800 2014-01-02 23:44:19 -0800 Patch bug-126249-20131227094758.patch text/plain 3250 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTVmMjQxZWUyNTEyNjVk M2JmMjQzYzAzZjMyZmQ3NGQ2N2I5ZDgxZS4uMjAwODlhN2U5NGQzNDg0OTcyZTY2N2E5Y2MwNmY0 ODQ2ZjQ0MDRhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTEyLTI2ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIFJl bW92ZSBkZWZhdWx0UGFnZUdyb3VwSWRlbnRpZmllciBub3QgdG8gbWFrZSB0aGUgY29uZnVzaW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYyNDkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBld2tfcGFn ZV9ncm91cF9jcmVhdGUgYWx3YXlzIGNyZWF0ZXMgbmV3IHBhZ2UgZ3JvdXAsCisgICAgICAgIGJ1 dCB0aGUgaWRlbnRpZmllcnMgb2YgcGFnZSBncm91cHMgd2lsbCBiZSBzYW1lIGFzICJkZWZhdWx0 UGFnZUdyb3VwSWRlbnRpZmllciIgd2hlbiBwYXNzZWQgMCBvciAiIi4KKyAgICAgICAgSXQgaXMg dW5uZWNlc3NhcnkgYW5kIGp1c3QgbWFrZXMgdGhlIGNvbmZ1c2lvbi4KKworICAgICAgICBUaGlz IHBhdGNoIGxldCBXZWJQYWdlR3JvdXAgZ2VuZXJhdGUgdW5pcXVlIGlkZW50aWZpZXIgaWYgMCBv ciAiIiBpcyBwYXNzZWQgYXMgYXJndW1lbnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC9ld2tfcGFnZV9ncm91cC5jcHA6CisgICAgICAgIChFd2tQYWdlR3JvdXA6OmNyZWF0ZSk6Cisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3BhZ2VfZ3JvdXBfcHJpdmF0ZS5oOgorCiAy MDEzLTEyLTI2ICBUaGlhZ28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVu Ym9zc2Eub3JnPgogCiAgICAgICAgIFtXSzJdW0Nvb3JkaW5hdGVkR3JhcGhpY3NdIFJlbW92aW5n IGR1cGxpY2F0ZSBzY2FsZSBpbmZvcm1hdGlvbiBmcm9tIFdlYlZJZXcuY3BwCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfcGFnZV9ncm91cC5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfcGFnZV9ncm91cC5jcHAKaW5kZXgg ODRjZDU2NzhjMGE0YTVjMmIwZjJmZjNjMjI2YzYwZmU1ZmJlMWFlYS4uNDFiNDVhMjg4NGMyYWY2 MjgzMDliNzdiM2IzMGUzYTEyNjcyODBiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX3BhZ2VfZ3JvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a19wYWdlX2dyb3VwLmNwcApAQCAtMzUsOCArMzUsNiBAQAogCiB1 c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogCi1jb25zdCBjaGFyIEV3a1BhZ2VHcm91cDo6ZGVmYXVs dElkZW50aWZpZXJbXSA9ICJkZWZhdWx0UGFnZUdyb3VwSWRlbnRpZmllciI7Ci0KIHR5cGVkZWYg SGFzaE1hcDxXS1BhZ2VHcm91cFJlZiwgRXdrUGFnZUdyb3VwKj4gUGFnZUdyb3VwTWFwOwogCiBz dGF0aWMgaW5saW5lIFBhZ2VHcm91cE1hcCYgcGFnZUdyb3VwTWFwKCkKQEAgLTU4LDkgKzU2LDkg QEAgUGFzc1JlZlB0cjxFd2tQYWdlR3JvdXA+IEV3a1BhZ2VHcm91cDo6ZmluZE9yQ3JlYXRlV3Jh cHBlcihXS1BhZ2VHcm91cFJlZiBwYWdlR3IKICAgICByZXR1cm4gYWRvcHRSZWYobmV3IEV3a1Bh Z2VHcm91cChwYWdlR3JvdXBSZWYpKTsKIH0KIAotUGFzc1JlZlB0cjxFd2tQYWdlR3JvdXA+IEV3 a1BhZ2VHcm91cDo6Y3JlYXRlKGNvbnN0IFN0cmluZyYgaWRlbnRpZmllcikKK1Bhc3NSZWZQdHI8 RXdrUGFnZUdyb3VwPiBFd2tQYWdlR3JvdXA6OmNyZWF0ZShjb25zdCBjaGFyKiBpZGVudGlmaWVy KQogewotICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBpZGVudGlmaWVyUmVmID0gYWRvcHRX Syh0b0NvcGllZEFQSShpZGVudGlmaWVyLmlzRW1wdHkoKSA/IGRlZmF1bHRJZGVudGlmaWVyIDog aWRlbnRpZmllcikpOworICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBpZGVudGlmaWVyUmVm ID0gYWRvcHRXSyh0b0NvcGllZEFQSShpZGVudGlmaWVyKSk7CiAgICAgV0tSZXRhaW5QdHI8V0tQ YWdlR3JvdXBSZWY+IHBhZ2VHcm91cFJlZiA9IGFkb3B0V0soV0tQYWdlR3JvdXBDcmVhdGVXaXRo SWRlbnRpZmllcihpZGVudGlmaWVyUmVmLmdldCgpKSk7CiAKICAgICByZXR1cm4gYWRvcHRSZWYo bmV3IEV3a1BhZ2VHcm91cChwYWdlR3JvdXBSZWYuZ2V0KCkpKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19wYWdlX2dyb3VwX3ByaXZhdGUuaCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19wYWdlX2dyb3VwX3ByaXZhdGUuaApp bmRleCAzZjkyMjAxN2RiYjZmZDc5MmI3ODY2MzE3NjA0YjY5OTQ1YTg5MzkxLi43NTJlYTE5MWIy YjE4ZWM3ODBkMThmYjRhMDQxMjI5M2FhZTExOTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfcGFnZV9ncm91cF9wcml2YXRlLmgKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3BhZ2VfZ3JvdXBfcHJpdmF0ZS5oCkBAIC00 MSw3ICs0MSw3IEBAIHB1YmxpYzoKICAgICBFV0tfT0JKRUNUX0RFQ0xBUkUoRXdrUGFnZUdyb3Vw KQogCiAgICAgc3RhdGljIFBhc3NSZWZQdHI8RXdrUGFnZUdyb3VwPiBmaW5kT3JDcmVhdGVXcmFw cGVyKFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm91cFJlZik7Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8 RXdrUGFnZUdyb3VwPiBjcmVhdGUoY29uc3QgU3RyaW5nJiBpZGVudGlmaWVyID0gU3RyaW5nKCkp OworICAgIHN0YXRpYyBQYXNzUmVmUHRyPEV3a1BhZ2VHcm91cD4gY3JlYXRlKGNvbnN0IGNoYXIq KTsKIAogICAgIH5Fd2tQYWdlR3JvdXAoKTsKIApAQCAtNTMsOCArNTMsNiBAQCBwdWJsaWM6CiBw cml2YXRlOgogICAgIGV4cGxpY2l0IEV3a1BhZ2VHcm91cChXS1BhZ2VHcm91cFJlZiBwYWdlR3Jv dXBSZWYpOyAgICAKIAotICAgIHN0YXRpYyBjb25zdCBjaGFyIGRlZmF1bHRJZGVudGlmaWVyW107 Ci0KICAgICBXS1JldGFpblB0cjxXS1BhZ2VHcm91cFJlZj4gbV9wYWdlR3JvdXBSZWY7CiB9Owog Cg==